coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3292 discussions

[XS] Change in coreboot[main]: drivers/mipi: Fine tune clock for IVO_T109NW41
by Felix Held (Code Review) 03 Apr '24

03 Apr '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81625?usp=email ) Change subject: drivers/mipi: Fine tune clock for IVO_T109NW41 ...................................................................... drivers/mipi: Fine tune clock for IVO_T109NW41 Fine tune the panel clock to prevent mipi noise from affecting wifi band. After tuning, the panel refresh rate keeps at 60Hz and wifi test passed. Just keep consistent with the Linux kernel panel driver panel-boe-tv101wum-nl6 configuration. BUG=b:330807136 TEST=fw screen display normally Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Change-Id: I128b33fbcda9759330a363ebb6cf66415405c488 Reviewed-on: https://review.coreboot.org/c/coreboot/+/81625 Reviewed-by: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yidi Lin <yidilin(a)google.com> --- M src/drivers/mipi/panel-IVO_T109NW41.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified cong yang: Looks good to me, but someone else must approve Yidi Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, approved diff --git a/src/drivers/mipi/panel-IVO_T109NW41.c b/src/drivers/mipi/panel-IVO_T109NW41.c index 4801992..21e1029 100644 --- a/src/drivers/mipi/panel-IVO_T109NW41.c +++ b/src/drivers/mipi/panel-IVO_T109NW41.c @@ -9,10 +9,10 @@ .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { - .pixel_clock = 162600, + .pixel_clock = 166400, .lvds_dual_channel = 0, .refresh = 60, - .ha = 1200, .hbl = 120, .hso = 60, .hspw = 20, + .ha = 1200, .hbl = 150, .hso = 75, .hspw = 20, .va = 1920, .vbl = 135, .vso = 115, .vspw = 8, .phsync = '-', .pvsync = '-', .x_mm = 147, .y_mm = 235, -- To view, visit https://review.coreboot.org/c/coreboot/+/81625?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I128b33fbcda9759330a363ebb6cf66415405c488 Gerrit-Change-Number: 81625 Gerrit-PatchSet: 2 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[L] Change in coreboot[main]: acpi: Add acpigen_write_OSC_pci_domain
by Felix Held (Code Review) 03 Apr '24

03 Apr '24

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81375?usp=email ) Change subject: acpi: Add acpigen_write_OSC_pci_domain ...................................................................... Patch Set 19: (1 comment) File src/acpi/acpigen_pci.c: https://review.coreboot.org/c/coreboot/+/81375/comment/038c8b04_f24e64d2 : PS12, Line 348: __weak unsigned long get_granted_pci_features(const struct device *domain) : { : return 0; : } : : __weak unsigned long get_granted_cxl_features(const struct device *domain) : { : return 0; : } > Pass parameters instead of using weak functions looks good. […] i'd say that if a soc wants to use the functions added in this patch, it should provide the functions it calls, so there's no need for the weak functions here. if the functions that call the weak functions aren't called, the linker won't be unhappy about the functions being called not being implemented -- To view, visit https://review.coreboot.org/c/coreboot/+/81375?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711ce5350d718e47feb2912555108801ad7f918d Gerrit-Change-Number: 81375 Gerrit-PatchSet: 19 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 03 Apr 2024 12:43:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/xeon_sp: Use default soc_get_ioapic_info
by Arthur Heymans (Code Review) 03 Apr '24

03 Apr '24

Attention is currently required from: Christian Walter, Johnny Lin, Jonathan Zhang, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81628?usp=email ) Change subject: soc/intel/xeon_sp: Use default soc_get_ioapic_info ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81628?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1ecfba49cd9b4dfbb3f11d58d04d07ea1752a131 Gerrit-Change-Number: 81628 Gerrit-PatchSet: 2 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 03 Apr 2024 12:43:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: soc/intel/xeon_sp: Add Granite Rapids initial codes
by Felix Held (Code Review) 03 Apr '24

03 Apr '24

Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Felix Singer, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Paul Menzel, Shuo Liu, TangYiwei, Tim Chu. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81316?usp=email ) Change subject: soc/intel/xeon_sp: Add Granite Rapids initial codes ...................................................................... Patch Set 36: (1 comment) File src/soc/intel/xeon_sp/gnr/cpu.c: https://review.coreboot.org/c/coreboot/+/81316/comment/76398080_3f4c55e9 : PS36, Line 61: {X86_VENDOR_INTEL, CPUID_GRANITERAPIDS}, those two lines are missing cpu match mask struct element -- To view, visit https://review.coreboot.org/c/coreboot/+/81316?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3084e1b5abf25d8d9504bebeaed2a15b916ed56b Gerrit-Change-Number: 81316 Gerrit-PatchSet: 36 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: TangYiwei Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 03 Apr 2024 12:40:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: riscv/opensbi: make the opensbi payload a flat binary
by Arthur Heymans (Code Review) 03 Apr '24

03 Apr '24

Attention is currently required from: Arthur Heymans, Jonathan Neuschäfer, Maximilian Brune, Philipp Hug, ron minnich. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81632?usp=email ) Change subject: riscv/opensbi: make the opensbi payload a flat binary ...................................................................... Patch Set 4: (2 comments) File src/arch/riscv/Makefile.mk: https://review.coreboot.org/c/coreboot/+/81632/comment/ac0f96e4_eb3d3874 : PS4, Line 178: $(OPENSBI_CBFS)-compression := non is it executed in place? or why not compress? File src/mainboard/emulation/qemu-riscv/memlayout.ld: https://review.coreboot.org/c/coreboot/+/81632/comment/b12468ce_24018e09 : PS4, Line 9: #define ROMSTAGESIZE 0 Why this change? -- To view, visit https://review.coreboot.org/c/coreboot/+/81632?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I31525125e87ff5925ca82f4e48fe1191ba6326fd Gerrit-Change-Number: 81632 Gerrit-PatchSet: 4 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 03 Apr 2024 12:40:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya/var/sundance: Add GPIO table
by Felix Held (Code Review) 03 Apr '24

03 Apr '24

Attention is currently required from: Derek Huang, Dinesh Gehlot, Kapil Porwal, Leo Chou, Martin L Roth, Nick Vaccaro, Paul Menzel, Shou-Chieh Hsu, Subrata Banik, Varshit Pandya. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81613?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/brya/var/sundance: Add GPIO table ...................................................................... Patch Set 5: (2 comments) File src/mainboard/google/brya/variants/sundance/Makefile.inc: PS5: the file name should be Makefile.mk and not Makefile.inc; I think in January we changed the file extension used by the makefiles https://review.coreboot.org/c/coreboot/+/81613/comment/0076842a_aae2f5a2 : PS5, Line 1: # SPDX-License-Identifier: GPL-2.0-only > NO, There's no empty line after this line. at least in the other coreboot code there's an empty line after the spdx header; adding Martin to the review who might know more about this -- To view, visit https://review.coreboot.org/c/coreboot/+/81613?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I53ed5874347006985ca5231d1531fa519088f796 Gerrit-Change-Number: 81613 Gerrit-PatchSet: 5 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Comment-Date: Wed, 03 Apr 2024 12:35:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com> Comment-In-Reply-To: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/mipi: Fine tune clock for BOE_NV110WUM_L60
by Paul Menzel (Code Review) 03 Apr '24

03 Apr '24

Attention is currently required from: Ruihai Zhou, Xuxin Xiong, Yidi Lin. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81438?usp=email ) Change subject: drivers/mipi: Fine tune clock for BOE_NV110WUM_L60 ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81438/comment/ec24df28_9d7154c7 : PS4, Line 11: Just keep consistent with the Linux kernel panel driver : configuration. > https://chromium-review.googlesource. […] Thank you. This should be part of the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/81438?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic44c86f062d4e836f403ee97f2fc6370fff02797 Gerrit-Change-Number: 81438 Gerrit-PatchSet: 6 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 03 Apr 2024 12:18:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Update verb table to fix headset detection
by Paul Menzel (Code Review) 03 Apr '24

03 Apr '24

Attention is currently required from: Poornima Tom, Shelley Chen, Terry Cheong, Vamshi Krishna Gopal. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81654?usp=email ) Change subject: mb/google/brox: Update verb table to fix headset detection ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81654?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I71b7d59b3ab5310a0b6cdb31fb5033f94263d151 Gerrit-Change-Number: 81654 Gerrit-PatchSet: 2 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Terry Cheong <htcheong(a)google.com> Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Attention: Terry Cheong <htcheong(a)google.com> Gerrit-Comment-Date: Wed, 03 Apr 2024 12:16:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[main]: common: Begin Alder Lake integration
by Dinesh Gehlot (Code Review) 03 Apr '24

03 Apr '24

Attention is currently required from: Angel Pons, Tarun Tuli, Tim Wawrzynczak. Dinesh Gehlot has uploaded a new patch set (#7) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67800?usp=email ) Change subject: common: Begin Alder Lake integration ...................................................................... common: Begin Alder Lake integration Alder Lake uses the same generation of igfx engine as Tiger Lake, therefore the changes required to support ADL-P are minor. This patch starts with PCI device detection. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I3258a125d4b76929673eea5406d26575f9fbd535 --- M common/hw-gfx-gma-config.ads.template M configs/alderlake 2 files changed, 17 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/00/67800/7 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67800?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I3258a125d4b76929673eea5406d26575f9fbd535 Gerrit-Change-Number: 67800 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/brox: Update verb table to fix headset detection
by Poornima Tom (Code Review) 03 Apr '24

03 Apr '24

Attention is currently required from: Paul Menzel. Poornima Tom has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81654?usp=email ) Change subject: mb/google/brox: Update verb table to fix headset detection ...................................................................... Patch Set 2: (11 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/81654/comment/504aa2d9_ef99ba05 : PS1, Line 2: poornima tom > More common spelling is: Poornima Tom. […] Done https://review.coreboot.org/c/coreboot/+/81654/comment/f8ec96a9_9f8ddc7c : PS1, Line 7: Correct verbtable value > More specific: […] Done https://review.coreboot.org/c/coreboot/+/81654/comment/70c3f6ed_5543b4d0 : PS1, Line 7: mb/google/brox:Correct > Please add a space after the colon. Done https://review.coreboot.org/c/coreboot/+/81654/comment/fd1401ee_3c286f3e : PS1, Line 9: pinwidget > pin widget [1] […] Done https://review.coreboot.org/c/coreboot/+/81654/comment/ea2bc9ff_9aa19fab : PS1, Line 9: Corrected > Imperative mood: Correct …. Done https://review.coreboot.org/c/coreboot/+/81654/comment/1a8d4544_96150df8 : PS1, Line 9: pinwidget 20 > … of the Realtek ALC256 … Done https://review.coreboot.org/c/coreboot/+/81654/comment/935e4ac5_4569978c : PS1, Line 10: the updated verbtable received from Realtek > Please document the version/revision. Done https://review.coreboot.org/c/coreboot/+/81654/comment/2171afda_492c8d03 : PS1, Line 11: This fixes the headset detection failure, when : runtime suspend is enabled > Please add a dot/period at the end of sentences. Done https://review.coreboot.org/c/coreboot/+/81654/comment/1170bd1d_854ca517 : PS1, Line 9: Corrected verbtable value for pinwidget 20 based : on the updated verbtable received from Realtek. : This fixes the headset detection failure, when : runtime suspend is enabled > Please use 72 characters per line. Done https://review.coreboot.org/c/coreboot/+/81654/comment/cc9e293e_a6354912 : PS1, Line 16: under runtime suspend > What does that mean exactly? When the device is S0ix suspended, then plugging in a headset to the au […] reframed. https://review.coreboot.org/c/coreboot/+/81654/comment/2ec67884_e881eeff : PS1, Line 16: TEST=verified headset on Brox, under runtime suspend > I guess connected to the audio jack and no USB headset. ys , not on USB headset, but audio jack -- To view, visit https://review.coreboot.org/c/coreboot/+/81654?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I71b7d59b3ab5310a0b6cdb31fb5033f94263d151 Gerrit-Change-Number: 81654 Gerrit-PatchSet: 2 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 03 Apr 2024 10:09:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024