coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[M] Change in coreboot[main]: security/tpm: support compiling in multiple TPM drivers
by Julius Werner (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Krystian Hebel, Matt DeVillier, Michał Żygowski, Raul Rangel, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69162?usp=email ) Change subject: security/tpm: support compiling in multiple TPM drivers ...................................................................... Patch Set 38: (3 comments) File src/drivers/crb/tis.h: PS38: nit: rather than making new headers everywhere I think these could also just go into the various tpm.h that exist already. File src/lib/program.ld: https://review.coreboot.org/c/coreboot/+/69162/comment/3fec1ef4_e78c1698 : PS37, Line 46: RECORD_SIZE(tis_drivers) > I don't have strong preference here, changed to a sequence of `if`s. […] I think as long as all we're hardcoding there is "this driver exists", that's fine. File src/security/tpm/tss/tss.c: https://review.coreboot.org/c/coreboot/+/69162/comment/334c4f51_7c1d1fd5 : PS38, Line 36: DRIVER_TIS_DEFAULT I don't think this is correct for the Atmel case? I think `CONFIG(I2C_TPM)` is the right one to cover them both. -- To view, visit https://review.coreboot.org/c/coreboot/+/69162?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44c5a1d825afe414c2f5c2c90f4cfe41ba9bef5f Gerrit-Change-Number: 69162 Gerrit-PatchSet: 38 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 11 Apr 2024 00:17:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Makefile.mk: Account for large code model sections in cbfs_struct
by Julius Werner (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Arthur Heymans, Felix Singer. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81777?usp=email ) Change subject: Makefile.mk: Account for large code model sections in cbfs_struct ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81777?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie07779ef548337772183ffe2d642f971d8cceae7 Gerrit-Change-Number: 81777 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 11 Apr 2024 00:07:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO
by Karthik Ramasubramanian (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Shelley Chen, Sumeet R Pawnikar. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81789?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/brox/variants/baseboard/brox/gpio.c: https://review.coreboot.org/c/coreboot/+/81789/comment/bab00ed8_0a648265 : PS5, Line 202: PAD_CFG_NF(GPP_E9, NONE, PLTRST, NF2), Question: Should we have to use this always or should it be used only when ISH in full sensing mode? -- To view, visit https://review.coreboot.org/c/coreboot/+/81789?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a091b58deb855c7a7f1489a9506db2f821503b7 Gerrit-Change-Number: 81789 Gerrit-PatchSet: 5 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Wed, 10 Apr 2024 19:47:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO
by Karthik Ramasubramanian (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Shelley Chen, Sumeet R Pawnikar. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81789?usp=email ) Change subject: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81789?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a091b58deb855c7a7f1489a9506db2f821503b7 Gerrit-Change-Number: 81789 Gerrit-PatchSet: 5 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Wed, 10 Apr 2024 19:46:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/dell/optiplex_9020: Add support for TPM1.2 device
by Máté Kukri (Code Review) 10 Apr '24

10 Apr '24

Máté Kukri has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81827?usp=email ) Change subject: mb/dell/optiplex_9020: Add support for TPM1.2 device ...................................................................... mb/dell/optiplex_9020: Add support for TPM1.2 device These machines come with a TPM1.2 device by default. It is somewhat obsolote these days, but there is no harm in enabling it. Change-Id: Iec05321862aed58695c256b00494e5953219786d Signed-off-by: Mate Kukri <kukri.mate(a)gmail.com> --- M src/mainboard/dell/optiplex_9020/Kconfig M src/mainboard/dell/optiplex_9020/devicetree.cb 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/81827/1 diff --git a/src/mainboard/dell/optiplex_9020/Kconfig b/src/mainboard/dell/optiplex_9020/Kconfig index 2de4a9a..38c3281 100644 --- a/src/mainboard/dell/optiplex_9020/Kconfig +++ b/src/mainboard/dell/optiplex_9020/Kconfig @@ -12,7 +12,9 @@ select INTEL_GMA_HAVE_VBT select INTEL_INT15 select MAINBOARD_HAS_LIBGFXINIT + select MAINBOARD_HAS_TPM1 select MAINBOARD_USES_IFD_GBE_REGION + select MEMORY_MAPPED_TPM select NORTHBRIDGE_INTEL_HASWELL select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_LYNXPOINT diff --git a/src/mainboard/dell/optiplex_9020/devicetree.cb b/src/mainboard/dell/optiplex_9020/devicetree.cb index dce5869..841285b 100644 --- a/src/mainboard/dell/optiplex_9020/devicetree.cb +++ b/src/mainboard/dell/optiplex_9020/devicetree.cb @@ -70,6 +70,9 @@ device pnp 2e.b off end # Floppy Controller device pnp 2e.11 off end # Parallel Port end + chip drivers/pc80/tpm + device pnp 0c31.0 on end + end end device pci 1f.2 on end # SATA controller 1 device pci 1f.3 on end # SMBus -- To view, visit https://review.coreboot.org/c/coreboot/+/81827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec05321862aed58695c256b00494e5953219786d Gerrit-Change-Number: 81827 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: mb/dell/optiplex_9020: Implement late HWM initialization
by Máté Kukri (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Varshit Pandya. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81529?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/dell/optiplex_9020: Implement late HWM initialization ...................................................................... mb/dell/optiplex_9020: Implement late HWM initialization There are 4 different chassis types specified by vendor firmware, each with a slightly different HWM configuration. The chassis type to use is determined at runtime by reading a set of 4 PCH GPIOs: 70, 38, 17, and 0. Additionally vendor firmware also provides an option to run the fans at full speed. This is substituted with a coreboot nvram option in this implementation. This was tested to make fan control work on my OptiPlex 7020 SFF. NOTE: This is superficially similar to the OptiPlex 9010's SCH5545 however the OptiPlex 9020's SCH5555 does not use externally programmed EC firmware. Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43 Signed-off-by: Mate Kukri <kukri.mate(a)gmail.com> --- M src/mainboard/dell/optiplex_9020/Makefile.mk M src/mainboard/dell/optiplex_9020/bootblock.c M src/mainboard/dell/optiplex_9020/cmos.default M src/mainboard/dell/optiplex_9020/cmos.layout M src/mainboard/dell/optiplex_9020/mainboard.c A src/mainboard/dell/optiplex_9020/sch5555_ec.c A src/mainboard/dell/optiplex_9020/sch5555_ec.h 7 files changed, 454 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/81529/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/81529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43 Gerrit-Change-Number: 81529 Gerrit-PatchSet: 5 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/google/brya: Add new baseboard trulo
by Subrata Banik (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, Sumeet R Pawnikar, Varshit Pandya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81626?usp=email ) Change subject: mb/google/brya: Add new baseboard trulo ...................................................................... Patch Set 17: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d Gerrit-Change-Number: 81626 Gerrit-PatchSet: 17 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 10 Apr 2024 18:52:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO
by Nick Vaccaro (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Karthik Ramasubramanian, Shelley Chen, Sumeet R Pawnikar. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81789?usp=email ) Change subject: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81789?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a091b58deb855c7a7f1489a9506db2f821503b7 Gerrit-Change-Number: 81789 Gerrit-PatchSet: 5 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 10 Apr 2024 17:26:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO
by Shelley Chen (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Karthik Ramasubramanian, Nick Vaccaro, Sumeet R Pawnikar. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81789?usp=email ) Change subject: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81789/comment/5424a3b6_1160c25b : PS3, Line 9: > Remove extra space. Done https://review.coreboot.org/c/coreboot/+/81789/comment/8190fe3f_08c42c79 : PS3, Line 10: and > be an Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81789?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a091b58deb855c7a7f1489a9506db2f821503b7 Gerrit-Change-Number: 81789 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 10 Apr 2024 17:23:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO
by Shelley Chen (Code Review) 10 Apr '24

10 Apr '24

Attention is currently required from: Karthik Ramasubramanian, Shelley Chen. Hello Karthik Ramasubramanian, Nick Vaccaro, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81789?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO ...................................................................... mb/google/brox: Initialize NOTE_BOOK_MODE GPIO The GPIO for NOTE_BOOK_MODE has changed from GPP_B17 to GPP_E9. Also initializing NOTE_BOOT_MODE to be an output GPIO. BUG=b:316421831 BRANCH=None TEST=emerge-brox coreboot chromeos-bootimage Make sure that brox device still boots up with this change. Change-Id: I4a091b58deb855c7a7f1489a9506db2f821503b7 Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/mainboard/google/brox/variants/baseboard/brox/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/81789/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/81789?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a091b58deb855c7a7f1489a9506db2f821503b7 Gerrit-Change-Number: 81789 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024