Attention is currently required from: Felix Singer, Martin L Roth.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81671?usp=email )
Change subject: util/crossgcc: Update ACPICA from 20230628 to 20240321
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81671?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I41f56ba58af51b1ec1d7554fb35a49ccf9e778f6
Gerrit-Change-Number: 81671
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 15:13:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80721?usp=email )
Change subject: util/crossgcc/buildgcc: Use Intel mirror for ACPICA
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80721?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If3738b0cdab07c37ac1459a53e399e5de54435d5
Gerrit-Change-Number: 80721
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 15:13:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Aseda Aboagye, Cliff Huang, Lance Zhao, Nick Vaccaro, Shelley Chen, Tim Wawrzynczak.
Hello Cliff Huang, Lance Zhao, Nick Vaccaro, Shelley Chen, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81895?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: acpigen_ps2_keybd: Add Fn key to linux,keymap
......................................................................
acpigen_ps2_keybd: Add Fn key to linux,keymap
Some devices may generate scancodes for the Fn key if they have one.
If they do, we should add them to the linux,keymap binding.
BUG=b:333096023
TEST=Flash DUT that emits a scancode for the Fn key, verify that it is
mapped to KEY_FN in the Linux kernel using `evtest` when pressing the Fn
key.
Change-Id: Ie4daa64bc6b619392276d0b5f16e2d195d5bd68c
Signed-off-by: Aseda Aboagye <aaboagye(a)google.com>
---
M src/acpi/Kconfig
M src/acpi/acpigen_ps2_keybd.c
2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/81895/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/81895?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie4daa64bc6b619392276d0b5f16e2d195d5bd68c
Gerrit-Change-Number: 81895
Gerrit-PatchSet: 4
Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81976?usp=email )
Change subject: soc/intel/common/block/cse: Drop unused symbols
......................................................................
soc/intel/common/block/cse: Drop unused symbols
SOC_INTEL_CSE_RW_A_FMAP_NAME, SOC_INTEL_CSE_RW_B_FMAP_NAME and
SOC_INTEL_CSE_RW_HASH_CBFS_NAME are not used.
Change-Id: I0639f03baf4edcf5f01d6673137dfbab1f2d4a25
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/soc/intel/common/block/cse/Kconfig
1 file changed, 0 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/81976/1
diff --git a/src/soc/intel/common/block/cse/Kconfig b/src/soc/intel/common/block/cse/Kconfig
index b0524ea..d4180eb 100644
--- a/src/soc/intel/common/block/cse/Kconfig
+++ b/src/soc/intel/common/block/cse/Kconfig
@@ -189,30 +189,12 @@
help
Name of CSE region in FMAP
-config SOC_INTEL_CSE_RW_A_FMAP_NAME
- string "Location of CSE RW A in FMAP" if SOC_INTEL_CSE_RW_UPDATE
- default "ME_RW_A"
- help
- Name of CSE RW A region in FMAP
-
-config SOC_INTEL_CSE_RW_B_FMAP_NAME
- string "Location of CSE RW B in FMAP" if SOC_INTEL_CSE_RW_UPDATE
- default "ME_RW_B"
- help
- Name of CSE RW B region in FMAP
-
config SOC_INTEL_CSE_RW_CBFS_NAME
string "CBFS entry name for CSE RW blob" if SOC_INTEL_CSE_RW_UPDATE
default "me_rw"
help
CBFS entry name for Intel CSE CBFS RW blob
-config SOC_INTEL_CSE_RW_HASH_CBFS_NAME
- string "CBFS name for CSE RW hash file" if SOC_INTEL_CSE_RW_UPDATE
- default "me_rw.hash"
- help
- CBFS name for Intel CSE CBFS RW hash file
-
config SOC_INTEL_CSE_RW_VERSION_CBFS_NAME
string "CBFS name for CSE RW version file" if SOC_INTEL_CSE_RW_UPDATE
default "me_rw.version"
--
To view, visit https://review.coreboot.org/c/coreboot/+/81976?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0639f03baf4edcf5f01d6673137dfbab1f2d4a25
Gerrit-Change-Number: 81976
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
Attention is currently required from: Martin L Roth.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77419?usp=email )
Change subject: vc/intel: Remove unnecessary Kconfig options
......................................................................
Patch Set 2:
(1 comment)
File src/vendorcode/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/77419/comment/aef44938_bd152b26 :
PS2, Line 23: config UDK_2013_VERSION
this symbol is not used.
--
To view, visit https://review.coreboot.org/c/coreboot/+/77419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If987b50d8ec3bb2ab99096e5e3c325e4d90a67a9
Gerrit-Change-Number: 77419
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 14:52:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81974?usp=email )
Change subject: drivers/wifi/generic: Drop unused symbol
......................................................................
drivers/wifi/generic: Drop unused symbol
WIFI_MTCL_CBFS_FILEPATH is not used.
Change-Id: Icdd0332ae9c56a54596a775c0a9aa7b9f8d6738c
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/drivers/wifi/generic/Kconfig
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/81974/1
diff --git a/src/drivers/wifi/generic/Kconfig b/src/drivers/wifi/generic/Kconfig
index 4065f67..dab502e 100644
--- a/src/drivers/wifi/generic/Kconfig
+++ b/src/drivers/wifi/generic/Kconfig
@@ -67,8 +67,3 @@
When enabled, adds the MTCL function for MediaTek WiFi chipsets.
This function supplies country list information used to enable or
disable operation on 5.9GHz and 6GHz bands.
-
-config WIFI_MTCL_CBFS_FILEPATH
- string "The cbfs file which has WIFI MTCL defaults"
- depends on USE_MTCL
- default ""
--
To view, visit https://review.coreboot.org/c/coreboot/+/81974?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icdd0332ae9c56a54596a775c0a9aa7b9f8d6738c
Gerrit-Change-Number: 81974
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange