coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[S] Change in coreboot[main]: soc/intel/alderlake: select UDK_202111_BINDING for ADL-N
by Subrata Banik (Code Review) 09 Mar '24

09 Mar '24

Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Ronak Kanabar, V Sowmya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80274?usp=email ) Change subject: soc/intel/alderlake: select UDK_202111_BINDING for ADL-N ...................................................................... Patch Set 7: -Code-Review (1 comment) File src/soc/intel/alderlake/Makefile.mk: https://review.… [View More]

1 0

[XS] Change in coreboot[main]: vendorcode/edk2-stable202302: Remove wchar_t asserts
by Arthur Heymans (Code Review) 09 Mar '24

09 Mar '24

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81192?usp=email ) Change subject: vendorcode/edk2-stable202302: Remove wchar_t asserts ...................................................................... vendorcode/edk2-stable202302: Remove wchar_t asserts Remove those MSVC compiler defaults checks so that the GCC defaults for wchar_t can be used. The FSP interface does not depend on wchar_t. TEST: the resulting binaries are the same for … [View More]intel/mtlrvp Change-Id: I0ee1abc7e9ba46665838b63a6cfe0f4aa300114c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/meteorlake/Makefile.mk M src/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include/Base.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/81192/1 diff --git a/src/soc/intel/meteorlake/Makefile.mk b/src/soc/intel/meteorlake/Makefile.mk index 39a1d65..893523c 100644 --- a/src/soc/intel/meteorlake/Makefile.mk +++ b/src/soc/intel/meteorlake/Makefile.mk @@ -60,5 +60,4 @@ CPPFLAGS_common += -I$(src)/soc/intel/meteorlake CPPFLAGS_common += -I$(src)/soc/intel/meteorlake/include -CFLAGS_common += -fshort-wchar endif diff --git a/src/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include/Base.h b/src/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include/Base.h index f1b9c14..8cdf6aa 100644 --- a/src/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include/Base.h +++ b/src/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include/Base.h @@ -792,8 +792,9 @@ STATIC_ASSERT (sizeof (UINT64) == 8, "sizeof (UINT64) does not meet UEFI Specification Data Type requirements"); STATIC_ASSERT (sizeof (CHAR8) == 1, "sizeof (CHAR8) does not meet UEFI Specification Data Type requirements"); STATIC_ASSERT (sizeof (CHAR16) == 2, "sizeof (CHAR16) does not meet UEFI Specification Data Type requirements"); -STATIC_ASSERT (sizeof (L'A') == 2, "sizeof (L'A') does not meet UEFI Specification Data Type requirements"); -STATIC_ASSERT (sizeof (L"A") == 4, "sizeof (L\"A\") does not meet UEFI Specification Data Type requirements"); +// Removed to have coreboot code compile with the Linux gcc defaults. The FSP interface does not need wchar_t anyway. +//STATIC_ASSERT (sizeof (L'A') == 2, "sizeof (L'A') does not meet UEFI Specification Data Type requirements"); +//STATIC_ASSERT (sizeof (L"A") == 4, "sizeof (L\"A\") does not meet UEFI Specification Data Type requirements"); // // The following three enum types are used to verify that the compiler -- To view, visit https://review.coreboot.org/c/coreboot/+/81192?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0ee1abc7e9ba46665838b63a6cfe0f4aa300114c Gerrit-Change-Number: 81192 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange [View Less]

1 0

[S] Change in coreboot[main]: soc/intel/alderlake: select UDK_202111_BINDING for ADL-N
by Arthur Heymans (Code Review) 09 Mar '24

09 Mar '24

Attention is currently required from: Dinesh Gehlot, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Ronak Kanabar, V Sowmya. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80274?usp=email ) Change subject: soc/intel/alderlake: select UDK_202111_BINDING for ADL-N ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: My suggestion is to just drop the assert. Coreboot isn't UEFI and should … [View More]

1 0

[S] Change in coreboot[main]: soc/intel/alderlake: select UDK_202111_BINDING for ADL-N
by Arthur Heymans (Code Review) 09 Mar '24

09 Mar '24

Attention is currently required from: Dinesh Gehlot, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Ronak Kanabar, V Sowmya. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80274?usp=email ) The change is no longer submittable: All-Comments-Resolved and Code-Review are unsatisfied now. Change subject: soc/intel/alderlake: select UDK_202111_BINDING for ADL-N ...................................................................... Patch Set 7: Code-… [View More]

1 0

[S] Change in coreboot[main]: payloads/Kconfig: Add flat binary as payload option
by Arthur Heymans (Code Review) 09 Mar '24

09 Mar '24

Attention is currently required from: Martin L Roth, Maximilian Brune. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80191?usp=email ) Change subject: payloads/Kconfig: Add flat binary as payload option ...................................................................... Patch Set 2: (1 comment) File payloads/Kconfig: https://review.coreboot.org/c/coreboot/+/80191/comment/e2094e02_03be8af6 : PS2, Line 90: string "Additional cbfstool … [View More]

1 0

[M] Change in coreboot[main]: arch/riscv: use PMP
by ron minnich (Code Review) 09 Mar '24

09 Mar '24

Attention is currently required from: Arthur Heymans, Maximilian Brune, Philipp Hug. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81153?usp=email ) Change subject: arch/riscv: use PMP ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: My trivial S-mode code now runs (it was a different problem) and Linux does two SBI calls. I think this code is right now. The next thing to fix is … [View More]

1 0

[S] Change in coreboot[main]: mb/google/brya: Create nova variant
by Kenneth Chan (Code Review) 09 Mar '24

09 Mar '24

Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Kapil Porwal, Lucas Chen, Nick Vaccaro, Subrata Banik. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81132?usp=email ) Change subject: mb/google/brya: Create nova variant ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81132?usp=email To unsubscribe, or for help … [View More]

1 0

[L] Change in coreboot[main]: util/inteltool: Add support for Alder Lake-N
by Brandon Weeks (Code Review) 09 Mar '24

09 Mar '24

Attention is currently required from: Felix Singer, Pratikkumar V Prajapati, Sean Rhodes. Brandon Weeks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79732?usp=email ) Change subject: util/inteltool: Add support for Alder Lake-N ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79732/comment/684986f6_cde5045a : PS1, Line 8: > > `Possible … [View More]

1 0

[L] Change in coreboot[main]: util/inteltool: Add support for Alder Lake-N
by Brandon Weeks (Code Review) 09 Mar '24

09 Mar '24

Attention is currently required from: Brandon Weeks, Pratikkumar V Prajapati, Sean Rhodes. Hello Pratikkumar V Prajapati, Sean Rhodes, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79732?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: util/inteltool: Add support for Alder Lake-N .........................................… [View More]

1 0

[L] Change in coreboot[main]: util/inteltool: Add support for Alder Lake-N
by Brandon Weeks (Code Review) 09 Mar '24

09 Mar '24

Attention is currently required from: Brandon Weeks, Pratikkumar V Prajapati, Sean Rhodes. Hello Pratikkumar V Prajapati, Sean Rhodes, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79732?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Sean Rhodes, Verified+1 by build bot (Jenkins) Change subject: util/inteltool: Add support for Alder Lake-N ...........… [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024