coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[S] Change in coreboot[main]: genbuild_h: Fix and harden major/minor version parsing
by Maximilian Brune (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Martin L Roth, Nico Huber. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81290?usp=email ) Change subject: genbuild_h: Fix and harden major/minor version parsing ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File util/genbuild_h/genbuild_h.sh: https://review.coreboot.org/c/coreboot/+/81290/comment/826b60cc_4877ec6a : PS1, Line 39: MAJOR_VER="$(echo "${VERSION}" | sed -n 's/^0*$[0-9]*$\.0*$[0-9]*$.*/\1/p')" : MINOR_VER="$(echo "${VERSION}" | sed -n 's/^0*$[0-9]*$\.0*$[0-9]*$.*/\2/p')" > But I looked a little into sed now. If sed should support the `-E', seems in flux. The Open Group doesn't mention it [1]. Yet the GNU sed history claims since 2013 it would be standardized. As always a lot of annoying inconsistency. Personally I don't care and would just assume that it is compatible enough for running on the systems that we actually support. But I agree about not putting it into a bug fix. I guess then lets just play it safe for now (and probably forever). https://review.coreboot.org/c/coreboot/+/81290/comment/cdb56c96_9584cd30 : PS1, Line 40: * > Without -E we don't have + nor {}. My proposal was to add `-E`, but I guess we don't do that now. > Also, the {2} would feel like documenting when we started to use the new version scheme (after 2009) and would make other (downstream) versioning harder without gaining us anything. I try to be as explicit as possible for regular expressions in order to avoid surprises through too ambiguously described regex expressions. But I guess if we really want to support other versioning schemes we don't really have a choice. Fine by me -- To view, visit https://review.coreboot.org/c/coreboot/+/81290?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie39381a8ef4b971556168b6996efeefe6adf2b14 Gerrit-Change-Number: 81290 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 16:51:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: ec/hp/kbc1126/acpi: Drop unnecessary _STA methods
by Felix Held (Code Review) 16 Mar '24

16 Mar '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81206?usp=email ) Change subject: ec/hp/kbc1126/acpi: Drop unnecessary _STA methods ...................................................................... ec/hp/kbc1126/acpi: Drop unnecessary _STA methods _STA unconditionally returning 0xF is pretty much the default[1] and should be removed to reduce some noise. [1] https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/06_Device_Configuration/Devic… Change-Id: I0390767aa866e322c762038c12116a15b280af1a Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81206 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/ec/hp/kbc1126/acpi/ac.asl M src/ec/hp/kbc1126/acpi/ec.asl 2 files changed, 0 insertions(+), 10 deletions(-) Approvals: Nico Huber: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/ec/hp/kbc1126/acpi/ac.asl b/src/ec/hp/kbc1126/acpi/ac.asl index 59681cf..9743045 100644 --- a/src/ec/hp/kbc1126/acpi/ac.asl +++ b/src/ec/hp/kbc1126/acpi/ac.asl @@ -47,11 +47,6 @@ Name (_HID, "ACPI0003") Name (_PCL, Package () { \_SB }) - Method (_STA) - { - Return (0x0F) - } - Method (_PSR) { Local0 = GACS () diff --git a/src/ec/hp/kbc1126/acpi/ec.asl b/src/ec/hp/kbc1126/acpi/ec.asl index afe0a70..ef68cc4 100644 --- a/src/ec/hp/kbc1126/acpi/ec.asl +++ b/src/ec/hp/kbc1126/acpi/ec.asl @@ -12,11 +12,6 @@ IO (Decode16, 0x66, 0x66, 1, 1) }) - Method (_STA) - { - Return (0x0F) - } - OperationRegion (ECRM, EmbeddedControl, 0x00, 0xFF) Field (ECRM, ByteAcc, NoLock, Preserve) { -- To view, visit https://review.coreboot.org/c/coreboot/+/81206?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0390767aa866e322c762038c12116a15b280af1a Gerrit-Change-Number: 81206 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: ec/hp/kbc1126/acpi: Drop unnecessary method arguments
by Felix Held (Code Review) 16 Mar '24

16 Mar '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81205?usp=email ) Change subject: ec/hp/kbc1126/acpi: Drop unnecessary method arguments ...................................................................... ec/hp/kbc1126/acpi: Drop unnecessary method arguments Method(..., 0, NotSerialized) is the default[1] and can be reduced to Method(...) which reduces some noise. TEST=Timeless build produces the same binary [1] https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/19_ASL_Reference/ACPI_Source_… Change-Id: Ic24e004500a7fa2a5a5b38a3f6f0e13e4ce7dfac Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81205 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <inforichland(a)gmail.com> --- M src/ec/hp/kbc1126/acpi/ac.asl M src/ec/hp/kbc1126/acpi/battery.asl M src/ec/hp/kbc1126/acpi/ec.asl M src/ec/hp/kbc1126/acpi/lid.asl 4 files changed, 23 insertions(+), 22 deletions(-) Approvals: Nico Huber: Looks good to me, approved build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, but someone else must approve diff --git a/src/ec/hp/kbc1126/acpi/ac.asl b/src/ec/hp/kbc1126/acpi/ac.asl index f058cef..59681cf 100644 --- a/src/ec/hp/kbc1126/acpi/ac.asl +++ b/src/ec/hp/kbc1126/acpi/ac.asl @@ -52,7 +52,7 @@ Return (0x0F) } - Method (_PSR, 0, NotSerialized) + Method (_PSR) { Local0 = GACS () PWRS = Local0 /* GNVS.PWRS */ @@ -63,7 +63,7 @@ } } -Method (_Q06, 0, NotSerialized) +Method (_Q06) { Printf ("EC: AC STATUS") PWUP (0x05, (0x02 | 0x01)) diff --git a/src/ec/hp/kbc1126/acpi/battery.asl b/src/ec/hp/kbc1126/acpi/battery.asl index e657f4c..ff542a1 100644 --- a/src/ec/hp/kbc1126/acpi/battery.asl +++ b/src/ec/hp/kbc1126/acpi/battery.asl @@ -40,7 +40,7 @@ #define NLB1 0xC8 /* design capacity of warning */ #define NLB2 0x64 /* design capacity of low */ -Method (ITLB, 0, NotSerialized) +Method (ITLB) { Local0 = (NLB1 + 9) % 0x0a Local1 = (NLB1 + 9) / 0x0a @@ -127,17 +127,17 @@ Name (_HID, EisaId ("PNP0C0A")) Name (_UID, 0x01) - Method (_STA, 0, NotSerialized) + Method (_STA) { Return (BSTA (0x01)) } - Method (_BIF, 0, NotSerialized) + Method (_BIF) { Return (BTIF (0x00)) } - Method (_BST, 0, NotSerialized) + Method (_BST) { Return (BTSZ (0x00)) } @@ -153,17 +153,17 @@ Name (_HID, EisaId ("PNP0C0A")) Name (_UID, 0x02) - Method (_STA, 0, NotSerialized) + Method (_STA) { Return (BSTA (0x02)) } - Method (_BIF, 0, NotSerialized) + Method (_BIF) { Return (BTIF (0x01)) } - Method (_BST, 0, NotSerialized) + Method (_BST) { Return (BTSZ (0x01)) } @@ -440,7 +440,7 @@ } } -Method (_Q03, 0, NotSerialized) +Method (_Q03) { Printf ("EC: _Q03") Acquire (BTMX, 0xFFFF) @@ -450,7 +450,7 @@ SBTN (Local0, 0x80) } -Method (_Q08, 0, NotSerialized) +Method (_Q08) { Printf ("EC: PRIMARY BATTERY ATTACHED/DETACHED") PWUP (0x06, 0x01) @@ -470,7 +470,7 @@ } } -Method (_Q09, 0, NotSerialized) +Method (_Q09) { Printf ("EC: PRIMARY BATTERY STATUS") PWUP (0x04, 0x01) @@ -480,7 +480,7 @@ } } -Method (_Q18, 0, NotSerialized) +Method (_Q18) { Printf ("EC: SECONDARY BATTERY ATTACHED/DETACHED") PWUP (0x06, 0x02) @@ -500,7 +500,7 @@ } } -Method (_Q19, 0, NotSerialized) +Method (_Q19) { Printf ("EC: SECONDARY BATTERY STATUS") PWUP (0x04, 0x02) diff --git a/src/ec/hp/kbc1126/acpi/ec.asl b/src/ec/hp/kbc1126/acpi/ec.asl index 4c0056d..afe0a70 100644 --- a/src/ec/hp/kbc1126/acpi/ec.asl +++ b/src/ec/hp/kbc1126/acpi/ec.asl @@ -12,7 +12,7 @@ IO (Decode16, 0x66, 0x66, 1, 1) }) - Method (_STA, 0, NotSerialized) + Method (_STA) { Return (0x0F) } @@ -200,28 +200,28 @@ /* The following are _Qxx methods in vendor DSDT whose function is unknown. Just leave a debug message here. */ - Method (_Q04, 0, NotSerialized) + Method (_Q04) { Printf ("EC: _Q04") PNOT() } - Method (_Q05, 0, NotSerialized) + Method (_Q05) { Printf ("EC: _Q05") } - Method (_Q0B, 0, NotSerialized) + Method (_Q0B) { Printf ("EC: _Q0B") } - Method (_Q0C, 0, NotSerialized) + Method (_Q0C) { Printf ("EC: _Q0C") } - Method (_Q0D, 0, NotSerialized) + Method (_Q0D) { Printf ("EC: _Q0D") } diff --git a/src/ec/hp/kbc1126/acpi/lid.asl b/src/ec/hp/kbc1126/acpi/lid.asl index 1a5134f..ac5c55b 100644 --- a/src/ec/hp/kbc1126/acpi/lid.asl +++ b/src/ec/hp/kbc1126/acpi/lid.asl @@ -3,14 +3,15 @@ Device (LID) { Name (_HID, EisaId ("PNP0C0D")) - Method (_LID, 0, NotSerialized) + + Method (_LID) { Local0 = CLID Return (Local0) } } -Method (_Q0A, 0, NotSerialized) +Method (_Q0A) { Printf ("EC: LID STATUS") Notify (LID, 0x80) -- To view, visit https://review.coreboot.org/c/coreboot/+/81205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic24e004500a7fa2a5a5b38a3f6f0e13e4ce7dfac Gerrit-Change-Number: 81205 Gerrit-PatchSet: 7 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: drivers/intel/gma/acpi: Limit OpRegion size
by Matt DeVillier (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Patrick Rudolph. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81295?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: drivers/intel/gma/acpi: Limit OpRegion size ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: what board(s) is this a problem on? I'm not seeing any issues here on ChromeOS devices from SNB thru RPL -- To view, visit https://review.coreboot.org/c/coreboot/+/81295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia2affa799e5cd84c0a03330e0f78919755f0e8ac Gerrit-Change-Number: 81295 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 15:14:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: acpi/acpi: mark CTBL coreboot table device as hidden
by Felix Held (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Cliff Huang, CoolStar, Lance Zhao, Matt DeVillier, Matt DeVillier, Tim Wawrzynczak. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81264?usp=email ) Change subject: acpi/acpi: mark CTBL coreboot table device as hidden ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > this breaks attachment of coolstar's Windows drivers, which allow non-admin cbmem console access via […] haven't tried that, since i didn't have network plugged in, but is that driver available via windows update? if not, it would be good if it was made available, so that the unknown device warning disappears -- To view, visit https://review.coreboot.org/c/coreboot/+/81264?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifaefeb662da33323460333d9ca9c0e8340720fd1 Gerrit-Change-Number: 81264 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 14:53:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex: Reland RAMTOP caching for Ovis
by Stefan Reinauer (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81270?usp=email ) Change subject: mb/google/rex: Reland RAMTOP caching for Ovis ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81270?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0b73eb8fb9cd6ca70d3d7168b79dfd0fbc550e3 Gerrit-Change-Number: 81270 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 14:51:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Docs/tutorial: Do not install Ada compiler by default
by Felix Held (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Naveen Iyer, Nico Huber. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81296?usp=email ) Change subject: Docs/tutorial: Do not install Ada compiler by default ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: i wonder why the ada compiler is causing issues for some user; always worked for me. i see a lot of value in installing a halfway complete set of tools that might be needed when working on coreboot, so unless there's a very strong reason to not include that, i'd like to keep the ada compiler in there to keep things easier for developers File Documentation/tutorial/part1.md: https://review.coreboot.org/c/coreboot/+/81296/comment/0b756dc0_3741721c : PS2, Line 43: (not available on most Intel boards) most intel socs should be supported by libgfxinit -- To view, visit https://review.coreboot.org/c/coreboot/+/81296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I57f421f7ee1bda4063c13d372fe9c32b95cfd2bc Gerrit-Change-Number: 81296 Gerrit-PatchSet: 2 Gerrit-Owner: Naveen Iyer Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Naveen Iyer Gerrit-Comment-Date: Sat, 16 Mar 2024 14:48:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: amdfwtool: Set the table size only for FWs
by Felix Held (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Bao Zheng, Fred Reitberger, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81255?usp=email ) Change subject: amdfwtool: Set the table size only for FWs ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81255?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5dfbbb55912c8e37243c351427a8df89c12e5da8 Gerrit-Change-Number: 81255 Gerrit-PatchSet: 7 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 14:41:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Docs/tutorial: Do not install Ada compiler by default
by Naveen Iyer (Code Review) 16 Mar '24

16 Mar '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81296?usp=email to look at the new patch set (#2). Change subject: Docs/tutorial: Do not install Ada compiler by default ...................................................................... Docs/tutorial: Do not install Ada compiler by default For newbies starting with coreboot, installing Ada compiler would sometimes result in issues while building the coreboot toolchain. Since the idea of the coreboot tutorial is to only install minimum additional software, installing Ada compiler should not be part of the default step in the tutorial. The warning printed by have_gnat() in util/crossgcc/buildgcc might still be useful. Change-Id: I57f421f7ee1bda4063c13d372fe9c32b95cfd2bc Signed-off-by: Naveen R. Iyer <iyernaveenr(a)gmail.com> --- M Documentation/tutorial/part1.md 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/81296/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I57f421f7ee1bda4063c13d372fe9c32b95cfd2bc Gerrit-Change-Number: 81296 Gerrit-PatchSet: 2 Gerrit-Owner: Naveen Iyer Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: Do not install Ada compiler by default
by Naveen Iyer (Code Review) 16 Mar '24

16 Mar '24

Naveen Iyer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81296?usp=email ) Change subject: Do not install Ada compiler by default ...................................................................... Do not install Ada compiler by default For newbies starting with coreboot, installing Ada compiler would sometimes result in issues while building the coreboot toolchain. Since the idea of the coreboot tutorial is to only install minimum additional software, installing Ada compiler should not be part of the default step in the tutorial. The warning printed by have_gnat() in util/crossgcc/buildgcc might still be useful. Change-Id: I57f421f7ee1bda4063c13d372fe9c32b95cfd2bc Signed-off-by: Naveen R. Iyer <iyernaveenr(a)gmail.com> --- M Documentation/tutorial/part1.md 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/81296/1 diff --git a/Documentation/tutorial/part1.md b/Documentation/tutorial/part1.md index 0500742..2a0b37a 100644 --- a/Documentation/tutorial/part1.md +++ b/Documentation/tutorial/part1.md @@ -29,16 +29,19 @@ ### Step 1 - Install tools and libraries needed for coreboot Debian based distros: -`sudo apt-get install -y bison build-essential curl flex git gnat +`sudo apt-get install -y bison build-essential curl flex gcc git libncurses5-dev libssl-dev m4 zlib1g-dev pkg-config` Arch based distros: -`sudo pacman -S base-devel curl git gcc-ada ncurses zlib` +`sudo pacman -S base-devel curl git gcc ncurses zlib` Redhat based distros: -`sudo dnf install git make gcc-gnat flex bison xz bzip2 gcc g++ +`sudo dnf install git make flex bison xz bzip2 gcc g++ ncurses-devel wget zlib-devel patch` +**Note: If you need additional features like native graphics initialization +(not available on most Intel boards), then you will need the Ada compiler +(GNAT). ### Step 2 - Download coreboot source tree -- To view, visit https://review.coreboot.org/c/coreboot/+/81296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I57f421f7ee1bda4063c13d372fe9c32b95cfd2bc Gerrit-Change-Number: 81296 Gerrit-PatchSet: 1 Gerrit-Owner: Naveen Iyer Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024