coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: 3rdparty/amd_blobs: update submodule pointer
by Matt DeVillier (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Felix Held. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81263?usp=email ) Change subject: 3rdparty/amd_blobs: update submodule pointer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81263?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If1bd0b37bebcdd600465dbd48162792e2c32bfb7 Gerrit-Change-Number: 81263 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 16 Mar 2024 23:58:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/intel/gma/acpi: Limit OpRegion size
by Joel Linn (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Matt DeVillier, Patrick Rudolph. Joel Linn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81295?usp=email ) Change subject: drivers/intel/gma/acpi: Limit OpRegion size ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: > no issue here with samsung/stumpy (SNB) or google/link (IVB) so there has to be more to it Stumbled on this porting to a hp pro 3500 series (SNB). -- To view, visit https://review.coreboot.org/c/coreboot/+/81295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia2affa799e5cd84c0a03330e0f78919755f0e8ac Gerrit-Change-Number: 81295 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Joel Linn Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 23:48:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Docs/tutorial: Do not install Ada compiler by default
by Naveen Iyer (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Felix Held, Nico Huber. Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81296?usp=email ) Change subject: Docs/tutorial: Do not install Ada compiler by default ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > i wonder why the ada compiler is causing issues for some user; always worked for me. […] Thanks for your review. Two points - 1/2) There were linking issues when building crossgcc-i386. Symbols like "__gnat_raise_from_signal_handler" were missing. This symbol is just one example. There were other symbols missing as well. Looked at multiple ways to resolve this: https://mail.coreboot.org/hyperkitty/list/coreboot-gerrit@coreboot.org/mess… Some forums suggested that this issue usually crops up when the versions of gcc and Ada mismatch. For people who want to try coreboot, having to downgrade or upgrade their existing gcc to make sure the versions for both gcc and Ada match might be a roadblock and/or deal breaker. 2/2) Tutorial seems to suggest that only bare minimum necessary to get a newbie to quickly start with coreboot on QEMU was described. However, requiring Ada compiler install, resulting in breaking the coreboot toolchain build process, seems to be an unnecessary hassle for a newbie to deal with. A newbie could always install Ada compiler when they really need it. For example, I, a newbie, did not need Ada compiler in order to boot the coreboot I built using QEMU. BTW, that's why I made this point in my commit: "The warning printed by have_gnat() in util/crossgcc/buildgcc might still be useful." So, experienced users could still stop the build, install Ada compiler if they'd like to, then go back to installing the toolchain. I just have an issue with forcing newbies to install stuff they don't immediately need. Once they see the value of installing something extra, they could always do that then. -- To view, visit https://review.coreboot.org/c/coreboot/+/81296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I57f421f7ee1bda4063c13d372fe9c32b95cfd2bc Gerrit-Change-Number: 81296 Gerrit-PatchSet: 2 Gerrit-Owner: Naveen Iyer Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 16 Mar 2024 23:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/intel/gma/acpi: Limit OpRegion size
by Matt DeVillier (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Patrick Rudolph. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81295?usp=email ) Change subject: drivers/intel/gma/acpi: Limit OpRegion size ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > The ticket lists Lenovo X230, Lenovo W520, Macbookpro10,1 aspire_xc600, hp 8200/6200, hp 8300/6300 ( […] no issue here with samsung/stumpy (SNB) or google/link (IVB) so there has to be more to it -- To view, visit https://review.coreboot.org/c/coreboot/+/81295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia2affa799e5cd84c0a03330e0f78919755f0e8ac Gerrit-Change-Number: 81295 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 21:30:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87E-ITX (Haswell)
by Máté Kukri (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Nicholas Chin. Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email ) Change subject: mb/asrock: Add Z87E-ITX (Haswell) ...................................................................... Patch Set 2: Code-Review+1 (9 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81022/comment/f747fa17_8b9a2342 : PS2, Line 10: output to build against current main. I do not physically have this FIXMEs make sense with this context. If you aren't able to check anything on this board anymore, please ack my comments. Patchset: PS2: LGTM. File src/mainboard/asrock/z87e-itx/Kconfig: PS2: I usually set CBFS_SIZE to cover the BIOS region in the flash descriptor. File src/mainboard/asrock/z87e-itx/data.vbt: PS2: How was this file obtained? Dump under Linux? File src/mainboard/asrock/z87e-itx/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/81022/comment/2fb83ac7_0ab96271 : PS2, Line 11: -- FIXME: check this If you can, maybe try disabling the unused ones? File src/mainboard/asrock/z87e-itx/hda_verb.c: https://review.coreboot.org/c/coreboot/+/81022/comment/b627072f_52ba6768 : PS2, Line 20: This board seems to have HDMI. Can you add the HDA verbs for HDMI audio? File src/mainboard/asrock/z87e-itx/romstage.c: https://review.coreboot.org/c/coreboot/+/81022/comment/0a5cd31c_7dd83929 : PS2, Line 12: /* FIXME: called after romstage_common, remove it if not used */ I guess try removing this? https://review.coreboot.org/c/coreboot/+/81022/comment/38ebf795_9d140329 : PS2, Line 19: /* FIXME: check this */ Can you check which ones are needed with `i2cdetect`? https://review.coreboot.org/c/coreboot/+/81022/comment/047f7171_1e89c1a1 : PS2, Line 27: /* FIXME: Length and Location are computed from IOBP values, may be inaccurate */ If all USB ports work, remove the FIXME? -- To view, visit https://review.coreboot.org/c/coreboot/+/81022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586 Gerrit-Change-Number: 81022 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 20:34:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: acpi/acpi: mark CTBL coreboot table device as hidden
by CoolStar (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Cliff Huang, Felix Held, Lance Zhao, Matt DeVillier, Matt DeVillier, Tim Wawrzynczak. CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81264?usp=email ) Change subject: acpi/acpi: mark CTBL coreboot table device as hidden ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > haven't tried that, since i didn't have network plugged in, but is that driver available via windows […] No. Driver is here: https://github.com/coolstar/driverinstallers/tree/master/crosec/drivers/cor… Putting it on Windows update would require me to register an LLC, buy an EV cert and get an account on the microsoft hardware portal... gets very expensive unfortunately -- To view, visit https://review.coreboot.org/c/coreboot/+/81264?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifaefeb662da33323460333d9ca9c0e8340720fd1 Gerrit-Change-Number: 81264 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 16 Mar 2024 19:54:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: [RFC] region: Introduce region_create() functions
by Maximilian Brune (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Andrey Petrov, Julius Werner, Jérémy Compostella, Martin L Roth, Nico Huber, Ronak Kanabar. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79905?usp=email ) Change subject: [RFC] region: Introduce region_create() functions ...................................................................... Patch Set 6: (1 comment) File src/commonlib/include/commonlib/region.h: https://review.coreboot.org/c/coreboot/+/79905/comment/d321168c_bd8ffdf0 : PS1, Line 103: static inline int region_create_untrusted( > > Well you have to repeat that for all sources that we deem "untrusted". […] Our APIs (the untrusted part) should define the constraints of the parameter. I don't understand why that cannot be independent of the `region_create()`. Do we now need a `untrusted_create` for all our 'subsystems' now? If I have an untrusted interface like SMM, I know the requirements for the parameters passed through this interface and can therefore verify them. If I pass the 'verified' parameters to trusted code like `region_create()`, I know both interfaces (the SMM interface and the region interface) and can make sure I only pass valid/sane parameters in there. I think I am missing an actual example where the separation of the validity check and the `region_create()` can lead to issues. -- To view, visit https://review.coreboot.org/c/coreboot/+/79905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4ae3e6274c981c9ab4fb1263c2a72fa68ef1c32b Gerrit-Change-Number: 79905 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 18:01:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/intel/gma/acpi: Limit OpRegion size
by Patrick Rudolph (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Matt DeVillier. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81295?usp=email ) Change subject: drivers/intel/gma/acpi: Limit OpRegion size ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > what board(s) is this a problem on? I'm not seeing any issues here on ChromeOS devices from SNB thru […] The ticket lists Lenovo X230, Lenovo W520, Macbookpro10,1 aspire_xc600, hp 8200/6200, hp 8300/6300 (affected) Those are quite old systems, so it's possible that the issue only affects SNB/IVB. -- To view, visit https://review.coreboot.org/c/coreboot/+/81295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia2affa799e5cd84c0a03330e0f78919755f0e8ac Gerrit-Change-Number: 81295 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 17:55:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/riscv: add constants for Base Extension
by Maximilian Brune (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Arthur Heymans, Philipp Hug, ron minnich. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81286?usp=email ) Change subject: arch/riscv: add constants for Base Extension ...................................................................... Patch Set 1: (2 comments) File src/arch/riscv/include/sbi.h: https://review.coreboot.org/c/coreboot/+/81286/comment/0dac053a_20f59f1c : PS1, Line 20: #define SBI_EXTENSION_ID 0x10 I would change the name to SBI_BASE_EXTENSION (makes it more easy to find the appropriate place in the SBI spec). https://review.coreboot.org/c/coreboot/+/81286/comment/fc9d4b6d_62b94c35 : PS1, Line 20: define SBI_EXTENSION_ID 0x10 : #define SBI_GET_SBI_SPEC_VERSION 0 : #define SBI_GET_SBI_IMPL_ID 1 : #define SBI_GET_SBI_IMPL_VERSION 2 : #define SBI_PROBE_EXTENSION 3 : #define SBI_GET_MVENDORID 4 : #define SBI_GET_MARCHID 5 : #define SBI_GET_MIMPID 6 maybe something like this: ``` #define SBI_BASE_EXTENSION 0x10 # define SBI_GET_SBI_SPEC_VERSION 0 # define SBI_GET_SBI_IMPL_ID 1 # define SBI_GET_SBI_IMPL_VERSION 2 # define SBI_PROBE_EXTENSION 3 # define SBI_GET_MVENDORID 4 # define SBI_GET_MARCHID 5 # define SBI_GET_MIMPID 6 ``` to visualize the attachment of the FIDs to the specific EID. -- To view, visit https://review.coreboot.org/c/coreboot/+/81286?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaad763464678d1921dfefdbee1e39fba2fe5585a Gerrit-Change-Number: 81286 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 17:34:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: genbuild_h: Fix and harden major/minor version parsing
by Nico Huber (Code Review) 16 Mar '24

16 Mar '24

Attention is currently required from: Martin L Roth. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81290?usp=email ) Change subject: genbuild_h: Fix and harden major/minor version parsing ...................................................................... Patch Set 1: (1 comment) File util/genbuild_h/genbuild_h.sh: https://review.coreboot.org/c/coreboot/+/81290/comment/19bc85b9_1c5d2be2 : PS1, Line 39: MAJOR_VER="$(echo "${VERSION}" | sed -n 's/^0*$[0-9]*$\.0*$[0-9]*$.*/\1/p')" : MINOR_VER="$(echo "${VERSION}" | sed -n 's/^0*$[0-9]*$\.0*$[0-9]*$.*/\2/p')" > > But I looked a little into sed now. If sed should support the `-E', seems in flux. […] I've been looking some more into it. And it turns out that what is published by the Open Group so far is the 2018 edition of Issue 7. And what they have been cooking up for the last 15 years is Issue 8 (with the sed changes made to the draft in 2012). IMO quite annoying when it takes decades to change something (they got from the first version to Issue 7 within 20 years, what's holding them back now?). Though, I'm quite happy now that I know that people kind of agreed on `-E` for sed. This was always annoying me that we had it for grep but not for sed. So maybe it's time to risk using it in general (GNU, BSD and Busybox seem covered). -- To view, visit https://review.coreboot.org/c/coreboot/+/81290?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie39381a8ef4b971556168b6996efeefe6adf2b14 Gerrit-Change-Number: 81290 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 16 Mar 2024 17:25:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024