Attention is currently required from: Arthur Heymans, Jérémy Compostella.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81379?usp=email )
Change subject: Kconfig: Make GBD_STUB and long mode mutually exclusive
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81379?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icaf7d0763829d5badf73d38bb8fc3d36cfe18964
Gerrit-Change-Number: 81379
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 21 Mar 2024 16:14:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Maximilian Brune, Patrick Georgi, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81410?usp=email )
Change subject: arch/riscv: add Kconfig variable RISCV_HAS_MENVCFG
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81410/comment/92e62295_d70cdda8 :
PS1, Line 10: Provide a Kconfig variable, default y, to enable it.
> What happens if it's enabled but not present in the chip vs if it's present but disabled? Is this de […]
that's why it's not interactive. If it's enabled in the binary, but not enabled in the part, you'll get a fault. There are very few parts that do not have it IIUC, it went in a while ago.
The printf is a placeholder for hug's code.
You're right, it changes the binary, what am I thinking.
Patchset:
PS1:
> Why wouldn't this change the binary? You're adding code. […]
yeah, you're right. I wonder if it's best to yank out the code change for now?
File src/arch/riscv/payload.c:
https://review.coreboot.org/c/coreboot/+/81410/comment/4e1e4f8f_acc006de :
PS1, Line 72: part
> Nit: Chip? SOC? […]
I like that. Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I627dde377708cde2491d4abe625c482d64f7aa87
Gerrit-Change-Number: 81410
Gerrit-PatchSet: 2
Gerrit-Owner: ron minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Thu, 21 Mar 2024 16:13:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Comment-In-Reply-To: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: comment
Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80313?usp=email )
(
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: util/docker/: Drop recommonmark pip module
......................................................................
util/docker/: Drop recommonmark pip module
The documentation is now built using MyST Parser, so Recommonmark can be
dropped.
Change-Id: I7f6810c9429573c0c51d3d72b36e9fc2ae2185f5
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80313
Reviewed-by: Martin L Roth <gaumless(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M util/docker/coreboot-jenkins-node/Dockerfile
M util/docker/doc.coreboot.org/Dockerfile
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Martin L Roth: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile
index d1a5de9..51a4b27 100644
--- a/util/docker/coreboot-jenkins-node/Dockerfile
+++ b/util/docker/coreboot-jenkins-node/Dockerfile
@@ -78,7 +78,6 @@
pip3 install --no-cache-dir \
setuptools==58.2.0 \
jinja2==3.1.3 \
- recommonmark===0.7.1 \
myst-parser===2.0.0 \
sphinx===7.2.6 \
sphinxcontrib-ditaa===1.0.2 \
diff --git a/util/docker/doc.coreboot.org/Dockerfileb/util/docker/doc.coreboot.org/Dockerfile
index d0c32c9..3f28c83 100644
--- a/util/docker/doc.coreboot.org/Dockerfile
+++ b/util/docker/doc.coreboot.org/Dockerfile
@@ -14,7 +14,6 @@
pip3 install --upgrade --no-cache-dir pip && \
pip3 install --no-cache-dir \
jinja2==3.1.3 \
- recommonmark===0.7.1 \
myst-parser==2.0.0 \
sphinx===7.2.6 \
sphinxcontrib-ditaa===1.0.2 \
--
To view, visit https://review.coreboot.org/c/coreboot/+/80313?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7f6810c9429573c0c51d3d72b36e9fc2ae2185f5
Gerrit-Change-Number: 80313
Gerrit-PatchSet: 5
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Maximilian Brune, Patrick Georgi, Philipp Hug, ron minnich.
Hello Martin L Roth, Maximilian Brune, Patrick Georgi, Philipp Hug,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81410?usp=email
to look at the new patch set (#3).
Change subject: arch/riscv: add Kconfig variable RISCV_HAS_MENVCFG
......................................................................
arch/riscv: add Kconfig variable RISCV_HAS_MENVCFG
Older parts do not have the menvcfg csr.
Provide a Kconfig variable, default y, to enable it.
Check the variable in the payload code, when coreboot SBI
is used, and print out if it is enabled.
Add constants for this new CSR.
Signed-off-by: Ronald G Minnich <rminnich(a)gmail.com>
Change-Id: I627dde377708cde2491d4abe625c482d64f7aa87
---
M src/arch/riscv/Kconfig
M src/arch/riscv/include/arch/encoding.h
M src/arch/riscv/payload.c
3 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/81410/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/81410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I627dde377708cde2491d4abe625c482d64f7aa87
Gerrit-Change-Number: 81410
Gerrit-PatchSet: 3
Gerrit-Owner: ron minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sean Rhodes.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81395?usp=email )
Change subject: Revert "mb/starlabs/starbook/{adl,rpl}: Disable GpioOverride"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81395?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f83e79c1b21a6c3799abed4a279b8bd59ac3570
Gerrit-Change-Number: 81395
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Thu, 21 Mar 2024 16:10:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81394?usp=email )
Change subject: mb/starlabs/starbook/adl: Correct the layout
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81394?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibdec5121518452ec16cebcc4f2fb563355373be3
Gerrit-Change-Number: 81394
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Thu, 21 Mar 2024 16:09:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Maximilian Brune, Patrick Georgi, Philipp Hug, ron minnich.
Hello Martin L Roth, Maximilian Brune, Patrick Georgi, Philipp Hug,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81410?usp=email
to look at the new patch set (#2).
Change subject: arch/riscv: add Kconfig variable RISCV_HAS_MENVCFG
......................................................................
arch/riscv: add Kconfig variable RISCV_HAS_MENVCFG
Older parts do not have the menvcfg csr.
Provide a Kconfig variable, default y, to enable it.
Check the variable in the payload code, when coreboot SBI
is used, and print out if it is enabled.
Add constants for this new CSR.
Signed-off-by: Ronald G Minnich <rminnich(a)gmail.com>
Change-Id: I627dde377708cde2491d4abe625c482d64f7aa87
---
M src/arch/riscv/Kconfig
M src/arch/riscv/include/arch/encoding.h
M src/arch/riscv/payload.c
3 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/81410/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I627dde377708cde2491d4abe625c482d64f7aa87
Gerrit-Change-Number: 81410
Gerrit-PatchSet: 2
Gerrit-Owner: ron minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset