Attention is currently required from: Felix Held, Fred Reitberger, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78281?usp=email )
Change subject: amdfwtool: Use macro to get the table relative address
......................................................................
Patch Set 9:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/78281/comment/c905e5ac_8d07a802 :
PS8, Line 1219: (char *)ctx->biosdir - ctx->rom
> can BUFF_TO_RUN_MODE(*ctx, ctx->biosdir, AMD_ADDR_REL_BIOS) be used here?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/78281?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iece4ba65e0476543a8d472168d93801714330dde
Gerrit-Change-Number: 78281
Gerrit-PatchSet: 9
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 21 Mar 2024 23:41:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Zheng Bao.
Hello Felix Held, Fred Reitberger, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78281?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Code-Review+2 by Felix Held, Verified+1 by build bot (Jenkins)
Change subject: amdfwtool: Use macro to get the table relative address
......................................................................
amdfwtool: Use macro to get the table relative address
TEST=Identical binary test on all AMD SOC platform
Change-Id: Iece4ba65e0476543a8d472168d93801714330dde
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/78281/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/78281?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iece4ba65e0476543a8d472168d93801714330dde
Gerrit-Change-Number: 78281
Gerrit-PatchSet: 9
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin L Roth.
Hello Martin L Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81419?usp=email
to look at the new patch set (#2).
Change subject: [for test] upgrade LLVM to 18.1.2 and CMake to 3.29.0
......................................................................
[for test] upgrade LLVM to 18.1.2 and CMake to 3.29.0
Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/clang-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/clang-18.1.2.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-18.1.2.src.tar.xz.cksum
D util/crossgcc/sum/cmake-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/cmake-18.1.2.src.tar.xz.cksum
D util/crossgcc/sum/cmake-3.28.3.tar.gz.cksum
A util/crossgcc/sum/cmake-3.29.0.tar.gz.cksum
D util/crossgcc/sum/compiler-rt-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-18.1.2.src.tar.xz.cksum
A util/crossgcc/sum/libunwind-18.1.2.src.tar.xz.cksum
A util/crossgcc/sum/lld-18.1.2.src.tar.xz.cksum
D util/crossgcc/sum/llvm-17.0.6.src.tar.xz.cksum
A util/crossgcc/sum/llvm-18.1.2.src.tar.xz.cksum
15 files changed, 22 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/81419/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb
Gerrit-Change-Number: 81419
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held, Varshit Pandya.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81384?usp=email )
Change subject: vc/amd/opensil/genoa_poc/mpio: add debug output for unused chip
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81384?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4fc28d39a229494b487b300b28f92bf3adad66f5
Gerrit-Change-Number: 81384
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 21 Mar 2024 21:54:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81383?usp=email )
Change subject: vc/amd/opensil/genoa_poc/mpio: fix unused MPIO chip warning
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81383?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f55a3f8e1d220d4eb7b0287d03b7af2e5d2889f
Gerrit-Change-Number: 81383
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 21 Mar 2024 21:53:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81342?usp=email )
Change subject: vc/amd/opensil/genoa_poc/mpio: use device status for port_present
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieaa2af6c5ff3fc7e25992e7fdf14d37ee4a57d62
Gerrit-Change-Number: 81342
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 21 Mar 2024 21:53:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81341?usp=email )
Change subject: vc/amd/opensil/genoa_poc/mpio: simplify per_device_config arguments
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81341?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0466f7ad2f5c9874d45712fa9f89b978bd2a09bc
Gerrit-Change-Number: 81341
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 21 Mar 2024 21:52:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Varshit Pandya.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81340?usp=email )
Change subject: vc/amd/opensil/genoa_poc/mpio: move PCIe port function below mpio chip
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81340?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e39bf68d30d7d00b16f943953e8207d6fe9ef41
Gerrit-Change-Number: 81340
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 21 Mar 2024 21:51:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment