coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[S] Change in coreboot[main]: arch/riscv: add Kconfig variable RISCV_SOC_HAS_MENVCFG
by Nico Huber (Code Review) 22 Mar '24

22 Mar '24

Attention is currently required from: Maximilian Brune, Patrick Georgi, Philipp Hug, ron minnich. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81410?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: arch/riscv: add Kconfig variable RISCV_SOC_HAS_MENVCFG ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/arch/riscv/Kconfig: https://review.coreboot.org/c/coreboot/+/81410/comment/a7f59a98_03ccbb83 : PS5, Line 120: depends on (!SOC_SIFIVE_FU540 && !SOC_SIFIVE_FU740) Wouldn't it be better to handle this locally, e.g. in `soc/sifive/fu540/Kconfig` ``` config RISCV_SOC_HAS_MENVCFG default n ``` Even if we know that there won't be more cases, listing special cases in common code is rather discouraged and we wouldn't want such a pattern to spread. -- To view, visit https://review.coreboot.org/c/coreboot/+/81410?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I627dde377708cde2491d4abe625c482d64f7aa87 Gerrit-Change-Number: 81410 Gerrit-PatchSet: 5 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 22 Mar 2024 10:38:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/xeon_sp/gnr: Add soc_pci_domain_fill_ssdt
by Shuo Liu (Code Review) 22 Mar '24

22 Mar '24

Attention is currently required from: Arthur Heymans, Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81374?usp=email ) Change subject: soc/intel/xeon_sp/gnr: Add soc_pci_domain_fill_ssdt ...................................................................... Patch Set 4: (2 comments) File src/soc/intel/xeon_sp/gnr/soc_acpi.c: https://review.coreboot.org/c/coreboot/+/81374/comment/2f54986b_4411af48 : PS4, Line 83: acpigen_write_scope > acpigen_write_scope(acpi_device_scope(domain)); Done https://review.coreboot.org/c/coreboot/+/81374/comment/8e929c0c_c7d61492 : PS4, Line 87: > Those tabs after * are confusing. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81374?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I28bfdf74d8044235f79f67d832860d8b4306670c Gerrit-Change-Number: 81374 Gerrit-PatchSet: 4 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 22 Mar 2024 10:20:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/xeon_sp: Use fixed BDF for IBL
by Shuo Liu (Code Review) 22 Mar '24

22 Mar '24

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, TangYiwei, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81321?usp=email ) Change subject: soc/intel/xeon_sp: Use fixed BDF for IBL ...................................................................... Patch Set 8: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81321/comment/1c089f5f_cf6aeb9c : PS8, Line 8: > In general, I am in favor of using the full name of an acronym the first time it is being used in do […] Acknowledged https://review.coreboot.org/c/coreboot/+/81321/comment/078c5996_1ebbbd48 : PS8, Line 9: IBL codes doesn't support bootloader controlled P2SB hidden and > s/IBL/Intermediate Bootloader (IBL)/ Done https://review.coreboot.org/c/coreboot/+/81321/comment/3d28bffe_84287300 : PS8, Line 10: unhidden. Hence, dyanmically read IBL HPET/IOAPIC BDF by > s/BDF/Bus:Device. […] Done https://review.coreboot.org/c/coreboot/+/81321/comment/5359aaa2_2be40b59 : PS8, Line 11: bootloader is not supported, because when P2SB is hidden the > s/P2SB/Primary-to-Sideband Bridge (P2SB)/ Done File src/soc/intel/xeon_sp/util.c: https://review.coreboot.org/c/coreboot/+/81321/comment/7d1e6097_85cc6801 : PS8, Line 95: if (CONFIG(SOC_INTEL_COMMON_IBL_BASE)) { > line length limit in coreboot is 96 characters. I don't know why checkpatch did not catch that. […] Done https://review.coreboot.org/c/coreboot/+/81321/comment/b15e0fee_5152708c : PS8, Line 105: union p2sb_bdf bdf = {.bus = PCH_IOAPIC_BUS_NUMBER, .dev = PCH_IOAPIC_DEV_NUM, .fn = PCH_IOAPIC_FUNC_NUM}; > same here. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81321?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3975cb00e215c4984c63bb8510e8aef7d4cc85a4 Gerrit-Change-Number: 81321 Gerrit-PatchSet: 8 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: TangYiwei Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 22 Mar 2024 10:13:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/docker: Place proper SELinux labels on volumes
by Nicholas Sudsgaard (Code Review) 22 Mar '24

22 Mar '24

Attention is currently required from: Martin L Roth. Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81420?usp=email ) Change subject: util/docker: Place proper SELinux labels on volumes ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'm not entirely sure whether this would affect the Jenkins side of things. -- To view, visit https://review.coreboot.org/c/coreboot/+/81420?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0a5000471d3578ddb79f532af4713f289919e2da Gerrit-Change-Number: 81420 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 22 Mar 2024 06:35:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/docker: Place proper SELinux labels on volumes
by Nicholas Sudsgaard (Code Review) 22 Mar '24

22 Mar '24

Attention is currently required from: Martin L Roth. Hello Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81420?usp=email to look at the new patch set (#2). Change subject: util/docker: Place proper SELinux labels on volumes ...................................................................... util/docker: Place proper SELinux labels on volumes Without the :z (or :Z) option SELinux will deny running processes in the container. :z is used instead of :Z, as sharing the container content is wanted in this situation. There are some pitfalls of using the :z or :Z option, however, as far as I know there should not be any issues with that when using this makefile. TEST=Works with an SELinux enabled system (Fedora 39) Change-Id: I0a5000471d3578ddb79f532af4713f289919e2da Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> --- M util/docker/Makefile 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/81420/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81420?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0a5000471d3578ddb79f532af4713f289919e2da Gerrit-Change-Number: 81420 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: util/docker: Place proper SELinux labels on volumes
by Nicholas Sudsgaard (Code Review) 22 Mar '24

22 Mar '24

Nicholas Sudsgaard has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81420?usp=email ) Change subject: util/docker: Place proper SELinux labels on volumes ...................................................................... util/docker: Place proper SELinux labels on volumes Without the :z (or :Z) option SELinux will deny running processes in the container. :z is used instead of :Z, as sharing the container content is wanted in this situation. There are some pitfalls of using the :z or :Z option, however, as far as I know there should not be any issues with that when using this makefile. TEST=Works with an SELinux enabled system (Fedora 39) Change-Id: I0a5000471d3578ddb79f532af4713f289919e2da Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> --- M util/docker/Makefile 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/81420/1 diff --git a/util/docker/Makefile b/util/docker/Makefile index 45562d7..f3c4acf 100644 --- a/util/docker/Makefile +++ b/util/docker/Makefile @@ -109,8 +109,8 @@ docker-run-local: test-docker $(DOCKER_CCACHE) $(DOCKER) run -it --rm \ - --volume $(DOCKER_CCACHE):/home/coreboot/.ccache \ - --volume $(top):/home/coreboot/coreboot \ + --volume $(DOCKER_CCACHE):/home/coreboot/.ccache:z \ + --volume $(top):/home/coreboot/coreboot:z \ --env HOME=/home/coreboot \ --user $(UID):$(GID) \ coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) \ @@ -146,7 +146,7 @@ docker-jenkins-server: test-docker-cache-dir test-docker $(DOCKER) run -d --privileged --restart=always \ -p $(COREBOOT_JENKINS_PORT):49151 \ - -v $(COREBOOT_JENKINS_CACHE_DIR):/data/cache \ + -v $(COREBOOT_JENKINS_CACHE_DIR):/data/cache:z \ --name=$(COREBOOT_JENKINS_CONTAINER) \ coreboot/coreboot-jenkins-node:$(COREBOOT_IMAGE_TAG) @@ -154,8 +154,8 @@ $(DOCKER) run -u root -it --privileged \ --entrypoint="/bin/bash" \ -p $(COREBOOT_JENKINS_PORT):49151 \ - -v $(top):/home/coreboot/coreboot \ - -v $(COREBOOT_JENKINS_CACHE_DIR):/data/cache \ + -v $(top):/home/coreboot/coreboot:z \ + -v $(COREBOOT_JENKINS_CACHE_DIR):/data/cache:z \ --name=$(COREBOOT_JENKINS_CONTAINER) \ --rm coreboot/coreboot-jenkins-node:$(COREBOOT_IMAGE_TAG) @@ -164,7 +164,7 @@ $(DOCKER) run -u $(USER) -it \ -e COLUMNS=$(shell tput cols) -e LINES=$(shell tput lines) -e TERM=$(TERM) \ -w /home/coreboot/coreboot \ - -v $(top):/home/coreboot/coreboot \ + -v $(top):/home/coreboot/coreboot:z \ --rm coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) \ /bin/bash -l @@ -180,14 +180,14 @@ mkdir -p $(top)/Documentation/_build $(DOCKER) run -it --rm \ --user $(UID):$(GID) \ - -v "$(top)/:/data-in/:ro" \ - -v "$(top)/Documentation/_build/:/data-out/" \ + -v "$(top)/:/data-in/:ro,z" \ + -v "$(top)/Documentation/_build/:/data-out/:z" \ doc.coreboot.org docker-livehtml-docs: test-docker docker-livehtml-docs: $(DOCKER) run -it --rm \ - --net=host -v "$(top)/:/data-in/:ro" \ + --net=host -v "$(top)/:/data-in/:ro,z" \ doc.coreboot.org livehtml help: -- To view, visit https://review.coreboot.org/c/coreboot/+/81420?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0a5000471d3578ddb79f532af4713f289919e2da Gerrit-Change-Number: 81420 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: soc/intel/xeon_sp/spr: Move XHCI code into southbridge folder
by Shuo Liu (Code Review) 22 Mar '24

22 Mar '24

Attention is currently required from: Arthur Heymans, Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81370?usp=email ) Change subject: soc/intel/xeon_sp/spr: Move XHCI code into southbridge folder ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81370?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2206ec5426a0f922cfce0e2d968e6806d349a6b2 Gerrit-Change-Number: 81370 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 22 Mar 2024 06:00:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp/spr: Drop unused defines
by Shuo Liu (Code Review) 22 Mar '24

22 Mar '24

Attention is currently required from: Arthur Heymans, Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81369?usp=email ) Change subject: soc/intel/xeon_sp/spr: Drop unused defines ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81369?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I507b08a62ebeae14a1e63f4340b0592605a32477 Gerrit-Change-Number: 81369 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 22 Mar 2024 05:59:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
by Joel Linn (Code Review) 22 Mar '24

22 Mar '24

Attention is currently required from: Matt DeVillier, Nicholas Chin. Joel Linn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email ) Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge) ...................................................................... Patch Set 2: (3 comments) File src/mainboard/hp/pro_3500_series/Kconfig: https://review.coreboot.org/c/coreboot/+/81368/comment/efc2ac99_e47ac625 : PS2, Line 37: # FIXME: check this > if checked, remove fixme I unfortunately have no EHCI debugger so I can't test this File src/mainboard/hp/pro_3500_series/early_init.c: https://review.coreboot.org/c/coreboot/+/81368/comment/9b854217_2163701b : PS2, Line 18: FIXME: Unknown current: RCBA(0x350c)=0x350c > address fixme comments Can you point me in some direction/to some documentation about the usb configuration? File src/superio/ite/common/early_serial.c: PS2: > 2nd Yes will move them to the previous changeset in the chain as it was already suggested there. -- To view, visit https://review.coreboot.org/c/coreboot/+/81368?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a Gerrit-Change-Number: 81368 Gerrit-PatchSet: 2 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 22 Mar 2024 05:53:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp/spr: Drop unused defines
by Jincheng Li (Code Review) 22 Mar '24

22 Mar '24

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu. Jincheng Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81369?usp=email ) Change subject: soc/intel/xeon_sp/spr: Drop unused defines ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > will test archercity as well. done -- To view, visit https://review.coreboot.org/c/coreboot/+/81369?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I507b08a62ebeae14a1e63f4340b0592605a32477 Gerrit-Change-Number: 81369 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 22 Mar 2024 05:18:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024