Attention is currently required from: Crystal Guo, Hung-Te Lin, Xi Chen, Xixi Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80687?usp=email )
Change subject: soc/mediatek: Add `MEDIATEK_DRAM_ADAPTIVE` config to support dram adaptive
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80687/comment/76ecd995_a5fe63a1 :
PS2, Line 9: Starting from MT8195
> People would need to know the history of MediaTek platforms in order to understand what this means e […]
Done
File src/soc/mediatek/common/memory.c:
--
To view, visit https://review.coreboot.org/c/coreboot/+/80687?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I05a01b1ab13fbf19b2a908c48a540a5c2e1ccbdc
Gerrit-Change-Number: 80687
Gerrit-PatchSet: 3
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 23 Feb 2024 05:13:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Varshit Pandya.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80701?usp=email )
Change subject: soc/amd/glinda: Update GPP_CLK_OUTPUT_AVAILABLE
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80701?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I26e9dea58b2ddf5cbedbcccb8bcbc5f9efab3165
Gerrit-Change-Number: 80701
Gerrit-PatchSet: 1
Gerrit-Owner: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 23 Feb 2024 05:12:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Crystal Guo, Hung-Te Lin, Xi Chen, Xixi Chen, Yidi Lin.
Hello Crystal Guo, Hung-Te Lin, Xi Chen, Xixi Chen, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80687?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Xixi Chen, Verified+1 by build bot (Jenkins)
Change subject: soc/mediatek: Add `MEDIATEK_DRAM_ADAPTIVE` config to support dram adaptive
......................................................................
soc/mediatek: Add `MEDIATEK_DRAM_ADAPTIVE` config to support dram adaptive
Starting from MT8195, MediaTek platform supports "dram adaptive" to
automatically detect dram information, including channel, rank, die
size..., and can automatically configure EMI settings. So we can just
pass a placeholder param blob to `mt_mem_init_run` by enabling this
option.
Platforms (MT8173, MT8183, MT8192) which do not support "dram adaptive"
need to implement `get_sdram_config` to get onboard DRAM configuration
info.
TEST=emerge-geralt coreboot && emerge-asurada coreboot
TEST=CONFIG_MEDIATEK_DRAM_ADAPTIVE is set to y on geralt
TEST=CONFIG_MEDIATEK_DRAM_ADAPTIVE is no set on asurada
Change-Id: I05a01b1ab13fbf19b2a908c48a540a5c2e1ccbdc
Signed-off-by: Yidi Lin <yidilin(a)chromium.org>
---
M src/mainboard/google/cherry/Makefile.mk
D src/mainboard/google/cherry/sdram_configs.c
M src/mainboard/google/corsola/Makefile.mk
D src/mainboard/google/corsola/sdram_configs.c
M src/mainboard/google/geralt/Makefile.mk
D src/mainboard/google/geralt/sdram_configs.c
M src/soc/mediatek/common/Kconfig
M src/soc/mediatek/common/include/soc/dramc_param_common.h
M src/soc/mediatek/common/memory.c
M src/soc/mediatek/mt8186/include/soc/dramc_param.h
M src/soc/mediatek/mt8188/include/soc/dramc_param.h
M src/soc/mediatek/mt8192/include/soc/dramc_param.h
M src/soc/mediatek/mt8195/include/soc/dramc_param.h
13 files changed, 24 insertions(+), 55 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/80687/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80687?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I05a01b1ab13fbf19b2a908c48a540a5c2e1ccbdc
Gerrit-Change-Number: 80687
Gerrit-PatchSet: 3
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Forest Mittelberg, Matt DeVillier.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80712?usp=email )
Change subject: ec/chromeec: Enable auto fan control on startup
......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/80712/comment/a250fcef_de8fe3f4 :
PS1, Line 1195: google_chromeec_command
you should be able to call `ec_cmd_thermal_auto_fan_ctrl()`
from `chromeec/ec_cmd_api.h` instead of having to set up
the command struct here.
see some of the other ec_cmd_*() calls here for examples.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80712?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I08a8562531f8af0c71230477d0221d536443f096
Gerrit-Change-Number: 80712
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Fri, 23 Feb 2024 05:09:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans, Jérémy Compostella, Nick Vaccaro, Nico Huber, Shelley Chen, Tarun Tuli, Tim Wawrzynczak.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67490?usp=email )
Change subject: gma: Update DP training with new fields
......................................................................
Patch Set 23:
(1 comment)
File common/ironlake/hw-gfx-gma-pch-dp.ads:
https://review.coreboot.org/c/libgfxinit/+/67490/comment/4d38b41c_13027acd :
PS19, Line 26: Reason => "Needed for a common interface"
> Hi Arthur, […]
@arthur@aheymans.xyz could you please share your thoughts on the above comment?
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67490?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I3f7f8a93408a74cfa29d1493a48c88ce73dc690c
Gerrit-Change-Number: 67490
Gerrit-PatchSet: 23
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Shelley Chen <shchen(a)google.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Fri, 23 Feb 2024 04:35:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen(a)google.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment