coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3066 discussions

[S] Change in coreboot[main]: util/amdfwtool: build amdfwtool only for all tools or AMD CPUs
by Martin L Roth (Code Review) 23 Feb '24

23 Feb '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian, Matt DeVillier, Stefan Reinauer, ron minnich. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80714?usp=email ) Change subject: util/amdfwtool: build amdfwtool only for all tools or AMD CPUs ...................................................................... Patch Set 2: (3 comments) File Makefile: https://review.coreboot.org/c/coreboot/+/80714/comment/807a8a26_5dd84582 : PS2, Line 143: : ifneq ($(filter tools, $(MAKECMDGOALS)), ) : BUILD_ALL_TOOLS:=1 : endif > What does this do? A comment about the intention would be nice Done File util/amdfwtool/Makefile: https://review.coreboot.org/c/coreboot/+/80714/comment/27907e80_4400a472 : PS2, Line 20: BUILD_ALL_TOOLS := 1 > Do we need this? IIUC the build targets in this makefile here will apply when a user comes into this […] Not the way it's written now. I've removed this from this patch and added it to a follow-on that rewrites the Makefile to use what we can from Makefile.mk so that we don't need to update two makefiles when something changes. File util/amdfwtool/Makefile.mk: https://review.coreboot.org/c/coreboot/+/80714/comment/d55816d9_cd626d5d : PS2, Line 31: endif #($(CONFIG_USE_AMDFWTOOL),y) > #($(BUILD_ALL_TOOLS)$(CONFIG_USE_AMDFWTOOL),) Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80714?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9021674a06d65a79e24020790d317ab947c505fe Gerrit-Change-Number: 80714 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 23 Feb 2024 03:39:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: amdfwtool: Use Makefile.mk for Makefile settings
by Martin L Roth (Code Review) 23 Feb '24

23 Feb '24

Attention is currently required from: Martin L Roth. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80715?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: amdfwtool: Use Makefile.mk for Makefile settings ...................................................................... amdfwtool: Use Makefile.mk for Makefile settings When updating the Makefiles, to keep from having to update two files at the same time, import Makefile.mk into the external Makefile. This allows the bulk of the settings to be in a single location. While I'm here, I adjusted the print statements to match the rest of coreboot. Change-Id: Id5b869f49b34b22e6a02fc086e7b42975141a87e Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M util/amdfwtool/Makefile M util/amdfwtool/Makefile.mk 2 files changed, 22 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/80715/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80715?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id5b869f49b34b22e6a02fc086e7b42975141a87e Gerrit-Change-Number: 80715 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: vboot: Enable new arm64 SIMD crypto acceleration
by Yu-Ping Wu (Code Review) 23 Feb '24

23 Feb '24

Attention is currently required from: Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80710?usp=email ) Change subject: vboot: Enable new arm64 SIMD crypto acceleration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80710?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3820bd6b7505202b7edb6768385ce5deb18777a4 Gerrit-Change-Number: 80710 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 23 Feb 2024 03:03:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: util: Add hda-decoder
by Nicholas Sudsgaard (Code Review) 23 Feb '24

23 Feb '24

Attention is currently required from: Felix Singer, ron minnich. Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80470?usp=email ) Change subject: util: Add hda-decoder ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Holding this change off until CB:80695. -- To view, visit https://review.coreboot.org/c/coreboot/+/80470?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4fb652e178517b2b7aceaac8be005c5b2d3b03e Gerrit-Change-Number: 80470 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Feb 2024 02:18:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mainboard/clevo/l140mu: Use new enum names from azalia_device.h
by Nicholas Sudsgaard (Code Review) 23 Feb '24

23 Feb '24

Nicholas Sudsgaard has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80697?usp=email ) Change subject: mainboard/clevo/l140mu: Use new enum names from azalia_device.h ...................................................................... Abandoned Squashed into CB:80695 -- To view, visit https://review.coreboot.org/c/coreboot/+/80697?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a83a43772c44a142ab57ce65049645332963e99 Gerrit-Change-Number: 80697 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[main]: mainboard/siemens/chili: Use enums from azalia_device.h
by Nicholas Sudsgaard (Code Review) 23 Feb '24

23 Feb '24

Nicholas Sudsgaard has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80696?usp=email ) Change subject: mainboard/siemens/chili: Use enums from azalia_device.h ...................................................................... Abandoned Squashed into CB:80695 -- To view, visit https://review.coreboot.org/c/coreboot/+/80696?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I097b8fcfd6e87baf3eab56f9234f860f29a3fa2c Gerrit-Change-Number: 80696 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[L] Change in coreboot[main]: include/device: Merge enums from azalia_device.h and azalia.h
by Nicholas Sudsgaard (Code Review) 23 Feb '24

23 Feb '24

Attention is currently required from: Nicholas Chin. Hello Nicholas Chin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80695?usp=email to look at the new patch set (#3). Change subject: include/device: Merge enums from azalia_device.h and azalia.h ...................................................................... include/device: Merge enums from azalia_device.h and azalia.h We were keeping 2 copies of the same thing (albeit there were some slight differences). As azalia_device.h is used much more in the codebase this was kept as the base and then some of the nice features of azalia.h were incorporated. The significant changes are: - All enum names now use the `AZALIA_` prefix. - Locations are now expressed using a combination of ORs (e.g. `AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_FRONT`). This also drops the AzaliaPinConfiguration enum as it was never used since added in 2013. Change-Id: Ie874b083a18963679981a9cd2b25d123890d628e Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> --- D src/include/device/azalia.h M src/include/device/azalia_device.h M src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c M src/mainboard/siemens/chili/variants/chili/hda_verb.c 4 files changed, 162 insertions(+), 259 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/80695/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie874b083a18963679981a9cd2b25d123890d628e Gerrit-Change-Number: 80695 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: amdfwtool: Use Makefile.mk for Makefile settings
by Martin L Roth (Code Review) 23 Feb '24

23 Feb '24

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80715?usp=email ) Change subject: amdfwtool: Use Makefile.mk for Makefile settings ...................................................................... amdfwtool: Use Makefile.mk for Makefile settings When updating the Makefiles, to keep from having to update two files at the same time, import Makefile.mk into the external Makefile. This allows the bulk of the settings to be in a single location. Change-Id: Id5b869f49b34b22e6a02fc086e7b42975141a87e Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M util/amdfwtool/Makefile M util/amdfwtool/Makefile.mk 2 files changed, 17 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/80715/1 diff --git a/util/amdfwtool/Makefile b/util/amdfwtool/Makefile index 9392f02..7ca3543 100644 --- a/util/amdfwtool/Makefile +++ b/util/amdfwtool/Makefile @@ -7,41 +7,24 @@ HOSTCC ?= cc endif -READ_SRC = amdfwread.c -READ_OBJ = $(READ_SRC:%.c=%.o) -TOOL_SRC = amdfwtool.c data_parse.c signed_psp.c handle_file.c -TOOL_OBJ = $(TOOL_SRC:%.c=%.o) -HEADER=amdfwtool.h TARGETS = amdfwread amdfwtool -WERROR=-Werror -CFLAGS :=-O2 -Wall -Wextra -Wshadow ${WERROR} -CFLAGS += -I $(top)/src/commonlib/bsd/include -CFLAGS += -D_GNU_SOURCE # memmem() from string.h - -ifneq ($(PKG_CONFIG),) -HOSTPKGCONFIG ?= $(PKG_CONFIG) -else -HOSTPKGCONFIG ?= pkg-config -endif -CFLAGS += $(shell $(HOSTPKGCONFIG) --cflags libcrypto) -ifneq ($(.SHELLSTATUS),0) -$(error "Ensure that pkg-config is installed.") -endif -LDFLAGS += $(shell $(HOSTPKGCONFIG) --libs libcrypto) all: $(TARGETS) -amdfwread: $(READ_OBJ) - $(HOSTCC) $(READ_OBJ) $(LDFLAGS) -o $@ +BUILD_ALL_TOOLS = 1 +include ./Makefile.mk -amdfwtool: $(TOOL_OBJ) - $(HOSTCC) $(TOOL_OBJ) $(LDFLAGS) -o $@ +amdfwread: $(amdfwreadobj) + $(HOSTCC) $(amdfwreadobj) $(LDFLAGS) -o $@ + +amdfwtool: $(amdfwtoolobj) + $(HOSTCC) $(amdfwtoolobj) $(LDFLAGS) -o $@ %.o: %.c $(HEADER) - $(HOSTCC) $(CFLAGS) -c -o $@ $< + $(HOSTCC) $(AMDFWTOOLCFLAGS) -c -o $@ $< clean: - @rm -f $(TARGETS) $(READ_OBJ) $(TOOL_OBJ) + @rm -f $(TARGETS) $(amdfwreadobj) $(amdfwtoolobj) distclean: clean diff --git a/util/amdfwtool/Makefile.mk b/util/amdfwtool/Makefile.mk index d0b01ac..3462467 100644 --- a/util/amdfwtool/Makefile.mk +++ b/util/amdfwtool/Makefile.mk @@ -4,12 +4,17 @@ amdfwtoolobj = amdfwtool.o data_parse.o signed_psp.o handle_file.o amdfwreadobj = amdfwread.o +amdfwheader = amdfwtool.h AMDFWTOOLCFLAGS :=-O2 -Wall -Wextra -Wshadow -Werror AMDFWTOOLCFLAGS += -I $(top)/src/commonlib/bsd/include AMDFWTOOLCFLAGS += -D_GNU_SOURCE # memmem() from string.h +ifneq ($(PKG_CONFIG),) +HOSTPKGCONFIG ?= $(PKG_CONFIG) +else HOSTPKGCONFIG ?= pkg-config +endif AMDFWTOOLCFLAGS += $(shell $(HOSTPKGCONFIG) --cflags libcrypto) ifneq ($(.SHELLSTATUS),0) @@ -17,14 +22,14 @@ endif LDFLAGS += $(shell $(HOSTPKGCONFIG) --libs libcrypto) -$(objutil)/amdfwtool/%.o: $(top)/util/amdfwtool/%.c # $(HEADER) +$(objutil)/amdfwtool/%.o: $(top)/util/amdfwtool/%.c $(amdfwheader) $(HOSTCC) $(AMDFWTOOLCFLAGS) $(HOSTCFLAGS) -c -o $@ $< -$(objutil)/amdfwtool/amdfwtool: $(addprefix $(objutil)/amdfwtool/,$(amdfwtoolobj)) +$(objutil)/amdfwtool/amdfwtool: $(addprefix $(objutil)/amdfwtool/,$(amdfwtoolobj)) $(amdfwheader) printf " AMDFWTOOL\n" $(HOSTCC) $(addprefix $(objutil)/amdfwtool/,$(amdfwtoolobj)) $(LDFLAGS) -o $@ -$(objutil)/amdfwtool/amdfwread: $(addprefix $(objutil)/amdfwtool/,$(amdfwreadobj)) +$(objutil)/amdfwtool/amdfwread: $(addprefix $(objutil)/amdfwtool/,$(amdfwreadobj)) $(amdfwheader) printf " AMDFWREAD\n" $(HOSTCC) $(addprefix $(objutil)/amdfwtool/,$(amdfwreadobj)) $(LDFLAGS) -o $@ -- To view, visit https://review.coreboot.org/c/coreboot/+/80715?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id5b869f49b34b22e6a02fc086e7b42975141a87e Gerrit-Change-Number: 80715 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: util/amdfwtool: build amdfwtool only for all tools or AMD CPUs
by Martin L Roth (Code Review) 23 Feb '24

23 Feb '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian, Martin L Roth, Matt DeVillier, ron minnich. Hello Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian, Matt DeVillier, build bot (Jenkins), ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80714?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Karthik Ramasubramanian, Code-Review+2 by ron minnich, Verified+1 by build bot (Jenkins) Change subject: util/amdfwtool: build amdfwtool only for all tools or AMD CPUs ...................................................................... util/amdfwtool: build amdfwtool only for all tools or AMD CPUs When we're building non-AMD processors, don't bother building amdfwtool unless we're specifically building all of the tools like for abuild. Change-Id: I9021674a06d65a79e24020790d317ab947c505fe Signed-off-by: Martin Roth <gaumless(a)gmail.com> --- M Makefile M src/soc/amd/common/block/psp/Kconfig M src/southbridge/amd/pi/hudson/Kconfig M util/amdfwtool/Makefile.mk 4 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/80714/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80714?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9021674a06d65a79e24020790d317ab947c505fe Gerrit-Change-Number: 80714 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: Update chromeec submodule to upstream main
by Elyes Haouas (Code Review) 23 Feb '24

23 Feb '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80704?usp=email ) Change subject: Update chromeec submodule to upstream main ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/80704?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2a6e460f90feb55ac0ad8911aa9ff6d4eb6591b8 Gerrit-Change-Number: 80704 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024