Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jincheng Li, Kapil Porwal, Ronak Kanabar, Shuo Liu, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80693?usp=email )
Change subject: drivers/mrc_cache: Deselect MRC_CACHE_USING_MRC_VERSION by default
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80693/comment/6c65d9fb_481fac28 :
PS2, Line 9: MRC_CACHE_USING_MRC_VERSION is by default selected when a platform
: uses EDK binding >= 202302 even the corresponding FSP doesn't provide
: the feature.
> Done
Acknowledged
Patchset:
PS1:
> Hi Subrata, EDK2 version binding is irrelevant as this is SoC FSP choice to enable/disable this feat […]
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/80693?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I84fdcfbf3c833a7ccb259a1a1d4be0bcfe291dc3
Gerrit-Change-Number: 80693
Gerrit-PatchSet: 4
Gerrit-Owner: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Mon, 26 Feb 2024 08:21:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Elyes Haouas, Martin L Roth.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80737?usp=email )
Change subject: [WIP]util/crossgcc: Build compiler-rt using runtimes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Don't you need to change CLANG_RUNTIME="libgcc"
> by CLANG_RUNTIME="compiler-rt" into xcompile ?
To use it, yes. But you need to build it first.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80737?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacd9b5f1fc1444b3dd1a785b91510f346e7a2f51
Gerrit-Change-Number: 80737
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 26 Feb 2024 08:11:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80763?usp=email
to look at the new patch set (#2).
Change subject: mb/google/nissa/var/glassway: Add memory config
......................................................................
mb/google/nissa/var/glassway: Add memory config
Follow glassway schematic to set memory configruation board straps.
BUG=b:319071869
BRANCH=None
TEST=None
Change-Id: Id85d590ed55997690e4c279ae83544b78fe72eec
Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com>
---
A src/mainboard/google/brya/variants/glassway/Makefile.mk
A src/mainboard/google/brya/variants/glassway/memory.c
2 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/80763/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80763?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id85d590ed55997690e4c279ae83544b78fe72eec
Gerrit-Change-Number: 80763
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Shawn Ku, Subrata Banik.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80742?usp=email )
Change subject: mb/google/nissa/var/glassway: Initialize devicetree setting
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80742/comment/02550f5b_4066d337 :
PS2, Line 7: for glassway
> remove, already in var.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80742?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibbb10a373bd5fa52a0833b81133517d2a088536b
Gerrit-Change-Number: 80742
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Shawn Ku <shawnku(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 26 Feb 2024 08:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Gerrit-MessageType: comment