coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3067 discussions

[M] Change in coreboot[main]: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
by Subrata Banik (Code Review) 26 Feb '24

26 Feb '24

Attention is currently required from: Kapil Porwal, Paul Menzel, Paz Zcharya, Shelley Chen. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80738?usp=email ) Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection ...................................................................... Patch Set 7: (1 comment) File src/vendorcode/google/chromeos/splash.c: https://review.coreboot.org/c/coreboot/+/80738/comment/b9a00d12_9f6e4cb6 : PS7, Line 8: if (chromeos_device_branded_plus_hard()) : return "cb_plus_logo.bmp"; : else if (chromeos_device_branded_plus_soft()) > These can probably be consolidated into the same if condition unless you have a reason for separating them? i just want to make these three logic separate for better code readability -- To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Gerrit-Change-Number: 80738 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 21:24:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
by Shelley Chen (Code Review) 26 Feb '24

26 Feb '24

Attention is currently required from: Kapil Porwal, Paul Menzel, Paz Zcharya, Subrata Banik. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80738?usp=email ) Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection ...................................................................... Patch Set 7: (1 comment) File src/vendorcode/google/chromeos/splash.c: https://review.coreboot.org/c/coreboot/+/80738/comment/be17f984_3f088902 : PS7, Line 8: if (chromeos_device_branded_plus_hard()) : return "cb_plus_logo.bmp"; : else if (chromeos_device_branded_plus_soft()) These can probably be consolidated into the same if condition unless you have a reason for separating them? -- To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Gerrit-Change-Number: 80738 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 21:17:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Documentation/tutorial/part1.md: Reformat Redhat package description
by Felix Singer (Code Review) 26 Feb '24

26 Feb '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80749?usp=email ) Change subject: Documentation/tutorial/part1.md: Reformat Redhat package description ...................................................................... Documentation/tutorial/part1.md: Reformat Redhat package description Convert multiline Redhat package list to one-line code markup. Change-Id: I1ba38bf2fc767a3f1694c55cf50e137ce10bfd75 Signed-off-by: Juan José García-Castro Crespo <jjgcc(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80749 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nicholas Chin <nic.c3.14(a)gmail.com> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M Documentation/tutorial/part1.md 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Felix Singer: Looks good to me, approved Nicholas Chin: Looks good to me, approved build bot (Jenkins): Verified diff --git a/Documentation/tutorial/part1.md b/Documentation/tutorial/part1.md index 041c7f4..0500742 100644 --- a/Documentation/tutorial/part1.md +++ b/Documentation/tutorial/part1.md @@ -36,8 +36,8 @@ `sudo pacman -S base-devel curl git gcc-ada ncurses zlib` Redhat based distros: -`sudo dnf install git make gcc-gnat flex bison xz bzip2 gcc g++` -`ncurses-devel wget zlib-devel patch` +`sudo dnf install git make gcc-gnat flex bison xz bzip2 gcc g++ +ncurses-devel wget zlib-devel patch` ### Step 2 - Download coreboot source tree -- To view, visit https://review.coreboot.org/c/coreboot/+/80749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1ba38bf2fc767a3f1694c55cf50e137ce10bfd75 Gerrit-Change-Number: 80749 Gerrit-PatchSet: 2 Gerrit-Owner: Juan José García-Castro Crespo Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/rex/var/deku: replace IOEX with GPIOs
by Felix Held (Code Review) 26 Feb '24

26 Feb '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80570?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/rex/var/deku: replace IOEX with GPIOs ...................................................................... mb/google/rex/var/deku: replace IOEX with GPIOs IOEX was replaced with GPIOs, this CL makes the required changes BUG=b:325533052 TEST=Built FW image correctly. Change-Id: I09ebba336b179cb36c6801b47ee0be5ade08c257 Signed-off-by: Eran Mitrani <mitrani(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80570 Reviewed-by: Derek Huang <derekhuang(a)google.com> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/rex/variants/deku/gpio.c 1 file changed, 23 insertions(+), 23 deletions(-) Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified Kapil Porwal: Looks good to me, approved Derek Huang: Looks good to me, approved diff --git a/src/mainboard/google/rex/variants/deku/gpio.c b/src/mainboard/google/rex/variants/deku/gpio.c index 1c5e629..515b1d0 100644 --- a/src/mainboard/google/rex/variants/deku/gpio.c +++ b/src/mainboard/google/rex/variants/deku/gpio.c @@ -55,8 +55,8 @@ PAD_NC(GPP_B05, NONE), /* GPP_B06 : net NC is not present in the given design */ PAD_NC(GPP_B06, NONE), - /* GPP_B07 : IOEX_INT_ODL */ - PAD_CFG_GPI(GPP_B07, NONE, DEEP), + /* GPP_B07 : net NC is not present in the given design */ + PAD_NC(GPP_B07, NONE), /* GPP_B08 : [] ==> PWM_BUZZER */ PAD_CFG_GPO(GPP_B08, 0, DEEP), /* GPP_B09 : net NC is not present in the given design */ @@ -247,22 +247,22 @@ PAD_NC(GPP_F09, NONE), /* GPP_F10 : net NC is not present in the given design */ PAD_NC(GPP_F10, NONE), - /* GPP_F11 : net NC is not present in the given design */ - PAD_NC(GPP_F11, NONE), - /* GPP_F12 : net NC is not present in the given design */ - PAD_NC(GPP_F12, NONE), - /* GPP_F13 : net NC is not present in the given design */ - PAD_NC(GPP_F13, NONE), - /* GPP_F14 : net NC is not present in the given design */ - PAD_NC(GPP_F14, NONE), - /* GPP_F15 : net NC is not present in the given design */ - PAD_NC(GPP_F15, NONE), - /* GPP_F16 : net NC is not present in the given design */ - PAD_NC(GPP_F16, NONE), - /* GPP_F17 : net NC is not present in the given design */ - PAD_NC(GPP_F17, NONE), - /* GPP_F18 : net NC is not present in the given design */ - PAD_NC(GPP_F18, NONE), + /* GPP_F11 : [] ==> AV_GPIO_P0 */ + PAD_CFG_GPO(GPP_F11, 0, DEEP), + /* GPP_F12 : [] ==> AV_GPIO_P1 */ + PAD_CFG_GPO(GPP_F12, 0, DEEP), + /* GPP_F13 : [] ==> AV_GPIO_P2 */ + PAD_CFG_GPO(GPP_F13, 0, DEEP), + /* GPP_F14 : [] ==> AV_GPIO_P3 */ + PAD_CFG_GPO(GPP_F14, 0, DEEP), + /* GPP_F15 : [] ==> AV_GPIO_P4 */ + PAD_CFG_GPO(GPP_F15, 0, DEEP), + /* GPP_F16 : [] ==> AV_GPIO_P5 */ + PAD_CFG_GPO(GPP_F16, 0, DEEP), + /* GPP_F17 : [] ==> AV_GPIO_P6 */ + PAD_CFG_GPO(GPP_F17, 0, DEEP), + /* GPP_F18 : [] ==> AV_GPIO_P7 */ + PAD_CFG_GPO(GPP_F18, 0, DEEP), /* GPP_F19 : [GPP_F19_STRAP] ==> Component NC */ PAD_NC(GPP_F19, NONE), /* GPP_F20 : [GPP_F20_STRAP] ==> Component NC */ @@ -271,7 +271,7 @@ PAD_NC(GPP_F21, NONE), /* GPP_F22 : [] ==> GPP_F22_ISH_GP8A */ PAD_NC(GPP_F22, NONE), - /* GPP_F23 : [] ==> TP_SOC_ISH_MCF_INT_L */ + /* GPP_F23 : [] ==> GPP_F23_ISH_GP9A */ PAD_NC(GPP_F23, NONE), /* GPP_H00 : GPP_H00_STRAP ==> Component NC */ @@ -306,10 +306,10 @@ PAD_NC(GPP_H16, NONE), /* GPP_H17 : net NC is not present in the given design */ PAD_NC(GPP_H17, NONE), - /* GPP_H19 : [] ==> I2C_IOEX_SDA */ - PAD_CFG_NF_LOCK(GPP_H19, NONE, NF1, LOCK_CONFIG), - /* GPP_H20 : [] ==> I2C_IOEX_SCL */ - PAD_CFG_NF_LOCK(GPP_H20, NONE, NF1, LOCK_CONFIG), + /* GPP_H19 : net NC is not present in the given design */ + PAD_NC(GPP_H19, NONE), + /* GPP_H20 : net NC is not present in the given design */ + PAD_NC(GPP_H20, NONE), /* GPP_H21 : net NC is not present in the given design */ PAD_NC(GPP_H21, NONE), /* GPP_H22 : net NC is not present in the given design */ -- To view, visit https://review.coreboot.org/c/coreboot/+/80570?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I09ebba336b179cb36c6801b47ee0be5ade08c257 Gerrit-Change-Number: 80570 Gerrit-PatchSet: 6 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/deku: Correct GPIO F19/F20 to not connected
by Felix Held (Code Review) 26 Feb '24

26 Feb '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80569?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/rex/var/deku: Correct GPIO F19/F20 to not connected ...................................................................... mb/google/rex/var/deku: Correct GPIO F19/F20 to not connected GPP_F19 and GPP_F20 sre set incorrectly previously. Change them to not connected according to schematics. BUG=b:305793886 TEST=Built FW image correctly. Change-Id: Ifb6da1f8696f44cb47be3d1de83c55e62b12a9e9 Signed-off-by: Eran Mitrani <mitrani(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80569 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Eric Lai <ericllai(a)google.com> --- M src/mainboard/google/rex/variants/deku/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Kapil Porwal: Looks good to me, approved Subrata Banik: Looks good to me, approved diff --git a/src/mainboard/google/rex/variants/deku/gpio.c b/src/mainboard/google/rex/variants/deku/gpio.c index 9aa5900..1c5e629 100644 --- a/src/mainboard/google/rex/variants/deku/gpio.c +++ b/src/mainboard/google/rex/variants/deku/gpio.c @@ -264,9 +264,9 @@ /* GPP_F18 : net NC is not present in the given design */ PAD_NC(GPP_F18, NONE), /* GPP_F19 : [GPP_F19_STRAP] ==> Component NC */ - PAD_CFG_NF(GPP_F19, NONE, DEEP, NF1), + PAD_NC(GPP_F19, NONE), /* GPP_F20 : [GPP_F20_STRAP] ==> Component NC */ - PAD_CFG_NF(GPP_F20, NONE, DEEP, NF1), + PAD_NC(GPP_F20, NONE), /* GPP_F21 : [GPP_F21_STRAP] ==> Component NC */ PAD_NC(GPP_F21, NONE), /* GPP_F22 : [] ==> GPP_F22_ISH_GP8A */ -- To view, visit https://review.coreboot.org/c/coreboot/+/80569?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb6da1f8696f44cb47be3d1de83c55e62b12a9e9 Gerrit-Change-Number: 80569 Gerrit-PatchSet: 5 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: Documentation: Update the code of conduct
by Martin L Roth (Code Review) 26 Feb '24

26 Feb '24

Attention is currently required from: Eric Lai, Stefan Reinauer, ron minnich. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80619?usp=email ) Change subject: Documentation: Update the code of conduct ...................................................................... Patch Set 2: (1 comment) File Documentation/community/code_of_conduct.md: https://review.coreboot.org/c/coreboot/+/80619/comment/3300c1e9_c6cdfa8b : PS1, Line 126: > extra line? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80619?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e2010a16f31f892bd1761b56b96ea773877dea0 Gerrit-Change-Number: 80619 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 19:02:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: Documentation: Add 24.05 release notes template
by Martin L Roth (Code Review) 26 Feb '24

26 Feb '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80618?usp=email ) Change subject: Documentation: Add 24.05 release notes template ...................................................................... Documentation: Add 24.05 release notes template In preparation for the upcoming release, add the template for the 24.05 release and update index.md. Change-Id: Ic8fdf82519ffa4001bcc06bdd808eaebdde18a1e Signed-off-by: Martin Roth <gaumless(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80618 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- A Documentation/releases/coreboot-24.05-relnotes.md M Documentation/releases/index.md 2 files changed, 98 insertions(+), 2 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/Documentation/releases/coreboot-24.05-relnotes.md b/Documentation/releases/coreboot-24.05-relnotes.md new file mode 100644 index 0000000..da7e014 --- /dev/null +++ b/Documentation/releases/coreboot-24.05-relnotes.md @@ -0,0 +1,95 @@ +Upcoming release - coreboot 24.05 +======================================================================== + +The 24.05 release is scheduled for Mid May, 2024 + + +Update this document with changes that should be in the release notes. + +* Please use Markdown. +* See the past few release notes for the general format. +* The chip and board additions and removals will be updated right + before the release, so those do not need to be added. +* Note that all changes before the release are done are marked upcoming. + A final version of the notes are done after the release. + + + +Significant or interesting changes +---------------------------------- + +* Add changes that need a full description here + +* This section should have full descriptions and can or should have + a link to the referenced commits. + + + +Additional coreboot changes +--------------------------- + +The following are changes across a number of patches, or changes worth +noting, but not needing a full description. + +* Changes that only need a line or two of description go here. + + + +Changes to external resources +----------------------------- + +### Toolchain updates + + +### Git submodule pointers + + +### External payloads + + + +Platform Updates +---------------- + +### Added mainboards: +* To be filled in immediately before the release by the release team + + +### Removed Mainboards +* To be filled in immediately before the release by the release team + + +### Updated SoCs +* To be filled in immediately before the release by the release team + + + +Plans to move platform support to a branch +------------------------------------------ +* To be filled in immediately before the release by the release team + + + +Statistics from the 4.22 to the 24.02 release +-------------------------------------------- +* To be filled in immediately before the release by the release team + + + +Significant Known and Open Issues +--------------------------------- + +Issues from the coreboot bugtracker: https://ticket.coreboot.org/ +* To be filled in immediately before the release by the release team + + + +coreboot Links and Contact Information +-------------------------------------- + +* Main Web site: https://www.coreboot.org +* Downloads: https://coreboot.org/downloads.html +* Source control: https://review.coreboot.org +* Documentation: https://doc.coreboot.org +* Issue tracker: https://ticket.coreboot.org/projects/coreboot +* Donations: https://coreboot.org/donate.html diff --git a/Documentation/releases/index.md b/Documentation/releases/index.md index 74968d3..17a9462 100644 --- a/Documentation/releases/index.md +++ b/Documentation/releases/index.md @@ -3,7 +3,7 @@ ## Upcoming release Please add to the release notes as changes are added: -* [24.02 - February 2024](coreboot-24.02-relnotes.md) +* [24.05 - May 2024](coreboot-24.05-relnotes.md) The [checklist] contains instructions to ensure that a release covers all important things and provides a reliable format for tarballs, branch @@ -15,7 +15,8 @@ ## Previous releases -* [4.22 - November 2023](coreboot-4.22-relnotes.md) +* [24.02 - February 2024](coreboot-24.02-relnotes.md) +* [4.22 - November 2023](coreboot-4.22-relnotes.md) * [4.21 - August 2023](coreboot-4.21-relnotes.md) * [4.20.1 - May 2023](coreboot-4.20.1-relnotes.md) * [4.19 - January 2023](coreboot-4.19-relnotes.md) -- To view, visit https://review.coreboot.org/c/coreboot/+/80618?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic8fdf82519ffa4001bcc06bdd808eaebdde18a1e Gerrit-Change-Number: 80618 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: soc/intel/xeon_sp: Add memory type check utils
by Nico Huber (Code Review) 26 Feb '24

26 Feb '24

Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Jincheng Li, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80632?usp=email ) Change subject: soc/intel/xeon_sp: Add memory type check utils ...................................................................... Patch Set 4: (2 comments) File src/soc/intel/xeon_sp/spr/soc_util.c: https://review.coreboot.org/c/coreboot/+/80632/comment/1839fe03_531dfc6d : PS4, Line 185: UINT16 `uint16_t` (This shows that FSP headers are leaking somewhere.) File src/soc/intel/xeon_sp/util.c: https://review.coreboot.org/c/coreboot/+/80632/comment/77771eac_8dc04439 : PS4, Line 116: bool is_memtype_reserved(UINT16 mem_type) `uint16_t` -- To view, visit https://review.coreboot.org/c/coreboot/+/80632?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f5f3c0f16dc50bc739146e46afce2e5fbf4f62c Gerrit-Change-Number: 80632 Gerrit-PatchSet: 4 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 18:51:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/common/lpc: Don't open a window for unassigned resources
by Nico Huber (Code Review) 26 Feb '24

26 Feb '24

Attention is currently required from: Matt DeVillier, Subrata Banik. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80750?usp=email ) Change subject: soc/intel/common/lpc: Don't open a window for unassigned resources ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80750?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifba14a8f134ba12d5f5e9fdbac775d4f82b4c4de Gerrit-Change-Number: 80750 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 18:46:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/deku: Correct GPIO F19/F20 to not connected
by Eran Mitrani (Code Review) 26 Feb '24

26 Feb '24

Attention is currently required from: Dinesh Gehlot, Jakub Czapiga, Paul Menzel, Tarun. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80569?usp=email ) Change subject: mb/google/rex/var/deku: Correct GPIO F19/F20 to not connected ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80569/comment/77407295_e83356ed : PS2, Line 7: variants > var Done https://review.coreboot.org/c/coreboot/+/80569/comment/7b37ae1b_d009fcc7 : PS2, Line 7: correct GPIO F19 and F20 configuration > Maybe: […] Done https://review.coreboot.org/c/coreboot/+/80569/comment/4555a96c_3195a7e0 : PS2, Line 9: GPP_F19 and GPP_F20 were set incorrectly previously. : Changed to not connected. : This CL corrects these settings according to schematics. > Please do not wrap lines, just because the sentence ends. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80569?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb6da1f8696f44cb47be3d1de83c55e62b12a9e9 Gerrit-Change-Number: 80569 Gerrit-PatchSet: 4 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 18:17:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024