Attention is currently required from: Anil Kumar K, Jamie Ryu, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79413?usp=email )
Change subject: soc/intel/common/block/cse: Use IFWI build version for update check
......................................................................
Patch Set 18: Code-Review+1
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/79413/comment/8ba22e9a_3f0881ee :
PS15, Line 912: CONFIG_SOC_INTEL_CSE_RW_VERSION_CBFS_NAME
> Do we still want to call this CSE RW version. […]
This is used for previous platform for saving CSE version, we're trying to reuse the file and makefile for less change and avoid previous platform impact.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79413?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib95ffeabda01c66fcce35ca3065c06362c75d848
Gerrit-Change-Number: 79413
Gerrit-PatchSet: 18
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Comment-Date: Wed, 28 Feb 2024 05:38:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Anil Kumar K, Jamie Ryu, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik.
Hello Anil Kumar K, Jamie Ryu, Pratikkumar V Prajapati, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79413?usp=email
to look at the new patch set (#18).
Change subject: soc/intel/common/block/cse: Use IFWI build version for update check
......................................................................
soc/intel/common/block/cse: Use IFWI build version for update check
Use IFWI build version(32bits) in existing CSE BPDT header
instead of CSE FW version to check CSE FW update.
New build config(SOC_INTEL_CSE_USE_IFWI_BUILD_VERSION) is added
not to affect existing platforms which use cse_lite common code and
CSE FW version for update check.
With this change, we can do
1. can create CSE FW update image when other IFWI FWs(ex. PMC) is
changed while CSE FW version is same
2. can create dummy upgrade/downgrade test image by just changing
coreboot configuration
For enabling this, we need to update below
1. Update build config
CONFIG_SOC_INTEL_CSE_USE_IFWI_BUILD_VERSION=y
CONFIG_SOC_INTEL_CSE_RW_VERSION="2347" #2023WW47
2. Update blobs with IFWI version in fit config
IfwiBuildVersion value="2347"
TEST= build coreboot image with specific IFWI build version
(ex. 2347: 2023WW47)
Upgrade test
1. Open coreboot image with FIT
2. Update IFWI build version to 2346.
3. Flash and boot to OS and check coreboot log
Downgrade test
1. Open coreboot image with FIT
2. Update IFWI build version to 2348.
3. Flash and boot to OS and check coreboot log
Restore test
1. Open coreboot image with FIT
2. Update IFWI build version to 0.
3. Flash and boot to OS and check coreboot log
Check CSE FW upgrade/downgrade happen from the log
Change-Id: Ib95ffeabda01c66fcce35ca3065c06362c75d848
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
---
M src/soc/intel/common/block/cse/Kconfig
M src/soc/intel/common/block/cse/cse_lite.c
2 files changed, 108 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/79413/18
--
To view, visit https://review.coreboot.org/c/coreboot/+/79413?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib95ffeabda01c66fcce35ca3065c06362c75d848
Gerrit-Change-Number: 79413
Gerrit-PatchSet: 18
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anil Kumar K, Jamie Ryu, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79413?usp=email )
Change subject: soc/intel/common/block/cse: Use IFWI build version for update check
......................................................................
Patch Set 16: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79413/comment/1138a00c_2e11cfab :
PS15, Line 7: verion
> typo
Done
https://review.coreboot.org/c/coreboot/+/79413/comment/5c546a91_8d30a6ea :
PS15, Line 9:
> space not required
Done
https://review.coreboot.org/c/coreboot/+/79413/comment/bf4a737b_6d78c874 :
PS15, Line 9: cse bpdt
> use CAPS
Done
https://review.coreboot.org/c/coreboot/+/79413/comment/e32ed779_c5ad8d1e :
PS15, Line 17: FWs
> pls provide ex: on which other FW is being referred to here
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79413?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib95ffeabda01c66fcce35ca3065c06362c75d848
Gerrit-Change-Number: 79413
Gerrit-PatchSet: 16
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Comment-Date: Wed, 28 Feb 2024 04:32:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Jamie Ryu, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik, Wonkyu Kim.
Hello Anil Kumar K, Jamie Ryu, Pratikkumar V Prajapati, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79413?usp=email
to look at the new patch set (#16).
Change subject: soc/intel/common/block/cse: Use IFWI build version for update check
......................................................................
soc/intel/common/block/cse: Use IFWI build version for update check
Use IFWI build version(32bits) in existing CSE BPDT header
instead of CSE FW version to check CSE FW update.
New build config (SOC_INTEL_CSE_USE_IFWI_BUILD_VERSION) is added
not to affect existing platforms which use cse_lite common code and
CSE FW version for update check.
With this change, we can do
1. can create CSE FW update image when other IFWI FWs(ex. PMC) is
changed while CSE FW version is same
2. can create dummy upgrade/downgrade test image by just changing
coreboot configuration
For enabling this, we need to update below
1. Update build config
CONFIG_SOC_INTEL_CSE_USE_IFWI_BUILD_VERSION=y
CONFIG_SOC_INTEL_CSE_RW_VERSION="2347" #2023WW47
2. Update blobs with IFWI version in fit config
IfwiBuildVersion value="2347"
TEST= build coreboot image with specific IFWI build version
(ex. 2347: 2023WW47)
Upgrade test
1. Open coreboot image with FIT
2. Update IFWI build version to 2346.
3. Flash and boot to OS and check coreboot log
Downgrade test
1. Open coreboot image with FIT
2. Update IFWI build version to 2348.
3. Flash and boot to OS and check coreboot log
Restore test
1. Open coreboot image with FIT
2. Update IFWI build version to 0.
3. Flash and boot to OS and check coreboot log
Check CSE FW upgrade/downgrade happen from the log
Change-Id: Ib95ffeabda01c66fcce35ca3065c06362c75d848
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
---
M src/soc/intel/common/block/cse/Kconfig
M src/soc/intel/common/block/cse/cse_lite.c
2 files changed, 108 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/79413/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/79413?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib95ffeabda01c66fcce35ca3065c06362c75d848
Gerrit-Change-Number: 79413
Gerrit-PatchSet: 16
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Michael Niewöhner, Nico Huber.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80740?usp=email )
Change subject: include/device/azalia_device.h: Merge location1 and location2
......................................................................
Patch Set 13:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80740?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5a61a37ed70027700f07f1532c500f04d7a16ce1
Gerrit-Change-Number: 80740
Gerrit-PatchSet: 13
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Wed, 28 Feb 2024 03:40:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Michael Niewöhner, Nicholas Chin, Nico Huber.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email )
Change subject: include/device: Merge enums from azalia_device.h and azalia.h
......................................................................
Patch Set 9:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80695?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie874b083a18963679981a9cd2b25d123890d628e
Gerrit-Change-Number: 80695
Gerrit-PatchSet: 9
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 28 Feb 2024 03:40:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Felix Singer, Nicholas Chin, Nico Huber, Paul Menzel.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80343?usp=email )
Change subject: mainboard/lenovo: Add ThinkCentre M710s (Skylake)
......................................................................
Patch Set 26:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80343/comment/0c50d0ed_a308f2c5 :
PS25, Line 16: Internal flashing
> Is this internal flashing from the vendor firmware, or coreboot?
Only coreboot. I wrote about that in the docs but forgot to mention that here. Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80343?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I551753aecfbd2c0ee57d85bb22cb943eb21af3cc
Gerrit-Change-Number: 80343
Gerrit-PatchSet: 26
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 28 Feb 2024 03:27:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment