coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3066 discussions

[M] Change in coreboot[main]: lib/romstage_handoff.c: Initialize using a cbmem hook
by Arthur Heymans (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Andrey Petrov, Damien Zammit, Felix Held, Huang Jin, Julius Werner, Lee Leahy, Matt DeVillier, Ronak Kanabar. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52933?usp=email ) Change subject: lib/romstage_handoff.c: Initialize using a cbmem hook ...................................................................... Patch Set 3: (1 comment) File src/lib/romstage_handoff.c: https://review.coreboot.org/c/coreboot/+/52933/comment/d6b53986_c50c78e7 : PS3, Line 56: ROMSTAGE_CBMEM_INIT_HOOK(romstage_handoff_init); > Since this file is compiled unconditionally, adding an INIT_HOOK() expands this to a lot of platforms which never used it. Please add a Kconfig to limit compilation of the file to the right set of boards if you want to do this (I'm not quite sure what exactly this is or what the right set of boards for it would be, but I know the Arm boards I work on don't use this, for example). Done. HAVE_ACPI_RESUME is the proper flag. -- To view, visit https://review.coreboot.org/c/coreboot/+/52933?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93abf33a6eb055eeaba1fed5042387822de1aa20 Gerrit-Change-Number: 52933 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Huang Jin Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Huang Jin Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Feb 2024 10:19:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: lib/romstage_handoff.c: Initialize using a cbmem hook
by Arthur Heymans (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Damien Zammit, Huang Jin, Lee Leahy. Hello Andrey Petrov, Angel Pons, Damien Zammit, Huang Jin, Lee Leahy, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52933?usp=email to look at the new patch set (#4). Change subject: lib/romstage_handoff.c: Initialize using a cbmem hook ...................................................................... lib/romstage_handoff.c: Initialize using a cbmem hook This reduces platform boilerplate code. Change-Id: I93abf33a6eb055eeaba1fed5042387822de1aa20 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/amd/agesa/romstage.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/memory_init.c M src/include/romstage_handoff.h M src/lib/romstage_handoff.c M src/northbridge/intel/gm45/romstage.c M src/northbridge/intel/haswell/romstage.c M src/northbridge/intel/i945/early_init.c M src/northbridge/intel/ironlake/romstage.c M src/northbridge/intel/pineview/romstage.c M src/northbridge/intel/sandybridge/romstage.c M src/northbridge/intel/x4x/romstage.c M src/soc/amd/stoneyridge/romstage.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/broadwell/romstage.c 15 files changed, 9 insertions(+), 52 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/52933/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/52933?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93abf33a6eb055eeaba1fed5042387822de1aa20 Gerrit-Change-Number: 52933 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Huang Jin Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Huang Jin Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: vc/amd/opensil/genoa_poc: remove xSIM-api dependency from opensil.h
by Varshit Pandya (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Felix Held. Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80287?usp=email ) Change subject: vc/amd/opensil/genoa_poc: remove xSIM-api dependency from opensil.h ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80287/comment/a71511e6_1ae55afe : PS1, Line 18: May be you already did that but add info that you did a build test ? File src/vendorcode/amd/opensil/genoa_poc/ramstage.c: https://review.coreboot.org/c/coreboot/+/80287/comment/fb6c626a_128b44fe : PS1, Line 178: /* TODO: also call timepoints 2 and 3 from coreboot. Are they NOOP? */ Can this be removed now ? -- To view, visit https://review.coreboot.org/c/coreboot/+/80287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I969bc0862560b7254c48f04e9a03387417f328bc Gerrit-Change-Number: 80287 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Feb 2024 10:15:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: [WIP,UNTESTED] arch/x86/ioapic: always write IOAPIC ID in set_ioapic_id
by Felix Held (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella, Nico Huber. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80330?usp=email ) Change subject: [WIP,UNTESTED] arch/x86/ioapic: always write IOAPIC ID in set_ioapic_id ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: haven't looked at all the details yet, but at least for the socs i work on the old behavior seems to be quite questionable to me. i guess that this might be some regression from the ioapic id cleanup; before that one we used MAX_CPUS as ID for the first ioapic -- To view, visit https://review.coreboot.org/c/coreboot/+/80330?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic8538f82a6b10f16eeb228669db197dc8e326ffd Gerrit-Change-Number: 80330 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 02 Feb 2024 10:06:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Add FSP_DOES_NOT_NEED_TEMP_RAM
by Arthur Heymans (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Andrey Petrov, Chen, Gang C, David Hendricks, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Ronak Kanabar, Shuo Liu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80328?usp=email ) Change subject: drivers/intel/fsp2_0: Add FSP_DOES_NOT_NEED_TEMP_RAM ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80328/comment/0dcc1e64_6c4ee7ce : PS3, Line 8: > Need to justify your change. It does neither describe a problem nor why this change is necessary. Does it fix something? I presume the dual+ socket issue? It's worth mentioning though. -- To view, visit https://review.coreboot.org/c/coreboot/+/80328?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17a73e4f627c91808ed17c712b72937662ae9293 Gerrit-Change-Number: 80328 Gerrit-PatchSet: 3 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Feb 2024 10:06:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in em100[main]: em100: return an error if a command fails
by Name of user not set (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: c.koehne(a)beckhoff.com. Hello Jakub Czapiga, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/em100/+/80250?usp=email to look at the new patch set (#2). Change subject: em100: return an error if a command fails ...................................................................... em100: return an error if a command fails We don't properly return an error in every code path when a command fails. This makes it hard to use this tool in a shell script because you can't be sure that your command was successful. Change-Id: I2554252d007a92e939088389d67f9d4cede837ee Signed-off-by: Corvin Köhne <c.koehne(a)beckhoff.com> --- M em100.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/50/80250/2 -- To view, visit https://review.coreboot.org/c/em100/+/80250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: main Gerrit-Change-Id: I2554252d007a92e939088389d67f9d4cede837ee Gerrit-Change-Number: 80250 Gerrit-PatchSet: 2 Gerrit-Owner: c.koehne(a)beckhoff.com Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: c.koehne(a)beckhoff.com Gerrit-MessageType: newpatchset

1 0

[S] Change in em100[main]: em100: exit when using an invalid device name
by Name of user not set (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: c.koehne(a)beckhoff.com. Hello Jakub Czapiga, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/em100/+/80249?usp=email to look at the new patch set (#2). Change subject: em100: exit when using an invalid device name ...................................................................... em100: exit when using an invalid device name If you use a stupid device name like `em100 --device bla`, we won't exit with an error right now. It just ignores the devices and uses the first device it can find. This could lead to unexpected issues when connecting more than one EM100 device to your machine. It's much better to exit if we're unable to parse the device name. Change-Id: If0f7b8b576224a9db6ab319c2212bc245110c5c1 Signed-off-by: Corvin Köhne <c.koehne(a)beckhoff.com> --- M em100.c 1 file changed, 11 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/49/80249/2 -- To view, visit https://review.coreboot.org/c/em100/+/80249?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: main Gerrit-Change-Id: If0f7b8b576224a9db6ab319c2212bc245110c5c1 Gerrit-Change-Number: 80249 Gerrit-PatchSet: 2 Gerrit-Owner: c.koehne(a)beckhoff.com Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: c.koehne(a)beckhoff.com Gerrit-MessageType: newpatchset

1 0

[XS] Change in em100[main]: em100: free device list when calling em100 --list
by Name of user not set (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Stefan Reinauer, c.koehne(a)beckhoff.com. Hello Jakub Czapiga, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/em100/+/80248?usp=email to look at the new patch set (#2). Change subject: em100: free device list when calling em100 --list ...................................................................... em100: free device list when calling em100 --list After querying the device list by calling libusb_get_device_list, you have to free the list with lib_usb_free_device_list to properly clean up the resources allocated by libusb. This solves some warnings issued by libusb when calling `em100 --list`. Change-Id: Id1849bb69d534928016256dd01e9550ef414d330 Signed-off-by: Corvin Köhne <c.koehne(a)beckhoff.com> --- M em100.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/48/80248/2 -- To view, visit https://review.coreboot.org/c/em100/+/80248?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: main Gerrit-Change-Id: Id1849bb69d534928016256dd01e9550ef414d330 Gerrit-Change-Number: 80248 Gerrit-PatchSet: 2 Gerrit-Owner: c.koehne(a)beckhoff.com Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: c.koehne(a)beckhoff.com Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: [WIP,UNTESTED] arch/x86/ioapic: always write IOAPIC ID in set_ioapic_id
by Felix Held (Code Review) 02 Feb '24

02 Feb '24

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80330?usp=email ) Change subject: [WIP,UNTESTED] arch/x86/ioapic: always write IOAPIC ID in set_ioapic_id ...................................................................... [WIP,UNTESTED] arch/x86/ioapic: always write IOAPIC ID in set_ioapic_id It seems very odd to me that the IOAPIC ID doesn't get written to the register if it's 0 which is a valid IOAPIC ID which is used for the first IOAPIC in the system. I'm not sure yet if that was to work around some issue with some older system, but relying of the IOAPIC ID of the first IOAPIC in the system to be 0 seems to be a bad idea to me. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ic8538f82a6b10f16eeb228669db197dc8e326ffd --- M src/arch/x86/ioapic.c 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/80330/1 diff --git a/src/arch/x86/ioapic.c b/src/arch/x86/ioapic.c index 04c852b..df97a50 100644 --- a/src/arch/x86/ioapic.c +++ b/src/arch/x86/ioapic.c @@ -131,12 +131,8 @@ ioapic_base); printk(BIOS_DEBUG, "IOAPIC: ID = 0x%02x\n", ioapic_id); - if (ioapic_id) { - /* Set IOAPIC ID if it has been specified. */ - io_apic_write(ioapic_base, 0x00, - (io_apic_read(ioapic_base, 0x00) & 0xf0ffffff) | - (ioapic_id << 24)); - } + io_apic_write(ioapic_base, 0x00, + (io_apic_read(ioapic_base, 0x00) & 0xf0ffffff) | (ioapic_id << 24)); printk(BIOS_SPEW, "IOAPIC: Dumping registers\n"); for (i = 0; i < 3; i++) -- To view, visit https://review.coreboot.org/c/coreboot/+/80330?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic8538f82a6b10f16eeb228669db197dc8e326ffd Gerrit-Change-Number: 80330 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Add FSP_DOES_NOT_NEED_TEMP_RAM
by Patrick Rudolph (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Chen, Gang C, David Hendricks, Johnny Lin, Lean Sheng Tan, Ronak Kanabar, Shuo Liu. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80328?usp=email ) Change subject: drivers/intel/fsp2_0: Add FSP_DOES_NOT_NEED_TEMP_RAM ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80328/comment/9363784a_a7132d67 : PS3, Line 8: Need to justify your change. It does neither describe a problem nor why this change is necessary. Does it fix something? https://review.coreboot.org/c/coreboot/+/80328/comment/2cc1414b_1823057c : PS3, Line 11: some why ones? -- To view, visit https://review.coreboot.org/c/coreboot/+/80328?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17a73e4f627c91808ed17c712b72937662ae9293 Gerrit-Change-Number: 80328 Gerrit-PatchSet: 3 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Feb 2024 10:00:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024