Attention is currently required from: Alper Nebi Yasak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80373?usp=email )
Change subject: drivers/qemu/fw_cfg: Clean up #if directives
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80373?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I554cfa7997e3c3fe910795ecd733c0ec45102011
Gerrit-Change-Number: 80373
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 15:03:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Derek Huang, Dolan Liu, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80316?usp=email )
Change subject: mb/google/nissa: Skip GPP_F15 GPIO locking to avoid IRQ storm
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80316/comment/5a14c1b9_13216e54 :
PS5, Line 7: Skip locking for GPP_F15 GPIO
> Maybe: Skip GPP_F15 GPIO locking to avoid IRQ storm
Done
https://review.coreboot.org/c/coreboot/+/80316/comment/bb5d9dec_f01b7667 :
PS5, Line 16: will occurs
> occurs or will occur
Done
https://review.coreboot.org/c/coreboot/+/80316/comment/7ddb8abe_84bb61fb :
PS5, Line 9: There is an existing issue for nissa where wake up from
: RTC wake is not working during suspend_stress_test.
:
: The phenomenon of the issue is that after pulling out the
: stylus, can see an interrupt storm occurs checking through
: "cat /proc/interrupts | grep acpi".
: When the counter of interrupt is greater than a certain
: value, "Disabling IRQ #9" will occurs, so RTC wake is not
: working.
> Please make use of the whole length of 72 characters per line. […]
Done
https://review.coreboot.org/c/coreboot/+/80316/comment/54b29abe_17323492 :
PS5, Line 22: dispeared
> Present tense: disappears
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80316?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie143c43e0555d17d8a290f17637b537fba806144
Gerrit-Change-Number: 80316
Gerrit-PatchSet: 6
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 07 Feb 2024 15:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak, Julius Werner, Philipp Hug, ron minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80372?usp=email )
Change subject: arch/io.h: Add stubs for x86 I/O port functions to other arches
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80372/comment/81299059_0de95b58 :
PS3, Line 19: We could cover every port function call with #if CONFIG(ARCH_X86), but
: that gets very cluttery. And it looks like it might be possible to
: somehow access to I/O ports over MMIO, as far as I can tell from U-Boot
: and Linux code.
The hardware often has a translator. Can you add that information as a TODO comment in the code?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80372?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7d9177283e8c692088ba8e30d6dfe52623c8cb9
Gerrit-Change-Number: 80372
Gerrit-PatchSet: 3
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 15:03:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Derek Huang, Dolan Liu, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu.
Hello Derek Huang, Dolan Liu, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80316?usp=email
to look at the new patch set (#6).
Change subject: mb/google/nissa: Skip GPP_F15 GPIO locking to avoid IRQ storm
......................................................................
mb/google/nissa: Skip GPP_F15 GPIO locking to avoid IRQ storm
There is an existing issue for nissa where wake up from RTC wake is not working during suspend_stress_test.
The phenomenon of the issue is that after pulling out the stylus, can see an interrupt storm occurs, checking through:
"cat /proc/interrupts | grep acpi".
When the counter of interrupt is greater than a certain value, "Disabling IRQ #9" will occur, so RTC wake is not working.
Reference: https://review.coreboot.org/c/coreboot/+/65086
This patch skips the locking for GPP_F15 to allow kernel to
configure it later. The interrupt storm of acpi disappears.
BUG=b:321348117
TEST=1. cat /proc/interrupts | grep acpi
there isn't interrupt storm of acpi when pulling out stylus.
2. The stylus tools panel will pop up when pulling out it.
3. Inserts stylus can wakeup DUT after powerd_dbus_suspend.
4. Passed:
suspend_stress_test -c 2500 --suspend_min=15 --suspend_max=20
Change-Id: Ie143c43e0555d17d8a290f17637b537fba806144
Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/baseboard/nissa/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/80316/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/80316?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie143c43e0555d17d8a290f17637b537fba806144
Gerrit-Change-Number: 80316
Gerrit-PatchSet: 6
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alper Nebi Yasak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80375?usp=email )
Change subject: drivers/qemu: Split Cirrus display support from Bochs display support
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/emulation/qemu/Kconfig:
https://review.coreboot.org/c/coreboot/+/80375/comment/41d0849b_09a15834 :
PS1, Line 26: DRIVERS_EMULATION_QEMU_CIRRUS
Should Cirrus and Bochs be mutually exclusive?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80375?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic9492b501ed4fdcbda6886db60b1e5348715e667
Gerrit-Change-Number: 80375
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 14:58:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80374?usp=email )
Change subject: drivers/qemu: Drop redundant vga_io addition to ramstage
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80374?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib31344e242689682d74d8a83c97b6e8027641926
Gerrit-Change-Number: 80374
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 14:56:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80376?usp=email )
Change subject: drivers/qemu/bochs: Allow building for non-x86 architectures
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/emulation/qemu/bochs.c:
https://review.coreboot.org/c/coreboot/+/80376/comment/993ad437_e7684da6 :
PS1, Line 52: #if CONFIG(CPU_QEMU_X86)
I saw on your qemu riscv PCI code that you add IO resources to the PCI domain. In qemu I see that reading and writing to VIRT_PCIE_PIO should be translated to IO read/writes, so it should work with implementations of outx/inx that do mmio writes to that region.
Anyway it would be a good idea to throw errors instead of silently doing nothing on the IO path.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80376?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7f72d7ea13e54ecf89d067394c02b572c5f92d24
Gerrit-Change-Number: 80376
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 14:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Dolan Liu, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Paul Menzel, Simon Yang, Subrata Banik.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80259?usp=email )
Change subject: mb/google/nissa/var/anraggar: Config DP AUX BIAS according to fw_config
......................................................................
Patch Set 14:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80259/comment/8cfc04bd_acbb1a99 :
PS13, Line 9: EVT mini-build changes redriver IC from PS8745 to ANX7493, the
: ANX7493 not support DP AUX BIAS, so connects DP AUX BIAS
: of DB to SOC directly. Add DB_AUX_BIAS bit field to fw_config
: for compatibility.
> Please re-flow for 72 characters per line.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80259?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53974ec7444912a63d0fe0a9303c9e5d6941f68d
Gerrit-Change-Number: 80259
Gerrit-PatchSet: 14
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 14:52:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Dolan Liu, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Simon Yang, Subrata Banik, Weimin Wu.
Hello Dolan Liu, Eric Lai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Simon Yang, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80259?usp=email
to look at the new patch set (#14).
Change subject: mb/google/nissa/var/anraggar: Config DP AUX BIAS according to fw_config
......................................................................
mb/google/nissa/var/anraggar: Config DP AUX BIAS according to fw_config
EVT mini-build changes redriver IC from PS8745 to ANX7493, the ANX7493 not support DP AUX BIAS, so connects DP AUX BIAS of DB to SOC directly. Add DB_AUX_BIAS bit field to fw_config for compatibility.
BUG=b:320235566
TEST=DP function of MB and DB workable
Change-Id: I53974ec7444912a63d0fe0a9303c9e5d6941f68d
Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
M src/mainboard/google/brya/variants/anraggar/variant.c
2 files changed, 34 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/80259/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/80259?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53974ec7444912a63d0fe0a9303c9e5d6941f68d
Gerrit-Change-Number: 80259
Gerrit-PatchSet: 14
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alper Nebi Yasak, Philipp Hug, ron minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80379?usp=email )
Change subject: mainboard/qemu-riscv: Move DRAM resource setup to read_resources
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80379?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic171cb7e22d9da2df18a9d171a5ab89c2cd3298b
Gerrit-Change-Number: 80379
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 14:47:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment