Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80383?usp=email )
Change subject: Makefile.mk: Include build/dsdt.d at common point of build
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
> Need to double check if this is actually working
Done. Needed to add an eval.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80383?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8271d1e172395917f2859c8bbfd2041ddc572ca
Gerrit-Change-Number: 80383
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 07 Feb 2024 16:25:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80383?usp=email
to look at the new patch set (#3).
Change subject: Makefile.mk: Include build/dsdt.d at common point of build
......................................................................
Makefile.mk: Include build/dsdt.d at common point of build
Instead of including the dependency file generated in asl_template when
the template is evaluated, add it to the DEPENDENCIES variable so that
it is included when the rest of the .d files in the DEPENDENCIES are
included in the top level Makefile. This should be safe since template
is evaluated while calling includemakefiles, which is called before the
files in DEPENDENCIES are included.
TEST:
1. Build dell/e6400
2. Run `touch src/mainboard/dell/e6400/dsdt.asl` (defined as a
prerequisite of build/dsdt.aml in build/dsdt.d)
3. Run `make --debug=b`
4. Verify that dsdt.aml was rebuilt due dsdt.asl being newer than target
Change-Id: Ie8271d1e172395917f2859c8bbfd2041ddc572ca
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Makefile.mk
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/80383/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80383?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8271d1e172395917f2859c8bbfd2041ddc572ca
Gerrit-Change-Number: 80383
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80383?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Makefile.mk: Include build/dsdt.d at common point of build
......................................................................
Makefile.mk: Include build/dsdt.d at common point of build
Instead of including the dependency file generated in asl_template when
the template is evaluated, add it to the DEPENDENCIES variable so that
it is included when the rest of the .d files in the DEPENDENCIES are
included in the top level Makefile. This should be safe since template
is evaluated while calling includemakefiles, which is called before the
files in DEPENDENCIES are included.
Change-Id: Ie8271d1e172395917f2859c8bbfd2041ddc572ca
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Makefile.mk
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/80383/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80383?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8271d1e172395917f2859c8bbfd2041ddc572ca
Gerrit-Change-Number: 80383
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80383?usp=email )
Change subject: Makefile.mk: Include build/dsdt.d at common point of build
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Need to double check if this is actually working
--
To view, visit https://review.coreboot.org/c/coreboot/+/80383?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8271d1e172395917f2859c8bbfd2041ddc572ca
Gerrit-Change-Number: 80383
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 16:01:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80369?usp=email )
Change subject: drivers/qemu/fw_cfg: Support architectures using MMIO
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/emulation/qemu/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/80369/comment/a37f7edc_03e972de :
PS1, Line 62: #if CONFIG(CPU_QEMU_X86)
> Regular C `if ()` is much preferred. I know this isn't straight forward here […]
I've see the cleanup commit, so feel free to ignore, or re-order the patches.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80369?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacab3f6959cb6af747fde8a5af5cb35ce2bca512
Gerrit-Change-Number: 80369
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 16:01:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak, Julius Werner, Philipp Hug, ron minnich.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80372?usp=email )
Change subject: arch/io.h: Add stubs for x86 I/O port functions to other arches
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80372?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7d9177283e8c692088ba8e30d6dfe52623c8cb9
Gerrit-Change-Number: 80372
Gerrit-PatchSet: 3
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 15:59:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80369?usp=email )
Change subject: drivers/qemu/fw_cfg: Support architectures using MMIO
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Btw. if we expect the DTB anyway for the memory probing, we could
as well query the MMIO address from it (should be there for riscv,
so I expect for arm too).
--
To view, visit https://review.coreboot.org/c/coreboot/+/80369?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacab3f6959cb6af747fde8a5af5cb35ce2bca512
Gerrit-Change-Number: 80369
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 15:58:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80369?usp=email )
Change subject: drivers/qemu/fw_cfg: Support architectures using MMIO
......................................................................
Patch Set 1:
(2 comments)
File src/drivers/emulation/qemu/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/80369/comment/3ea37cfa_f6d893ac :
PS1, Line 61: else {
When using braces, they should be on all paths, i.e. the if() part too.
https://review.coreboot.org/c/coreboot/+/80369/comment/066f2a69_6520ead4 :
PS1, Line 62: #if CONFIG(CPU_QEMU_X86)
Regular C `if ()` is much preferred. I know this isn't straight forward here
because of the missing declarations. Though, maybe a single #if block above
would be nicer, e.g.
```
#if !CONFIG(CPU_QEMU_X86)
unsigned char inb(int);
void outb(unsigned char, int);
...
#endif
```
Then the compiler shouldn't complain and the linker drop the dead paths.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80369?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacab3f6959cb6af747fde8a5af5cb35ce2bca512
Gerrit-Change-Number: 80369
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 15:56:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80368?usp=email )
Change subject: mb/qemu/fw_cfg: Move fw_cfg driver to drivers/emulation/qemu
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80368/comment/243c8bd3_015bed09 :
PS1, Line 12: q95
*q35
File src/drivers/emulation/qemu/Kconfig:
https://review.coreboot.org/c/coreboot/+/80368/comment/02672003_fd755ddd :
PS1, Line 29: bool "QEMU firmware configuration driver"
This shouldn't have a prompt but only be selected by the mainboard ports that need it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80368?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0348bb2fa3a4cc1ef6561206a5dd02feb16ae869
Gerrit-Change-Number: 80368
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 15:50:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Alper Nebi Yasak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80367?usp=email )
Change subject: mb/qemu/fw_cfg: Use fw_cfg_read() to read SMBIOS data
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80367?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I18e60b8e9de34f2b0ff67af4113beec1d7467329
Gerrit-Change-Number: 80367
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 15:44:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment