Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun.
sridhar siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80361?usp=email )
Change subject: soc/intel/cmn/sa: Refactor SA common code
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/intel/common/block/include/intelblocks/systemagent.h:
https://review.coreboot.org/c/coreboot/+/80361/comment/c6661508_c9162d04 :
PS3, Line 36:
: /* DMA Protected Range Register */
: #define DPR 0x5C
nit: My miss to add this comment earlier, may be this definition can be moved to above line#14 in the same file since it is part of "Device 0:0.0 PCI configuration space ". I'm fine if you wish to add the change through separate patch to avoid rebase.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80361?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I476f213d75a0978336b3749a5ba1499107eb2238
Gerrit-Change-Number: 80361
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: sridhar siricilla <siricillasridhar(a)gmail.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 08 Feb 2024 15:07:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Nico Huber.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80409?usp=email )
Change subject: include/device/device: fix soft_reserved_ram_resource macro
......................................................................
Patch Set 2:
(1 comment)
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/80409/comment/24c81538_383112d4 :
PS2, Line 386: soft_reserved_ram_resource
Can we keep it consistent and use _kb or change the actual users of this to use byte sized values?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80409?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b454175c6530e539aa24dffb771368b0aea6da9
Gerrit-Change-Number: 80409
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 08 Feb 2024 15:05:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80311?usp=email )
Change subject: docker/doc.coreboot.org: Install pip modules into virtual env
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80311/comment/3740e908_af95d83d :
PS1, Line 12: to install modules to an "externally managed environment" [1], which
> > `'sucessfully' may be misspelled - perhaps 'successfully'?` […]
Resolved, reworded commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80311?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd9cc5e6fb28b42ef8e4fa5db01eb9ef192ba0ec
Gerrit-Change-Number: 80311
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Thu, 08 Feb 2024 15:02:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth.
Hello Felix Singer, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80311?usp=email
to look at the new patch set (#3).
Change subject: docker/doc.coreboot.org: Install pip modules into virtual env
......................................................................
docker/doc.coreboot.org: Install pip modules into virtual env
Currently, pip modules are installed system-wide, which may cause
conflicts with modules installed using the package manager. Newer
versions of the Alpine base image also mark its system wide Python
installation as an externally managed environment, which will cause
pip to return an error as per recent Python recommendations [1].
[1] https://peps.python.org/pep-0668/
Change-Id: Idd9cc5e6fb28b42ef8e4fa5db01eb9ef192ba0ec
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/docker/doc.coreboot.org/Dockerfile
M util/docker/doc.coreboot.org/makeSphinx.sh
2 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/80311/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80311?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd9cc5e6fb28b42ef8e4fa5db01eb9ef192ba0ec
Gerrit-Change-Number: 80311
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Martin L Roth.
Hello Felix Singer, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80311?usp=email
to look at the new patch set (#2).
Change subject: docker/doc.coreboot.org: Install pip modules into virtual env
......................................................................
docker/doc.coreboot.org: Install pip modules into virtual env
Currently, pip modules are installed system-wide, which may cause
conflicts with modules installed using the package manager. Newer
versions of the Alpine base image also mark its system wide Python installation as an externally managed environment, which will cause
pip to return an error as per recent Python recommendations [1][2].
[1] https://peps.python.org/pep-0668/
[2] https://packaging.python.org/en/latest/specifications/externally-managed-en…
Change-Id: Idd9cc5e6fb28b42ef8e4fa5db01eb9ef192ba0ec
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/docker/doc.coreboot.org/Dockerfile
M util/docker/doc.coreboot.org/makeSphinx.sh
2 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/80311/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80311?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd9cc5e6fb28b42ef8e4fa5db01eb9ef192ba0ec
Gerrit-Change-Number: 80311
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held, Nico Huber.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80409?usp=email )
Change subject: include/device/device: fix soft_reserved_ram_resource macro
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> So we really merged the soft-reserved stuff...
What seems to be the problem with it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80409?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b454175c6530e539aa24dffb771368b0aea6da9
Gerrit-Change-Number: 80409
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 08 Feb 2024 14:57:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80399?usp=email )
Change subject: Makefile: Drop unused variable originalobjs
......................................................................
Makefile: Drop unused variable originalobjs
This was added in commit 963bed546f (Make: Use unaltered object list for
dependency inclusion) to fix an issue with dependency inclusion. The
logic that used originalobjs was changed in commit db273065f6 (build
system: extend src-to-obj for non-.c/.S files), leaving the variable
unused.
Change-Id: I011ff2070bc31ab9ddf2536873555d0157f91fce
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Makefile
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/80399/1
diff --git a/Makefile b/Makefile
index 4a87d2f..11f4c46 100644
--- a/Makefile
+++ b/Makefile
@@ -357,9 +357,6 @@
# For Ada includes
$(foreach class,$(classes),$(eval $(class)-ada-dirs:=$(sort $(dir $(filter %.ads %.adb,$($(class)-srcs)) $($(class)-extra-specs)))))
-# Save all objs before processing them (for dependency inclusion)
-originalobjs:=$(foreach var, $(addsuffix -objs,$(classes)), $($(var)))
-
# Call post-processors if they're defined
$(foreach class,$(classes),\
$(if $(value $(class)-postprocess),$(eval $(call $(class)-postprocess,$($(class)-objs)))))
--
To view, visit https://review.coreboot.org/c/coreboot/+/80399?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I011ff2070bc31ab9ddf2536873555d0157f91fce
Gerrit-Change-Number: 80399
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80383?usp=email
to look at the new patch set (#4).
Change subject: Makefile.mk: Include build/dsdt.d at the same time as DEPENDENCIES
......................................................................
Makefile.mk: Include build/dsdt.d at the same time as DEPENDENCIES
Instead of including the dependency file generated in asl_template when
the template is evaluated, add it to the DEPENDENCIES variable so that
it is included at the same time as the rest of the .d files the top
level Makefile. This should be safe since asl_template is evaluated
while calling includemakefiles, which is occurs before the files in
DEPENDENCIES are included.
TEST:
1. Build dell/e6400
2. Run `touch src/mainboard/dell/e6400/dsdt.asl` (defined as a
prerequisite of build/dsdt.aml in build/dsdt.d)
3. Run `make --debug=b`
4. Verify that dsdt.aml was rebuilt due dsdt.asl being newer than target
Change-Id: Ie8271d1e172395917f2859c8bbfd2041ddc572ca
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M Makefile.mk
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/80383/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80383?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8271d1e172395917f2859c8bbfd2041ddc572ca
Gerrit-Change-Number: 80383
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset