Attention is currently required from: Alexander Couzens, Nicholas Chin.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80437?usp=email )
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/lenovo/haswell/Kconfig:
https://review.coreboot.org/c/coreboot/+/80437/comment/bc270fa9_bfc73122 :
PS4, Line 8: select H8_HAS_LEDLOGO
> Nit: Move before H8_HAS_PRIMARY_FN_KEYS to keep the list in alphabetical order
Right, forgot about that.
Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80437?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Gerrit-Change-Number: 80437
Gerrit-PatchSet: 5
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 10 Feb 2024 19:47:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Evgeny Zinoviev, Nicholas Chin.
Hello Alexander Couzens, Nicholas Chin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80437?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+2 by Nicholas Chin
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
......................................................................
ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
The name LEDLOGO comes from schematics. It's the red indicator, embedded
in the dot of the 'i' of the ThinkPad logo on laptop's lid.
In vendor firmware, this led starts fading in-and-out, or, in other
words, pulsing, when laptop is put to S3. It helps to determine whether
the laptop is in S3 just by taking a look at the logo.
As of now, coreboot doesn't do anything with this particular indicator,
it's always in enabled (on) state, which is not very convenient.
This patch fixes it.
Tested on T440p.
Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/acpi/systemstatus.asl
M src/mainboard/lenovo/haswell/Kconfig
3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/80437/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/80437?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Gerrit-Change-Number: 80437
Gerrit-PatchSet: 5
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Evgeny Zinoviev.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80437?usp=email )
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/mainboard/lenovo/haswell/Kconfig:
https://review.coreboot.org/c/coreboot/+/80437/comment/8e038471_aa68ec59 :
PS4, Line 8: select H8_HAS_LEDLOGO
Nit: Move before H8_HAS_PRIMARY_FN_KEYS to keep the list in alphabetical order
--
To view, visit https://review.coreboot.org/c/coreboot/+/80437?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Gerrit-Change-Number: 80437
Gerrit-PatchSet: 4
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 10 Feb 2024 19:45:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Nicholas Chin.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80437?usp=email )
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/lenovo/haswell/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/80437/comment/603f859d_54abc33c :
PS1, Line 3: #define H8_HAS_LEDLOGO
> No problem, turned it into a Kconfig.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80437?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Gerrit-Change-Number: 80437
Gerrit-PatchSet: 4
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 10 Feb 2024 19:43:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evgeny Zinoviev <me(a)ch1p.io>
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Nicholas Chin.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80437?usp=email )
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
There's a change between first and current patchsets.
The first patchset puts LEDLOGO in blinking mode during the waking stage, just like the existing code does with the suspend LED. But to be honest, I don't remember it blinking when waking up with vendor firmware.
So in the last patchset, I changed the behavior, putting it to simple "on" state during the waking stage, just like the power button LED.
If somebody remembers different behavior with vendor fw, please tell me in comments, but I think the last version is correct.
File src/mainboard/lenovo/haswell/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/80437/comment/d795c819_ae31f1b5 :
PS1, Line 3: #define H8_HAS_LEDLOGO
> It might be be better to implement this as a Kconfig and use something like `#if CONFIG(H8_HAS_LEDLO […]
No problem, turned it into a Kconfig.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80437?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Gerrit-Change-Number: 80437
Gerrit-PatchSet: 4
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 10 Feb 2024 19:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Evgeny Zinoviev.
Hello Alexander Couzens, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80437?usp=email
to look at the new patch set (#4).
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
......................................................................
ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
The name LEDLOGO comes from schematics. It's the red indicator, embedded
in the dot of the 'i' of the ThinkPad logo on laptop's lid.
In vendor firmware, this led starts fading in-and-out, or, in other
words, pulsing, when laptop is put to S3. It helps to determine whether
the laptop is in S3 just by taking a look at the logo.
As of now, coreboot doesn't do anything with this particular indicator,
it's always in enabled (on) state, which is not very convenient.
This patch fixes it.
Tested on T440p.
Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/acpi/systemstatus.asl
M src/mainboard/lenovo/haswell/Kconfig
3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/80437/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80437?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Gerrit-Change-Number: 80437
Gerrit-PatchSet: 4
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Evgeny Zinoviev.
Hello Alexander Couzens, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80437?usp=email
to look at the new patch set (#3).
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
......................................................................
ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
The name LEDLOGO comes from schematics. It's the red indicator, embedded
in the dot of the 'i' of the ThinkPad logo on laptop's lid.
In vendor firmware, this led starts fading in-and-out, or, in other
words, pulsing, when laptop is put to S3. It helps to determine whether
the laptop is in S3 just by taking a look at the logo.
As of now, coreboot doesn't do anything with this particular indicator,
it's always in enabled (on) state, whether it's in sleep mode or not,
which is not convenient.
This patch fixes it.
Tested on T440p.
Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/acpi/systemstatus.asl
M src/mainboard/lenovo/haswell/Kconfig
3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/80437/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80437?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Gerrit-Change-Number: 80437
Gerrit-PatchSet: 3
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Evgeny Zinoviev.
Hello Alexander Couzens, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80437?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
......................................................................
ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
The name LEDLOGO comes from schematics. It's the red indicator, embedded
in the dot of the 'i' of the ThinkPad logo on laptop's lid.
In vendor firmware, this led starts fading in-and-out, or, in other words,
pulsing, when laptop is put to S3. It helps to determine whether the
laptop is in S3 just by taking a look at the logo.
As of now, coreboot doesn't do anything with this particular indicator,
it's always in enabled (on) state, whether it's in sleep mode or not,
which is not convenient.
This patch fixes it.
Tested on T440p.
Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/acpi/systemstatus.asl
M src/mainboard/lenovo/haswell/Kconfig
3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/80437/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80437?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Gerrit-Change-Number: 80437
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Maximilian Brune, Philipp Hug.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79952?usp=email )
Change subject: arch/riscv/Makefile.inc: Fix OpenSBI compilation
......................................................................
Patch Set 3:
(1 comment)
File src/arch/riscv/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79952/comment/f06886fb_cf4111f1 :
PS3, Line 162: CC_ramstage
So the todo from above is resolved?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79952?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic14fa77d2f223664b9faba048b759e03efffcde8
Gerrit-Change-Number: 79952
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sat, 10 Feb 2024 18:09:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Felix Singer, Martin L Roth, Maximilian Brune, Nico Huber.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80139?usp=email )
Change subject: util/crossgcc/buildgcc: Compile RISC-V GCC with medany
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
could you resolve the build error?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80139?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If5f07ce034686dd7fec160ea76838507c0ba7fa0
Gerrit-Change-Number: 80139
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 10 Feb 2024 17:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment