Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80560?usp=email )
Change subject: intelblocks/systemagent: Add missing N6005 Jasper Lake SKU to PCI ID list
......................................................................
intelblocks/systemagent: Add missing N6005 Jasper Lake SKU to PCI ID list
Change-Id: I3fb4c6cfe24290c34682ff1c3396540465048727
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
M src/soc/intel/common/block/systemagent/systemagent.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/80560/1
diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c
index c2d561a..4d54d88 100644
--- a/src/soc/intel/common/block/systemagent/systemagent.c
+++ b/src/soc/intel/common/block/systemagent/systemagent.c
@@ -407,6 +407,7 @@
PCI_DID_INTEL_JSL_ID_3,
PCI_DID_INTEL_JSL_ID_4,
PCI_DID_INTEL_JSL_ID_5,
+ PCI_DID_INTEL_JSL_ID_6,
PCI_DID_INTEL_ADL_S_ID_1,
PCI_DID_INTEL_ADL_S_ID_2,
PCI_DID_INTEL_ADL_S_ID_3,
--
To view, visit https://review.coreboot.org/c/coreboot/+/80560?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3fb4c6cfe24290c34682ff1c3396540465048727
Gerrit-Change-Number: 80560
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: newchange
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80497?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: superio/ite/it8659e: Add driver for ITE IT8659E
......................................................................
superio/ite/it8659e: Add driver for ITE IT8659E
Based on the non-public "ITE IT8659E-I Preliminary Specification V0.7.2
(For H Version)".
TEST=Initialize IT8659E on the new Protectli platform
Change-Id: I11657ec6e1c880f0cee247071486a904a92bb7a1
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
M src/superio/ite/Makefile.mk
A src/superio/ite/it8659e/Kconfig
A src/superio/ite/it8659e/Makefile.inc
A src/superio/ite/it8659e/acpi/superio.asl
A src/superio/ite/it8659e/chip.h
A src/superio/ite/it8659e/it8659e.h
A src/superio/ite/it8659e/superio.c
7 files changed, 345 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/80497/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80497?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I11657ec6e1c880f0cee247071486a904a92bb7a1
Gerrit-Change-Number: 80497
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, David Hendricks, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Srinidhi N Kaushik, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80360?usp=email )
Change subject: soc/intel/xeon-sp: Hook up public FSP bin and headers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I use UefiPayloadPkg with the current Eagle Stream FSP 1.1.1.316, they payload crashes on my 2S AC.
Is it expected to be broken without the fixes for toctou?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80360?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I778d3535c273dff653330518653bdefcb45e66f4
Gerrit-Change-Number: 80360
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Fri, 16 Feb 2024 09:15:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Srinidhi N Kaushik, Tim Chu.
Hello Christian Walter, David Hendricks, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Srinidhi N Kaushik, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80360?usp=email
to look at the new patch set (#2).
Change subject: soc/intel/xeon-sp: Hook up public FSP bin and headers
......................................................................
soc/intel/xeon-sp: Hook up public FSP bin and headers
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I778d3535c273dff653330518653bdefcb45e66f4
---
M src/soc/intel/xeon_sp/spr/Kconfig
M src/soc/intel/xeon_sp/spr/Makefile.mk
M src/soc/intel/xeon_sp/spr/romstage.c
D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/FspUpd.h
D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/FspmUpd.h
D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/FspsUpd.h
D src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/FsptUpd.h
M src/vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/IioPcieConfigUpd.h
8 files changed, 8 insertions(+), 1,799 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/80360/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80360?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I778d3535c273dff653330518653bdefcb45e66f4
Gerrit-Change-Number: 80360
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Srinidhi N Kaushik, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80360?usp=email )
Change subject: soc/intel/xeon-sp: Hook up public FSP bin and headers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I use UefiPayloadPkg with the current Eagle Stream FSP 1.1.1.316, they payload crashes on my 2S AC.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80360?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I778d3535c273dff653330518653bdefcb45e66f4
Gerrit-Change-Number: 80360
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Fri, 16 Feb 2024 08:59:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Sean Rhodes.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80462?usp=email )
Change subject: mb/starlabs/starbook/{kbl,cml}: Remove libgfxinit code
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Likely grub config then - it's just not used at all, and not all boards have it, so I'd prefer them to all the be same
This was tested to work at some point? Why not simply change the default and leave it as an option for those that want to use it anyway?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80462?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I86af51f07f29971070bdccc3a589e807425cb83a
Gerrit-Change-Number: 80462
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Fri, 16 Feb 2024 08:49:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80462?usp=email )
Change subject: mb/starlabs/starbook/{kbl,cml}: Remove libgfxinit code
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> No objection, but libgfxinit does work with GRUB. […]
Likely grub config then - it's just not used at all, and not all boards have it, so I'd prefer them to all the be same
--
To view, visit https://review.coreboot.org/c/coreboot/+/80462?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I86af51f07f29971070bdccc3a589e807425cb83a
Gerrit-Change-Number: 80462
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Fri, 16 Feb 2024 08:28:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80553?usp=email )
Change subject: soc/intel/common/block/dtt: Add ACPI stub for TCPU device
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80553?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I926d0461e5e0dfaf606102575c2be555a6bfb695
Gerrit-Change-Number: 80553
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 16 Feb 2024 08:27:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment