Attention is currently required from: Felix Held, Ivan Chen, Karthik Ramasubramanian, Paul Menzel.
Kevin Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79887?usp=email )
Change subject: mb/google/dedede/var/beadrix: Generate SPD ID for supported memory part
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/79887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a6925395b52dc7aa5c0f93b8820099369db4dbf
Gerrit-Change-Number: 79887
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 16 Feb 2024 10:37:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Ivan Chen, Karthik Ramasubramanian, Paul Menzel.
Kevin Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79887?usp=email )
Change subject: mb/google/dedede/var/beadrix: Generate SPD ID for supported memory part
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/79887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3a6925395b52dc7aa5c0f93b8820099369db4dbf
Gerrit-Change-Number: 79887
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 16 Feb 2024 10:26:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Srinidhi N Kaushik, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80360?usp=email )
Change subject: soc/intel/xeon-sp: Hook up public FSP bin and headers
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> > I use UefiPayloadPkg with the current Eagle Stream FSP 1.1.1. […]
IIRC David tried UEFI payload before and it can boot up OS w/o TOCTOU workaround. It's my first time trying an UEFI payload though.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80360?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I778d3535c273dff653330518653bdefcb45e66f4
Gerrit-Change-Number: 80360
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Srinidhi N Kaushik <kaushiksrinidhin(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Fri, 16 Feb 2024 10:08:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Ashish Kumar Mishra, Bob Moragues, Karthik Ramasubramanian, Nick Vaccaro, Shelley Chen, Subrata Banik.
Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80564?usp=email )
Change subject: mb/google/brox: Handle bluetooth enable on devices
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80564/comment/d1444718_342f2aec :
PS2, Line 24: field BT 10 10
: option BT_DISCRETE 0
: option BT_CNVI 1
: end
> > I'm not aware where ISH assigned to 10. For now, we could reuse WIFI field. […]
I checked in config.star where 21st bit is taken for ISH. Now I'm reusing WIFI field for both BT and WIFI, as earlier.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80564?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iba008682fcfa7ddc1ec400649c8742c721666f1d
Gerrit-Change-Number: 80564
Gerrit-PatchSet: 2
Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.corp-partner.google.com>
Gerrit-CC: srinivas.kulkarni(a)intel.com
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 16 Feb 2024 10:07:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen(a)google.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Ashish Kumar Mishra <ashish.k.mishra(a)intel.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Yang.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80571?usp=email
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/beadrix: Disable un-used C1 port by daughterboard
......................................................................
mb/google/dedede/var/beadrix: Disable un-used C1 port by daughterboard
Probe usb ports by FW_CONFIG setting to disable C1 port on
beadrix poin2 new daughterboard without C1 port.
BUG=b:316365055
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot
Change-Id: Idb455b2f963025e4e5d4662bb0975009bb4ff3f8
Signed-off-by: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/beadrix/overridetree.cb
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/80571/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/80571?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb455b2f963025e4e5d4662bb0975009bb4ff3f8
Gerrit-Change-Number: 80571
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kevin Yang.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80571?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/google/dedede/var/beadrix: Disable un-used C1 port by daughterboard
......................................................................
mb/google/dedede/var/beadrix: Disable un-used C1 port by daughterboard
Probe usb ports by FW_CONFIG setting to disable C1 port on beadrix poin2 new daughterboard without C1 port.
BUG=b:316365055
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot
Change-Id: Idb455b2f963025e4e5d4662bb0975009bb4ff3f8
Signed-off-by: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/beadrix/overridetree.cb
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/80571/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80571?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb455b2f963025e4e5d4662bb0975009bb4ff3f8
Gerrit-Change-Number: 80571
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kevin Yang.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80571?usp=email
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/beadrix: Disable un-used C1 port by daughterboard
......................................................................
mb/google/dedede/var/beadrix: Disable un-used C1 port by daughterboard
Probe usb ports by FW_CONFIG setting to disable C1 port on
beadrix poin2 new daughterboard without C1 port.
BUG=b:316365055
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot
Change-Id: Idb455b2f963025e4e5d4662bb0975009bb4ff3f8
Signed-off-by: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/beadrix/overridetree.cb
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/80571/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80571?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb455b2f963025e4e5d4662bb0975009bb4ff3f8
Gerrit-Change-Number: 80571
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Yang <kevin.yang(a)ecs.corp-partner.google.com>
Gerrit-MessageType: newpatchset