Attention is currently required from: Arthur Heymans, Martin L Roth, Maximilian Brune.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72600?usp=email )
Change subject: treewide: Remove unused CHIPs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/72600?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia65a0a56a6668a13761bad35f6a44ed8f6a35a78
Gerrit-Change-Number: 72600
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 20 Feb 2024 11:00:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Julius Werner, Martin L Roth.
Hello Felix Singer, Julius Werner, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75031?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Code-Review+2 by Julius Werner, Verified+1 by build bot (Jenkins)
Change subject: arch/arm/armv7/Makefile.inc: Add more finegrained ld-ccopts
......................................................................
arch/arm/armv7/Makefile.inc: Add more finegrained ld-ccopts
Add linker targets only to stages when ARCH_#stage_ARMV7 is set.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I4340681e30059d6f18a49a49937668cd3dd39ce1
---
M src/arch/arm/armv7/Makefile.mk
1 file changed, 15 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/75031/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/75031?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4340681e30059d6f18a49a49937668cd3dd39ce1
Gerrit-Change-Number: 75031
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/74138?usp=email )
Change subject: security/tpm: Handle S3 resume logging
......................................................................
Abandoned
wrong
--
To view, visit https://review.coreboot.org/c/coreboot/+/74138?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7049bf23fea876cdd19103af6e6fd3d5a20ed114
Gerrit-Change-Number: 74138
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Nick Vaccaro, Sean Rhodes, Subrata Banik.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80166?usp=email )
Change subject: mb/intel/adlrvp: Include ADL-N ID 5
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80166/comment/b41f5a90_ef7733f5 :
PS8, Line 7: mb/intel/adlrvp
Replace it with `soc/intel/alderlake`.
Looks like the mainboard changes are already merged as part of previous CL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80166?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7b9fc64ccf8e2401dcd55607e8f09b348efb3182
Gerrit-Change-Number: 80166
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 20 Feb 2024 10:48:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69792?usp=email
to look at the new patch set (#2).
Change subject: payloads/Kconfig: Don't show FIT payload option on x86
......................................................................
payloads/Kconfig: Don't show FIT payload option on x86
On AMD systems where the verstage selects ARCH_ARM the bogus option to
add a FIT payload is show. Therefore be more specific about the arch of
the stage loading the payload (ramstage).
Change-Id: I7afc3b94c5ab8044af0920c87cc8d190467c2a88
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M payloads/Kconfig
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/69792/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69792?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7afc3b94c5ab8044af0920c87cc8d190467c2a88
Gerrit-Change-Number: 69792
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69792?usp=email )
Change subject: payloads/Kconfig: Don't show FIT payload option on x86
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69792/comment/bd27c1e2_671fa528 :
PS1, Line 10: will be show
> is shown
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69792?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7afc3b94c5ab8044af0920c87cc8d190467c2a88
Gerrit-Change-Number: 69792
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 20 Feb 2024 10:47:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Martin L Roth, Maximilian Brune.
Hello Angel Pons, Felix Singer, Martin L Roth, Maximilian Brune, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72600?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by Martin L Roth, Code-Review+2 by Maximilian Brune
Change subject: treewide: Remove unused CHIPs
......................................................................
treewide: Remove unused CHIPs
No devicetree uses these anymore.
Change-Id: Ia65a0a56a6668a13761bad35f6a44ed8f6a35a78
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/amd/pi/00730F01/Makefile.mk
D src/cpu/amd/pi/00730F01/chip_name.c
M src/cpu/intel/model_1067x/model_1067x_init.c
M src/cpu/intel/slot_1/Makefile.mk
D src/cpu/intel/slot_1/slot_1.c
5 files changed, 0 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/72600/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/72600?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia65a0a56a6668a13761bad35f6a44ed8f6a35a78
Gerrit-Change-Number: 72600
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/71871?usp=email
to look at the new patch set (#5).
Change subject: arch/x86/*.ld: Use MEMORY command to verify sections
......................................................................
arch/x86/*.ld: Use MEMORY command to verify sections
Using the MEMORY command is easier to read than manual assertions.
Change-Id: Icface3a286fe01b28e103e0ca7233e071329c9f0
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/x86/bootblock.ld
M src/arch/x86/car.ld
M src/arch/x86/memlayout.ld
M src/soc/example/min86/Kconfig
4 files changed, 30 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/71871/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/71871?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icface3a286fe01b28e103e0ca7233e071329c9f0
Gerrit-Change-Number: 71871
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset