Attention is currently required from: Sean Rhodes.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80613?usp=email )
Change subject: mb/intel/adlrvp: Remove ADLRVP_M mainboard
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80613?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icc853a9df44a4a770db76e119644f0b4c7fcc2c8
Gerrit-Change-Number: 80613
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Tue, 20 Feb 2024 07:55:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Yu-Ping Wu.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80621?usp=email )
Change subject: tests/lib/ux_locales-test: Simplify macros
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File tests/lib/ux_locales-test.c:
https://review.coreboot.org/c/coreboot/+/80621/comment/1910e26d_2ceea8b5 :
PS2, Line 210: NULL
> I think the comment for `UX_LOCALES_GET_TEXT_TEST` is already pretty clear that `NULL` means "text n […]
I don't have strong opinions.
I just tried to improve readability without digging into the MACRO's implementation. Since the MACRO comments are clear enough, I'm okay with the current version.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80621?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3199e2a061550282fb08122943994c835845543
Gerrit-Change-Number: 80621
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 07:52:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Paul Menzel, Sean Rhodes.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80486?usp=email )
Change subject: soc/intel/alderlake: Sync UPD Usb4CmMode with Kconfig
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80486?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8a99db165301ce08caf55aac0e33ca1994559d62
Gerrit-Change-Number: 80486
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 20 Feb 2024 07:48:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Andrey Petrov, Arthur Heymans, Chen, Gang C, Christian Walter, Jincheng Li, Johnny Lin, Jérémy Compostella, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80579?usp=email )
Change subject: drivers/intel/fsp: Work around multi socket Xeon-SP pipe init bug
......................................................................
Patch Set 4: -Code-Review
(1 comment)
Patchset:
PS4:
will do validation before suggesting to move ahead.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80579?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I38a4f4b7470556e528a1672044c31f8bd92887d4
Gerrit-Change-Number: 80579
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 07:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hsuan-ting Chen, Jakub Czapiga.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80621?usp=email )
Change subject: tests/lib/ux_locales-test: Simplify macros
......................................................................
Patch Set 2:
(2 comments)
File tests/lib/ux_locales-test.c:
https://review.coreboot.org/c/coreboot/+/80621/comment/81eb7bf2_8233ee7b :
PS2, Line 190: _expect
> Just want to confirm: so for found, we will display like `expect="translation_1_0"` (with quotation) […]
Exactly.
https://review.coreboot.org/c/coreboot/+/80621/comment/cc0b6040_5e8a870b :
PS2, Line 210: NULL
> Maybe `NULL /* No text found */` would be more clear.
I think the comment for `UX_LOCALES_GET_TEXT_TEST` is already pretty clear that `NULL` means "text not expected to be found".
Or, do you prefer keeping the `UX_LOCALES_GET_TEXT_FOUND_TEST` and `UX_LOCALES_GET_TEXT_NOT_FOUND_TEST` macros? In that case, the macros can still be simplified.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80621?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3199e2a061550282fb08122943994c835845543
Gerrit-Change-Number: 80621
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 07:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Yu-Ping Wu.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80621?usp=email )
Change subject: tests/lib/ux_locales-test: Simplify macros
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File tests/lib/ux_locales-test.c:
https://review.coreboot.org/c/coreboot/+/80621/comment/68d2817f_98d7380f :
PS2, Line 190: _expect
Just want to confirm: so for found, we will display like `expect="translation_1_0"` (with quotation) and for not found, we will display as `expect=NULL` right?
https://review.coreboot.org/c/coreboot/+/80621/comment/797ff681_e1970cb5 :
PS2, Line 210: NULL
Maybe `NULL /* No text found */` would be more clear.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80621?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3199e2a061550282fb08122943994c835845543
Gerrit-Change-Number: 80621
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 06:49:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Stefan Reinauer, ron minnich.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80619?usp=email )
Change subject: Documentation: Update the code of conduct
......................................................................
Patch Set 1:
(1 comment)
File Documentation/community/code_of_conduct.md:
https://review.coreboot.org/c/coreboot/+/80619/comment/725db1ab_1c3a5781 :
PS1, Line 126:
extra line?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80619?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e2010a16f31f892bd1761b56b96ea773877dea0
Gerrit-Change-Number: 80619
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 06:15:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment