Attention is currently required from: Elyes Haouas, Felix Singer, Nicholas Sudsgaard, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80332?usp=email )
Change subject: device/azalia: Separate codec checking and initialization
......................................................................
Patch Set 9:
(1 comment)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/80332/comment/a305a41c_78a80301 :
PS5, Line 249: u32
> Yeah, please do that in a separate patch.
yes, that's a separate logical change, so please do that in a follow-up
--
To view, visit https://review.coreboot.org/c/coreboot/+/80332?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I92b6d184abccdbe0e1bfce98a2c959a97a618a29
Gerrit-Change-Number: 80332
Gerrit-PatchSet: 9
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 20 Feb 2024 13:39:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Anand Vaikar, Fred Reitberger, Jason Glenesk, Martin L Roth, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80353?usp=email )
Change subject: mb/amd/birman_plus: Add Birman+ board support for Phoenix SOC
......................................................................
Patch Set 13: Code-Review+1
(2 comments)
Patchset:
PS13:
some files have comments that say that those should be updated for birman; maybe change that to birman+?
the ec and gpios probably need some changes too, but that's something for future follow-up patches
File src/mainboard/amd/birman/Kconfig:
PS13:
this whitespace change to the birman kconfig is unrelated and should be removed from this patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/80353?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I075dcf0214f8dc8b33b0e429d83d270b2f0952e1
Gerrit-Change-Number: 80353
Gerrit-PatchSet: 13
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 13:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Matt DeVillier, Paul Menzel.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80179?usp=email )
Change subject: i2c/drivers/generic: Add support for including a rotation matrix
......................................................................
Patch Set 6:
(1 comment)
File src/drivers/i2c/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/80179/comment/0ff78b3a_2a724bf0 :
PS4, Line 81: int
> yeah, probed and detected should probably also be bool, but that's something for a separate patch. […]
Sorry, so change it back - and then separate patch to switch them both to bools?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80179?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4a940d999a0e300a6fe21269f18bab6e3c0523c
Gerrit-Change-Number: 80179
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 20 Feb 2024 13:14:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78884?usp=email )
Change subject: util/crossgcc: Update LLVM from 16.0.6 to 17.0.6
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS8:
> Done
i would have strongly preferred if we waited with this until the release is tested and published. if testing will find a major problem with the release and we need to add some fixes and re-do the release, this uprev will already be included which might be some major change. let's hope that this won't happe, but for the next time, please wait with submitting patches like this until the release is tested and officially announced
--
To view, visit https://review.coreboot.org/c/coreboot/+/78884?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifed410f4b7fdc358535f01850328c642d19ff1f6
Gerrit-Change-Number: 78884
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 13:10:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80606?usp=email )
Change subject: crossgcc: Upgrade binutils from 2.41 to 2.42
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> Done
i would have strongly preferred if we waited with this until the release is tested and published. if testing will find a major problem with the release and we need to add some fixes and re-do the release, this uprev will already be included which might be some major change. let's hope that this won't happe, but for the next time, please wait with submitting patches like this until the release is tested and officially announced
--
To view, visit https://review.coreboot.org/c/coreboot/+/80606?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6e9b2dac6fed702e8e353290971699cb9ee05dfc
Gerrit-Change-Number: 80606
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 20 Feb 2024 13:10:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80268?usp=email )
Change subject: soc/amd: rework DRAM and fixed resource reporting
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/mendocino/root_complex.c:
https://review.coreboot.org/c/coreboot/+/80268/comment/4ec8cf71_aa405434 :
PS2, Line 178: ram_from_to
> This does not have IORESOURCE_RESERVE so it will be reported in ACPI _CSR ? Maybe skipping for IORES […]
that's what was eventually done in CB:80407
--
To view, visit https://review.coreboot.org/c/coreboot/+/80268?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib19fd94e06fa3a1d95ade7fafe22db013045a942
Gerrit-Change-Number: 80268
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 13:07:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Anand Vaikar, Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Paul Menzel.
Hello Felix Held, Fred Reitberger, Jason Glenesk, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80353?usp=email
to look at the new patch set (#13).
Change subject: mb/amd/birman_plus: Add Birman+ board support for Phoenix SOC
......................................................................
mb/amd/birman_plus: Add Birman+ board support for Phoenix SOC
1) Initial commit for upstreaming Birmanplus mainboard changes.
2) Add the DXIO descriptors for Birmanplus mainboard.
Change-Id: I075dcf0214f8dc8b33b0e429d83d270b2f0952e1
Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com>
---
M src/mainboard/amd/birman/Kconfig
A src/mainboard/amd/birman_plus/Kconfig
A src/mainboard/amd/birman_plus/Kconfig.name
A src/mainboard/amd/birman_plus/Makefile.mk
A src/mainboard/amd/birman_plus/board_info.txt
A src/mainboard/amd/birman_plus/board_phoenix.fmd
A src/mainboard/amd/birman_plus/bootblock.c
A src/mainboard/amd/birman_plus/chromeos.c
A src/mainboard/amd/birman_plus/chromeos_phoenix.fmd
A src/mainboard/amd/birman_plus/devicetree_phoenix.cb
A src/mainboard/amd/birman_plus/dsdt.asl
A src/mainboard/amd/birman_plus/early_gpio.c
A src/mainboard/amd/birman_plus/ec.c
A src/mainboard/amd/birman_plus/ec.h
A src/mainboard/amd/birman_plus/gpio.c
A src/mainboard/amd/birman_plus/gpio.h
A src/mainboard/amd/birman_plus/mainboard.c
A src/mainboard/amd/birman_plus/port_descriptors.c
18 files changed, 1,346 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/80353/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/80353?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I075dcf0214f8dc8b33b0e429d83d270b2f0952e1
Gerrit-Change-Number: 80353
Gerrit-PatchSet: 13
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80638?usp=email )
Change subject: vendorcode/cavium: Fix bitfields with signed integers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Just wondering, how did you notice? Isn't the code compiled by the CI and there should be errors?
CB:74501
--
To view, visit https://review.coreboot.org/c/coreboot/+/80638?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0b2add2f1078a88347fea7dc65d422d0e5a210a1
Gerrit-Change-Number: 80638
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Tue, 20 Feb 2024 12:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80639?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/qualcomm/sc7{1,2}80: Increase romstage/verstage section for clang
......................................................................
soc/qualcomm/sc7{1,2}80: Increase romstage/verstage section for clang
Clang builds slightly larger binaries so increase the section.
Change-Id: Ide01233f209613678c5408f1afab19415c1071be
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/soc/qualcomm/sc7180/memlayout.ld
M src/soc/qualcomm/sc7280/memlayout.ld
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/80639/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80639?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide01233f209613678c5408f1afab19415c1071be
Gerrit-Change-Number: 80639
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Julius Werner, Paul Menzel, Subrata Banik.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70175?usp=email )
Change subject: lib/lzmadecode: Allow for 8 byte reads on 64bit
......................................................................
Patch Set 4:
(1 comment)
File src/lib/lzmadecode.h:
https://review.coreboot.org/c/coreboot/+/70175/comment/2da49ee2_a16188b7 :
PS4, Line 24:
including types.h should fix the build error
--
To view, visit https://review.coreboot.org/c/coreboot/+/70175?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890c075307c0aec877618d9902ea352ae42a3bfa
Gerrit-Change-Number: 70175
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 20 Feb 2024 12:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment