coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: drivers/intel/fsp2_0: Add FSP-I and FSP-O
by Shuo Liu (Code Review) 27 Dec '24

27 Dec '24

Attention is currently required from: Andrey Petrov, Christian Walter, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Subrata Banik. Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/83113?usp=email ) Change subject: drivers/intel/fsp2_0: Add FSP-I and FSP-O ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83113?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I53ed1eb45eac89d72ae472fe2b41d64c5eecb182 Gerrit-Change-Number: 83113 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Fri, 27 Dec 2024 02:02:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/kanix: Add Synaptics touchpad
by Tyler Wang (Code Review) 27 Dec '24

27 Dec '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun. Tyler Wang has posted comments on this change by Kenneth Chan. ( https://review.coreboot.org/c/coreboot/+/85776?usp=email ) Change subject: mb/google/rex/var/kanix: Add Synaptics touchpad ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Gerrit-Change-Number: 85776 Gerrit-PatchSet: 7 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Fri, 27 Dec 2024 01:12:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/kanix: Add Synaptics touchpad
by Kenneth Chan (Code Review) 27 Dec '24

27 Dec '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tyler Wang. Kenneth Chan has posted comments on this change by Kenneth Chan. ( https://review.coreboot.org/c/coreboot/+/85776?usp=email ) Change subject: mb/google/rex/var/kanix: Add Synaptics touchpad ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85776/comment/7bda332f_21e31d7e?us… : PS4, Line 9: Add Synaptics touchpad for kanix. > remove this line. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Gerrit-Change-Number: 85776 Gerrit-PatchSet: 7 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Fri, 27 Dec 2024 01:11:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/kanix: Add Synaptics touchpad
by Kenneth Chan (Code Review) 27 Dec '24

27 Dec '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Kenneth Chan, Tarun, Tyler Wang. Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, Tyler Wang, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85776?usp=email to look at the new patch set (#7). Change subject: mb/google/rex/var/kanix: Add Synaptics touchpad ...................................................................... mb/google/rex/var/kanix: Add Synaptics touchpad BUG=None BRANCH=firmware-rex-15709.B TEST=1. emerge-rex coreboot 2. check touchpad function is working properly. Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/kanix/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/85776/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/85776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Gerrit-Change-Number: 85776 Gerrit-PatchSet: 7 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/kanix: Add Synaptics touchpad
by Kenneth Chan (Code Review) 27 Dec '24

27 Dec '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Kenneth Chan, Tarun, Tyler Wang. Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, Tyler Wang, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85776?usp=email to look at the new patch set (#6). Change subject: mb/google/rex/var/kanix: Add Synaptics touchpad ...................................................................... mb/google/rex/var/kanix: Add Synaptics touchpad BUG=None BRANCH=rex TEST=1. emerge-rex coreboot 2. check touchpad function is working properly. Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/kanix/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/85776/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Gerrit-Change-Number: 85776 Gerrit-PatchSet: 6 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/kanix: Add Synaptics touchpad
by Kenneth Chan (Code Review) 27 Dec '24

27 Dec '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Kenneth Chan, Tarun, Tyler Wang. Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, Tyler Wang, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85776?usp=email to look at the new patch set (#5). Change subject: mb/google/rex/var/kanix: Add Synaptics touchpad ...................................................................... mb/google/rex/var/kanix: Add Synaptics touchpad BUG=None BRANCH=rex TEST=1. emerge-rex coreboot 2. check touchpad function is working properly. Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/kanix/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/85776/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/85776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I89b9e24f98c1e7af571507283469411fd389431a Gerrit-Change-Number: 85776 Gerrit-PatchSet: 5 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[XS] Change in coreboot[main]: tests: Replace 'unsigned long int' by 'unsigned long'
by Ariel Otilibili (Code Review) 27 Dec '24

27 Dec '24

Ariel Otilibili has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85788?usp=email ) Change subject: tests: Replace 'unsigned long int' by 'unsigned long' ...................................................................... tests: Replace 'unsigned long int' by 'unsigned long' As suggested by the linter: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/art… Cc: Jakub Czapiga <czapiga(a)google.com> Change-Id: Ia41f0674f4abab285d89ed5101b3805975f3f381 Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr> --- M tests/device/i2c-test.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/85788/1 diff --git a/tests/device/i2c-test.c b/tests/device/i2c-test.c index 4b96d94..36b9e4a 100644 --- a/tests/device/i2c-test.c +++ b/tests/device/i2c-test.c @@ -80,7 +80,7 @@ static void mock_expect_params_platform_i2c_transfer(void) { - unsigned long int expected_flags[] = {0, I2C_M_RD, I2C_M_TEN, I2C_M_RECV_LEN, + unsigned long expected_flags[] = {0, I2C_M_RD, I2C_M_TEN, I2C_M_RECV_LEN, I2C_M_NOSTART}; /* Flags should always be only within supported range */ -- To view, visit https://review.coreboot.org/c/coreboot/+/85788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia41f0674f4abab285d89ed5101b3805975f3f381 Gerrit-Change-Number: 85788 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili Gerrit-CC: Jakub Czapiga <czapiga(a)google.com>

1 0

[XS] Change in coreboot[main]: lib: Replace 'unsigned long int' by 'unsigned long'
by Ariel Otilibili (Code Review) 27 Dec '24

27 Dec '24

Ariel Otilibili has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85787?usp=email ) Change subject: lib: Replace 'unsigned long int' by 'unsigned long' ...................................................................... lib: Replace 'unsigned long int' by 'unsigned long' As suggested by the linter: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/art… Change-Id: I93d951eac69150b6cd73c9e56cb02a73c5118340 Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr> --- M src/lib/ubsan.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/85787/1 diff --git a/src/lib/ubsan.c b/src/lib/ubsan.c index 560493c..456a272 100644 --- a/src/lib/ubsan.c +++ b/src/lib/ubsan.c @@ -43,8 +43,8 @@ if (!location || !location->filename) location = &unknown_location; printk(BIOS_ERR, "%s %s:%lu:%lu\n", violation, location->filename, - (unsigned long int)location->line, - (unsigned long int)location->column); + (unsigned long)location->line, + (unsigned long)location->column); die("ubsan: unrecoverable error.\n"); } -- To view, visit https://review.coreboot.org/c/coreboot/+/85787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93d951eac69150b6cd73c9e56cb02a73c5118340 Gerrit-Change-Number: 85787 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili

1 0

[S] Change in coreboot[main]: util/cbfstool: Replace 'unsigned long int' by 'unsigned long'
by Ariel Otilibili (Code Review) 27 Dec '24

27 Dec '24

Ariel Otilibili has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85786?usp=email ) Change subject: util/cbfstool: Replace 'unsigned long int' by 'unsigned long' ...................................................................... util/cbfstool: Replace 'unsigned long int' by 'unsigned long' As suggested by the linter: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/art… Cc: Nico Huber <nico.h(a)gmx.de> Cc: Julius Werner <jwerner(a)chromium.org> Cc: "Jérémy Compostella" <jeremy.compostella(a)intel.com> Cc: Ron Minnich <rminnich(a)gmail.com> Cc: Shuo Liu <shuo.liu(a)intel.com> Cc: Arthur Heymans <arthur(a)aheymans.xyz> Cc: Patrick Georgi <patrick(a)coreboot.org> Change-Id: If94e70778d0302552f151c31d3073524162faf9e Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr> --- M util/cbfstool/cbfstool.c M util/cbfstool/flashmap/fmap.c 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/85786/1 diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index 25f4847..6fec2b8 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -352,11 +352,11 @@ return 1; union { - unsigned long int array[3]; + unsigned long array[3]; struct { - unsigned long int flash_base; - unsigned long int mmap_base; - unsigned long int mmap_size; + unsigned long flash_base; + unsigned long mmap_base; + unsigned long mmap_size; }; } mmap_args; char *suffix = NULL; diff --git a/util/cbfstool/flashmap/fmap.c b/util/cbfstool/flashmap/fmap.c index 46c31bb..bf9f4bb 100644 --- a/util/cbfstool/flashmap/fmap.c +++ b/util/cbfstool/flashmap/fmap.c @@ -74,7 +74,7 @@ /* brute force linear search */ static long int fmap_lsearch(const uint8_t *image, size_t len) { - unsigned long int offset; + unsigned long offset; int fmap_found = 0; for (offset = 0; offset < len - strlen(FMAP_SIGNATURE); offset++) { @@ -96,7 +96,7 @@ /* if image length is a power of 2, use binary search */ static long int fmap_bsearch(const uint8_t *image, size_t len) { - unsigned long int offset = -1; + unsigned long offset = -1; int fmap_found = 0, stride; /* -- To view, visit https://review.coreboot.org/c/coreboot/+/85786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If94e70778d0302552f151c31d3073524162faf9e Gerrit-Change-Number: 85786 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com> Gerrit-CC: ron minnich <rminnich(a)gmail.com>

1 0

[XS] Change in coreboot[main]: samsung/exynos5250: Replace 'unsigned long int' by 'unsigned long'
by Ariel Otilibili (Code Review) 27 Dec '24

27 Dec '24

Ariel Otilibili has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85785?usp=email ) Change subject: samsung/exynos5250: Replace 'unsigned long int' by 'unsigned long' ...................................................................... samsung/exynos5250: Replace 'unsigned long int' by 'unsigned long' As suggested by the linter: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/art… Change-Id: I7eddb0934ccd24c9994a60d7058a1e518c6c9c9f Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr> --- M src/soc/samsung/exynos5250/fb.c M src/soc/samsung/exynos5250/include/soc/dp-core.h 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/85785/1 diff --git a/src/soc/samsung/exynos5250/fb.c b/src/soc/samsung/exynos5250/fb.c index ab097e2..2ddc49c 100644 --- a/src/soc/samsung/exynos5250/fb.c +++ b/src/soc/samsung/exynos5250/fb.c @@ -95,7 +95,7 @@ * @param lcdbase pointer to the base address of framebuffer. * @param pd pointer to the main panel_data structure */ -void fb_init(unsigned long int fb_size, void *lcdbase, +void fb_init(unsigned long fb_size, void *lcdbase, struct exynos5_fimd_panel *pd) { unsigned int val; @@ -532,7 +532,7 @@ * @param lcdbase Base address of LCD frame buffer * @return 0 if ok, -ve error code on error */ -int lcd_ctrl_init(unsigned long int fb_size, +int lcd_ctrl_init(unsigned long fb_size, struct exynos5_fimd_panel *panel_data, void *lcdbase) { int ret = 0; diff --git a/src/soc/samsung/exynos5250/include/soc/dp-core.h b/src/soc/samsung/exynos5250/include/soc/dp-core.h index 0c8aed7..6b2a21c 100644 --- a/src/soc/samsung/exynos5250/include/soc/dp-core.h +++ b/src/soc/samsung/exynos5250/include/soc/dp-core.h @@ -234,9 +234,9 @@ /* startup and init */ struct exynos5_fimd_panel; -void fb_init(unsigned long int fb_size, void *lcdbase, +void fb_init(unsigned long fb_size, void *lcdbase, struct exynos5_fimd_panel *pd); int dp_controller_init(struct s5p_dp_device *dp_device); -int lcd_ctrl_init(unsigned long int fb_size, +int lcd_ctrl_init(unsigned long fb_size, struct exynos5_fimd_panel *panel_data, void *lcdbase); #endif /* CPU_SAMSUNG_EXYNOS5250_DP_CORE_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/85785?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7eddb0934ccd24c9994a60d7058a1e518c6c9c9f Gerrit-Change-Number: 85785 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024