coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[M] Change in coreboot[main]: util/amdfwtool: Add binary parsing
by Felix Held (Code Review) 02 Dec '24

02 Dec '24

Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Marshall Dawson, Maximilian Brune, Paul Menzel. Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84373?usp=email ) Change subject: util/amdfwtool: Add binary parsing ...................................................................... Patch Set 8: (1 comment) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/84373/comment/8129c3a3_da005fa2?us… : PS8, Line 263: { .type = AMD_FW_MINIMSMU, .subprog = 0, .level = PSP_BOTH | PSP_LVL2_AB }, : { .type = AMD_FW_MINIMSMU, .subprog = 1, .level = PSP_BOTH | PSP_LVL2_AB }, > Dropping "Instance" seems like it could potentially be a problem. this adds the inst=0, subprog=1 case, but drops the inst=1, subprog=0 case -- To view, visit https://review.coreboot.org/c/coreboot/+/84373?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef Gerrit-Change-Number: 84373 Gerrit-PatchSet: 8 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Comment-Date: Mon, 02 Dec 2024 19:18:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

[M] Change in coreboot[main]: util/amdfwtool: Add binary parsing
by Marshall Dawson (Code Review) 02 Dec '24

02 Dec '24

Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Felix Held, Maximilian Brune, Paul Menzel. Marshall Dawson has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84373?usp=email ) Change subject: util/amdfwtool: Add binary parsing ...................................................................... Patch Set 8: (4 comments) Patchset: PS8: Since this gets used across SOC generations, I'd really like to see a sampling of successful tests with this patch. Will see if Felix can help. File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/84373/comment/fc901a4d_f5568ef0?us… : PS8, Line 263: { .type = AMD_FW_MINIMSMU, .subprog = 0, .level = PSP_BOTH | PSP_LVL2_AB }, : { .type = AMD_FW_MINIMSMU, .subprog = 1, .level = PSP_BOTH | PSP_LVL2_AB }, Dropping "Instance" seems like it could potentially be a problem. https://review.coreboot.org/c/coreboot/+/84373/comment/fafb60f0_521aca35?us… : PS8, Line 324: { .type = AMD_BIOS_APOB_NV, .level = BDT_BOTH }, Are you sure this is required? Or maybe it became a requirement on glinda? IIRC we've traditionally kept Level 1 as minimal as possible. https://review.coreboot.org/c/coreboot/+/84373/comment/9e245410_398e269c?us… : PS8, Line 381: { .type = AMD_BIOS_MP2_CFG, .level = BDT_BOTH }, Same as above. -- To view, visit https://review.coreboot.org/c/coreboot/+/84373?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef Gerrit-Change-Number: 84373 Gerrit-PatchSet: 8 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 19:10:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: drivers/spi: add RPMC support
by Matt DeVillier (Code Review) 02 Dec '24

02 Dec '24

Attention is currently required from: Felix Held. Matt DeVillier has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/84837?usp=email ) Change subject: drivers/spi: add RPMC support ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84837?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9bd69d0105c66bf5ecb6c90e8c782a81912bd40 Gerrit-Change-Number: 84837 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 19:02:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: drivers/pc80/pc/keyboard.c: Add function to change a command byte bit
by Jérémy Compostella (Code Review) 02 Dec '24

02 Dec '24

Attention is currently required from: Nicholas Sudsgaard. Jérémy Compostella has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/85330?usp=email ) Change subject: drivers/pc80/pc/keyboard.c: Add function to change a command byte bit ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85330?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8745d1848f223634043eecc4659021a76a2b239b Gerrit-Change-Number: 85330 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Comment-Date: Mon, 02 Dec 2024 18:53:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: vendorcode/amd/fsp/glinda: port usb_phy_config structure
by Marshall Dawson (Code Review) 02 Dec '24

02 Dec '24

Attention is currently required from: Anand Vaikar, Felix Held, Fred Reitberger, Jason Glenesk, Maximilian Brune, ritul guru. Marshall Dawson has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84435?usp=email ) Change subject: vendorcode/amd/fsp/glinda: port usb_phy_config structure ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84435/comment/afbf0536_f90d3ee0?us… : PS5, Line 11: Reviewed-by: Anand Vaikar <a.vaikar2021(a)gmail.com> : Reviewed-by: Ritul Guru <ritul.bits(a)gmail.com> : Tested-by: Satya Sreenivas L <Satya.SreenivasL(a)amd.com> : > I didn't know that tool existed. Thanks for the pointer. […] I suspected I meant the comment for the AMD folks. But glad you know about it too, now 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/84435?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0603f5da689b6738ea54305a665b150121bc520c Gerrit-Change-Number: 84435 Gerrit-PatchSet: 7 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 18:37:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[S] Change in coreboot[main]: soc/amd/glinda: Update MCA banks
by Felix Held (Code Review) 02 Dec '24

02 Dec '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84374?usp=email ) Change subject: soc/amd/glinda: Update MCA banks ...................................................................... soc/amd/glinda: Update MCA banks source: PPR 57254 Rev 1.59 Table "Non-core MCA Bank to Block Mapping" Change-Id: I16f5f9db08ab3232caa64fcdc90b8fc062869fcc Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84374 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/soc/amd/glinda/mca.c 1 file changed, 21 insertions(+), 8 deletions(-) Approvals: Felix Held: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/amd/glinda/mca.c b/src/soc/amd/glinda/mca.c index c843f4e..e89f0c8 100644 --- a/src/soc/amd/glinda/mca.c +++ b/src/soc/amd/glinda/mca.c @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: Update for Glinda */ - #include <amdblocks/mca.h> #include <cpu/x86/msr.h> #include <types.h> @@ -18,12 +16,27 @@ [8] = "L3 cache unit", [9] = "L3 cache unit", [10] = "L3 cache unit", - [11] = "UMC", - [12] = "UMC", - [13] = "CS", - [14] = "CS", - [15] = "NBIO", - [16] = "PIE", + [11] = "L3 cache unit", + [12] = "L3 cache unit", + [13] = "L3 cache unit", + [14] = "L3 cache unit", + [15] = "UMC", + [16] = "UMC", + [17] = "UMC", + [18] = "UMC", + [19] = "CS", + [20] = "CS", + [21] = "CS", + [22] = "CS", + [23] = "", + [24] = "", + [25] = "", + [26] = "", + [27] = "PIE", + [28] = "NBIO", + [29] = "KPX_SERDES", + [30] = "KPX_SERDES", + [31] = "", }; bool mca_has_expected_bank_count(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/84374?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I16f5f9db08ab3232caa64fcdc90b8fc062869fcc Gerrit-Change-Number: 84374 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: soc/amd/glinda: Update MCA banks
by Felix Held (Code Review) 02 Dec '24

02 Dec '24

Attention is currently required from: Ana Carolina Cabral, Maximilian Brune. Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84374?usp=email ) Change subject: soc/amd/glinda: Update MCA banks ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84374?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I16f5f9db08ab3232caa64fcdc90b8fc062869fcc Gerrit-Change-Number: 84374 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Comment-Date: Mon, 02 Dec 2024 18:16:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: util/crossgcc: Add libstdcxx target
by Jon Murphy (Code Review) 02 Dec '24

02 Dec '24

Attention is currently required from: Felix Singer, Karthik Ramasubramanian, Martin L Roth, Raul Rangel. Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email ) Change subject: util/crossgcc: Add libstdcxx target ...................................................................... Patch Set 9: (1 comment) File util/crossgcc/buildgcc: https://review.coreboot.org/c/coreboot/+/85275/comment/4b0eb33c_9b33b3fd?us… : PS8, Line 787: rm -f "gcc/$TARGETARCH/$GCC_VERSION" && \ : ln -s "$DESTDIR$TARGETDIR/$TARGETARCH/bin" "gcc/$TARGETARCH/$GCC_VERSION" && \ : $MAKE $JOBS CFLAGS_FOR_BUILD="$HOSTCFLAGS" all-gcc && \ : $MAKE install-gcc DESTDIR="$DESTDIR" || touch .failed : : if [ ! -f .failed ] && [ "$(echo $TARGETARCH | grep -c -- -mingw32)" -eq 0 ]; then : # shellcheck disable=SC2086 : $MAKE $JOBS CFLAGS_FOR_BUILD="$HOSTCFLAGS" all-target-libgcc && \ : $MAKE install-target-libgcc DESTDIR=$DESTDIR || touch .failed : fi > Move this function below `configure_GCC` so that the diff shows that this wasn't changed. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed Gerrit-Change-Number: 85275 Gerrit-PatchSet: 9 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 02 Dec 2024 17:51:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>

1 0

[M] Change in coreboot[main]: util/crossgcc: Add libstdcxx target
by Jon Murphy (Code Review) 02 Dec '24

02 Dec '24

Attention is currently required from: Felix Singer, Karthik Ramasubramanian, Martin L Roth, Raul Rangel. Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email ) Change subject: util/crossgcc: Add libstdcxx target ...................................................................... Patch Set 8: (2 comments) Patchset: PS5: > Honestly I feel like any modular solution we come up with is going to be more complex than this 48 l […] It's also not doing anything unreasonable. We're adding support for an additional library that could be useful to upstream and other projects. I added it in a way that wouldn't affect any other builds, and would only be called as needed. File util/crossgcc/buildgcc: https://review.coreboot.org/c/coreboot/+/85275/comment/040f0fa8_a5f0ba20?us… : PS8, Line 784: @ > POSIX `sh` doesn't actually have arrays AFAIK. Ack, I was using bash locally. I'll update. -- To view, visit https://review.coreboot.org/c/coreboot/+/85275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed Gerrit-Change-Number: 85275 Gerrit-PatchSet: 8 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 02 Dec 2024 17:47:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com>

1 0

[XS] Change in coreboot[main]: src/soc/intel/cmn/blk/cse: Log cse sync information
by Karthik Ramasubramanian (Code Review) 02 Dec '24

02 Dec '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal. Karthik Ramasubramanian has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/85219?usp=email ) Change subject: src/soc/intel/cmn/blk/cse: Log cse sync information ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/85219/comment/08fb4882_f21353af?us… : PS1, Line 838: if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE)) : elog_add_event_byte(ELOG_TYPE_FW_CSE_SYNC, ELOG_FW_RAMSTAGE_CSE_SYNC); : else : elog_add_event_byte(ELOG_TYPE_FW_CSE_SYNC, ELOG_FW_ROMSTAGE_CSE_SYNC); `elog_add_event_byte(ELOG_TYPE_FW_CSE_SYNC, ENV_RAMSTAGE ? ...);` -- To view, visit https://review.coreboot.org/c/coreboot/+/85219?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idece841c2b069d7688afc258470667ed2851a282 Gerrit-Change-Number: 85219 Gerrit-PatchSet: 1 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 02 Dec 2024 17:44:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024