coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[M] Change in coreboot[main]: mb/google/brya/var/*: Use name 'LCD0' for internal panel output
by Matt DeVillier (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Kapil Porwal, Matt DeVillier, Nick Vaccaro, Won Chung. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Won Chung, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80174?usp=email to look at the new patch set (#3). Change subject: mb/google/brya/var/*: Use name 'LCD0' for internal panel output ...................................................................... mb/google/brya/var/*: Use name 'LCD0' for internal panel output The GMA driver generates the brightness controls expecting the name LCD0, so we need to use it here as well so that the DSDT and SSDT parts match. TEST=build/boot Win11 on google/brya (redrix), verify brightness controls are functional. Change-Id: I389553b2ddc5b09d165229e2d8066cacf852b82c Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/brya/variants/anahera/overridetree.cb M src/mainboard/google/brya/variants/anahera4es/overridetree.cb M src/mainboard/google/brya/variants/anraggar/overridetree.cb M src/mainboard/google/brya/variants/banshee/overridetree.cb M src/mainboard/google/brya/variants/brya0/overridetree.cb M src/mainboard/google/brya/variants/crota/overridetree.cb M src/mainboard/google/brya/variants/dochi/overridetree.cb M src/mainboard/google/brya/variants/felwinter/overridetree.cb M src/mainboard/google/brya/variants/gimble/overridetree.cb M src/mainboard/google/brya/variants/gimble4es/overridetree.cb M src/mainboard/google/brya/variants/kano/overridetree.cb M src/mainboard/google/brya/variants/marasov/overridetree.cb M src/mainboard/google/brya/variants/mithrax/overridetree.cb M src/mainboard/google/brya/variants/omnigul/overridetree.cb M src/mainboard/google/brya/variants/osiris/overridetree.cb M src/mainboard/google/brya/variants/primus/overridetree.cb M src/mainboard/google/brya/variants/redrix/overridetree.cb M src/mainboard/google/brya/variants/redrix4es/overridetree.cb M src/mainboard/google/brya/variants/skolas/overridetree.cb M src/mainboard/google/brya/variants/skolas4es/overridetree.cb M src/mainboard/google/brya/variants/taeko/overridetree.cb M src/mainboard/google/brya/variants/taeko4es/overridetree.cb M src/mainboard/google/brya/variants/taniks/overridetree.cb M src/mainboard/google/brya/variants/vell/overridetree.cb M src/mainboard/google/brya/variants/volmar/overridetree.cb 25 files changed, 29 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/80174/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80174?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I389553b2ddc5b09d165229e2d8066cacf852b82c Gerrit-Change-Number: 80174 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Won Chung <wonchung(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Won Chung <wonchung(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/brya/var/pujjo: Add i2c device for Parade touch screen
by Nick Vaccaro (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Derek Huang, Eric Lai, Felix Held, Kapil Porwal, Leo Chou, Nick Vaccaro, Subrata Banik. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80024?usp=email ) Change subject: mb/google/brya/var/pujjo: Add i2c device for Parade touch screen ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80024?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I51bd89beffd912fc147da11d19f38cb44cbe570a Gerrit-Change-Number: 80024 Gerrit-PatchSet: 7 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 24 Jan 2024 16:16:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: vc/amd/opensil/genoa_poc/mpio: rename mpio_config to configure_mpio
by Felix Held (Code Review) 24 Jan '24

24 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80147?usp=email ) Change subject: vc/amd/opensil/genoa_poc/mpio: rename mpio_config to configure_mpio ...................................................................... vc/amd/opensil/genoa_poc/mpio: rename mpio_config to configure_mpio As a preparation for the following patch, rename mpio_config to configure_mpio to make it both a bit more descriptive and to match the naming scheme used for the functions that get called by setup_opensil. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ic4b1aa6e964cbbb4affb89cacd33af8b24871bb6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80147 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Reviewed-by: Varshit Pandya <pandyavarshit(a)gmail.com> --- M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Marshall Dawson: Looks good to me, approved build bot (Jenkins): Verified Varshit Pandya: Looks good to me, approved diff --git a/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c b/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c index c268293..49a8934 100644 --- a/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c +++ b/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c @@ -175,7 +175,7 @@ mpio_port++; } -static void mpio_config(void *const config) +static void configure_mpio(void *const config) { MPIOCLASS_INPUT_BLK *mpio_data = SilFindStructure(SilId_MpioClass, 0); mpio_global_config(mpio_data); @@ -183,11 +183,11 @@ /* Find all devices with this chip */ for (struct device *dev = &dev_root; dev; dev = dev->next) - if (dev->chip_ops->init == mpio_config) + if (dev->chip_ops->init == configure_mpio) per_device_config(mpio_data, dev->bus->dev, dev->chip_info); } struct chip_operations vendorcode_amd_opensil_genoa_poc_mpio_ops = { CHIP_NAME("AMD GENOA MPIO") - .init = mpio_config, + .init = configure_mpio, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/80147?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4b1aa6e964cbbb4affb89cacd33af8b24871bb6 Gerrit-Change-Number: 80147 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: [UNTESTED]cpu/amd: Lock down paging and EFER in SMM
by Arthur Heymans (Code Review) 24 Jan '24

24 Jan '24

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80187?usp=email ) Change subject: [UNTESTED]cpu/amd: Lock down paging and EFER in SMM ...................................................................... [UNTESTED]cpu/amd: Lock down paging and EFER in SMM Changing page tables or the value of EFER in SMM is undesirable in the coreboot use case. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I96fb75759444e9c2afa3bec719045ece1ec2daf8 --- M src/cpu/x86/smm/smm_stub.S M src/include/cpu/amd/msr.h 2 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/80187/1 diff --git a/src/cpu/x86/smm/smm_stub.S b/src/cpu/x86/smm/smm_stub.S index f97ab59..cd01611 100644 --- a/src/cpu/x86/smm/smm_stub.S +++ b/src/cpu/x86/smm/smm_stub.S @@ -9,6 +9,7 @@ * found in smm.h. */ +#include <cpu/amd/msr.h> #include <cpu/x86/cr.h> #include <cpu/x86/msr.h> #include <cpu/x86/lapic_def.h> @@ -196,9 +197,15 @@ mov %ecx, %edi /* entry64.inc preserves ebx, esi, edi, ebp */ #include <cpu/x86/64bit/entry64.inc> +#if CONFIG(CPU_AMD_PI) || CONFIG(SOC_AMD_COMMON) + /* Lock down paging */ + movl $HWCR_MSR, %ecx + rdmsr + or $SMM_PGCFG_LOCK, %eax + wrmsr +#endif mov %edi, %ecx - push %rbx /* uintptr_t *canary */ push %rcx /* size_t cpu */ @@ -211,6 +218,14 @@ push %ebx /* uintptr_t *canary */ push %ecx /* size_t cpu */ push %esp /* smm_module_params *arg (allocated on stack). */ + +#if CONFIG(CPU_AMD_PI) || CONFIG(SOC_AMD_COMMON) + /* Lock down paging */ + movl $HWCR_MSR, %ecx + rdmsr + or $SMM_PGCFG_LOCK, %eax + wrmsr +#endif mov c_handler, %eax call *%eax #endif diff --git a/src/include/cpu/amd/msr.h b/src/include/cpu/amd/msr.h index 3f7febc..8ad7a2f 100644 --- a/src/include/cpu/amd/msr.h +++ b/src/include/cpu/amd/msr.h @@ -16,6 +16,7 @@ #define FS_Base 0xC0000100 #define HWCR_MSR 0xC0010015 #define SMM_LOCK (1 << 0) +#define SMM_PGCFG_LOCK (1 << 3) #define NB_CFG_MSR 0xC001001f #define FidVidStatus 0xC0010042 #define MC0_CTL_MASK 0xC0010044 -- To view, visit https://review.coreboot.org/c/coreboot/+/80187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I96fb75759444e9c2afa3bec719045ece1ec2daf8 Gerrit-Change-Number: 80187 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: mb/siemens/mc_ehl3: Use PSE GbE 0 instead of PSE GbE 1
by Mario Scheithauer (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Jan Samek, Johannes Hahn, Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80186?usp=email ) Change subject: mb/siemens/mc_ehl3: Use PSE GbE 0 instead of PSE GbE 1 ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80186/comment/ac090c01_07de30b6 : PS1, Line 10: 1 0 File src/mainboard/siemens/mc_ehl/variants/mc_ehl3/gpio.c: https://review.coreboot.org/c/coreboot/+/80186/comment/1c7b471d_21d5e938 : PS1, Line 111: PAD_CFG_NF(GPP_C6, NONE, DEEP, NF1), /* PSE_GBE0_AUXTS */ : PAD_CFG_NF(GPP_C7, NONE, DEEP, NF1), /* PSE_GBE0_PPS */ I think C6 and C7 belong to GBE1. You should be able to set both to NC. -- To view, visit https://review.coreboot.org/c/coreboot/+/80186?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I322371f944d15134e6f48ecd84a4026c2fced27b Gerrit-Change-Number: 80186 Gerrit-PatchSet: 1 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Johannes Hahn <johannes-hahn(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Johannes Hahn <johannes-hahn(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 14:12:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: Add MTCL function to ACPI SSDT tables
by Nico Huber (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Cliff Huang, David Ruth, Lance Zhao, Paul Menzel, Subrata Banik, Subrata Banik, Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80170?usp=email ) Change subject: Add MTCL function to ACPI SSDT tables ...................................................................... Patch Set 6: (1 comment) File src/acpi/acpigen.c: https://review.coreboot.org/c/coreboot/+/80170/comment/51727f1a_6e71d96a : PS6, Line 1968: acpigen_write_byte(bytes[i]); > Looking into the kernel code (which looks crazy btw.) it seems to expect […] Sorry, nevermind. I confused acpigen_write_byte() and acpigen_emit_byte(). -- To view, visit https://review.coreboot.org/c/coreboot/+/80170?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9b5e7312a44e114270e664b983626faa6cfee350 Gerrit-Change-Number: 80170 Gerrit-PatchSet: 6 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: David Ruth <druth(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 14:09:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/screebo: Modify TCC_offset to 20
by Subrata Banik (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Sumeet R Pawnikar, Tarun. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80159?usp=email ) Change subject: mb/google/rex/var/screebo: Modify TCC_offset to 20 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Is this reviewed by Screebo ODM? > Please check bug b:309569030#comment4 for TCC_offset change discussion. It seems ODM not considering to change this TCC_Offset right now. w/o ur override the tcc_offset was 20. now you have force set the tcc_offset to 10 hence, this CL is required to restore the current settings I hope you have noticed below comments bt still you have changed the screebo device thermal behaviour w/ ur cl. ``` Hi Sumeet 1.For user experience view, we don't want CPU temperature be close to much higher temperature as 100 degree C. 2.The performance target is aligned on quadrilateral meeting. 3.Now, SW setting modification will impact the system validation plan due to FW locked down. So we don't suggest to implement this modification as you pointed at this moment. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/80159?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idc76f9c0054f21f066b779e6404a1c175eb396a0 Gerrit-Change-Number: 80159 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 13:37:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/screebo: Modify TCC_offset to 20
by Sumeet R Pawnikar (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80159?usp=email ) Change subject: mb/google/rex/var/screebo: Modify TCC_offset to 20 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Is this reviewed by Screebo ODM? Please check bug b:309569030#comment4 for TCC_offset change discussion. It seems ODM not considering to change this TCC_Offset right now. -- To view, visit https://review.coreboot.org/c/coreboot/+/80159?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idc76f9c0054f21f066b779e6404a1c175eb396a0 Gerrit-Change-Number: 80159 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 13:32:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/galtic: Support for Samsung K4U6E3S4AB-MGCL
by Daniel Peng (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Derek Huang, Edward Dai, Felix Held, Ivan Chen, Karthik Ramasubramanian, Paul Menzel. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80150?usp=email ) Change subject: mb/google/dedede/var/galtic: Support for Samsung K4U6E3S4AB-MGCL ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Fixed the conflict. Please kindly help to review if no concern. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/80150?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3f6c784a194e141a3dd1e5a37b3cf12106e692d6 Gerrit-Change-Number: 80150 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Edward Dai <edwarddai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Edward Dai <edwarddai(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 24 Jan 2024 13:31:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/galtic: Support for Samsung K4U6E3S4AB-MGCL
by Daniel Peng (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Daniel Peng, Derek Huang, Edward Dai, Felix Held, Ivan Chen, Karthik Ramasubramanian, Paul Menzel. Hello Derek Huang, Edward Dai, Felix Held, Ivan Chen, Karthik Ramasubramanian, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80150?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Daniel Peng, Verified+1 by build bot (Jenkins) Change subject: mb/google/dedede/var/galtic: Support for Samsung K4U6E3S4AB-MGCL ...................................................................... mb/google/dedede/var/galtic: Support for Samsung K4U6E3S4AB-MGCL Add the new memory support: Samsung K4U6E3S4AB-MGCL BUG=b:320137193 BRANCH=firmware-dedede-13606.B TEST=Run command "go run ./util/spd_tools/src/part_id_gen/\ part_id_gen.go JSL lp4x \ src/mainboard/google/dedede/variants/galtic/memory/ \ src/mainboard/google/dedede/variants/galtic/memory/\ mem_parts_used.txt" Change-Id: I3f6c784a194e141a3dd1e5a37b3cf12106e692d6 Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/galtic/memory/Makefile.mk M src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt 3 files changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/80150/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80150?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3f6c784a194e141a3dd1e5a37b3cf12106e692d6 Gerrit-Change-Number: 80150 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Edward Dai <edwarddai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Edward Dai <edwarddai(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024