Attention is currently required from: Arthur Heymans, Christian Walter, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jeff Daly, Johnny Lin, Jonathan Zhang, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Sean Rhodes, Subrata Banik, Tarun, Tim Chu, Vanessa Eusebio, Werner Zeh.
Felix Singer has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80073?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel: Rename Makefiles from .inc to .mk
......................................................................
soc/intel: Rename Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ib479b93b7d0b2e790d0495b6a6b4b4298a515d9a
---
R src/soc/intel/Makefile.mk
R src/soc/intel/alderlake/Makefile.mk
R src/soc/intel/alderlake/romstage/Makefile.mk
R src/soc/intel/apollolake/Makefile.mk
R src/soc/intel/baytrail/Makefile.mk
R src/soc/intel/baytrail/romstage/Makefile.mk
R src/soc/intel/braswell/Makefile.mk
R src/soc/intel/braswell/romstage/Makefile.mk
R src/soc/intel/broadwell/Makefile.mk
R src/soc/intel/broadwell/pch/Makefile.mk
R src/soc/intel/cannonlake/Makefile.mk
M src/soc/intel/cannonlake/cnl_memcfg_init.c
R src/soc/intel/cannonlake/romstage/Makefile.mk
R src/soc/intel/common/Makefile.mk
R src/soc/intel/common/basecode/Makefile.mk
R src/soc/intel/common/basecode/debug/Makefile.mk
R src/soc/intel/common/basecode/ramtop/Makefile.mk
R src/soc/intel/common/block/Makefile.mk
R src/soc/intel/common/block/acpi/Makefile.mk
R src/soc/intel/common/block/chip/Makefile.mk
R src/soc/intel/common/block/cnvi/Makefile.mk
R src/soc/intel/common/block/cpu/Makefile.mk
R src/soc/intel/common/block/crashlog/Makefile.mk
R src/soc/intel/common/block/cse/Makefile.mk
R src/soc/intel/common/block/dsp/Makefile.mk
R src/soc/intel/common/block/dtt/Makefile.mk
R src/soc/intel/common/block/fast_spi/Makefile.mk
R src/soc/intel/common/block/gpio/Makefile.mk
R src/soc/intel/common/block/gpmr/Makefile.mk
R src/soc/intel/common/block/graphics/Makefile.mk
R src/soc/intel/common/block/gspi/Makefile.mk
R src/soc/intel/common/block/hda/Makefile.mk
R src/soc/intel/common/block/i2c/Makefile.mk
R src/soc/intel/common/block/ioc/Makefile.mk
R src/soc/intel/common/block/ipu/Makefile.mk
R src/soc/intel/common/block/irq/Makefile.mk
R src/soc/intel/common/block/itss/Makefile.mk
R src/soc/intel/common/block/lpc/Makefile.mk
R src/soc/intel/common/block/lpss/Makefile.mk
R src/soc/intel/common/block/memory/Makefile.mk
R src/soc/intel/common/block/oc_wdt/Makefile.mk
R src/soc/intel/common/block/p2sb/Makefile.mk
R src/soc/intel/common/block/pcie/Makefile.mk
R src/soc/intel/common/block/pcie/rtd3/Makefile.mk
R src/soc/intel/common/block/pcr/Makefile.mk
R src/soc/intel/common/block/pmc/Makefile.mk
R src/soc/intel/common/block/power_limit/Makefile.mk
R src/soc/intel/common/block/rtc/Makefile.mk
R src/soc/intel/common/block/sata/Makefile.mk
R src/soc/intel/common/block/scs/Makefile.mk
R src/soc/intel/common/block/sgx/Makefile.mk
R src/soc/intel/common/block/smbus/Makefile.mk
R src/soc/intel/common/block/smm/Makefile.mk
R src/soc/intel/common/block/spi/Makefile.mk
R src/soc/intel/common/block/sram/Makefile.mk
R src/soc/intel/common/block/systemagent/Makefile.mk
R src/soc/intel/common/block/tcss/Makefile.mk
R src/soc/intel/common/block/thermal/Makefile.mk
R src/soc/intel/common/block/timer/Makefile.mk
R src/soc/intel/common/block/tracehub/Makefile.mk
R src/soc/intel/common/block/uart/Makefile.mk
R src/soc/intel/common/block/usb4/Makefile.mk
R src/soc/intel/common/block/vtd/Makefile.mk
R src/soc/intel/common/block/xdci/Makefile.mk
R src/soc/intel/common/block/xhci/Makefile.mk
R src/soc/intel/common/pch/Makefile.mk
R src/soc/intel/common/pch/lockdown/Makefile.mk
R src/soc/intel/denverton_ns/Makefile.mk
R src/soc/intel/elkhartlake/Makefile.mk
R src/soc/intel/elkhartlake/romstage/Makefile.mk
R src/soc/intel/jasperlake/Makefile.mk
R src/soc/intel/jasperlake/romstage/Makefile.mk
R src/soc/intel/meteorlake/Makefile.mk
R src/soc/intel/meteorlake/romstage/Makefile.mk
R src/soc/intel/skylake/Makefile.mk
R src/soc/intel/skylake/nhlt/Makefile.mk
R src/soc/intel/skylake/romstage/Makefile.mk
R src/soc/intel/tigerlake/Makefile.mk
R src/soc/intel/tigerlake/romstage/Makefile.mk
R src/soc/intel/xeon_sp/Makefile.mk
R src/soc/intel/xeon_sp/cpx/Makefile.mk
R src/soc/intel/xeon_sp/ebg/Makefile.mk
R src/soc/intel/xeon_sp/lbg/Makefile.mk
R src/soc/intel/xeon_sp/ras/Makefile.mk
R src/soc/intel/xeon_sp/skx/Makefile.mk
R src/soc/intel/xeon_sp/spr/Makefile.mk
86 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/80073/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80073?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib479b93b7d0b2e790d0495b6a6b4b4298a515d9a
Gerrit-Change-Number: 80073
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier.
Felix Singer has uploaded a new patch set (#3) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80071?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/amd/*: Rename Makefiles from .inc to .mk
......................................................................
soc/amd/*: Rename Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950
---
R src/soc/amd/cezanne/Makefile.mk
R src/soc/amd/cezanne/psp_verstage/Makefile.mk
R src/soc/amd/common/Makefile.mk
R src/soc/amd/common/block/Makefile.mk
R src/soc/amd/common/block/acp/Makefile.mk
R src/soc/amd/common/block/acpi/Makefile.mk
R src/soc/amd/common/block/acpimmio/Makefile.mk
R src/soc/amd/common/block/alink/Makefile.mk
R src/soc/amd/common/block/aoac/Makefile.mk
R src/soc/amd/common/block/apob/Makefile.mk
R src/soc/amd/common/block/cpu/Makefile.mk
R src/soc/amd/common/block/cpu/car/Makefile.mk
R src/soc/amd/common/block/cpu/mca/Makefile.mk
R src/soc/amd/common/block/cpu/noncar/Makefile.mk
R src/soc/amd/common/block/cpu/smm/Makefile.mk
R src/soc/amd/common/block/cpu/tsc/Makefile.mk
R src/soc/amd/common/block/data_fabric/Makefile.mk
R src/soc/amd/common/block/emmc/Makefile.mk
R src/soc/amd/common/block/gpio/Makefile.mk
R src/soc/amd/common/block/graphics/Makefile.mk
R src/soc/amd/common/block/hda/Makefile.mk
R src/soc/amd/common/block/i2c/Makefile.mk
R src/soc/amd/common/block/iommu/Makefile.mk
R src/soc/amd/common/block/lpc/Makefile.mk
R src/soc/amd/common/block/pci/Makefile.mk
R src/soc/amd/common/block/pm/Makefile.mk
R src/soc/amd/common/block/psp/Makefile.mk
R src/soc/amd/common/block/root_complex/Makefile.mk
R src/soc/amd/common/block/sata/Makefile.mk
R src/soc/amd/common/block/simnow/Makefile.mk
R src/soc/amd/common/block/smbus/Makefile.mk
R src/soc/amd/common/block/smi/Makefile.mk
R src/soc/amd/common/block/smn/Makefile.mk
R src/soc/amd/common/block/smu/Makefile.mk
R src/soc/amd/common/block/spi/Makefile.mk
R src/soc/amd/common/block/stb/Makefile.mk
R src/soc/amd/common/block/uart/Makefile.mk
R src/soc/amd/common/block/xhci/Makefile.mk
R src/soc/amd/common/fsp/Makefile.mk
R src/soc/amd/common/fsp/pci/Makefile.mk
R src/soc/amd/common/pi/Makefile.mk
R src/soc/amd/common/psp_verstage/Makefile.mk
R src/soc/amd/common/vboot/Makefile.mk
R src/soc/amd/genoa_poc/Makefile.mk
R src/soc/amd/glinda/Makefile.mk
R src/soc/amd/glinda/psp_verstage/Makefile.mk
R src/soc/amd/mendocino/Makefile.mk
R src/soc/amd/mendocino/psp_verstage/Makefile.mk
R src/soc/amd/phoenix/Makefile.mk
R src/soc/amd/phoenix/psp_verstage/Makefile.mk
R src/soc/amd/picasso/Makefile.mk
R src/soc/amd/picasso/psp_verstage/Makefile.mk
R src/soc/amd/stoneyridge/Makefile.mk
53 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/80071/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80071?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950
Gerrit-Change-Number: 80071
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Martin L Roth.
Felix Singer has uploaded a new patch set (#3) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80070?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: northbridge: Rename Makefiles from .inc to .mk
......................................................................
northbridge: Rename Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Iddac15cc42532f44dda44032be0f8525f6347abd
---
R src/northbridge/amd/pi/00730F01/Makefile.mk
R src/northbridge/amd/pi/Makefile.mk
R src/northbridge/intel/e7505/Makefile.mk
R src/northbridge/intel/gm45/Makefile.mk
R src/northbridge/intel/haswell/Makefile.mk
R src/northbridge/intel/haswell/broadwell_mrc/Makefile.mk
R src/northbridge/intel/haswell/haswell_mrc/Makefile.mk
R src/northbridge/intel/haswell/native_raminit/Makefile.mk
R src/northbridge/intel/i440bx/Makefile.mk
R src/northbridge/intel/i945/Makefile.mk
R src/northbridge/intel/ironlake/Makefile.mk
R src/northbridge/intel/pineview/Makefile.mk
R src/northbridge/intel/sandybridge/Makefile.mk
R src/northbridge/intel/x4x/Makefile.mk
14 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/80070/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80070?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iddac15cc42532f44dda44032be0f8525f6347abd
Gerrit-Change-Number: 80070
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Caveh Jalali, Forest Mittelberg, Jeremy Soller, Martin L Roth, Nicholas Chin, Sean Rhodes, Tim Crawford.
Felix Singer has uploaded a new patch set (#3) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80069?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Caveh Jalali, Code-Review+1 by Sean Rhodes, Verified+1 by build bot (Jenkins)
Change subject: ec: Rename Makefiles from .inc to .mk
......................................................................
ec: Rename Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ic060f3605cd18d4bf774573c21957f626f984e2c
---
R src/ec/51nb/npce985la0dx/Makefile.mk
R src/ec/acpi/Makefile.mk
R src/ec/clevo/it5570e/Makefile.mk
R src/ec/compal/ene932/Makefile.mk
R src/ec/dell/mec5035/Makefile.mk
R src/ec/google/chromeec/Makefile.mk
R src/ec/google/chromeec/audio_codec/Makefile.mk
R src/ec/google/chromeec/i2c_tunnel/Makefile.mk
R src/ec/google/chromeec/mux/Makefile.mk
R src/ec/google/chromeec/mux/conn/Makefile.mk
R src/ec/google/common/Makefile.mk
R src/ec/google/wilco/Makefile.mk
R src/ec/hp/kbc1126/Makefile.mk
R src/ec/intel/Makefile.mk
R src/ec/kontron/it8516e/Makefile.mk
R src/ec/kontron/kempld/Makefile.mk
R src/ec/lenovo/h8/Makefile.mk
R src/ec/lenovo/pmh7/Makefile.mk
R src/ec/purism/librem-ec/Makefile.mk
R src/ec/quanta/ene_kb3940q/Makefile.mk
R src/ec/quanta/it8518/Makefile.mk
R src/ec/roda/it8518/Makefile.mk
R src/ec/smsc/mec1308/Makefile.mk
R src/ec/starlabs/merlin/Makefile.mk
R src/ec/system76/ec/Makefile.mk
25 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/80069/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80069?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic060f3605cd18d4bf774573c21957f626f984e2c
Gerrit-Change-Number: 80069
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jérémy Compostella, Martin L Roth, ron minnich.
Felix Singer has uploaded a new patch set (#3) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80068?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: cpu: Rename Makefiles from .inc to .mk
......................................................................
cpu: Rename Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I552d487978906f5ea74c3d0d85373fe5b2de3f38
---
R src/cpu/Makefile.mk
R src/cpu/amd/Makefile.mk
R src/cpu/amd/mtrr/Makefile.mk
R src/cpu/amd/pi/00730F01/Makefile.mk
R src/cpu/amd/pi/Makefile.mk
R src/cpu/armltd/Makefile.mk
R src/cpu/intel/Makefile.mk
R src/cpu/intel/common/Makefile.mk
R src/cpu/intel/fit/Makefile.mk
R src/cpu/intel/haswell/Makefile.mk
R src/cpu/intel/microcode/Makefile.mk
R src/cpu/intel/model_1067x/Makefile.mk
R src/cpu/intel/model_106cx/Makefile.mk
R src/cpu/intel/model_2065x/Makefile.mk
R src/cpu/intel/model_206ax/Makefile.mk
R src/cpu/intel/model_65x/Makefile.mk
R src/cpu/intel/model_67x/Makefile.mk
R src/cpu/intel/model_68x/Makefile.mk
R src/cpu/intel/model_6bx/Makefile.mk
R src/cpu/intel/model_6ex/Makefile.mk
R src/cpu/intel/model_6fx/Makefile.mk
R src/cpu/intel/model_6xx/Makefile.mk
R src/cpu/intel/model_f2x/Makefile.mk
R src/cpu/intel/model_f3x/Makefile.mk
R src/cpu/intel/model_f4x/Makefile.mk
R src/cpu/intel/slot_1/Makefile.mk
R src/cpu/intel/smm/Makefile.mk
R src/cpu/intel/smm/gen1/Makefile.mk
R src/cpu/intel/socket_441/Makefile.mk
R src/cpu/intel/socket_BGA956/Makefile.mk
R src/cpu/intel/socket_FCBGA559/Makefile.mk
R src/cpu/intel/socket_LGA775/Makefile.mk
R src/cpu/intel/socket_m/Makefile.mk
R src/cpu/intel/socket_mPGA604/Makefile.mk
R src/cpu/intel/socket_p/Makefile.mk
R src/cpu/intel/speedstep/Makefile.mk
R src/cpu/intel/turbo/Makefile.mk
R src/cpu/power9/Makefile.mk
R src/cpu/qemu-power8/Makefile.mk
R src/cpu/qemu-x86/Makefile.mk
R src/cpu/x86/64bit/Makefile.mk
R src/cpu/x86/Makefile.mk
R src/cpu/x86/cache/Makefile.mk
R src/cpu/x86/lapic/Makefile.mk
R src/cpu/x86/mtrr/Makefile.mk
R src/cpu/x86/name/Makefile.mk
R src/cpu/x86/pae/Makefile.mk
R src/cpu/x86/smm/Makefile.mk
R src/cpu/x86/tsc/Makefile.mk
49 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/80068/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80068?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I552d487978906f5ea74c3d0d85373fe5b2de3f38
Gerrit-Change-Number: 80068
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Erik van den Bogaert, Frans Hendriks, Martin L Roth, Xi Chen.
Felix Singer has uploaded a new patch set (#4) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80067?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: vendorcode: Rename Makefiles from .inc to .mk
......................................................................
vendorcode: Rename Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I80559b7c86a8fd2583cb0335279f676e0aa0209e
---
R src/vendorcode/Makefile.mk
R src/vendorcode/amd/Makefile.mk
R src/vendorcode/amd/opensil/Makefile.mk
R src/vendorcode/amd/opensil/genoa_poc/Makefile.mk
R src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.mk
R src/vendorcode/amd/pi/00670F00/Makefile.mk
R src/vendorcode/amd/pi/Makefile.mk
R src/vendorcode/cavium/Makefile.mk
R src/vendorcode/eltan/Makefile.mk
R src/vendorcode/eltan/security/Makefile.mk
R src/vendorcode/eltan/security/mboot/Makefile.mk
R src/vendorcode/eltan/security/verified_boot/Makefile.mk
R src/vendorcode/google/Makefile.mk
R src/vendorcode/google/chromeos/Makefile.mk
R src/vendorcode/intel/Makefile.mk
R src/vendorcode/mediatek/Makefile.mk
R src/vendorcode/mediatek/mt8192/Makefile.mk
R src/vendorcode/mediatek/mt8192/dramc/Makefile.mk
R src/vendorcode/mediatek/mt8195/Makefile.mk
R src/vendorcode/mediatek/mt8195/dramc/Makefile.mk
R src/vendorcode/siemens/Makefile.mk
R src/vendorcode/siemens/hwilib/Makefile.mk
22 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/80067/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80067?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80559b7c86a8fd2583cb0335279f676e0aa0209e
Gerrit-Change-Number: 80067
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Cliff Huang, Julius Werner, Jérémy Compostella, Lance Zhao, Maximilian Brune, Philipp Hug, Tim Wawrzynczak, ron minnich.
Felix Singer has uploaded a new patch set (#3) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80066?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: acpi,arch,commonlib: Rename Makefiles from .inc to .mk
......................................................................
acpi,arch,commonlib: Rename Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca
---
R src/acpi/Makefile.mk
R src/arch/arm/Makefile.mk
R src/arch/arm/armv4/Makefile.mk
R src/arch/arm/armv7/Makefile.mk
R src/arch/arm/libgcc/Makefile.mk
R src/arch/arm64/Makefile.mk
R src/arch/arm64/armv8/Makefile.mk
R src/arch/ppc64/Makefile.mk
R src/arch/riscv/Makefile.mk
R src/arch/x86/Makefile.mk
R src/commonlib/Makefile.mk
R src/commonlib/storage/Makefile.mk
12 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/80066/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80066?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca
Gerrit-Change-Number: 80066
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Felix Singer, Jakub Czapiga, Martin L Roth.
Felix Singer has uploaded a new patch set (#3) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by Felix Singer, Verified+1 by build bot (Jenkins)
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mk
......................................................................
Makefiles: Rename top-level Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
The rest of the Makefiles will be renamed in following commits.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
---
M Makefile
R Makefile.mk
R payloads/Makefile.mk
M payloads/coreinfo/Makefile
M payloads/libpayload/Makefile
R tests/Makefile.mk
R toolchain.mk
R util/kconfig/Makefile.mk
M util/lint/kconfig_lint
R util/testing/Makefile.mk
10 files changed, 19 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/80063/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80063?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Jakub Czapiga, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mak
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80063/comment/9e5ab606_f7905e76 :
PS2, Line 10: This means that editors don't recognize the files, and don't
: open them with highlighting and any other specific editor functionality.
:
> I also prefer .mk to be honest, but I don't have a strong opinion about it. .mak is fine to me. […]
I wrote a script that adjusts everything. Will update shortly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80063?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sat, 20 Jan 2024 23:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Jakub Czapiga, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mak
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80063/comment/c2ce6103_351d8da0 :
PS2, Line 10: This means that editors don't recognize the files, and don't
: open them with highlighting and any other specific editor functionality.
:
> I didn't try emacs. my editors recognize the .mak extension by default. […]
I also prefer .mk to be honest, but I don't have a strong opinion about it. .mak is fine to me. I will see if I can come up with something and adjust the patch series.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80063?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sat, 20 Jan 2024 22:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment