Attention is currently required from: Cliff Huang, Julius Werner, Jérémy Compostella, Lance Zhao, Martin L Roth, Maximilian Brune, Philipp Hug, Tim Wawrzynczak, ron minnich.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80066?usp=email )
Change subject: acpi,arch,commonlib: Rename Makefiles from .inc to .mk
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> .mak is also commonly used. For example, here's the pattern matching for the Geany editor: […]
See discussion in CB:80063. Closing this one here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80066?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca
Gerrit-Change-Number: 80066
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Sun, 21 Jan 2024 00:32:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Jakub Czapiga, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mk
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80063/comment/99cc6401_905be9d3 :
PS2, Line 10: This means that editors don't recognize the files, and don't
: open them with highlighting and any other specific editor functionality.
:
> I wrote a script that adjusts everything. Will update shortly.
I updated the changes until CB:80129. While rebasing CB:80103, there was an one-line conflict that I needed to resolve manually, but otherwise this script worked very well 😄
If anyone is interested:
```
#!/usr/bin/env bash
# This function is ran in a while-loop per commit. See below.
function black_magic() {
# Get list of changed files
changed_files="$(
git show --name-only --oneline |
tail -n +2
)"
# Adjust file extensions in modified files
sed -i'' 's/\.mak/\.mk/g' ${changed_files}
# To make things not overly complicated,
# save changes done so far and adjust file
# extensions in commit messages.
commit_message="$(
git log --format=%B -n 1 |
sed 's/\.mak/\.mk/g'
)"
git add ${changed_files}
git commit --amend -m "${commit_message}"
# Rename files from .mak to .mk
for file in ${changed_files}; do
# Filter out files with no extension
[[ $file == *.mak ]] || continue
destdir="$(dirname ${file})"
filename="$(basename ${file} .mak)"
git mv "${file}" "${destdir}/${filename}.mk"
done
# Save again
git commit --amend --no-edit
}
black_magic
while true; do
git rebase --continue || exit 1
black_magic
done
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/80063?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 21 Jan 2024 00:18:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Julius Werner.
Felix Singer has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80129?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: src, util: Update toolchain.inc references to .mk
......................................................................
src, util: Update toolchain.inc references to .mk
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ieaf7894f49a90f562b164924cc025e3eab5a3f7f
---
M src/arch/arm/include/arch/memlayout.h
M src/arch/arm64/include/arch/memlayout.h
M src/include/rules.h
M util/lint/lint-stable-003-whitespace
4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/80129/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80129?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieaf7894f49a90f562b164924cc025e3eab5a3f7f
Gerrit-Change-Number: 80129
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Felix Singer has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80128?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Documentation: Update Makefile .inc references to .mk
......................................................................
Documentation: Update Makefile .inc references to .mk
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I464170e60a22f39225044c6794d091455d931e9c
---
M Documentation/getting_started/build_system.md
M Documentation/getting_started/kconfig.md
M Documentation/sbom/sbom.md
M Documentation/technotes/2020-03-unit-testing-coreboot.md
M Documentation/tutorial/part3.md
5 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/80128/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80128?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I464170e60a22f39225044c6794d091455d931e9c
Gerrit-Change-Number: 80128
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Felix Singer has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80127?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/autoport: Update Makefile.inc generation to Makefile.mk
......................................................................
util/autoport: Update Makefile.inc generation to Makefile.mk
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ib77cb3a0852092ac414fe0160fe10d6e58fcf660
---
M util/autoport/main.go
M util/autoport/readme.md
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/80127/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80127?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib77cb3a0852092ac414fe0160fe10d6e58fcf660
Gerrit-Change-Number: 80127
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk.
Felix Singer has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80126?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/release: Remove makefile.inc references from genrelnotes
......................................................................
util/release: Remove makefile.inc references from genrelnotes
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Id86ebc20cf5af5b65812c3f09235d0cba86d13f2
---
M util/release/genrelnotes
1 file changed, 7 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/80126/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80126?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id86ebc20cf5af5b65812c3f09235d0cba86d13f2
Gerrit-Change-Number: 80126
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Felix Singer, Michał Żygowski, Patrick Rudolph, Piotr Król, Werner Zeh.
Felix Singer has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80125?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: src, util: Clean up makefile.inc in text, help & comments
......................................................................
src, util: Clean up makefile.inc in text, help & comments
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ib69236fb5d68272f92405512dc231fa75ecccaa6
---
M src/Kconfig
M src/mainboard/cavium/cn8100_sff_evb/board.fmd
M src/mainboard/google/glados/variants/asuka/variant.c
M src/mainboard/google/nyan_big/bct/Makefile.mk
M src/mainboard/google/nyan_blaze/bct/Makefile.mk
M src/mainboard/intel/strago/Kconfig
M src/mainboard/opencellular/elgon/board.fmd
M src/mainboard/opencellular/elgon/vboot.fmd
M src/mainboard/protectli/vault_bsw/Kconfig
M src/mainboard/siemens/mc_apl1/Makefile.mk
M src/sbom/Makefile.mk
M util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch
M util/scripts/rm_unused_code
13 files changed, 17 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/80125/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80125?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib69236fb5d68272f92405512dc231fa75ecccaa6
Gerrit-Change-Number: 80125
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-MessageType: newpatchset
Felix Singer has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80124?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/mb: Update variant template Makefiles from .inc to .mk
......................................................................
util/mb: Update variant template Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I2a6a4d1eb7e0d0cd32c8690caf3eff340cdb0d8c
---
R util/mainboard/google/brya0/template/memory/Makefile.mk
R util/mainboard/google/dalboz/template/Makefile.mk
R util/mainboard/google/dalboz/template/spd/Makefile.mk
R util/mainboard/google/guybrush/template/Makefile.mk
R util/mainboard/google/guybrush/template/memory/Makefile.mk
R util/mainboard/google/hatch/template/Makefile.mk
R util/mainboard/google/nissa/template/memory/Makefile.mk
R util/mainboard/google/puff/template/Makefile.mk
R util/mainboard/google/rex0/template/Makefile.mk
R util/mainboard/google/rex0/template/memory/Makefile.mk
R util/mainboard/google/trembyle/template/Makefile.mk
R util/mainboard/google/trembyle/template/spd/Makefile.mk
R util/mainboard/google/volteer/template/memory/Makefile.mk
R util/mainboard/google/waddledee/template/memory/Makefile.mk
R util/mainboard/google/waddledoo/template/memory/Makefile.mk
15 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/80124/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80124?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2a6a4d1eb7e0d0cd32c8690caf3eff340cdb0d8c
Gerrit-Change-Number: 80124
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Julius Werner, Stefan Reinauer.
Felix Singer has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80123?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util: Rename Makefiles from .inc to .mk
......................................................................
util: Rename Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I434940ebb46853980596f7ad55d27a62c90280fa
---
M Makefile.mk
R util/amdfwtool/Makefile.mk
R util/bincfg/Makefile.mk
M util/cbfstool/Makefile
R util/cbfstool/Makefile.mk
R util/cbfstool/bpdt_formats/Makefile.mk
R util/cbfstool/fpt_formats/Makefile.mk
R util/crossgcc/Makefile.mk
M util/futility/Makefile
R util/futility/Makefile.mk
M util/ifdtool/Makefile
R util/ifdtool/Makefile.mk
R util/marvell/Makefile.mk
R util/marvell/doimage_mv/Makefile.mk
R util/nvidia/Makefile.mk
R util/nvramtool/Makefile.mk
R util/qemu/Makefile.mk
R util/sconfig/Makefile.mk
R util/supermicro/Makefile.mk
19 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/80123/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80123?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I434940ebb46853980596f7ad55d27a62c90280fa
Gerrit-Change-Number: 80123
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jakub Czapiga.
Felix Singer has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80122?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: tests: Rename Makefiles from .inc to .mk
......................................................................
tests: Rename Makefiles from .inc to .mk
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Id09eafd293a54198aab87281f529749325df8b07
---
M tests/Makefile.common
M tests/Makefile.mk
R tests/acpi/Makefile.mk
R tests/commonlib/Makefile.mk
R tests/commonlib/bsd/Makefile.mk
R tests/console/Makefile.mk
R tests/device/Makefile.mk
R tests/drivers/Makefile.mk
R tests/lib/Makefile.mk
9 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/80122/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80122?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id09eafd293a54198aab87281f529749325df8b07
Gerrit-Change-Number: 80122
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-MessageType: newpatchset