Attention is currently required from: Mike Banon.
Balázs Vinarz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79838?usp=email )
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
I really appreciate your diligence, but I'm afraid nobody will merge this ever. It's just a better way to share this script.
What exactly we need to change with the older AGESA code to have these old boards back in the master?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Gerrit-Change-Number: 79838
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-CC: awokd(a)danwin1210.me
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Comment-Date: Sun, 21 Jan 2024 15:22:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79543?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/hp/snb_ivb_desktops: Make baseboard more generic
......................................................................
mb/hp/snb_ivb_desktops: Make baseboard more generic
In preparation to merging all the other HP sandy/ivy desktops in here
as variants.
Move hda_verb.c, early_init.c, gma-mainboard.ads and data.vbt into
variant directories.
Kconfig: Move options not common to the others under the variants instead.
devicetree: Move XHCI to variant overridetrees (8200 gen has no USB 3)
board_info: Make it more generic. It seems to be copied from 8200 SFF
and inaccurate to Z220 anyway.
TEST: BUILD_TIMELESS=1, all the files in CBFS are identical, except config
(since the VBT data file moved).
Change-Id: Icce22efb8d353359781db3f03c67058d8fbe11b8
Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com>
---
M src/mainboard/hp/snb_ivb_desktops/Kconfig
M src/mainboard/hp/snb_ivb_desktops/Makefile.inc
M src/mainboard/hp/snb_ivb_desktops/board_info.txt
M src/mainboard/hp/snb_ivb_desktops/devicetree.cb
R src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/data.vbt
R src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c
R src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/gma-mainboard.ads
R src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/hda_verb.c
M src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/overridetree.cb
C src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/data.vbt
C src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c
C src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/gma-mainboard.ads
C src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/hda_verb.c
M src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/overridetree.cb
14 files changed, 23 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/79543/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/79543?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icce22efb8d353359781db3f03c67058d8fbe11b8
Gerrit-Change-Number: 79543
Gerrit-PatchSet: 8
Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Balázs Vinarz.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79838?usp=email )
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
Boots fine on Lenovo G505S + builds fine for ASUS A88XM-E and AM1I-A (maybe they boot fine too)
--
To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Gerrit-Change-Number: 79838
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-CC: awokd(a)danwin1210.me
Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Comment-Date: Sun, 21 Jan 2024 14:43:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Balázs Vinarz, Mike Banon.
Hello Balázs Vinarz, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79838?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Mike Banon, Verified+1 by build bot (Jenkins)
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
restore_agesa.sh reverts the opensource AGESA AMD boards removal
that happened after 5e8e911b7caee021faff96c4e82a77a42544ea62
commit (0 point of history, or 0 PoH) - by git-reverting:
1) the "bad commits" (marked as "CBF" = coreboot build failure)
- that either remove or break a code needed for our boards
2) the "unlucky commits" (marked as "GRF" = git revert failure)
- that are a roadblock for git-reverting the "bad commits"
Right now at 4ea72c1fac81d170f0164eee97ca06ed21ed6dc7 (5620 PoH),
it takes 45 CBF git reverts - just 1% of 5620 commits since the
OSS AGESA removal! - making this removal look questionable and
the idea of opensource AGESA AMD boards restoration viable.
SUCCESSFUL BOOT TESTS for the opensource AGESA boards which I own
(Lenovo G505S - fam15 laptop, ASUS A88XM-E - fam15 desktop,
ASUS AM1I-A - fam16 desktop) :
4ea72c1fac81d170f0164eee97ca06ed21ed6dc7 (5620 PoH) for Lenovo G505S
69ffebf5ccf123bc0b3fb28b485985af0597761d (3698 PoH) for ASUS A88XM-E
Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
---
A util/scripts/restore_agesa.sh
1 file changed, 290 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79838/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Gerrit-Change-Number: 79838
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-CC: awokd(a)danwin1210.me
Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78333?usp=email )
Change subject: soc/intel/xeon_sp: Add IIO resources via SSDT
......................................................................
Patch Set 23: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/78333?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I691d7497dceb89619652e5523a29ea30a7b0fab8
Gerrit-Change-Number: 78333
Gerrit-PatchSet: 23
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-CC: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sun, 21 Jan 2024 13:20:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Chen, Gang C, Cliff Huang, Felix Held, Jincheng Li, Lance Zhao, Lean Sheng Tan, Paul Menzel, Shuo Liu, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78334?usp=email )
Change subject: device/device.h: Drop acpi_inject_dsdt
......................................................................
Patch Set 22: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/78334?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffefc865901b15fa299931b6ed4c27a9e3a1c330
Gerrit-Change-Number: 78334
Gerrit-PatchSet: 22
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 21 Jan 2024 13:02:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Shuo Liu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80090?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: device/device_util: Add method to retrieve the domain
......................................................................
Patch Set 1:
(2 comments)
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/80090/comment/c44e5068_7c3dcda0 :
PS1, Line 267: while (dev->bus) {
The root device is identified by `dev == dev->bus->dev`. So the cannonical
way to walk up is
```
for (dev = dev->bus->dev; dev != dev->bus->dev; dev = dev->bus->dev)
```
This has come up more often lately, so we should probably add an inline
is_root() for this. To make the code more self explaining. Let me know
if you'd prefer (me) to add that later.
https://review.coreboot.org/c/coreboot/+/80090/comment/e75956a9_89c9fe50 :
PS1, Line 269: if (!dev)
This should never be the case and shouldn't be ignored. An assert() would
be suitable I guess.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80090?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0068b82e139fe7a35e6b1b91b7d386b750c80748
Gerrit-Change-Number: 80090
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Comment-Date: Sun, 21 Jan 2024 12:17:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Johnny Lin, Patrick Rudolph, Shuo Liu, Tim Chu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80089?usp=email )
Change subject: soc/intel/xeon_sp: Fix devicetree walking up
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
We probably should add a function to create a bus, so we
won't forget this again. Let me know if I should implement
something.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80089?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8cc50cabf7ad540c52498e1ffe7f9246550ed87b
Gerrit-Change-Number: 80089
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sun, 21 Jan 2024 12:10:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79058?usp=email )
Change subject: soc/intel/xeon_sp: Allocate resources above 4G
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS13:
After this commit, now I always have this warning while doing a "make menuconfig" :
src/soc/intel/xeon_sp/Kconfig:94:warning: config symbol defined without type
To fix this, please add "bool" line before "default y" to specify the config symbol type.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79058?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27d4f9ce91c12ed4ab3b2f18f2a92b742115d275
Gerrit-Change-Number: 79058
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 21 Jan 2024 11:50:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment