Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80140?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: Documentation: Fix trivial typo in the "Coding Style" chapter
......................................................................
Documentation: Fix trivial typo in the "Coding Style" chapter
This should not have any impact on produced binaries.
Due to the simplicity, the patch has not been tested.
Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Signed-off-by: Tillmann Severin <tillmann.severin(a)mailbox.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80140
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M Documentation/contributing/coding_style.md
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
diff --git a/Documentation/contributing/coding_style.md b/Documentation/contributing/coding_style.md
index bdf6c60..8828da4 100644
--- a/Documentation/contributing/coding_style.md
+++ b/Documentation/contributing/coding_style.md
@@ -808,7 +808,7 @@
message and return an error code. The calling display initialization function
knows that without the EDID there is no way to initialize the display correctly,
so it will also immediately return with an error code without running its
-remaining code that would initialize the SoC's display controller. Exeuction
+remaining code that would initialize the SoC's display controller. Execution
returns further up the function stack to the mainboard initialization code
which continues booting despite the failed display initialization, since
display functionality is non-essential to the system. (Code is encouraged but
--
To view, visit https://review.coreboot.org/c/coreboot/+/80140?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Gerrit-Change-Number: 80140
Gerrit-PatchSet: 4
Gerrit-Owner: Name of user not set #1005316
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Arthur Heymans, Felix Singer, Jakub Czapiga, Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mk
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Patchset:
PS3:
Vim picks up .mk fine. Cloc too (but not .mak). First Google hit suggests
.mak is a Microsoft thing?
File Makefile:
https://review.coreboot.org/c/coreboot/+/80063/comment/0ce07545_eb4d8afb :
PS3, Line 299: # TODO: Remove Makefile.inc support
This won't be easy, the pattern already spread to other projects.
I'd say we should just stay backwards compatible?
https://review.coreboot.org/c/coreboot/+/80063/comment/093e8a19_6c3524ff :
PS3, Line 306: $(eval $(call includemakefiles,$(dir)/Makefile.inc))) \
Just walking $(cursubdirs) once and calling includemakefiles twice
would work too, I guess.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80063?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 21 Jan 2024 11:22:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Name of user not set #1005316 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80140?usp=email )
Change subject: Documentation: Fix trivial typo in the "Coding Style" chapter
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80140/comment/18dbadfa_7b0b556e :
PS2, Line 7: Documentation: Fix trivial typo in the "Writing documentation" chapter
> Coding style chapter?
Thanks, you are right of course ;-) I updated the commit msg accordingly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80140?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Gerrit-Change-Number: 80140
Gerrit-PatchSet: 3
Gerrit-Owner: Name of user not set #1005316
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 21 Jan 2024 11:19:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Name of user not set #1005316.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80140?usp=email
to look at the new patch set (#3).
Change subject: Documentation: Fix trivial typo in the "Coding Style" chapter
......................................................................
Documentation: Fix trivial typo in the "Coding Style" chapter
This should not have any impact on produced binaries.
Due to the simplicity, the patch has not been tested.
Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Signed-off-by: Tillmann Severin <tillmann.severin(a)mailbox.org>
---
M Documentation/contributing/coding_style.md
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/80140/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80140?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Gerrit-Change-Number: 80140
Gerrit-PatchSet: 3
Gerrit-Owner: Name of user not set #1005316
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Name of user not set #1005316
Gerrit-MessageType: newpatchset
Attention is currently required from: Name of user not set #1005316.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80140?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Documentation: Fix trivial typo in the "Writing documentation" chapter
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80140/comment/a80becaa_4c526594 :
PS2, Line 7: Documentation: Fix trivial typo in the "Writing documentation" chapter
Coding style chapter?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80140?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Gerrit-Change-Number: 80140
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1005316
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Name of user not set #1005316
Gerrit-Comment-Date: Sun, 21 Jan 2024 11:14:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Name of user not set #1005316.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80140?usp=email )
Change subject: Documentation: Fix trivial typo in the "Writing documentation" chapter
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80140?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Gerrit-Change-Number: 80140
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1005316
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Name of user not set #1005316
Gerrit-Comment-Date: Sun, 21 Jan 2024 11:11:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Name of user not set #1005316 has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/80140?usp=email )
Change subject: Documentation: Fix trivial typo in the "Writing documentation" chapter
......................................................................
Documentation: Fix trivial typo in the "Writing documentation" chapter
This should not have any impact on produced binaries.
Due to the simplicity, the patch has not been tested.
Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Signed-off-by: Tillmann Severin <tillmann.severin(a)mailbox.org>
---
M Documentation/contributing/coding_style.md
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/80140/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80140?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Gerrit-Change-Number: 80140
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1005316
Gerrit-MessageType: newpatchset
Name of user not set #1005316 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80140?usp=email )
Change subject: Documentation: Fix trivial typo in the "Writing documentation" chapter
......................................................................
Documentation: Fix trivial typo in the "Writing documentation" chapter
This should not have any impact on produced binaries.
Due to the simplicity, the patch has not be tested.
Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Signed-off-by: Tillmann Severin <tillmann.severin(a)mailbox.org>
---
M Documentation/contributing/coding_style.md
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/80140/1
diff --git a/Documentation/contributing/coding_style.md b/Documentation/contributing/coding_style.md
index bdf6c60..8828da4 100644
--- a/Documentation/contributing/coding_style.md
+++ b/Documentation/contributing/coding_style.md
@@ -808,7 +808,7 @@
message and return an error code. The calling display initialization function
knows that without the EDID there is no way to initialize the display correctly,
so it will also immediately return with an error code without running its
-remaining code that would initialize the SoC's display controller. Exeuction
+remaining code that would initialize the SoC's display controller. Execution
returns further up the function stack to the mainboard initialization code
which continues booting despite the failed display initialization, since
display functionality is non-essential to the system. (Code is encouraged but
--
To view, visit https://review.coreboot.org/c/coreboot/+/80140?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic52f2be6a91aa3534d222f08733d1ba8bc1265a9
Gerrit-Change-Number: 80140
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1005316
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans.
Iru Cai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79880?usp=email )
Change subject: sb/intel/common: Get memory map from SPI controller
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
This (and also after applying CB:79881) doesn't boot. The boot log:
[NOTE ] coreboot-4.22-513-g8c240ef0982b Sun Jan 21 09:04:05 UTC 2024 x86_32 bootblock starting (log level: 7)...
[EMERG] Cannot locate primary
--
To view, visit https://review.coreboot.org/c/coreboot/+/79880?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f31c175345ec3efab02255a7063054eb0ad29e4
Gerrit-Change-Number: 79880
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 21 Jan 2024 10:31:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Angel Pons, Arthur Heymans, Christian Walter, Erik van den Bogaert, Felix Singer, Frans Hendriks, Jeremy Soller, Johnny Lin, Jonathan Zhang, Jonathon Hall, Lean Sheng Tan, Martin L Roth, Michael Niewöhner, Michał Kopeć, Michał Żygowski, Morgan Jang, Nico Huber, Patrick Rudolph, Philipp Hug, Piotr Król, Sean Rhodes, Stefan Ott, Tim Chu, Tim Crawford, Werner Zeh, ron minnich.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80111?usp=email )
Change subject: mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80111?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4790adb41cb62c8c8dd44261a2926dfb6350955a
Gerrit-Change-Number: 80111
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sun, 21 Jan 2024 08:20:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment