coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[S] Change in coreboot[master]: arch/arm64: Hook up ACPI table generation
by Kyösti Mälkki (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans, Julius Werner, Lance Zhao, Lean Sheng Tan, Maximilian Brune, Nico Huber, Paul Menzel, Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76071?usp=email ) Change subject: arch/arm64: Hook up ACPI table generation ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/acpi/Kconfig: https://review.coreboot.org/c/coreboot/+/76071/comment/5cd29575_5f4e46a6 : PS6, Line 78: config MAX_ACPI_TABLE_SIZE_KB This is sort of missing 'depends on HAVE_ACPI_TABLES' but we probably should group most of the file under a single 'if HAVE_ACPI_TABLES' anyway. -- To view, visit https://review.coreboot.org/c/coreboot/+/76071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f60c546ec262ffb4d447fe6476844cf5a1b756d Gerrit-Change-Number: 76071 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 07:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add overridetree
by Sumeet R Pawnikar (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Chen-Tsung Hsieh, Dtrain Hsu, Ian Feng, Kenny Pan, Rex Chou, Shou-Chieh Hsu, Subrata Banik, Tarun Tuli. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76662?usp=email ) Change subject: mb/google/nissa/var/craaskov: Add overridetree ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76662?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id002282d91dc94b00f5d133203b62ca39d6cae6d Gerrit-Change-Number: 76662 Gerrit-PatchSet: 10 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Kenny Pan <kennypan(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 07:46:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Configure GPIOs according to schematics
by Sumeet R Pawnikar (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Chen-Tsung Hsieh, Derek Huang, Dtrain Hsu, Jamie Chen, Kenny Pan, Paul Menzel, Rex Chou, Shou-Chieh Hsu, Tarun Tuli. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76636?usp=email ) Change subject: mb/google/nissa/var/craaskov: Configure GPIOs according to schematics ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76636?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17fc9333a0ef592ea36b196b3fd417be47fb82bb Gerrit-Change-Number: 76636 Gerrit-PatchSet: 12 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kenny Pan <kennypan(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 07:46:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: acpi: Add functions to declare ARM GIC V3 hardware
by Arthur Heymans (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Julius Werner, Lance Zhao, Tim Wawrzynczak. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76132?usp=email ) Change subject: acpi: Add functions to declare ARM GIC V3 hardware ...................................................................... Patch Set 5: (2 comments) File src/arch/arm64/Makefile.inc: https://review.coreboot.org/c/coreboot/+/76132/comment/54ed1509_ed66329c : PS5, Line 122: ramstage-$(CONFIG_ACPI_COMMON_MADT_GICC_V3) += ../../acpi/acpi_gic.c > Why put that here and not in acpi/Makefile.inc? Similar to how arch/x86 includes apic/hpet/dmar acpi code. File src/include/acpi/acpi.h: https://review.coreboot.org/c/coreboot/+/76132/comment/271beb87_fd951b07 : PS5, Line 1571: uintptr_t get_gicr_base(void); > These are platform callbacks, right? They should probably be a bit better namespaced, e.g. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5074d0a76316e854b7801e14b3241f88e805b02f Gerrit-Change-Number: 76132 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 02 Aug 2023 07:41:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: acpi: Add function to add ARM PL011 to ACPI DBG2
by Arthur Heymans (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak. Hello Lance Zhao, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76297?usp=email to look at the new patch set (#4). Change subject: acpi: Add function to add ARM PL011 to ACPI DBG2 ...................................................................... acpi: Add function to add ARM PL011 to ACPI DBG2 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I3c3f7f579ec0ec4fdb72e1f6b785026daab17bac --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 54 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/76297/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/76297?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c3f7f579ec0ec4fdb72e1f6b785026daab17bac Gerrit-Change-Number: 76297 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: acpi: Add functions to declare ARM GIC V3 hardware
by Arthur Heymans (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak. Hello Julius Werner, Lance Zhao, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76132?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: acpi: Add functions to declare ARM GIC V3 hardware ...................................................................... acpi: Add functions to declare ARM GIC V3 hardware For GICD and GICR a SOC needs to implement 2 callbacks to get the base of those interrupt controllers. For all the cpu GIC the code loops over all the DEVICE_PATH_GICC_V3 devices in a similar fashion to how x86 lapics are added. It's up to the SOC to add those devices to the tree. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I5074d0a76316e854b7801e14b3241f88e805b02f --- M src/acpi/Kconfig M src/acpi/acpi.c A src/acpi/acpi_gic.c M src/arch/arm64/Makefile.inc M src/include/acpi/acpi.h M src/include/device/path.h 6 files changed, 108 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/76132/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/76132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5074d0a76316e854b7801e14b3241f88e805b02f Gerrit-Change-Number: 76132 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6
by Kane Chen (Code Review) 02 Aug '23

02 Aug '23

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76880?usp=email ) Change subject: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6 ...................................................................... soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6 SOC_INTEL_METEORLAKE_DEBUG_CONSENT=6 is more common use case for soc debug with usb dbc. TEST=boot to os on screebo and dbc connection is OK. Change-Id: Ic12528bdd8b1feda7f1b65045c863341f932d3a2 Signed-off-by: Kane Chen <kane.chen(a)intel.corp-partner.google.com> --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/76880/1 diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index 2eb1405..b34daec 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -346,7 +346,7 @@ int "Debug Consent for MTL" # USB DBC is more common for developers so make this default to 3 if # SOC_INTEL_DEBUG_CONSENT=y - default 3 if SOC_INTEL_DEBUG_CONSENT + default 6 if SOC_INTEL_DEBUG_CONSENT default 0 help This is to control debug interface on SOC. @@ -354,9 +354,8 @@ PlatformDebugConsent in FspmUpd.h has the details. Desired platform debug type are - 0:Disabled, 1:Enabled (DCI OOB+[DbC]), 2:Enabled (DCI OOB), - 3:Enabled (USB3 DbC), 4:Enabled (XDP/MIPI60), 5:Enabled (USB2 DbC), - 6:Enable (2-wire DCI OOB), 7:Manual + 0:Disabled, 2:Enabled Trace Active, 4:Enabled Trace Ready, + 6:Enable Trace Power-Off, 7:Manual config DATA_BUS_WIDTH int -- To view, visit https://review.coreboot.org/c/coreboot/+/76880?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic12528bdd8b1feda7f1b65045c863341f932d3a2 Gerrit-Change-Number: 76880 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: arch/arm64: Hook up ACPI table generation
by Arthur Heymans (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Julius Werner, Kyösti Mälkki, Lean Sheng Tan, Maximilian Brune, Nico Huber, Paul Menzel. Hello Julius Werner, Kyösti Mälkki, Lean Sheng Tan, Maximilian Brune, Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76071?usp=email to look at the new patch set (#6). Change subject: arch/arm64: Hook up ACPI table generation ...................................................................... arch/arm64: Hook up ACPI table generation Linux is able to detect and use ACPI tables on an out of tree target using hacked version of u-boot to pass ACPI through UEFI. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I4f60c546ec262ffb4d447fe6476844cf5a1b756d --- M src/acpi/Kconfig M src/arch/arm64/tables.c M src/arch/x86/Kconfig 3 files changed, 23 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/76071/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/76071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f60c546ec262ffb4d447fe6476844cf5a1b756d Gerrit-Change-Number: 76071 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: arch/arm64: Hook up ACPI table generation
by Arthur Heymans (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Julius Werner, Kyösti Mälkki, Lean Sheng Tan, Maximilian Brune, Nico Huber, Paul Menzel. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76071?usp=email ) Change subject: arch/arm64: Hook up ACPI table generation ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76071/comment/80474058_8ed9dad3 : PS4, Line 9: Linux > What version did you test with? No idea. I did not test this. @Max? https://review.coreboot.org/c/coreboot/+/76071/comment/24fb2342_722759c2 : PS4, Line 9: Linux is able to detect and use ACPI tables on an out of tree target > > `Possible repeated word: 'via'` […] Done https://review.coreboot.org/c/coreboot/+/76071/comment/6b279a09_e3e9b3c6 : PS4, Line 10: using hacked version of u-boot to pass the via via UEFI. > Ah, you mean instead of one of the words *via*. Done File src/arch/arm64/tables.c: https://review.coreboot.org/c/coreboot/+/76071/comment/97f5c122_bde447ee : PS4, Line 18: printk(BIOS_ERR, "Increase ACPI size\n"); > I see that this is the same as what x86 already does, but this is a truly terrible API. We're running straight over other CBMEM spaces and this isn't even an assert(), just a BIOS_ERR print. Can we (in a separate patch effort) fix write_acpi_tables() to actually take an upper bound and respect it? The whole acpi generation code is very unsafe... I added an assert here but making ACPI generation more safe is a larger effort. -- To view, visit https://review.coreboot.org/c/coreboot/+/76071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f60c546ec262ffb4d447fe6476844cf5a1b756d Gerrit-Change-Number: 76071 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 07:36:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Configure GPIOs according to schematics
by Eric Lai (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Chen-Tsung Hsieh, Derek Huang, Dtrain Hsu, Jamie Chen, Kenny Pan, Paul Menzel, Rex Chou, Shou-Chieh Hsu, Sumeet R Pawnikar, Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76636?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/nissa/var/craaskov: Configure GPIOs according to schematics ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: @googler, please review then I'll submit. -- To view, visit https://review.coreboot.org/c/coreboot/+/76636?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17fc9333a0ef592ea36b196b3fd417be47fb82bb Gerrit-Change-Number: 76636 Gerrit-PatchSet: 12 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Kenny Pan <kennypan(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 07:36:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023