coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[L] Change in coreboot[master]: mb/google/rex/var/karis: Add initial devicetree config
by Tyler Wang (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: David Wu, Kapil Porwal, Subrata Banik, Tarun Tuli. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76606?usp=email ) Change subject: mb/google/rex/var/karis: Add initial devicetree config ...................................................................... Patch Set 9: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/76606?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48a0f0ce86c2228e1022886ba2965592abb0a58d Gerrit-Change-Number: 76606 Gerrit-PatchSet: 9 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 08:54:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/boxy: Add power limits for N4500/N5100
by Stanley Wu (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Paul Menzel. Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76876?usp=email ) Change subject: mb/google/dedede/var/boxy: Add power limits for N4500/N5100 ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76876/comment/e9dd8fdf_e46d94d4 : PS1, Line 7: Add power limits > Maybe more specific: Add power limits for N4500/N5100 Done https://review.coreboot.org/c/coreboot/+/76876/comment/f1bacaa5_4602a1b6 : PS1, Line 7: for Boxy > Redundant, as already in prefix. Done https://review.coreboot.org/c/coreboot/+/76876/comment/69cf26e5_44b17af1 : PS1, Line 5: ommitDate: 2023-08-01 11:43:35 +0800 : : mb/google/dedede/var/boxy:Add > Please add a space after the colon. Done https://review.coreboot.org/c/coreboot/+/76876/comment/62b369ba_6aff0119 : PS1, Line 9: JSL PDG > Please also add the document id. Done https://review.coreboot.org/c/coreboot/+/76876/comment/01641a79_ba12fdbb : PS1, Line 12: TEST=emerge-dedede coreboot and read correct value on boxy > How can this be read? BIOS log will show the values during post. -- To view, visit https://review.coreboot.org/c/coreboot/+/76876?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b063dc235fb714ba47eb620b914f2f9e92a2715 Gerrit-Change-Number: 76876 Gerrit-PatchSet: 2 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 02 Aug 2023 08:33:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi.c: Fill in >4G FADT entries correctly
by Kyösti Mälkki (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans, Felix Held, Lance Zhao, Lean Sheng Tan, Nico Huber, Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76179?usp=email ) Change subject: acpi.c: Fill in >4G FADT entries correctly ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/76179/comment/774211bc_88d9cd74 : PS5, Line 1092: fadt->x_firmware_ctl_h = (uint32_t)((uint64_t)(uintptr_t)facs >> 32); > > Wouldn't write shift work here without warnings with just: […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/76179?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84ab0068e8409a5e525ddc781347087680d80640 Gerrit-Change-Number: 76179 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Aug 2023 08:20:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/variants/ovis: Use and configure RT8168 driver
by Subrata Banik (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, YH Lin. Subrata Banik has uploaded a new patch set (#3) to the change originally created by Stefan Reinauer. ( https://review.coreboot.org/c/coreboot/+/76872?usp=email ) Change subject: mb/google/rex/variants/ovis: Use and configure RT8168 driver ...................................................................... mb/google/rex/variants/ovis: Use and configure RT8168 driver This makes sure we don't get a random mac address on boot. Additionally, program the LAN WAKE GPIO properly as per the Ovis schematics dated July'23. BUG=b:293905992 TEST=Verified on google/ovis that able to get the fixed MAC address across the power cycles. Change-Id: I699e52e25f851de325f96ef885e04d15ca64badd Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb M src/mainboard/google/rex/variants/ovis/gpio.c M src/mainboard/google/rex/variants/ovis/overridetree.cb 4 files changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/76872/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/76872?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I699e52e25f851de325f96ef885e04d15ca64badd Gerrit-Change-Number: 76872 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6
by Subrata Banik (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76880?usp=email ) Change subject: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76880?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic12528bdd8b1feda7f1b65045c863341f932d3a2 Gerrit-Change-Number: 76880 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 08:07:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: acpi: Add functions to declare ARM GIC V3 hardware
by Kyösti Mälkki (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans, Felix Held, Julius Werner, Lance Zhao, Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76132?usp=email ) Change subject: acpi: Add functions to declare ARM GIC V3 hardware ...................................................................... Patch Set 6: (3 comments) File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/76132/comment/58f18eb1_9ab21633 : PS6, Line 147: if (CONFIG(ACPI_COMMON_MADT_GICC_V3)) { Do we want the calls here or introduce acpi_arch_fill_madt() for aarch64? File src/acpi/acpi_gic.c: https://review.coreboot.org/c/coreboot/+/76132/comment/b0fa0c30_bbc50084 : PS3, Line 22: /* For platforms implementing ARMv8 the format must be: Maybe this comment is a bit confusing, should this refer to GICC v3 ? File src/arch/arm64/Makefile.inc: https://review.coreboot.org/c/coreboot/+/76132/comment/d5b89e6e_08dc25a9 : PS5, Line 122: ramstage-$(CONFIG_ACPI_COMMON_MADT_GICC_V3) += ../../acpi/acpi_gic.c > > Why put that here and not in acpi/Makefile.inc? […] FelixH and I thought that arch/x86 should be revisited for this, CB:76008. -- To view, visit https://review.coreboot.org/c/coreboot/+/76132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5074d0a76316e854b7801e14b3241f88e805b02f Gerrit-Change-Number: 76132 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Aug 2023 08:06:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6
by Kane Chen (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76880?usp=email ) Change subject: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Hi Subrata, […] FYI SOC_INTEL_DEBUG_CONSENT can be enabled by USE=intel_debug emerge-rex coreboot -- To view, visit https://review.coreboot.org/c/coreboot/+/76880?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic12528bdd8b1feda7f1b65045c863341f932d3a2 Gerrit-Change-Number: 76880 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 08:03:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6
by Kane Chen (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76880?usp=email ) Change subject: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Do we see any boot time impact or S0ix regression ? Hi Subrata, this is for debug purpose. it won't be enabled unless enabling SOC_INTEL_DEBUG_CONSENT thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/76880?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic12528bdd8b1feda7f1b65045c863341f932d3a2 Gerrit-Change-Number: 76880 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 08:02:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6
by Subrata Banik (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Jakub Czapiga, Kane Chen, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76880?usp=email ) Change subject: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Do we see any boot time impact or S0ix regression ? -- To view, visit https://review.coreboot.org/c/coreboot/+/76880?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic12528bdd8b1feda7f1b65045c863341f932d3a2 Gerrit-Change-Number: 76880 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 07:55:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: acpi/acpi.h: Add MADT GIC structures
by Kyösti Mälkki (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans, Felix Held, Felix Singer, Nico Huber, Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76131?usp=email ) Change subject: acpi/acpi.h: Add MADT GIC structures ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e6544c956cb3d516d2e5900357af9ae8976cc8e Gerrit-Change-Number: 76131 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Aug 2023 07:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023