coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[M] Change in coreboot[master]: acpi.c: Swap XSDT and RSDT for adding/finding tables
by Kapil Porwal (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans, Felix Held, Lance Zhao, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76000?usp=email ) Change subject: acpi.c: Swap XSDT and RSDT for adding/finding tables ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > @kapil, can u please test this CL ? verified on Screebo. -- To view, visit https://review.coreboot.org/c/coreboot/+/76000?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6588676186faa896b6076f871d7f8f633db21e70 Gerrit-Change-Number: 76000 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Aug 2023 17:03:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake/Kconfig: Enable PRERAM VSD buffer for rex
by Subrata Banik (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Dinesh Gehlot, Jakub Czapiga, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76609?usp=email ) Change subject: soc/intel/meteorlake/Kconfig: Enable PRERAM VSD buffer for rex ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: shouldn't u need to enable this earlier in this patch train ? -- To view, visit https://review.coreboot.org/c/coreboot/+/76609?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cc3972fa51fea1e7605ac3c33423317044125c5 Gerrit-Change-Number: 76609 Gerrit-PatchSet: 5 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 16:41:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src: Store CSE RW FW version during cse_fw_sync
by Subrata Banik (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Julius Werner, Kapil Porwal. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76395?usp=email ) Change subject: src: Store CSE RW FW version during cse_fw_sync ...................................................................... Patch Set 9: (5 comments) Patchset: PS9: I wish to use `cbmem_find()` from post-DRAM stage as all data have synced into the CBMEM. why to call specific VSD APIs. File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h: https://review.coreboot.org/c/coreboot/+/76395/comment/d4f610e9_a3f63107 : PS9, Line 90: #define CBMEM_ID_CSE_PARTITION_VERSION 0x43535056 drop this is a separate CL File src/drivers/intel/ish/ish.c: https://review.coreboot.org/c/coreboot/+/76395/comment/f8324261_b9f904fe : PS9, Line 53: cbmem_vsd_find() why can't i still use `cbmem_find(CBMEM_ID_VSD)` File src/soc/intel/common/block/cse/cse.c: https://review.coreboot.org/c/coreboot/+/76395/comment/89c42baf_f31c6264 : PS9, Line 1424: cbmem_vsd_find same File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/76395/comment/bd931312_1a543ea2 : PS9, Line 1267: cbmem_vsd_find same -- To view, visit https://review.coreboot.org/c/coreboot/+/76395?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If95ce7e1584aae6be3c431f07f8d8e5001e7854a Gerrit-Change-Number: 76395 Gerrit-PatchSet: 9 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Aug 2023 16:41:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src: Implement framework for PRERAM VSD store
by Subrata Banik (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Dinesh Gehlot, Julius Werner, Kapil Porwal. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76393?usp=email ) Change subject: src: Implement framework for PRERAM VSD store ...................................................................... Patch Set 12: (1 comment) File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h: https://review.coreboot.org/c/coreboot/+/76393/comment/045b1b05_d0463ee0 : PS12, Line 91: 0x43565344 signature should be `_VSD` in little-endian format -- To view, visit https://review.coreboot.org/c/coreboot/+/76393?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0baebb902807d5403800ac18757512bd2a59d2b9 Gerrit-Change-Number: 76393 Gerrit-PatchSet: 12 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 02 Aug 2023 16:40:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src: Implement framework for PRERAM VSD store
by Paul Menzel (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Dinesh Gehlot, Julius Werner, Kapil Porwal. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76393?usp=email ) Change subject: src: Implement framework for PRERAM VSD store ...................................................................... Patch Set 12: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76393/comment/3c73074d_d18a003b : PS12, Line 9: This patch implements a framework that stores Vendor Specific Data > `'intialized' may be misspelled - perhaps 'initialized'?` Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/76393?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0baebb902807d5403800ac18757512bd2a59d2b9 Gerrit-Change-Number: 76393 Gerrit-PatchSet: 12 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 02 Aug 2023 16:38:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src: Implement config to Vendor Specific Data during PRERAM
by Subrata Banik (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Dinesh Gehlot, Julius Werner, Kapil Porwal, Paul Menzel. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76371?usp=email ) Change subject: src: Implement config to Vendor Specific Data during PRERAM ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76371?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia40f6a33cf2fd0198042c4e6733eea7debb78e8d Gerrit-Change-Number: 76371 Gerrit-PatchSet: 10 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 02 Aug 2023 16:36:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src: Implement framework for PRERAM VSD store
by Subrata Banik (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Dinesh Gehlot, Julius Werner, Kapil Porwal. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76393?usp=email ) Change subject: src: Implement framework for PRERAM VSD store ...................................................................... Patch Set 12: (1 comment) File src/lib/cbmem_vsd.c: https://review.coreboot.org/c/coreboot/+/76393/comment/e85581c5_66734196 : PS12, Line 40: : user_area = cbmem_add(CBMEM_ID_VSD, req_size); : brace around -- To view, visit https://review.coreboot.org/c/coreboot/+/76393?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0baebb902807d5403800ac18757512bd2a59d2b9 Gerrit-Change-Number: 76393 Gerrit-PatchSet: 12 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 02 Aug 2023 16:36:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: Add DRIVERS_GFX_GENERIC to BRYA and NISSA by default
by Won Chung (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik, Tarun Tuli. Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76873?usp=email ) Change subject: mb/google/brya: Add DRIVERS_GFX_GENERIC to BRYA and NISSA by default ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Suggest merge the patches by mb brya/nissa. […] Just to clarify, do you mean split the patch into two? For brask, we are not adding GFX devices at the moment. Its DDI and TCP usages are quite different from chromebooks: not all TCP are used for DP on USB-C, and DDIA is sometimes used for DP on USB-C. We are still exploring how GFX devices should be added for chromebox. -- To view, visit https://review.coreboot.org/c/coreboot/+/76873?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11afa9e8a1c8bf9f57bf6d195f07531182bd36f1 Gerrit-Change-Number: 76873 Gerrit-PatchSet: 1 Gerrit-Owner: Won Chung <wonchung(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 16:35:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: linux_trampoline: Handle 64-bit framebuffer addresses
by Tim Wawrzynczak (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Bill XIE, Nico Huber. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76479?usp=email ) Change subject: linux_trampoline: Handle 64-bit framebuffer addresses ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76479?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib20184cf207f092062a91ac3e6aa819b956efd33 Gerrit-Change-Number: 76479 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 02 Aug 2023 16:20:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/dedede/var/pirika: Support for Samsung K4U6E3S4AB-MGCL
by Karthik Ramasubramanian (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Anson Tseng, Daniel Peng, Derek Huang, Paul Menzel, Shou-Chieh Hsu. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76542?usp=email ) Change subject: mb/google/dedede/var/pirika: Support for Samsung K4U6E3S4AB-MGCL ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File src/mainboard/google/dedede/variants/pirika/memory/dram_id.generated.txt: https://review.coreboot.org/c/coreboot/+/76542/comment/9e686a26_c2be25ea : PS4, Line 4: /tmp/go-build352956073/b001/exe/part_id_gen > The changed was modified automatically after run command. […] It seems this is an artifact of "go run" which compiles the source code, installs the executable in a /tmp path and then executes it from there. There is nothing wrong with that. This line will not change if you run "go build" followed by executing the binary explicitly. -- To view, visit https://review.coreboot.org/c/coreboot/+/76542?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief9bbf11fc05c8155f1da7188926a29dbbfbe488 Gerrit-Change-Number: 76542 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 16:18:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023