coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[M] Change in coreboot[master]: acpi: Add SPCR table
by Lean Sheng Tan (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75685?usp=email ) Change subject: acpi: Add SPCR table ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > SPCR should only be used by linux with 'earlycon=' as argument. @Eric, still having error on your side? -- To view, visit https://review.coreboot.org/c/coreboot/+/75685?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64e624c17a27b9215a8ba83bd6cbb2c0a7aa1dfc Gerrit-Change-Number: 75685 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Aug 2023 17:16:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Configure GPIOs according to schematics
by 9elements QA (Code Review) 02 Aug '23

02 Aug '23

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76636?usp=email ) Change subject: mb/google/nissa/var/craaskov: Configure GPIOs according to schematics ...................................................................... Patch Set 13: Automatic boot test returned (PASS/FAIL/TOTAL): 8 / 8 / 16 FAIL: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/175999 FAIL: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/175997 FAIL: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/175996 FAIL: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/175995 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/175994 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/175993 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/175992 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/175991 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/175990 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/175989 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/175988 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/175987 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/175986 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/175985 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/175984 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/175983 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/76636?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17fc9333a0ef592ea36b196b3fd417be47fb82bb Gerrit-Change-Number: 76636 Gerrit-PatchSet: 13 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 17:14:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi/acpi.c: Move setting FADT SCI INT to arch specific code
by Lean Sheng Tan (Code Review) 02 Aug '23

02 Aug '23

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76295?usp=email ) Change subject: acpi/acpi.c: Move setting FADT SCI INT to arch specific code ...................................................................... acpi/acpi.c: Move setting FADT SCI INT to arch specific code Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Ic1533cb520a057b29fc8f926db38338cd3401b18 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76295 Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> --- M src/acpi/acpi.c M src/arch/x86/acpi.c 2 files changed, 18 insertions(+), 25 deletions(-) Approvals: Kyösti Mälkki: Looks good to me, approved build bot (Jenkins): Verified Lean Sheng Tan: Looks good to me, approved Sridhar Siricilla: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 1330f12..a2e9fdb 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -27,11 +27,6 @@ #include <types.h> #include <version.h> -#if ENV_X86 -#include <arch/ioapic.h> -#include <arch/smp/mpspec.h> -#endif - static acpi_rsdp_t *valid_rsdp(acpi_rsdp_t *rsdp); u8 acpi_checksum(u8 *table, u32 length) @@ -139,24 +134,6 @@ return sizeof(acpi_mcfg_mmconfig_t); } -static u16 acpi_sci_int(void) -{ -#if ENV_X86 - u8 gsi, irq, flags; - - ioapic_get_sci_pin(&gsi, &irq, &flags); - - /* ACPI Release 6.5, 5.2.9 and 5.2.15.5. */ - if (!CONFIG(ACPI_HAVE_PCAT_8259)) - return gsi; - - assert(irq < 16); - return irq; -#else - return 0; -#endif -} - static void acpi_create_madt(acpi_header_t *header, void *unused) { acpi_madt_t *madt = (acpi_madt_t *)header; @@ -1103,8 +1080,6 @@ fadt->preferred_pm_profile = acpi_get_preferred_pm_profile(); - fadt->sci_int = acpi_sci_int(); - arch_fill_fadt(fadt); acpi_fill_fadt(fadt); diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index ffa3463..018cdf5 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -1,12 +1,30 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpi.h> +#include <arch/ioapic.h> #include <cf9_reset.h> #include <cpu/x86/smm.h> #include <pc80/mc146818rtc.h> +static u16 acpi_sci_int(void) +{ + u8 gsi, irq, flags; + + ioapic_get_sci_pin(&gsi, &irq, &flags); + + /* ACPI Release 6.5, 5.2.9 and 5.2.15.5. */ + if (!CONFIG(ACPI_HAVE_PCAT_8259)) + return gsi; + + assert(irq < 16); + return irq; +} + + void arch_fill_fadt(acpi_fadt_t *fadt) { + fadt->sci_int = acpi_sci_int(); + if (CONFIG(HAVE_CF9_RESET)) { fadt->reset_reg.space_id = ACPI_ADDRESS_SPACE_IO; fadt->reset_reg.bit_width = 8; -- To view, visit https://review.coreboot.org/c/coreboot/+/76295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1533cb520a057b29fc8f926db38338cd3401b18 Gerrit-Change-Number: 76295 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: acpi/acpi.c: Add and use acpi_arch_fill_madt()
by Lean Sheng Tan (Code Review) 02 Aug '23

02 Aug '23

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76070?usp=email ) Change subject: acpi/acpi.c: Add and use acpi_arch_fill_madt() ...................................................................... acpi/acpi.c: Add and use acpi_arch_fill_madt() Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I4e5032fd02af7e8e9ffd2e20aa214a8392ab6335 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76070 Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Reviewed-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/acpi/acpi.c M src/acpi/acpi_apic.c M src/include/acpi/acpi.h 3 files changed, 20 insertions(+), 13 deletions(-) Approvals: Kyösti Mälkki: Looks good to me, approved Eric Lai: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved Sridhar Siricilla: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 65be82e..1330f12 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -165,15 +165,7 @@ if (acpi_fill_header(header, "APIC", MADT, sizeof(acpi_madt_t)) != CB_SUCCESS) return; - madt->lapic_addr = cpu_get_lapic_addr(); - if (CONFIG(ACPI_HAVE_PCAT_8259)) - madt->flags |= 1; - - if (CONFIG(ACPI_COMMON_MADT_LAPIC)) - current = acpi_create_madt_lapics_with_nmis(current); - - if (CONFIG(ACPI_COMMON_MADT_IOAPIC)) - current = acpi_create_madt_ioapic_gsi0_default(current); + current = acpi_arch_fill_madt(madt, current); if (CONFIG(ACPI_CUSTOM_MADT)) current = acpi_fill_madt(current); diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c index 38daaab..f952d0a 100644 --- a/src/acpi/acpi_apic.c +++ b/src/acpi/acpi_apic.c @@ -139,7 +139,7 @@ return irqoverride->length; } -unsigned long acpi_create_madt_ioapic_gsi0_default(unsigned long current) +static unsigned long acpi_create_madt_ioapic_gsi0_default(unsigned long current) { current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current, IO_APIC_ADDR); @@ -194,7 +194,7 @@ return current; } -unsigned long acpi_create_madt_lapics_with_nmis(unsigned long current) +static unsigned long acpi_create_madt_lapics_with_nmis(unsigned long current) { current = acpi_create_madt_lapics(current); current = acpi_create_madt_lapic_nmis(current); @@ -227,3 +227,19 @@ return x2apic->length; } + +unsigned long acpi_arch_fill_madt(acpi_madt_t *madt, unsigned long current) +{ + madt->lapic_addr = cpu_get_lapic_addr(); + + if (CONFIG(ACPI_HAVE_PCAT_8259)) + madt->flags |= 1; + + if (CONFIG(ACPI_COMMON_MADT_LAPIC)) + current = acpi_create_madt_lapics_with_nmis(current); + + if (CONFIG(ACPI_COMMON_MADT_IOAPIC)) + current = acpi_create_madt_ioapic_gsi0_default(current); + + return current; +} diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 510c790..151cdd0 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1530,6 +1530,7 @@ void preload_acpi_dsdt(void); unsigned long write_acpi_tables(const unsigned long addr); unsigned long acpi_fill_madt(unsigned long current); +unsigned long acpi_arch_fill_madt(acpi_madt_t *madt, unsigned long current); void acpi_fill_fadt(acpi_fadt_t *fadt); void arch_fill_fadt(acpi_fadt_t *fadt); @@ -1556,12 +1557,10 @@ u8 eniw, u32 hbig, u16 restriction, u16 qtg_id, const u32 *interleave_target); -unsigned long acpi_create_madt_ioapic_gsi0_default(unsigned long current); int acpi_create_madt_ioapic_from_hw(acpi_madt_ioapic_t *ioapic, u32 addr); unsigned long acpi_create_madt_one_lapic(unsigned long current, u32 cpu, u32 apic); -unsigned long acpi_create_madt_lapics_with_nmis(unsigned long current); unsigned long acpi_create_madt_lapic_nmis(unsigned long current); int acpi_create_srat_lapic(acpi_srat_lapic_t *lapic, u8 node, u8 apic); -- To view, visit https://review.coreboot.org/c/coreboot/+/76070?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e5032fd02af7e8e9ffd2e20aa214a8392ab6335 Gerrit-Change-Number: 76070 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: acpi/acpi.h: Add MADT GIC structures
by Lean Sheng Tan (Code Review) 02 Aug '23

02 Aug '23

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76131?usp=email ) Change subject: acpi/acpi.h: Add MADT GIC structures ...................................................................... acpi/acpi.h: Add MADT GIC structures Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I9e6544c956cb3d516d2e5900357af9ae8976cc8e Reviewed-on: https://review.coreboot.org/c/coreboot/+/76131 Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/include/acpi/acpi.h 1 file changed, 87 insertions(+), 0 deletions(-) Approvals: Lean Sheng Tan: Looks good to me, approved build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 0aa8026..510c790 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -748,6 +748,93 @@ u8 reserved[3]; } __packed acpi_madt_lx2apic_nmi_t; +/* MADT: GIC CPU Interface (GICC) Structure 6.5 */ +struct gicc_flags { + uint32_t enabled : 1; + /* 0 - Level-triggered | 1 - Edge-Triggered */ + uint32_t performance_interrupt_mode : 1; + uint32_t vgic_maintenance_interrupt_mode : 1; + uint32_t online_capable : 1; + uint32_t reserved : 28; +}; +_Static_assert(sizeof(struct gicc_flags) == sizeof(uint32_t), "Wrong gicc_flags size\n"); + +typedef struct acpi_gicc { + uint8_t type; + uint8_t length; + uint16_t reserved; + uint32_t cpu_interface_number; + uint32_t acpi_processor_uid; + struct gicc_flags flags; + uint32_t parking_protocol_version; + uint32_t performance_interrupt_gsiv; + uint64_t parked_address; + uint64_t physical_base_address; /* GIC v1/v2 or GIC v3/v4 in v2 compat mode */ + uint64_t gicv; + uint64_t gich; + uint32_t vgic_maintenance_interrupt; + uint64_t gicr_base_address; /* Only GIC v3 and above */ + uint64_t mpidr; + uint8_t processor_power_efficiency_class; + uint8_t reserved1; + uint16_t spe_overflow_interrupt; + uint16_t trbe_interrupt; +} __packed acpi_madt_gicc_t; +_Static_assert(sizeof(acpi_madt_gicc_t) == 82, "Wrong acpi_madt_gicc_t size\n"); + +/* MADT: GIC Distributor (GICD) Structure */ +typedef struct acpi_gicd { + uint8_t type; + uint8_t length; + uint16_t reserved1; + uint32_t gic_id; + uint64_t physical_base_address; + uint32_t system_vector_base; + uint8_t gic_version; + uint8_t reserved2[3]; +} __packed acpi_madt_gicd_t; +_Static_assert(sizeof(acpi_madt_gicd_t) == 24, "Wrong acpi_madt_gicd_t size\n"); + +/* MADT: GIC MSI Frame Structure */ +struct gic_msi_flags { + uint32_t spi_count_select : 1; + uint32_t reserved : 31; +}; +_Static_assert(sizeof(struct gic_msi_flags) == sizeof(uint32_t), "Wrong gic_msi_flags size\n"); + +typedef struct acpi_gic_msi { + uint8_t type; + uint8_t length; + uint16_t reserved; + uint32_t gic_msi_frame_id; + uint64_t physical_base_address; + struct gic_msi_flags flags; + uint16_t spi_count; + uint16_t spi_base; +} __packed acpi_gic_msi_t; +_Static_assert(sizeof(acpi_gic_msi_t) == 24, "Wrong acpi_gic_msi_t size\n"); + +/* MADT: GIC Redistributor (GICR) Structure */ +typedef struct acpi_girr { + uint8_t type; + uint8_t length; + uint16_t reserved; + uint64_t discovery_range_base_address; + uint32_t discovery_range_length; +} __packed acpi_madt_gicr_t; +_Static_assert(sizeof(acpi_madt_gicr_t) == 16, "Wrong acpi_madt_gicr_t size\n"); + +/* MADT: GIC Interrupt Translation Service (ITS) Structure */ +typedef struct acpi_gic_its { + uint8_t type; + uint8_t length; + uint16_t reserved; + uint32_t gic_its_id; + uint64_t physical_base_address; + uint32_t reserved2; +} __packed acpi_madt_gic_its_t; +_Static_assert(sizeof(acpi_madt_gic_its_t) == 20, "Wrong MADT acpi_madt_gic_its_t size\n"); + #define ACPI_DBG2_PORT_SERIAL 0x8000 #define ACPI_DBG2_PORT_SERIAL_16550 0x0000 #define ACPI_DBG2_PORT_SERIAL_16550_DBGP 0x0001 -- To view, visit https://review.coreboot.org/c/coreboot/+/76131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e6544c956cb3d516d2e5900357af9ae8976cc8e Gerrit-Change-Number: 76131 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: acpi/acpi.c: Add and use acpi_arch_fill_madt()
by Lean Sheng Tan (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76070?usp=email ) Change subject: acpi/acpi.c: Add and use acpi_arch_fill_madt() ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76070/comment/a32853f1_1c7b19ca : PS4, Line 7: acpi/acpi.c: Move MADT lapic addr to APIC code > acpi/acpi. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76070?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e5032fd02af7e8e9ffd2e20aa214a8392ab6335 Gerrit-Change-Number: 76070 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Aug 2023 17:09:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi/acpi.c: Add and use acpi_arch_fill_madt()
by Lean Sheng Tan (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak. Lean Sheng Tan has uploaded a new patch set (#5) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76070?usp=email ) Change subject: acpi/acpi.c: Add and use acpi_arch_fill_madt() ...................................................................... acpi/acpi.c: Add and use acpi_arch_fill_madt() Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I4e5032fd02af7e8e9ffd2e20aa214a8392ab6335 --- M src/acpi/acpi.c M src/acpi/acpi_apic.c M src/include/acpi/acpi.h 3 files changed, 20 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/76070/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/76070?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e5032fd02af7e8e9ffd2e20aa214a8392ab6335 Gerrit-Change-Number: 76070 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: acpi.c: Add FACS and DSDT to debug hex printing
by Lean Sheng Tan (Code Review) 02 Aug '23

02 Aug '23

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76350?usp=email ) Change subject: acpi.c: Add FACS and DSDT to debug hex printing ...................................................................... acpi.c: Add FACS and DSDT to debug hex printing TESTED acpixtract -a is able to extract all the dumped tables including FACS and DSDT. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I7fad86ead3b43b6819a2da030a72322b7e259376 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76350 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> --- M src/acpi/acpi.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Lean Sheng Tan: Looks good to me, approved diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index dea4c27..65be82e 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1553,6 +1553,9 @@ if (CONFIG(DEBUG_ACPICA_COMPATIBLE)) { printk(BIOS_DEBUG, "Printing ACPI tables in ACPICA compatible format\n"); + if (facs) + acpidump_print(facs); + acpidump_print(dsdt); for (size_t i = 0; xsdt->entry[i] != 0; i++) { acpidump_print((void *)(uintptr_t)xsdt->entry[i]); } -- To view, visit https://review.coreboot.org/c/coreboot/+/76350?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7fad86ead3b43b6819a2da030a72322b7e259376 Gerrit-Change-Number: 76350 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen
by Pratikkumar V Prajapati (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Jakub Czapiga, Ravishankar Sarawadi, Sumeet R Pawnikar, Tarun Tuli. Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75626?usp=email ) Change subject: soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen ...................................................................... Patch Set 16: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75626/comment/9831e40c_f5ddb547 : PS15, Line 10: UPDS > nit: UPDs Done -- To view, visit https://review.coreboot.org/c/coreboot/+/75626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8d33f470977ce8db2fd137bab9c63e325b4a32d Gerrit-Change-Number: 75626 Gerrit-PatchSet: 16 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 17:05:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen
by Pratikkumar V Prajapati (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Jakub Czapiga, Pratikkumar V Prajapati, Ravishankar Sarawadi, Tarun Tuli. Hello Jakub Czapiga, Kapil Porwal, Ravishankar Sarawadi, Sridhar Siricilla, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75626?usp=email to look at the new patch set (#16). Change subject: soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen ...................................................................... soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen Set UPD params GenerateNewTmeKey, TmeExcludeBase, and TmeExcludeSize when TME_KEY_REGENERATION_ON_WARM_BOOT config is enabled. These UPDs are programmed only when INTEL_TME is enabled. Bug=b:276120526 TEST=Able to build REX platform. Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.com> Change-Id: Ib8d33f470977ce8db2fd137bab9c63e325b4a32d --- M src/soc/intel/meteorlake/romstage/fsp_params.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/75626/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/75626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8d33f470977ce8db2fd137bab9c63e325b4a32d Gerrit-Change-Number: 75626 Gerrit-PatchSet: 16 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023