coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[M] Change in coreboot[master]: acpi: Add functions to declare ARM GIC V3 hardware
by Julius Werner (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Arthur Heymans, Felix Held, Kyösti Mälkki, Lance Zhao, Tim Wawrzynczak. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76132?usp=email ) Change subject: acpi: Add functions to declare ARM GIC V3 hardware ...................................................................... Patch Set 6: (1 comment) File src/arch/arm64/Makefile.inc: https://review.coreboot.org/c/coreboot/+/76132/comment/ffdb25aa_43566c01 : PS5, Line 122: ramstage-$(CONFIG_ACPI_COMMON_MADT_GICC_V3) += ../../acpi/acpi_gic.c > FelixH and I thought that arch/x86 should be revisited for this, CB:76008. That's a bit of a different case though since there's no separate guarding Kconfig for those files. In this case the files are already guarded by CONFIG_ACPI_COMMON_MADT_GICC_V3, and CONFIG_ACPI_COMMON_MADT_GICC_V3 should only be enabled for arm64 boards to begin with, so it should be fine to just add this to acpi/Makefile.inc directly. (Although I agree with Kyösti that even in that case it seems like a bad idea and should probably be solved in some other way if possible.) -- To view, visit https://review.coreboot.org/c/coreboot/+/76132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5074d0a76316e854b7801e14b3241f88e805b02f Gerrit-Change-Number: 76132 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 03 Aug 2023 00:13:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: drivers/intel/gma/Kconfig: Add VBT compression configuration entry
by Jérémy Compostella (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Anil Kumar K, Paul Menzel, Subrata Banik. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76816?usp=email ) Change subject: drivers/intel/gma/Kconfig: Add VBT compression configuration entry ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76816/comment/1a047daf_06d8df0d : PS2, Line 12: > I see. I’d start by describing the problem, that VBT is currently always LZMA compressed. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76816?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1df6a96c2ec122f0ef8ee6a1e96ffbd621b14941 Gerrit-Change-Number: 76816 Gerrit-PatchSet: 5 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 03 Aug 2023 00:11:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: drivers/intel/gma/Kconfig: Add VBT compression configuration entry
by Jérémy Compostella (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Anil Kumar K, Jérémy Compostella, Subrata Banik. Hello Anil Kumar K, Paul Menzel, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76816?usp=email to look at the new patch set (#6). Change subject: drivers/intel/gma/Kconfig: Add VBT compression configuration entry ...................................................................... drivers/intel/gma/Kconfig: Add VBT compression configuration entry Currently, the VBT compression is hardcoded to lzma. To offer more flexibility, this patch introduces a `CONFIG_VBT_CBFS_COMPRESSION'. This entry can be used to set the desired compression algorithm for VBT binary CBFS storage. For instance, it can be set to `none' to allow the VBT binary to be used in pre-memory stages such as romstage. Change-Id: I1df6a96c2ec122f0ef8ee6a1e96ffbd621b14941 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/drivers/intel/gma/Kconfig M src/drivers/intel/gma/Makefile.inc 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/76816/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/76816?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1df6a96c2ec122f0ef8ee6a1e96ffbd621b14941 Gerrit-Change-Number: 76816 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: cbfstool: Add relocation support for EFI binaries
by Jérémy Compostella (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Anil Kumar K, Cliff Huang, Paul Menzel, Subrata Banik. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76762?usp=email ) Change subject: cbfstool: Add relocation support for EFI binaries ...................................................................... Patch Set 6: (1 comment) File src/commonlib/fsp_relocate.c: https://review.coreboot.org/c/coreboot/+/76762/comment/cd7b93c6_ff209a14 : PS3, Line 284: return 0; > Thank you for the analysis. […] Sure, cf. https://review.coreboot.org/c/coreboot/+/76891/ -- To view, visit https://review.coreboot.org/c/coreboot/+/76762?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e98ffd1d864cf9ac675421471d888334d8ab28b Gerrit-Change-Number: 76762 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 03 Aug 2023 00:04:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: commonlib/fsp_relocate: Fix pe_relocate() return value on success
by Jérémy Compostella (Code Review) 03 Aug '23

03 Aug '23

Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76891?usp=email ) Change subject: commonlib/fsp_relocate: Fix pe_relocate() return value on success ...................................................................... commonlib/fsp_relocate: Fix pe_relocate() return value on success Similarily to te_relocate(), on success pe_relocate() should return 0. It has never been an issue so far as pe_relocate() return value is not tested. Change-Id: I8e531662952d12e1f0ffa34042dab778ea602bfc Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/commonlib/fsp_relocate.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/76891/1 diff --git a/src/commonlib/fsp_relocate.c b/src/commonlib/fsp_relocate.c index 8027994..4baf5e6 100644 --- a/src/commonlib/fsp_relocate.c +++ b/src/commonlib/fsp_relocate.c @@ -281,7 +281,7 @@ img_base_off += delta; write_le32(&ophdr->ImageBase, img_base_off); - return -1; + return 0; } static int te_relocate(uintptr_t new_addr, void *te) -- To view, visit https://review.coreboot.org/c/coreboot/+/76891?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e531662952d12e1f0ffa34042dab778ea602bfc Gerrit-Change-Number: 76891 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: Makefile.inc: Fix typo
by Jérémy Compostella (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Martin L Roth. Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76890?usp=email ) Change subject: Makefile.inc: Fix typo ...................................................................... Makefile.inc: Fix typo Change-Id: I96388245df406e6b4cb1cd3418f6a32d5b23499f Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/76890/1 diff --git a/Makefile.inc b/Makefile.inc index 094387f..414ef76 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -831,7 +831,7 @@ # mma, efi, deleted, null # 4 - Compression type [$(FILENAME)-compression] # none, LZMA -# 5 - Base address [$(FILANAME)-position] +# 5 - Base address [$(FILENAME)-position] # 6 - Alignment [$(FILENAME)-align] # 7 - cbfstool flags [$(FILENAME)-options] # -- To view, visit https://review.coreboot.org/c/coreboot/+/76890?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96388245df406e6b4cb1cd3418f6a32d5b23499f Gerrit-Change-Number: 76890 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: cbfstool: Add relocation support for EFI binaries
by Jérémy Compostella (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Anil Kumar K, Cliff Huang, Jérémy Compostella, Subrata Banik. Hello Anil Kumar K, Cliff Huang, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76762?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: cbfstool: Add relocation support for EFI binaries ...................................................................... cbfstool: Add relocation support for EFI binaries This patch allows EFI binaries stored in CBFS to be relocated at build time using the `--xip' option flag. It allows to include a Pre-EFI Initialization Module driver in CBFS and to execute it in pre-memory stages. Such a module could perform some platform specific initialization operations such as graphics initialization operations for instance. Change-Id: I5e98ffd1d864cf9ac675421471d888334d8ab28b Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/commonlib/fsp_relocate.c M src/commonlib/include/commonlib/fsp.h M util/cbfstool/cbfstool.c 3 files changed, 55 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/76762/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/76762?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e98ffd1d864cf9ac675421471d888334d8ab28b Gerrit-Change-Number: 76762 Gerrit-PatchSet: 5 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: src: Implement framework for PRERAM VSD store
by Julius Werner (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Subrata Banik. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76393?usp=email ) Change subject: src: Implement framework for PRERAM VSD store ...................................................................... Patch Set 12: (1 comment) Patchset: PS10: > > > * ISH firmware version which needs to be passed between romstage and ramstage […] Sorry, I still disagree with this whole "VSD" thing and the extra APIs you add for it. I don't see how they serve a purpose. CBMEM is already an allocator that can give you a data area of your preferred size. You don't need to add another API that's just "give me an area of size X" and all it does is chain that call to cbmem_add(). We agreed that pre-RAM CBMEM sounds like a good eventual long-term goal, and that it would take too long right now so you need a temporary stopgap solution instead. So please, for that temporary solution, just use a global variable. I agree that having everything floating around in global variables may get unwieldy long term, but that's why the solution is temporary. You don't need to design a big new temporary "VSD" API just so we can eventually throw it away again and do pre-RAM CBMEM instead. Don't over-engineer a stopgap, just do the simplest thing. -- To view, visit https://review.coreboot.org/c/coreboot/+/76393?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0baebb902807d5403800ac18757512bd2a59d2b9 Gerrit-Change-Number: 76393 Gerrit-PatchSet: 12 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 23:58:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/sifive/fu540/Kconfig: Fix opensbi platform
by Maximilian Brune (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Philipp Hug, ron minnich. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76688?usp=email ) Change subject: soc/sifive/fu540/Kconfig: Fix opensbi platform ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76688/comment/990d0b71_51a3afa9 : PS1, Line 11: ' > Nit: No apostrophe needed here. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76688?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76aa3d386936b331785a23edb8deb0d73609be47 Gerrit-Change-Number: 76688 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 23:53:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/sifive/fu540/Kconfig: Fix opensbi platform
by Maximilian Brune (Code Review) 02 Aug '23

02 Aug '23

Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich. Hello Martin L Roth, Philipp Hug, build bot (Jenkins), ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76688?usp=email to look at the new patch set (#2). Change subject: soc/sifive/fu540/Kconfig: Fix opensbi platform ...................................................................... soc/sifive/fu540/Kconfig: Fix opensbi platform commit 9a7a677 from opensbi project moved the fu540 platform to generic code and commit 26998f3 from opensbi removed the old non generic platform. Therefore opensbi platform needs to change to generic. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I76aa3d386936b331785a23edb8deb0d73609be47 --- M src/soc/sifive/fu540/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/76688/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76688?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76aa3d386936b331785a23edb8deb0d73609be47 Gerrit-Change-Number: 76688 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023