coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[XS] Change in coreboot[master]: mb/google/{rex,ovis}: Disable C1-state auto demotion for rex & ovis
by Sridhar Siricilla (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Jakub Czapiga, Paul Menzel, Subrata Banik, Sukumar Ghorai, Tarun Tuli. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76827?usp=email ) Change subject: mb/google/{rex,ovis}: Disable C1-state auto demotion for rex & ovis ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I548e0e5340dec537d05718dd2f4652e10fb36ac0 Gerrit-Change-Number: 76827 Gerrit-PatchSet: 5 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 05:02:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Hook up UPD for C1 C-state auto-demotion
by Sridhar Siricilla (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Jakub Czapiga, Paul Menzel, Subrata Banik, Sukumar Ghorai, Tarun Tuli. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76826?usp=email ) Change subject: soc/intel/meteorlake: Hook up UPD for C1 C-state auto-demotion ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76826?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cc60bd297271fcb3000c0298af71208e3be60fc Gerrit-Change-Number: 76826 Gerrit-PatchSet: 7 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 05:01:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/dedede/var/bugzzy: Configure LTE GPIOs using FW_CONFIG
by shkim (Code Review) 03 Aug '23

03 Aug '23

shkim has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/59684?usp=email ) Change subject: mb/google/dedede/var/bugzzy: Configure LTE GPIOs using FW_CONFIG ...................................................................... Abandoned Old un-merged commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/59684?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01f4d3c623cb7f1deb6264cb88774788417d291d Gerrit-Change-Number: 59684 Gerrit-PatchSet: 3 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: mb/google/brya/variants/yavilla : Modified NVM settings
by Serin Yeh (Code Review) 03 Aug '23

03 Aug '23

Serin Yeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76893?usp=email ) Change subject: mb/google/brya/variants/yavilla : Modified NVM settings ...................................................................... mb/google/brya/variants/yavilla : Modified NVM settings Modify NVM configs of MIPI camera module in coreboot for Yavilly project BUG=b:294155898 TEST=none Change-Id: I58932bc0f3dd935aa0ea8e68b2a4b0ae4907b316 Signed-off-by: Serin Yeh <serin.yeh(a)intel.corp-partner.google.com> --- M src/mainboard/google/brya/variants/yavilla/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/76893/1 diff --git a/src/mainboard/google/brya/variants/yavilla/overridetree.cb b/src/mainboard/google/brya/variants/yavilla/overridetree.cb index 12a26c2..4bae2e3 100644 --- a/src/mainboard/google/brya/variants/yavilla/overridetree.cb +++ b/src/mainboard/google/brya/variants/yavilla/overridetree.cb @@ -321,10 +321,10 @@ register "chip_name" = ""GT24C08"" register "device_type" = "INTEL_ACPI_CAMERA_NVM" - register "nvm_size" = "0x2000" + register "nvm_size" = "0x400" register "nvm_pagesize" = "1" register "nvm_readonly" = "1" - register "nvm_width" = "0x10" + register "nvm_width" = "0x08" register "nvm_compat" = ""atmel,24c08"" device i2c 50 on -- To view, visit https://review.coreboot.org/c/coreboot/+/76893?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58932bc0f3dd935aa0ea8e68b2a4b0ae4907b316 Gerrit-Change-Number: 76893 Gerrit-PatchSet: 1 Gerrit-Owner: Serin Yeh <serin.yeh(a)intel.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: MAINTAINERS: Add a maintainer for soc/intel/meteorlake and mb/google/rex
by Subrata Banik (Code Review) 03 Aug '23

03 Aug '23

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76884?usp=email ) Change subject: MAINTAINERS: Add a maintainer for soc/intel/meteorlake and mb/google/rex ...................................................................... MAINTAINERS: Add a maintainer for soc/intel/meteorlake and mb/google/rex Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: I7f01ee979036071ce7574254101e25b908f8e788 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76884 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M MAINTAINERS 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Kapil Porwal: Looks good to me, approved Subrata Banik: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index b3eb11e..71f6ab2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -343,6 +343,7 @@ M: Tarun Tuli <taruntuli(a)google.com> M: Kapil Porwal <kapilporwal(a)google.com> M: Jakub Czapiga <jacz(a)semihalf.com> +M: Eran Mitrani <mitrani(a)google.com> S: Maintained F: src/mainboard/google/rex/ @@ -868,6 +869,7 @@ M: Tarun Tuli <taruntuli(a)google.com> M: Kapil Porwal <kapilporwal(a)google.com> M: Jakub Czapiga <jacz(a)semihalf.com> +M: Eran Mitrani <mitrani(a)google.com> S: Maintained F: src/soc/intel/meteorlake/ -- To view, visit https://review.coreboot.org/c/coreboot/+/76884?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f01ee979036071ce7574254101e25b908f8e788 Gerrit-Change-Number: 76884 Gerrit-PatchSet: 2 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: MAINTAINERS: Add a maintainer for soc/intel/meteorlake and mb/google/rex
by Subrata Banik (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Eran Mitrani. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76884?usp=email ) Change subject: MAINTAINERS: Add a maintainer for soc/intel/meteorlake and mb/google/rex ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76884?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f01ee979036071ce7574254101e25b908f8e788 Gerrit-Change-Number: 76884 Gerrit-PatchSet: 1 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 04:30:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src: Implement framework for PRERAM VSD store
by Subrata Banik (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Julius Werner, Kapil Porwal, Lean Sheng Tan, Werner Zeh. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76393?usp=email ) Change subject: src: Implement framework for PRERAM VSD store ...................................................................... Patch Set 12: (1 comment) Patchset: PS10: > Sorry, I still disagree with this whole "VSD" thing and the extra APIs you add for it. I don't see how they serve a purpose. CBMEM is already an allocator that can give you a data area of your preferred size. You don't need to add another API that's just "give me an area of size X" and all it does is chain that call to cbmem_add(). > > We agreed that pre-RAM CBMEM sounds like a good eventual long-term goal, and that it would take too long right now so you need a temporary stopgap solution instead. So please, for that temporary solution, just use a global variable. I agree that having everything floating around in global variables may get unwieldy long term, but that's why the solution is temporary. You don't need to design a big new temporary "VSD" API just so we can eventually throw it away again and do pre-RAM CBMEM instead. Don't over-engineer a stopgap, just do the simplest thing. @Julius, it's okay that you don't agree with this solution of having a separate structure and API to read/write the VSD data. Ideally we can't make everyone happy with a single change. Fundamentally, I'm okay with the longer term proposal but that doesn't mean we will make the short term code messy (using so many global variables floating from different source files) so that it's difficult for anyone to follow and review. If it just one file where we are declaring all required global variables and then migrate into the cbmem, I would have easily follow your instructions but the usage model is different and there would be multiple file and files between the stages are involved hence, write function to sync those global variables after CBMEM comes online is a job honestly. Compared to that, calling into cbmem_vsd is much simpler where the caller adds the newer variable into the VSD and it's getting auto synced when cbmem comes online. As you might have noticed that we are working very actively to land this feature because there is a production requirement as well as so dependency CLs are blocked as we are working towards creating an infrastructure change to accommodate the pre-ram cbmem usage better. I don't see a point to cross-argue for reasons below 1. This feature is guarded against the Kconfig hence, not impacting any other SOC, mainboard unless selected. 2. This feature is not auto selected 3. The user of this feature is still inside the Intel SoC which this team is mostly focusing on. hence, no way it can impact other arch 4. Not touching existing cbmem infrastructure hence, in future decoupling would be easy 5. Usage of memory is still very limited once enabled. 6. Easy to navigate using cbmem_vsd to know the scope of those variables is at pre-ram or post-ram -- To view, visit https://review.coreboot.org/c/coreboot/+/76393?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0baebb902807d5403800ac18757512bd2a59d2b9 Gerrit-Change-Number: 76393 Gerrit-PatchSet: 12 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 04:25:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/dedede/var/bugzzy: Configure LTE GPIOs using FW_CONFIG
by SH Kim (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Edward Doan, Karthik Ramasubramanian, shkim. SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59684?usp=email ) Change subject: mb/google/dedede/var/bugzzy: Configure LTE GPIOs using FW_CONFIG ...................................................................... Patch Set 2: Code-Review-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/59684?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01f4d3c623cb7f1deb6264cb88774788417d291d Gerrit-Change-Number: 59684 Gerrit-PatchSet: 2 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Edward Doan <edoan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 04:16:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/dedede/var/bugzzy: Add stylus probe
by SH Kim (Code Review) 03 Aug '23

03 Aug '23

SH Kim has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/61618?usp=email ) Change subject: mb/google/dedede/var/bugzzy: Add stylus probe ...................................................................... Abandoned Abandon old unmerged commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/61618?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e42a63976b9521844f64180b550b16bac344f37 Gerrit-Change-Number: 61618 Gerrit-PatchSet: 2 Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward Doan <edoan(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: MAINTAINERS: Add a maintainer for soc/intel/meteorlake and mb/google/rex
by Kapil Porwal (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Eran Mitrani, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76884?usp=email ) Change subject: MAINTAINERS: Add a maintainer for soc/intel/meteorlake and mb/google/rex ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76884?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f01ee979036071ce7574254101e25b908f8e788 Gerrit-Change-Number: 76884 Gerrit-PatchSet: 1 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 03:40:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023