coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[S] Change in coreboot[master]: mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S
by Kun Liu (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli. Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76912?usp=email ) Change subject: mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/rex/Kconfig.name: https://review.coreboot.org/c/coreboot/+/76912/comment/2b9b1488_556b3cf8 : PS2, Line 10: select DRIVERS_GENESYSLOGIC_GL9750 > same as below Done https://review.coreboot.org/c/coreboot/+/76912/comment/9c527514_eb11c4a5 : PS2, Line 15: select DRIVERS_GENESYSLOGIC_GL9750 > Looks good. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98aa0d3e52c355f6c1528c912a6fa0f32652dda8 Gerrit-Change-Number: 76912 Gerrit-PatchSet: 3 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 03 Aug 2023 07:00:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S
by Kapil Porwal (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Kun Liu, Paul Menzel, Subrata Banik, Tarun Tuli. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76912?usp=email ) Change subject: mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/rex/Kconfig.name: https://review.coreboot.org/c/coreboot/+/76912/comment/ecad2795_2e25b423 : PS2, Line 10: select DRIVERS_GENESYSLOGIC_GL9750 same as below https://review.coreboot.org/c/coreboot/+/76912/comment/d19e5f38_d23f92d9 : PS2, Line 15: select DRIVERS_GENESYSLOGIC_GL9750 Looks good. Just move it under `BOARD_GOOGLE_MODEL_SCREEBO` in the `Kconfig` file -- To view, visit https://review.coreboot.org/c/coreboot/+/76912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98aa0d3e52c355f6c1528c912a6fa0f32652dda8 Gerrit-Change-Number: 76912 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 06:35:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: payloads/external/Linuxboot/Makefile: Add build prerequisite
by Frans Hendriks (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Christian Walter, Martin L Roth, Maximilian Brune, Stefan Reinauer. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76914?usp=email ) Change subject: payloads/external/Linuxboot/Makefile: Add build prerequisite ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Test building facebook monolith (LinuxBoot payload) -- To view, visit https://review.coreboot.org/c/coreboot/+/76914?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I459172f794ab9c1010cebcff5e28f1454e136fba Gerrit-Change-Number: 76914 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 06:24:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: payloads/external/LinuxBoot: Clean up
by Frans Hendriks (Code Review) 03 Aug '23

03 Aug '23

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76150?usp=email ) Change subject: payloads/external/LinuxBoot: Clean up ...................................................................... Patch Set 10: (2 comments) Patchset: PS10: > Which tree did you use to verify this patchset? […] The 'build' directory is located in LinuxBoot directory (payloads\external\LinuxBoot). I modified the linux.mk adding 'mkdir -p build' before curl. This solved the build error. PS10: The new patchset is solving my issue -- To view, visit https://review.coreboot.org/c/coreboot/+/76150?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25e757108e0dd473969fe5a192ad0733f1fe6286 Gerrit-Change-Number: 76150 Gerrit-PatchSet: 10 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 06:23:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: src: Implement framework for PRERAM VSD store
by Kapil Porwal (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Julius Werner, Lean Sheng Tan, Subrata Banik, Werner Zeh. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76393?usp=email ) Change subject: src: Implement framework for PRERAM VSD store ...................................................................... Patch Set 12: (3 comments) Patchset: PS10: > > Sorry, I still disagree with this whole "VSD" thing and the extra APIs you add for it. […] Although it is temporary, the current implementation has an advantage over static variables that it provides a way to carry data between preram stages. File src/cpu/intel/car/romstage.c: https://review.coreboot.org/c/coreboot/+/76393/comment/aa796154_11bc5d9c : PS12, Line 9: #include <cbmem_vsd.h> Remove it. File src/lib/cbmem_vsd.c: https://review.coreboot.org/c/coreboot/+/76393/comment/b506c03e_144cf1b9 : PS12, Line 55: if(!cbmem_area) > `space required before the open parenthesis '('` Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/76393?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0baebb902807d5403800ac18757512bd2a59d2b9 Gerrit-Change-Number: 76393 Gerrit-PatchSet: 12 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 06:22:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi/Kconfig: Move unused ACPI_EINJ config option to vendorcode
by Elyes Haouas (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: David Hendricks, Jonathan Zhang, Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68593?usp=email ) Change subject: acpi/Kconfig: Move unused ACPI_EINJ config option to vendorcode ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > Keep forgetting to uncheck resolved... I think that we can keep ACPI_EINJ_* definition as they are standard, but for the acpi_einj_* functions, I have no strong opinion. Maybe we should move those functions as they are not tested at all here. -- To view, visit https://review.coreboot.org/c/coreboot/+/68593?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I222478572a9e5efadd6719a164558833298e4c99 Gerrit-Change-Number: 68593 Gerrit-PatchSet: 10 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 06:12:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S
by Rui Zhou (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Kapil Porwal, Kun Liu, Paul Menzel, Subrata Banik, Tarun Tuli. Rui Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76912?usp=email ) Change subject: mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98aa0d3e52c355f6c1528c912a6fa0f32652dda8 Gerrit-Change-Number: 76912 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 06:03:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S
by Kun Liu (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Kapil Porwal, Paul Menzel, Rui Zhou, Subrata Banik, Tarun Tuli. Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76912?usp=email ) Change subject: mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76912/comment/d5fed743_2da38106 : PS1, Line 7: Compatible with RTS5227S and GL9750 > Please make it a statement by adding a verb (in imperative mood). […] Done File src/mainboard/google/rex/variants/screebo/overridetree.cb: https://review.coreboot.org/c/coreboot/+/76912/comment/3e446fd9_ab78a4df : PS1, Line 23: SD_GL9750 > do you also want to select `DRIVERS_GENESYSLOGIC_GL9750` for Screebo? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98aa0d3e52c355f6c1528c912a6fa0f32652dda8 Gerrit-Change-Number: 76912 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 03 Aug 2023 06:02:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S
by Kun Liu (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Jakub Czapiga, Kun Liu, Rui Zhou, Subrata Banik, Tarun Tuli. Hello Jakub Czapiga, Kapil Porwal, Rui Zhou, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76912?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Rui Zhou, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) Change subject: mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S ...................................................................... mb/google/rex/var/screebo: Add fw_config probe for GL9750 and RTS5227S Add support for SD card reader GL9750 and RTS5227S BUG=b:284273384 TEST=emerge-rex coreboot Change-Id: I98aa0d3e52c355f6c1528c912a6fa0f32652dda8 Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/rex/Kconfig.name M src/mainboard/google/rex/variants/screebo/overridetree.cb 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/76912/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98aa0d3e52c355f6c1528c912a6fa0f32652dda8 Gerrit-Change-Number: 76912 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/{rex,ovis}: Disable C1-state auto demotion for rex & ovis
by Kapil Porwal (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Jakub Czapiga, Paul Menzel, Subrata Banik, Sukumar Ghorai, Tarun Tuli. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76827?usp=email ) Change subject: mb/google/{rex,ovis}: Disable C1-state auto demotion for rex & ovis ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > @Kapil, can you please pick this cl for ur testing today? Verified basic sanity and S0iX on Screebo. -- To view, visit https://review.coreboot.org/c/coreboot/+/76827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I548e0e5340dec537d05718dd2f4652e10fb36ac0 Gerrit-Change-Number: 76827 Gerrit-PatchSet: 5 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 06:00:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023