coreboot-gerrit July 2023

coreboot-gerrit@coreboot.org

1 participants
4441 discussions

[XS] Change in coreboot[master]: Signed-off-by: VAGDEVI P <vagdevi.p@intel.com> Change-Id: If2176f3b26...
by Elyes Haouas (Code Review) 02 Jul '23

02 Jul '23

Attention is currently required from: vagdevi.p(a)intel.com. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60749?usp=email ) Change subject: Signed-off-by: VAGDEVI P <vagdevi.p(a)intel.com> Change-Id: If2176f3b26587d4ff6b5c7b06c193ddd1c9cbe86 [TEST] /mb/google/brya/variant/gimble Touchscree reset delay to 200ms ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: to drop? -- To view, visit https://review.coreboot.org/c/coreboot/+/60749?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f1b4ccf94233193c1f9c2dd82fd27a020a62186 Gerrit-Change-Number: 60749 Gerrit-PatchSet: 1 Gerrit-Owner: vagdevi.p(a)intel.com Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: vagdevi.p(a)intel.com Gerrit-Comment-Date: Sun, 02 Jul 2023 10:26:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: util/nixshell/toolchain: Update GNAT to version 12
by Elyes Haouas (Code Review) 02 Jul '23

02 Jul '23

Attention is currently required from: Felix Singer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66835?usp=email ) Change subject: util/nixshell/toolchain: Update GNAT to version 12 ...................................................................... Patch Set 2: (1 comment) File util/nixshell/toolchain.nix: https://review.coreboot.org/c/coreboot/+/66835/comment/d954f04c_0d664f61 : PS2, Line 11: gnat12 maybe change to gnat ? -- To view, visit https://review.coreboot.org/c/coreboot/+/66835?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I308dc7640e16b7cfb7679d81099d8896f3f454fc Gerrit-Change-Number: 66835 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Sun, 02 Jul 2023 09:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: DO NOT MERGE: Test Jenkins JUnit errors handling
by Elyes Haouas (Code Review) 02 Jul '23

02 Jul '23

Attention is currently required from: Jakub Czapiga. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58164?usp=email ) Change subject: DO NOT MERGE: Test Jenkins JUnit errors handling ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: To drop ? -- To view, visit https://review.coreboot.org/c/coreboot/+/58164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3fb56a266cd038185779432bfdb47a28a3ca2227 Gerrit-Change-Number: 58164 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Sun, 02 Jul 2023 09:49:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: (not tested)cpu/x86/{sipi_vector,smm}: Use uintptr_t
by Elyes Haouas (Code Review) 02 Jul '23

02 Jul '23

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/72378?usp=email ) Change subject: (not tested)cpu/x86/{sipi_vector,smm}: Use uintptr_t ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/72378?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I288d95549cb1a76f4214fe4a0994822799f2732d Gerrit-Change-Number: 72378 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: docker/coreboot-sdk/Dockerfile: Change gnat-12 to gnat
by Elyes Haouas (Code Review) 02 Jul '23

02 Jul '23

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/72511?usp=email ) Change subject: docker/coreboot-sdk/Dockerfile: Change gnat-12 to gnat ...................................................................... Abandoned see #76086 -- To view, visit https://review.coreboot.org/c/coreboot/+/72511?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ad6f8db135cdd94449c37b99b72f4ee95ae215e Gerrit-Change-Number: 72511 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: Documentation/releases: Add a number of "TODO" and "FIXME"
by Elyes Haouas (Code Review) 01 Jul '23

01 Jul '23

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/73095?usp=email ) Change subject: Documentation/releases: Add a number of "TODO" and "FIXME" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/73095?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d3989b2315c9c174cb6a484e96108460dac6e97 Gerrit-Change-Number: 73095 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/google/rex/var/ovis: Enable LAN0
by Kapil Porwal (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Jakub Czapiga, Subrata Banik, Tarun Tuli. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76213?usp=email ) Change subject: mb/google/rex/var/ovis: Enable LAN0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76213?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91b0a76395ade4459cf8705c333728a71f95df14 Gerrit-Change-Number: 76213 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Sat, 01 Jul 2023 18:13:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/ovis: Enable LAN1
by Kapil Porwal (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Jakub Czapiga, Subrata Banik, Tarun Tuli. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76212?usp=email ) Change subject: mb/google/rex/var/ovis: Enable LAN1 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/mainboard/google/rex/variants/ovis/gpio.c: https://review.coreboot.org/c/coreboot/+/76212/comment/90336e65_0672150d : PS2, Line 405: GPP_D02 > > > It is being set to 0 at both the places (bootblock and romstage). Is this intended? […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/76212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb67cb8e6fc03e3ff14b1b3d8382322fd0b3aeff Gerrit-Change-Number: 76212 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Sat, 01 Jul 2023 18:13:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/ovis: Enable LAN1
by Subrata Banik (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76212?usp=email ) Change subject: mb/google/rex/var/ovis: Enable LAN1 ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/rex/variants/ovis/gpio.c: https://review.coreboot.org/c/coreboot/+/76212/comment/68ead7e1_0f84397f : PS2, Line 405: GPP_D02 > > It is being set to 0 at both the places (bootblock and romstage). Is this intended? > > similar to SSD_PERST_L signal to complete the power seq. We can optimize it later if required -- To view, visit https://review.coreboot.org/c/coreboot/+/76212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb67cb8e6fc03e3ff14b1b3d8382322fd0b3aeff Gerrit-Change-Number: 76212 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sat, 01 Jul 2023 17:49:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/ovis: Enable LAN1
by Subrata Banik (Code Review) 01 Jul '23

01 Jul '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76212?usp=email ) Change subject: mb/google/rex/var/ovis: Enable LAN1 ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/rex/variants/ovis/gpio.c: https://review.coreboot.org/c/coreboot/+/76212/comment/7356cb36_20d6e7b1 : PS2, Line 405: GPP_D02 > It is being set to 0 at both the places (bootblock and romstage). Is this intended? similar to SSD_PERST_L signal to complete the power seq. -- To view, visit https://review.coreboot.org/c/coreboot/+/76212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb67cb8e6fc03e3ff14b1b3d8382322fd0b3aeff Gerrit-Change-Number: 76212 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sat, 01 Jul 2023 17:48:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2023