Attention is currently required from: Jeremy Soller, Paul Menzel.
Hello Jeremy Soller, Lean Sheng Tan, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61980?usp=email
to look at the new patch set (#5).
Change subject: mb/system76/tgl-h: Disable D3cold
......................................................................
mb/system76/tgl-h: Disable D3cold
Disable D3cold to prevent issues with Thunderbolt not working after S3
suspend.
Change-Id: Ib4362783546aa01f0f8f5baaad817ee76be9c39c
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M src/mainboard/system76/tgl-h/Kconfig
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/61980/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/61980?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4362783546aa01f0f8f5baaad817ee76be9c39c
Gerrit-Change-Number: 61980
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76127?usp=email )
Change subject: acpi/acpi.c: Reduce boilerplate
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76127/comment/3b145725_18cbb1bc :
PS1, Line 30: include <stdint.h>
not needed as line #32 include <types.h>
--
To view, visit https://review.coreboot.org/c/coreboot/+/76127?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4915b8cdfcfdbb34284ea75fa8a0fd23554152d
Gerrit-Change-Number: 76127
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 27 Jun 2023 16:15:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jeremy Soller, Tim Crawford.
Hello Jeremy Soller, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67837?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by Jeremy Soller, Verified+1 by build bot (Jenkins)
Change subject: mb/system76/addw1: Disable SaOcSupport
......................................................................
mb/system76/addw1: Disable SaOcSupport
Fixes addw2 hanging when using the provided 3200MT/s DIMMs.
Change-Id: I469b9c73d2e6bfa0b3c9175bcc87584aeaa95f75
Signed-off-by: Jeremy Soller <jeremy(a)system76.com>
---
M src/mainboard/system76/addw1/romstage.c
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/67837/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67837?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I469b9c73d2e6bfa0b3c9175bcc87584aeaa95f75
Gerrit-Change-Number: 67837
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jeremy Soller <jeremy(a)system76.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Daniel Peng, Shou-Chieh Hsu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75918?usp=email )
Change subject: mb/google/dedede/var/pirika: Add new Codec ALC5650
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75918?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39703a950620c90aa3740b7313b7d32cc68eede4
Gerrit-Change-Number: 75918
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Tue, 27 Jun 2023 15:44:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, Martin L Roth, Marvin Drees, Stefan Reinauer.
Hello Christian Walter, Martin L Roth, Marvin Drees, Stefan Reinauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76150?usp=email
to look at the new patch set (#5).
Change subject: payloads/external/LinuxBoot: Clean up
......................................................................
payloads/external/LinuxBoot: Clean up
There were some issues with the current Linuxboot Makefiles.
- multithreaded compilation didn't work, because some prerequisites
were missing
- initramfs wasn't added for x86 qemu boot.
- riscv support was incomplete
It began with separate patches, but resulted in a clean up patch, that
is hard to separate. The most important changes are the following:
- Instead of phony targets, actual files are now used as prerequisites
- riscv can now be used as target
- initramfs works now also for x86
- instead of querying the most recent version from the internet, I set a
known working version (because I tested it) that can be customized
and/or upgraded in the future. The reasons:
- querying the version from the internet requires a constant
connection to the internet even after linux kernel is already
build (aka subsequent builds).
- one usually wants to use a known working version, but optionally
still have the posibillity to choose a custom one. This patch
introduces this possibility in its most simple form.
- I removed as much ifeq statements as possible and moved that
responsibility to Kconfig, because they tend to make the
Makefile less readable.
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: I25e757108e0dd473969fe5a192ad0733f1fe6286
---
M payloads/external/LinuxBoot/Kconfig
M payloads/external/LinuxBoot/Makefile
M payloads/external/LinuxBoot/arm64/kernel_fdt_lzma.its
M payloads/external/LinuxBoot/targets/linux.mk
M payloads/external/LinuxBoot/targets/u-root.mk
M payloads/external/Makefile.inc
6 files changed, 104 insertions(+), 247 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/76150/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/76150?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e757108e0dd473969fe5a192ad0733f1fe6286
Gerrit-Change-Number: 76150
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-MessageType: newpatchset
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76133?usp=email )
Change subject: UNTESTED arch/x86/tables.c: Carve out ACPI as separate bootmem range
......................................................................
UNTESTED arch/x86/tables.c: Carve out ACPI as separate bootmem range
ACPI memory needs to be read only once by the OS and can in principle be
reclaimed afterwards.
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Change-Id: I1bd0ef2b1a36f101ecf89237eddcf07a79d0a9ec
---
M src/arch/x86/tables.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/76133/1
diff --git a/src/arch/x86/tables.c b/src/arch/x86/tables.c
index 1cff614..42c7b8a 100644
--- a/src/arch/x86/tables.c
+++ b/src/arch/x86/tables.c
@@ -222,4 +222,9 @@
const uintptr_t base = 0;
bootmem_add_range(base, forwarding_table - base, BM_MEM_TABLE);
+
+ if (CONFIG(HAVE_ACPI_TABLES)) {
+ const struct cbmem_entry *acpi = cbmem_entry_find(CBMEM_ID_ACPI);
+ bootmem_add_range((uintptr_t)cbmem_entry_start(acpi), cbmem_entry_size(acpi), BM_MEM_ACPI);
+ }
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/76133?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bd0ef2b1a36f101ecf89237eddcf07a79d0a9ec
Gerrit-Change-Number: 76133
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans, Christian Walter, Martin L Roth, Marvin Drees, Stefan Reinauer.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76150?usp=email )
Change subject: payloads/external/LinuxBoot: Clean up
......................................................................
Patch Set 4:
(1 comment)
File payloads/external/LinuxBoot/Kconfig:
https://review.coreboot.org/c/coreboot/+/76150/comment/a0bc6f21_fff72697 :
PS2, Line 55: choice
: prompt "Kernel release"
: default LINUXBOOT_KERNEL_STABLE
: help
: Choose the kernel release.
:
: Select 'custom' if your want to define the kernel version.
: For more information about the current 'mainline', 'stable' or 'longterm'
: version, visit: https://www.kernel.org/
:
: config LINUXBOOT_KERNEL_MAINLINE
: bool "mainline"
: help
: Mainline kernel version
:
: config LINUXBOOT_KERNEL_STABLE
: bool "stable"
: help
: Stable kernel version
:
: config LINUXBOOT_KERNEL_LONGTERM
: bool "longterm"
: help
: Longterm (LTS) kernel version
:
: config LINUXBOOT_KERNEL_CUSTOM
: bool "custom"
: help
: Custom kernel version
:
: endchoice
:
> This is broken now?
right forgot to remove it. I reduced the whole versioning part to:
Either supply a custom linux kernel version or use the one that is the default.
Makes stuff a lot easier. Especially considering the defconfig files. Will update the commit msg to reflect that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76150?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e757108e0dd473969fe5a192ad0733f1fe6286
Gerrit-Change-Number: 76150
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Comment-Date: Tue, 27 Jun 2023 15:24:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Martin L Roth, Marvin Drees, Maximilian Brune, Stefan Reinauer.
Hello Christian Walter, Martin L Roth, Marvin Drees, Stefan Reinauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76150?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: payloads/external/LinuxBoot: Clean up
......................................................................
payloads/external/LinuxBoot: Clean up
There were some issues with the current Linuxboot Makefiles.
- multithreaded compilation didn't work, because some prerequisites
were missing
- initramfs wasn't added for x86 qemu boot.
- riscv support was incomplete
It began with separate patches, but resulted in a clean up patch, that
is hard to separate. The most important changes are the following:
- Instead of phony targets, actual files are now used as prerequisites
- riscv can now be used as target
- initramfs works now also for x86
- instead of querying the most recent version from the internet, I set a
known working version (because I tested it) that can be customized
and/or upgraded in the future.
- I removed as much ifeq statements as possible and moved that
responsibility to Kconfig, because they tend to make the
Makefile less readable.
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: I25e757108e0dd473969fe5a192ad0733f1fe6286
---
M payloads/external/LinuxBoot/Kconfig
M payloads/external/LinuxBoot/Makefile
M payloads/external/LinuxBoot/arm64/kernel_fdt_lzma.its
M payloads/external/LinuxBoot/targets/linux.mk
M payloads/external/LinuxBoot/targets/u-root.mk
M payloads/external/Makefile.inc
6 files changed, 104 insertions(+), 247 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/76150/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/76150?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e757108e0dd473969fe5a192ad0733f1fe6286
Gerrit-Change-Number: 76150
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Martin L Roth, Marvin Drees, Maximilian Brune, Stefan Reinauer.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76150?usp=email )
Change subject: payloads/external/LinuxBoot: Clean up
......................................................................
Patch Set 3:
(1 comment)
File payloads/external/LinuxBoot/Kconfig:
https://review.coreboot.org/c/coreboot/+/76150/comment/48176bc7_66187628 :
PS2, Line 55: choice
: prompt "Kernel release"
: default LINUXBOOT_KERNEL_STABLE
: help
: Choose the kernel release.
:
: Select 'custom' if your want to define the kernel version.
: For more information about the current 'mainline', 'stable' or 'longterm'
: version, visit: https://www.kernel.org/
:
: config LINUXBOOT_KERNEL_MAINLINE
: bool "mainline"
: help
: Mainline kernel version
:
: config LINUXBOOT_KERNEL_STABLE
: bool "stable"
: help
: Stable kernel version
:
: config LINUXBOOT_KERNEL_LONGTERM
: bool "longterm"
: help
: Longterm (LTS) kernel version
:
: config LINUXBOOT_KERNEL_CUSTOM
: bool "custom"
: help
: Custom kernel version
:
: endchoice
:
This is broken now?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76150?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e757108e0dd473969fe5a192ad0733f1fe6286
Gerrit-Change-Number: 76150
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Comment-Date: Tue, 27 Jun 2023 15:06:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Martin L Roth, Marvin Drees, Stefan Reinauer.
Hello Christian Walter, Martin L Roth, Marvin Drees, Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76150?usp=email
to look at the new patch set (#3).
Change subject: payloads/external/LinuxBoot: Clean up
......................................................................
payloads/external/LinuxBoot: Clean up
There were some issues with the current Linuxboot Makefiles.
- multithreaded compilation didn't work, because some prerequisites
were missing
- initramfs wasn't added for x86 qemu boot.
- riscv support was incomplete
It began with separate patches, but resulted in a clean up patch, that
is hard to separate. The most important changes are the following:
- Instead of phony targets, actual files are now used as prerequisites
- riscv can now be used as target
- initramfs works now also for x86
- instead of querying the most recent version from the internet, I set a
known working version (because I tested it) that can be customized
and/or upgraded in the future.
- I removed as much ifeq statements as possible and moved that
responsibility to Kconfig, because they tend to make the
Makefile less readable.
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: I25e757108e0dd473969fe5a192ad0733f1fe6286
---
M payloads/external/LinuxBoot/Kconfig
M payloads/external/LinuxBoot/Makefile
M payloads/external/LinuxBoot/arm64/kernel_fdt_lzma.its
M payloads/external/LinuxBoot/targets/linux.mk
M payloads/external/LinuxBoot/targets/u-root.mk
M payloads/external/Makefile.inc
6 files changed, 104 insertions(+), 215 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/76150/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/76150?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e757108e0dd473969fe5a192ad0733f1fe6286
Gerrit-Change-Number: 76150
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-MessageType: newpatchset