coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[M] Change in coreboot[master]: mb/system76/{adl,tgl}: Add FMD files
by Tim Crawford (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Jeremy Soller. Hello Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76155?usp=email to look at the new patch set (#2). Change subject: mb/system76/{adl,tgl}: Add FMD files ...................................................................... mb/system76/{adl,tgl}: Add FMD files Replace `CBFS_SIZE` with FMD files to declare regions and sizes. This will be used to lock BIOS region (except SMMSTORE) on boot. Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/adl/Kconfig A src/mainboard/system76/adl/board.fmd M src/mainboard/system76/tgl-h/Kconfig A src/mainboard/system76/tgl-h/board-gbe.fmd A src/mainboard/system76/tgl-h/board.fmd M src/mainboard/system76/tgl-u/Kconfig A src/mainboard/system76/tgl-u/board.fmd 7 files changed, 62 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/76155/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Gerrit-Change-Number: 76155 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex: Enable Fast V-Mode for MTL-U 28W
by Jérémy Compostella (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Eric Herrmann, Jakub Czapiga, Jay Patel, Kapil Porwal, Subrata Banik, Tarun Tuli. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75764?usp=email ) Change subject: mb/google/rex: Enable Fast V-Mode for MTL-U 28W ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > > I have reached out internally to get all the necessary clarification. I will keep you posted. […] Since I'll be OOO starting tomorrow evening, I have handed over this activity to Ravi. -- To view, visit https://review.coreboot.org/c/coreboot/+/75764?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If834c1af8141a19fd2daae653579225b77cfa6c8 Gerrit-Change-Number: 75764 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Herrmann <eherrmann(a)chromium.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jay Patel <jay2.patel(a)intel.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Eric Herrmann <eherrmann(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 21:57:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/system76/{adl,tgl}: Add FMAP file
by Tim Crawford (Code Review) 27 Jun '23

27 Jun '23

Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76155?usp=email ) Change subject: mb/system76/{adl,tgl}: Add FMAP file ...................................................................... mb/system76/{adl,tgl}: Add FMAP file Replace `CBFS_SIZE` with an FMAP file to declare regions and sizes. This will be used to lock BIOS region (except SMMSTORE) on boot. Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/adl/Kconfig A src/mainboard/system76/adl/board.fmd M src/mainboard/system76/tgl-h/Kconfig A src/mainboard/system76/tgl-h/board-gbe.fmd A src/mainboard/system76/tgl-h/board.fmd M src/mainboard/system76/tgl-u/Kconfig A src/mainboard/system76/tgl-u/board.fmd 7 files changed, 62 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/76155/1 diff --git a/src/mainboard/system76/adl/Kconfig b/src/mainboard/system76/adl/Kconfig index 83176d1..f13f81c 100644 --- a/src/mainboard/system76/adl/Kconfig +++ b/src/mainboard/system76/adl/Kconfig @@ -59,15 +59,15 @@ default "oryp9" if BOARD_SYSTEM76_ORYP9 default "oryp10" if BOARD_SYSTEM76_ORYP10 -config CBFS_SIZE - default 0xA00000 - config CONSOLE_POST default y config DIMM_SPD_SIZE default 512 +config FMDFILE + default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/board.fmd" + config ONBOARD_VGA_IS_PRIMARY default y diff --git a/src/mainboard/system76/adl/board.fmd b/src/mainboard/system76/adl/board.fmd new file mode 100644 index 0000000..f50c357 --- /dev/null +++ b/src/mainboard/system76/adl/board.fmd @@ -0,0 +1,15 @@ +FLASH 32M { + SI_DESC 4K +#if CONFIG_MAINBOARD_USES_IFD_GBE_REGION + SI_GBE 8K +#endif + SI_ME 4824K + SI_BIOS@16M 16M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/system76/tgl-h/Kconfig b/src/mainboard/system76/tgl-h/Kconfig index 7debee2..16b1da1 100644 --- a/src/mainboard/system76/tgl-h/Kconfig +++ b/src/mainboard/system76/tgl-h/Kconfig @@ -55,12 +55,13 @@ config OVERRIDE_DEVICETREE default "variants/\$(CONFIG_VARIANT_DIR)/overridetree.cb" -config CBFS_SIZE - default 0xA00000 - config CONSOLE_POST default y +config FMDFILE + default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/board.fmd" if !MAINBOARD_USES_IFD_GBE_REGION + default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/board-gbe.fmd" if MAINBOARD_USES_IFD_GBE_REGION + config ONBOARD_VGA_IS_PRIMARY default y diff --git a/src/mainboard/system76/tgl-h/board-gbe.fmd b/src/mainboard/system76/tgl-h/board-gbe.fmd new file mode 100644 index 0000000..2bfb31c --- /dev/null +++ b/src/mainboard/system76/tgl-h/board-gbe.fmd @@ -0,0 +1,13 @@ +FLASH 16M { + SI_DESC 4K + SI_GBE 8K + SI_ME 5108K + SI_BIOS 11M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/system76/tgl-h/board.fmd b/src/mainboard/system76/tgl-h/board.fmd new file mode 100644 index 0000000..6f3a038 --- /dev/null +++ b/src/mainboard/system76/tgl-h/board.fmd @@ -0,0 +1,12 @@ +FLASH 16M { + SI_DESC 4K + SI_ME 5116K + SI_BIOS 11M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/system76/tgl-u/Kconfig b/src/mainboard/system76/tgl-u/Kconfig index ea2419b..943a1c3 100644 --- a/src/mainboard/system76/tgl-u/Kconfig +++ b/src/mainboard/system76/tgl-u/Kconfig @@ -53,12 +53,12 @@ default "galp5" if BOARD_SYSTEM76_GALP5 default "lemp10" if BOARD_SYSTEM76_LEMP10 -config CBFS_SIZE - default 0xA00000 - config CONSOLE_POST default y +config FMDFILE + default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/board.fmd" + config POST_DEVICE default n diff --git a/src/mainboard/system76/tgl-u/board.fmd b/src/mainboard/system76/tgl-u/board.fmd new file mode 100644 index 0000000..6f3a038 --- /dev/null +++ b/src/mainboard/system76/tgl-u/board.fmd @@ -0,0 +1,12 @@ +FLASH 16M { + SI_DESC 4K + SI_ME 5116K + SI_BIOS 11M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} -- To view, visit https://review.coreboot.org/c/coreboot/+/76155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Gerrit-Change-Number: 76155 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: [WIP] include/post_code: Reorganize POST code to range specific header
by Yuchen He (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Felix Singer, Martin L Roth, Nicholas Chin, Nico Huber, Paul Menzel. Yuchen He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76099?usp=email ) Change subject: [WIP] include/post_code: Reorganize POST code to range specific header ...................................................................... Patch Set 5: (1 comment) File src/include/post_code/error.h: https://review.coreboot.org/c/coreboot/+/76099/comment/06fda5a4_7b312f0d : PS5, Line 9: #ifndef _SMM_H_ wrong #ifndef -- To view, visit https://review.coreboot.org/c/coreboot/+/76099?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic140f6bd46f6de2ba31db453aac5cbfd3bd4be84 Gerrit-Change-Number: 76099 Gerrit-PatchSet: 5 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 21:22:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/system76: Add space for ramtop in CMOS layout
by Tim Crawford (Code Review) 27 Jun '23

27 Jun '23

Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76154?usp=email ) Change subject: mb/system76: Add space for ramtop in CMOS layout ...................................................................... mb/system76: Add space for ramtop in CMOS layout Fixes building when `USE_OPTION_TABLE` is selected. Change-Id: I4fb017aa549b24eda6b9e0356bc1776d4044c95d Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/addw1/cmos.layout M src/mainboard/system76/adl/cmos.layout M src/mainboard/system76/bonw14/cmos.layout M src/mainboard/system76/cml-u/cmos.layout M src/mainboard/system76/gaze15/cmos.layout M src/mainboard/system76/kbl-u/cmos.layout M src/mainboard/system76/oryp5/cmos.layout M src/mainboard/system76/oryp6/cmos.layout M src/mainboard/system76/rpl/cmos.layout M src/mainboard/system76/tgl-h/cmos.layout M src/mainboard/system76/tgl-u/cmos.layout M src/mainboard/system76/whl-u/cmos.layout 12 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/76154/1 diff --git a/src/mainboard/system76/addw1/cmos.layout b/src/mainboard/system76/addw1/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/addw1/cmos.layout +++ b/src/mainboard/system76/addw1/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/adl/cmos.layout b/src/mainboard/system76/adl/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/adl/cmos.layout +++ b/src/mainboard/system76/adl/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/bonw14/cmos.layout b/src/mainboard/system76/bonw14/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/bonw14/cmos.layout +++ b/src/mainboard/system76/bonw14/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/cml-u/cmos.layout b/src/mainboard/system76/cml-u/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/cml-u/cmos.layout +++ b/src/mainboard/system76/cml-u/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/gaze15/cmos.layout b/src/mainboard/system76/gaze15/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/gaze15/cmos.layout +++ b/src/mainboard/system76/gaze15/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/kbl-u/cmos.layout b/src/mainboard/system76/kbl-u/cmos.layout index ac81752..4e9a300 100644 --- a/src/mainboard/system76/kbl-u/cmos.layout +++ b/src/mainboard/system76/kbl-u/cmos.layout @@ -12,6 +12,7 @@ 400 8 r 0 century 412 4 e 6 debug_level +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/oryp5/cmos.layout b/src/mainboard/system76/oryp5/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/oryp5/cmos.layout +++ b/src/mainboard/system76/oryp5/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/oryp6/cmos.layout b/src/mainboard/system76/oryp6/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/oryp6/cmos.layout +++ b/src/mainboard/system76/oryp6/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/rpl/cmos.layout b/src/mainboard/system76/rpl/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/rpl/cmos.layout +++ b/src/mainboard/system76/rpl/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/tgl-h/cmos.layout b/src/mainboard/system76/tgl-h/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/tgl-h/cmos.layout +++ b/src/mainboard/system76/tgl-h/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/tgl-u/cmos.layout b/src/mainboard/system76/tgl-u/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/tgl-u/cmos.layout +++ b/src/mainboard/system76/tgl-u/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations diff --git a/src/mainboard/system76/whl-u/cmos.layout b/src/mainboard/system76/whl-u/cmos.layout index a53c3f4..0513315 100644 --- a/src/mainboard/system76/whl-u/cmos.layout +++ b/src/mainboard/system76/whl-u/cmos.layout @@ -14,6 +14,7 @@ 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter +904 80 h 0 ramtop 984 16 h 0 check_sum enumerations -- To view, visit https://review.coreboot.org/c/coreboot/+/76154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4fb017aa549b24eda6b9e0356bc1776d4044c95d Gerrit-Change-Number: 76154 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/system76: Select CBFS SMBIOS hooks
by Tim Crawford (Code Review) 27 Jun '23

27 Jun '23

Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76153?usp=email ) Change subject: mb/system76: Select CBFS SMBIOS hooks ...................................................................... mb/system76: Select CBFS SMBIOS hooks Multiple users have requested to have the DMI values for product UUID and serial number be populated. Enable the drivers so that we may set them when flashing or updating firmware. Change-Id: I710363d9df626d51756a265f0099f26ef28411c2 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/addw1/Kconfig M src/mainboard/system76/adl/Kconfig M src/mainboard/system76/bonw14/Kconfig M src/mainboard/system76/cml-u/Kconfig M src/mainboard/system76/gaze15/Kconfig M src/mainboard/system76/kbl-u/Kconfig M src/mainboard/system76/oryp5/Kconfig M src/mainboard/system76/oryp6/Kconfig M src/mainboard/system76/rpl/Kconfig M src/mainboard/system76/tgl-h/Kconfig M src/mainboard/system76/tgl-u/Kconfig M src/mainboard/system76/whl-u/Kconfig 12 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/76153/1 diff --git a/src/mainboard/system76/addw1/Kconfig b/src/mainboard/system76/addw1/Kconfig index f152392..d037504 100644 --- a/src/mainboard/system76/addw1/Kconfig +++ b/src/mainboard/system76/addw1/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_I2C_TAS5825M select EC_SYSTEM76_EC diff --git a/src/mainboard/system76/adl/Kconfig b/src/mainboard/system76/adl/Kconfig index 83176d1..a8530e7 100644 --- a/src/mainboard/system76/adl/Kconfig +++ b/src/mainboard/system76/adl/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_32768 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_INTEL_PMC select DRIVERS_INTEL_USB4_RETIMER diff --git a/src/mainboard/system76/bonw14/Kconfig b/src/mainboard/system76/bonw14/Kconfig index b3f1707..570cb3b 100644 --- a/src/mainboard/system76/bonw14/Kconfig +++ b/src/mainboard/system76/bonw14/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select EC_SYSTEM76_EC select EC_SYSTEM76_EC_COLOR_KEYBOARD diff --git a/src/mainboard/system76/cml-u/Kconfig b/src/mainboard/system76/cml-u/Kconfig index 992f8dc..2b500d9 100644 --- a/src/mainboard/system76/cml-u/Kconfig +++ b/src/mainboard/system76/cml-u/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select EC_SYSTEM76_EC select EC_SYSTEM76_EC_COLOR_KEYBOARD if BOARD_SYSTEM76_DARP6 diff --git a/src/mainboard/system76/gaze15/Kconfig b/src/mainboard/system76/gaze15/Kconfig index 3627cb1..882992e 100644 --- a/src/mainboard/system76/gaze15/Kconfig +++ b/src/mainboard/system76/gaze15/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select EC_SYSTEM76_EC select EC_SYSTEM76_EC_COLOR_KEYBOARD diff --git a/src/mainboard/system76/kbl-u/Kconfig b/src/mainboard/system76/kbl-u/Kconfig index f5cb968..ed38815 100644 --- a/src/mainboard/system76/kbl-u/Kconfig +++ b/src/mainboard/system76/kbl-u/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_CMOS_DEFAULT diff --git a/src/mainboard/system76/oryp5/Kconfig b/src/mainboard/system76/oryp5/Kconfig index 9a0a323..60b479b 100644 --- a/src/mainboard/system76/oryp5/Kconfig +++ b/src/mainboard/system76/oryp5/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_I2C_TAS5825M select EC_SYSTEM76_EC diff --git a/src/mainboard/system76/oryp6/Kconfig b/src/mainboard/system76/oryp6/Kconfig index 0aef4a6..85eb9d1 100644 --- a/src/mainboard/system76/oryp6/Kconfig +++ b/src/mainboard/system76/oryp6/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_I2C_TAS5825M select EC_SYSTEM76_EC diff --git a/src/mainboard/system76/rpl/Kconfig b/src/mainboard/system76/rpl/Kconfig index b2058d4..4115db6 100644 --- a/src/mainboard/system76/rpl/Kconfig +++ b/src/mainboard/system76/rpl/Kconfig @@ -1,6 +1,8 @@ config BOARD_SYSTEM76_RPL_COMMON def_bool n select BOARD_ROMSIZE_KB_32768 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select EC_SYSTEM76_EC select HAVE_ACPI_RESUME diff --git a/src/mainboard/system76/tgl-h/Kconfig b/src/mainboard/system76/tgl-h/Kconfig index 7debee2..e078f2f 100644 --- a/src/mainboard/system76/tgl-h/Kconfig +++ b/src/mainboard/system76/tgl-h/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_I2C_TAS5825M if BOARD_SYSTEM76_ORYP8 select EC_SYSTEM76_EC diff --git a/src/mainboard/system76/tgl-u/Kconfig b/src/mainboard/system76/tgl-u/Kconfig index ea2419b..0cd7b0d 100644 --- a/src/mainboard/system76/tgl-u/Kconfig +++ b/src/mainboard/system76/tgl-u/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select DRIVERS_INTEL_PMC select DRIVERS_INTEL_USB4_RETIMER diff --git a/src/mainboard/system76/whl-u/Kconfig b/src/mainboard/system76/whl-u/Kconfig index 470de97..a2fdb4f 100644 --- a/src/mainboard/system76/whl-u/Kconfig +++ b/src/mainboard/system76/whl-u/Kconfig @@ -3,6 +3,8 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 + select DRIVERS_GENERIC_CBFS_SERIAL + select DRIVERS_GENERIC_CBFS_UUID select DRIVERS_I2C_HID select EC_SYSTEM76_EC select EC_SYSTEM76_EC_COLOR_KEYBOARD if BOARD_SYSTEM76_DARP5 -- To view, visit https://review.coreboot.org/c/coreboot/+/76153?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I710363d9df626d51756a265f0099f26ef28411c2 Gerrit-Change-Number: 76153 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: mb/{skl,kbl}: Use true/false keywords for non-array dt options
by Felix Singer (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Angel Pons, Frans Hendriks, Jeremy Soller, Michael Niewöhner, Michał Żygowski, Nico Huber, Piotr Król, Sean Rhodes, Tim Crawford. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75888?usp=email ) Change subject: mb/{skl,kbl}: Use true/false keywords for non-array dt options ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75888/comment/8ab9621f_7d8cf245 : PS5, Line 25: soc_gen="skylake" && \ : options=`grep -A 1337 -r "struct soc_intel_${soc_gen}_config" "src/soc/intel/${soc_gen}/chip.h" | \ : grep "bool" | \ : cut -d ';' -f 1 | \ : tr '\t' ' ' | \ : cut -d ' ' -f 3 | \ : sed -E 's/[a-zA-Z0-9_]+\[.+\]//g'` : devicetrees=`find "src/mainboard" -name '*.cb' \ : -exec grep -H "chip soc/intel/${soc_gen}" {} \; | \ : cut -d ':' -f 1` && \ : for option in ${options}; do \ : echo ${devicetrees} | \ : xargs sed -i'' -E \ : -e "s/\"${option}\"(\s+)=(\s+)\"1\"/${option}\1=\2true/g" \ : -e "s/\"${option}\"(\s+)=(\s+)\"0\"/${option}\1=\2false/g"; \ : done : > opinions? Didn't have time to look at your proposal yet, but I will definitely look. Thanks for your review! 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/75888?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff063c37a093e597c6b73a583903ce5e4f698856 Gerrit-Change-Number: 75888 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 20:58:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: [WIP] include/post_code: Reorganize POST code to range specific header
by Yuchen He (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Felix Singer, Martin L Roth, Nicholas Chin, Nico Huber, Paul Menzel. Yuchen He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76099?usp=email ) Change subject: [WIP] include/post_code: Reorganize POST code to range specific header ...................................................................... Patch Set 5: (5 comments) File src/include/post_code/acpi.h: https://review.coreboot.org/c/coreboot/+/76099/comment/d09ed2d5_61f1dcf0 : PS5, Line 8: */ add empty line File src/include/post_code/bootstage.h: https://review.coreboot.org/c/coreboot/+/76099/comment/8e6fd594_9645751c : PS5, Line 13: */ add empty line File src/include/post_code/error.h: https://review.coreboot.org/c/coreboot/+/76099/comment/0e3ec245_00e408a4 : PS5, Line 8: */ add empty line File src/include/post_code/post_code_unregulated.h: https://review.coreboot.org/c/coreboot/+/76099/comment/a7673c46_e3b3d211 : PS5, Line 17: */ add empty line File src/include/post_code/soc.h: https://review.coreboot.org/c/coreboot/+/76099/comment/1f5aeddb_2639b598 : PS5, Line 8: */ add empty line -- To view, visit https://review.coreboot.org/c/coreboot/+/76099?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic140f6bd46f6de2ba31db453aac5cbfd3bd4be84 Gerrit-Change-Number: 76099 Gerrit-PatchSet: 5 Gerrit-Owner: Yuchen He <yuchenhe126(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 19:50:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Add QS(C0) stepping CPU ID
by Musse Abdullahi (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Musse Abdullahi. Hello Musse Abdullahi, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/76135?usp=email to review the following change. Change subject: soc/intel/meteorlake: Add QS(C0) stepping CPU ID ...................................................................... soc/intel/meteorlake: Add QS(C0) stepping CPU ID This patch adds CPU ID for C0 stepping (aka QS). DOC=#723567 TEST=Able to boot on C0 rvp (and rex) and get correct CPU Name in coreboot log. Change-Id: I53e3b197f2a0090e178877c1eef783b41670ca83 Signed-off-by: Musse Abdullahi <musse.abdullahi(a)intel.com> --- M src/include/cpu/intel/cpu_ids.h M src/soc/intel/common/block/cpu/mp_init.c M src/soc/intel/meteorlake/bootblock/report_platform.c 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/76135/1 diff --git a/src/include/cpu/intel/cpu_ids.h b/src/include/cpu/intel/cpu_ids.h index 2d64c5f..77b018f9 100644 --- a/src/include/cpu/intel/cpu_ids.h +++ b/src/include/cpu/intel/cpu_ids.h @@ -72,6 +72,7 @@ #define CPUID_METEORLAKE_A0_1 0xa06a0 #define CPUID_METEORLAKE_A0_2 0xa06a1 #define CPUID_METEORLAKE_B0 0xa06a2 +#define CPUID_METEORLAKE_C0 0xa06a4 #define CPUID_RAPTORLAKE_P_J0 0xb06a2 #define CPUID_RAPTORLAKE_P_Q0 0xb06a3 diff --git a/src/soc/intel/common/block/cpu/mp_init.c b/src/soc/intel/common/block/cpu/mp_init.c index 7466ff6..dfb4a04 100644 --- a/src/soc/intel/common/block/cpu/mp_init.c +++ b/src/soc/intel/common/block/cpu/mp_init.c @@ -35,6 +35,7 @@ { X86_VENDOR_INTEL, CPUID_METEORLAKE_A0_1, CPUID_EXACT_MATCH_MASK }, { X86_VENDOR_INTEL, CPUID_METEORLAKE_A0_2, CPUID_EXACT_MATCH_MASK }, { X86_VENDOR_INTEL, CPUID_METEORLAKE_B0, CPUID_EXACT_MATCH_MASK }, + { X86_VENDOR_INTEL, CPUID_METEORLAKE_C0, CPUID_EXACT_MATCH_MASK }, { X86_VENDOR_INTEL, CPUID_SKYLAKE_C0, CPUID_EXACT_MATCH_MASK }, { X86_VENDOR_INTEL, CPUID_SKYLAKE_D0, CPUID_EXACT_MATCH_MASK }, { X86_VENDOR_INTEL, CPUID_SKYLAKE_HQ0, CPUID_EXACT_MATCH_MASK }, diff --git a/src/soc/intel/meteorlake/bootblock/report_platform.c b/src/soc/intel/meteorlake/bootblock/report_platform.c index 3e8bc56..49d0661 100644 --- a/src/soc/intel/meteorlake/bootblock/report_platform.c +++ b/src/soc/intel/meteorlake/bootblock/report_platform.c @@ -20,6 +20,7 @@ { CPUID_METEORLAKE_A0_1, "MeteorLake A0" }, { CPUID_METEORLAKE_A0_2, "MeteorLake A0" }, { CPUID_METEORLAKE_B0, "MeteorLake B0" }, + { CPUID_METEORLAKE_C0, "MeteorLake C0" }, }; static struct { -- To view, visit https://review.coreboot.org/c/coreboot/+/76135?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53e3b197f2a0090e178877c1eef783b41670ca83 Gerrit-Change-Number: 76135 Gerrit-PatchSet: 1 Gerrit-Owner: Musse Abdullahi <musse.abdullahi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Musse Abdullahi <musse.abdullahi(a)intel.com> Gerrit-Attention: Musse Abdullahi <musse.abdullahi(a)intel.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Report CPU clock info
by Jakub Czapiga (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Hannah Williams, Jamie Ryu, Kapil Porwal, Subrata Banik, Tarun Tuli, Wonkyu Kim. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76124?usp=email ) Change subject: soc/intel/meteorlake: Report CPU clock info ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/meteorlake/bootblock/report_platform.c: https://review.coreboot.org/c/coreboot/+/76124/comment/77c5db6e_4cd4ec95 : PS5, Line 111: printk(BIOS_DEBUG, "CPU: Measured:%dMHz Max-Turbo:%dMHz\n", Other lines use coma separated format: `CPU: Measured %luMHz, Max-Turbo: %luMHz` (also use correct format for uint32_t) -- To view, visit https://review.coreboot.org/c/coreboot/+/76124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b056fb8db04eca345dd7a240d03463de7c59fc2 Gerrit-Change-Number: 76124 Gerrit-PatchSet: 5 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 18:19:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023