coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[S] Change in coreboot[master]: mb/google/dedede/var/dibbi: Update power limits
by Eric Lai (Code Review) 28 Jun '23

28 Jun '23

Attention is currently required from: ChiaLing, Paul Menzel, Zhuohao Lee. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75681?usp=email ) Change subject: mb/google/dedede/var/dibbi: Update power limits ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieaff856b762b546f3e99acb7ba2ce15791193da6 Gerrit-Change-Number: 75681 Gerrit-PatchSet: 12 Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chia-Ling Hou <chia-ling.hou(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: ChiaLing <chia-ling.hou(a)intel.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Wed, 28 Jun 2023 00:14:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/hades: select DUMP_SMBIOS_TYPE17
by Eric Lai (Code Review) 27 Jun '23

27 Jun '23

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76088?usp=email ) Change subject: mb/google/hades: select DUMP_SMBIOS_TYPE17 ...................................................................... mb/google/hades: select DUMP_SMBIOS_TYPE17 Hades uses DDR5 which can't read SPD from coreboot yet. Use smbios dump to print memory information. TEST=check the coreboot log. memory Channel-0-DIMM-0 type is DDR5 memory part number is MTC8C1084S1SC56BG1 memory max speed is 5600 MT/s memory speed is 5200 MT/s memory size is 16384 MiB Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: Ica44081228a3a1edc36e2110e84686582fbe8f33 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76088 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Ivy Jian: Looks good to me, approved diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 2a9941a..d142465 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -67,6 +67,7 @@ def_bool n select BOARD_GOOGLE_BRYA_COMMON select BOARD_ROMSIZE_KB_32768 + select DUMP_SMBIOS_TYPE17 select HAVE_SLP_S0_GATE select INCLUDE_NVIDIA_GPU_ASL select MEMORY_SODIMM -- To view, visit https://review.coreboot.org/c/coreboot/+/76088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica44081228a3a1edc36e2110e84686582fbe8f33 Gerrit-Change-Number: 76088 Gerrit-PatchSet: 2 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: arch/x86/Kconfig: remove period from DUMP_SMBIOS_TYPE17 title
by Eric Lai (Code Review) 27 Jun '23

27 Jun '23

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76087?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: arch/x86/Kconfig: remove period from DUMP_SMBIOS_TYPE17 title ...................................................................... arch/x86/Kconfig: remove period from DUMP_SMBIOS_TYPE17 title Option name strings should not end with a period, remove it. Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Change-Id: Id61d8961cad2cd311db7d9da3bdb86f0f28b57b4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76087 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M src/arch/x86/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 7b3f34a..ec1171b 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -360,7 +360,7 @@ Size of reserved space for EC firmware pointer config DUMP_SMBIOS_TYPE17 - bool "Dump part of SMBIOS type17 dimm information." + bool "Dump part of SMBIOS type17 dimm information" depends on GENERATE_SMBIOS_TABLES endif -- To view, visit https://review.coreboot.org/c/coreboot/+/76087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id61d8961cad2cd311db7d9da3bdb86f0f28b57b4 Gerrit-Change-Number: 76087 Gerrit-PatchSet: 3 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/dibbi: Update power limits
by Reka Norman (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: ChiaLing, Paul Menzel, Zhuohao Lee. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75681?usp=email ) Change subject: mb/google/dedede/var/dibbi: Update power limits ...................................................................... Patch Set 12: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75681/comment/0181605b_fb6b9f11 : PS11, Line 8: > Possible unwrapped commit description (prefer a maximum 72 chars per line) Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/75681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieaff856b762b546f3e99acb7ba2ce15791193da6 Gerrit-Change-Number: 75681 Gerrit-PatchSet: 12 Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chia-Ling Hou <chia-ling.hou(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: ChiaLing <chia-ling.hou(a)intel.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 23:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/system76/{adl,tgl}: Add FMD files
by Tim Crawford (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Jeremy Soller, Paul Menzel. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76155?usp=email ) Change subject: mb/system76/{adl,tgl}: Add FMD files ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76155/comment/7158eb74_8aff66a0 : PS3, Line 12: This corrects the BIOS region size to match the FIT config. > Please mention the values. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Gerrit-Change-Number: 76155 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 27 Jun 2023 22:34:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/system76/{adl,tgl}: Add FMD files
by Tim Crawford (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Jeremy Soller, Tim Crawford. Hello Jeremy Soller, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76155?usp=email to look at the new patch set (#4). Change subject: mb/system76/{adl,tgl}: Add FMD files ...................................................................... mb/system76/{adl,tgl}: Add FMD files Replace `CBFS_SIZE` with FMD files to declare regions and sizes. This will be used to lock BIOS region (except SMMSTORE) on boot. `CBFS_SIZE` was incorrectly set to 10 MiB, so this also corrects the BIOS region size to match the FIT values. Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/adl/Kconfig A src/mainboard/system76/adl/board.fmd M src/mainboard/system76/tgl-h/Kconfig A src/mainboard/system76/tgl-h/board-gbe.fmd A src/mainboard/system76/tgl-h/board.fmd M src/mainboard/system76/tgl-u/Kconfig A src/mainboard/system76/tgl-u/board.fmd 7 files changed, 62 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/76155/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/76155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Gerrit-Change-Number: 76155 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: {ec,mb}/system76: Replace color keyboard logic
by Paul Menzel (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Jeremy Soller, Tim Crawford. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76152?usp=email ) Change subject: {ec,mb}/system76: Replace color keyboard logic ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76152?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60d3d165a58e30d2afc8736c0eb64dd90c8227ca Gerrit-Change-Number: 76152 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 22:20:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: UNTESTED arch/x86/tables.c: Carve out ACPI as separate bootmem range
by Paul Menzel (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Arthur Heymans, Felix Held, Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76133?usp=email ) Change subject: UNTESTED arch/x86/tables.c: Carve out ACPI as separate bootmem range ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1bd0ef2b1a36f101ecf89237eddcf07a79d0a9ec Gerrit-Change-Number: 76133 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 27 Jun 2023 22:19:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/system76/{adl,tgl}: Add FMD files
by Paul Menzel (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Jeremy Soller, Tim Crawford. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76155?usp=email ) Change subject: mb/system76/{adl,tgl}: Add FMD files ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76155/comment/78dbc31a_81e89283 : PS3, Line 12: This corrects the BIOS region size to match the FIT config. Please mention the values. -- To view, visit https://review.coreboot.org/c/coreboot/+/76155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Gerrit-Change-Number: 76155 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 22:19:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/system76/{adl,tgl}: Add FMD files
by Tim Crawford (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Jeremy Soller. Hello Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76155?usp=email to look at the new patch set (#3). Change subject: mb/system76/{adl,tgl}: Add FMD files ...................................................................... mb/system76/{adl,tgl}: Add FMD files Replace `CBFS_SIZE` with FMD files to declare regions and sizes. This will be used to lock BIOS region (except SMMSTORE) on boot. This corrects the BIOS region size to match the FIT config. Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/adl/Kconfig A src/mainboard/system76/adl/board.fmd M src/mainboard/system76/tgl-h/Kconfig A src/mainboard/system76/tgl-h/board-gbe.fmd A src/mainboard/system76/tgl-h/board.fmd M src/mainboard/system76/tgl-u/Kconfig A src/mainboard/system76/tgl-u/board.fmd 7 files changed, 62 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/76155/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/76155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Gerrit-Change-Number: 76155 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023