Attention is currently required from: Kun Liu, Rui Zhou, Simon Zhou, Tarun Tuli, YH Lin.
Mac Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75573?usp=email )
Change subject: mb/google/rex/variants/screebo: add FW_CONFIG for audio/DB
......................................................................
Patch Set 9: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/75573?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I928aae61d4936509a7b68f4041c0cd72f298e83d
Gerrit-Change-Number: 75573
Gerrit-PatchSet: 9
Gerrit-Owner: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 02 Jun 2023 03:46:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: ChiaLing, Paul Menzel, Reka Norman, Ryan Lin, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli, Zhuohao Lee.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75406?usp=email )
Change subject: soc/intel/common: Add PsysPl1 support
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/power_limit/power_limit.c:
https://review.coreboot.org/c/coreboot/+/75406/comment/332d8c1f_efd14354 :
PS1, Line 160: tdp_psyspl1
> We can use psyspl1 to make performance more efficient. […]
A couple more questions:
1. I thought it always uses the most restrictive limits, so it would take the minimum of PL1 and PsysPl1. So in your example if PsysPL1 is 31W, it would still limit the CPU power to PL1. Is that not right? Or does it ignore PL1 if PSYS is enabled (and in that case why do we still set PL1?)
2. Should PsysPl1 be set to the total system thermal capacity? If so, that will be much lower than 31W on dibbi since it's fanless, e.g. maybe 6W?
https://review.coreboot.org/c/coreboot/+/75406/comment/76580c6d_51081fe1 :
PS1, Line 169: wrmsr(MSR_PLATFORM_POWER_LIMIT, limit);
> I think line 129 to 150 already set pl1.
Line 129 to 150 is setting MSR_PKG_POWER_LIMIT. I was talking about bits 23:17 in MSR_PLATFORM_POWER_LIMIT (PsysPL1 time window, not PL1 time window).
--
To view, visit https://review.coreboot.org/c/coreboot/+/75406?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51907859956631d5f54ba8237d92586431fe17b7
Gerrit-Change-Number: 75406
Gerrit-PatchSet: 3
Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-CC: Super Ni <super.ni(a)intel.com>
Gerrit-CC: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Ryan Lin <ryan.lin(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Fri, 02 Jun 2023 03:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman <rekanorman(a)google.com>
Comment-In-Reply-To: ChiaLing <chia-ling.hou(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Annie Chen, Arthur Heymans, David Hendricks, Lean Sheng Tan.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email )
Change subject: src/mainboard: Add Inventec setting
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75598/comment/bebd51d9_24abcd11 :
PS1, Line 9: Modify Inventec transformers coreboot setting based on ArcherCity.
how does it differ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/75598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684
Gerrit-Change-Number: 75598
Gerrit-PatchSet: 1
Gerrit-Owner: Annie Chen <chen.annieet(a)inventec.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Hung-Wei Chen <Chen.HW(a)inventec.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Annie Chen <chen.annieet(a)inventec.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Comment-Date: Fri, 02 Jun 2023 03:26:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Rui Zhou, Tarun Tuli.
Hello Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75575?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/google/rex/var/screebo: Add devicetree config for support audio ALC1019_ALC5682I_I2S
......................................................................
mb/google/rex/var/screebo: Add devicetree config for support audio ALC1019_ALC5682I_I2S
Add devicetree config for ALC1019_ALC5682I_I2S
BUG=b:278169268
TEST=emerge-rex coreboot and verified on screebo
Change-Id: I2814cc76aff43daf0353cfef41592591bbe3d213
Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/Kconfig.name
M src/mainboard/google/rex/variants/screebo/overridetree.cb
2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/75575/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/75575?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2814cc76aff43daf0353cfef41592591bbe3d213
Gerrit-Change-Number: 75575
Gerrit-PatchSet: 8
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal, Rui Zhou, Tarun Tuli.
Hello Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75575?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/google/rex/var/screebo: Add devicetree config for support audio ALC1019_ALC5682I_I2S
......................................................................
mb/google/rex/var/screebo: Add devicetree config for support audio ALC1019_ALC5682I_I2S
Add devicetree config for ALC1019_ALC5682I_I2S
BUG=b:278169268
TEST=emerge-rex coreboot and verified on screebo
Change-Id: I2814cc76aff43daf0353cfef41592591bbe3d213
Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/rex/Kconfig.name
M src/mainboard/google/rex/variants/screebo/overridetree.cb
2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/75575/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/75575?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2814cc76aff43daf0353cfef41592591bbe3d213
Gerrit-Change-Number: 75575
Gerrit-PatchSet: 7
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: newpatchset