coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[S] Change in coreboot[master]: Docs: Add help target and .phony identifiers
by Felix Singer (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Elyes Haouas, Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75496?usp=email ) Change subject: Docs: Add help target and .phony identifiers ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75496?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie61d44d87e8628e12d01f3355360e2a679b5ce85 Gerrit-Change-Number: 75496 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 02 Jun 2023 22:16:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Docs: Add help target and .phony identifiers
by Martin L Roth (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Elyes Haouas, Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75496?usp=email ) Change subject: Docs: Add help target and .phony identifiers ...................................................................... Patch Set 2: (2 comments) File Documentation/Makefile: https://review.coreboot.org/c/coreboot/+/75496/comment/1d05ce5c_d831b1c2 : PS1, Line 57: help: > nit: add an empty line before the help target Done https://review.coreboot.org/c/coreboot/+/75496/comment/62b524a6_8027f4b0 : PS1, Line 60: @echo "livesphinx - Broken??? should this be deleted?" > Probably not meant to be submitted? I will have a look later. removed. -- To view, visit https://review.coreboot.org/c/coreboot/+/75496?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie61d44d87e8628e12d01f3355360e2a679b5ce85 Gerrit-Change-Number: 75496 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 02 Jun 2023 22:14:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/docker: Split coreboot-sdk test into its own docker image
by Martin L Roth (Code Review) 03 Jun '23

03 Jun '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75494?usp=email ) Change subject: util/docker: Split coreboot-sdk test into its own docker image ...................................................................... util/docker: Split coreboot-sdk test into its own docker image This allows the coreboot-sdk docker image to build properly even if the testing fails, and keeps the added overhead out of the coreboot-sdk image. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I6488799256f57ad64e14c93e7317b7ad2a71781c Reviewed-on: https://review.coreboot.org/c/coreboot/+/75494 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M util/docker/Makefile A util/docker/coreboot-sdk-test/Dockerfile M util/docker/coreboot-sdk/Dockerfile 3 files changed, 38 insertions(+), 34 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/util/docker/Makefile b/util/docker/Makefile index cbe34f9..c86d8fd 100644 --- a/util/docker/Makefile +++ b/util/docker/Makefile @@ -48,6 +48,11 @@ sed "s/{{CROSSGCC_PARAM}}/$(COREBOOT_CROSSGCC_PARAM)/g" | \ $(DOCKER) build -t coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) - +coreboot-sdk-test: coreboot-sdk test-docker + @echo "Testing coreboot SDK $(crossgcc_version), built from commit $(DOCKER_COMMIT)" + cat coreboot-sdk-test/Dockerfile | \ + $(DOCKER) build -t coreboot/coreboot-sdk-test:$(COREBOOT_IMAGE_TAG) - + upload-coreboot-sdk: test-docker-login $(DOCKER) push coreboot/coreboot-sdk:$(COREBOOT_IMAGE_TAG) diff --git a/util/docker/coreboot-sdk-test/Dockerfile b/util/docker/coreboot-sdk-test/Dockerfile new file mode 100644 index 0000000..0ea57d1 --- /dev/null +++ b/util/docker/coreboot-sdk-test/Dockerfile @@ -0,0 +1,33 @@ +FROM coreboot-sdk +# Test the built image +RUN mkdir -p /tmp/work && \ + cd /tmp/work && \ + git clone https://review.coreboot.org/bios_extract.git && \ + make -C bios_extract && \ + git clone https://review.coreboot.org/memtest86plus.git && \ + make -C memtest86plus && \ + git clone https://review.coreboot.org/flashrom.git && \ + CONFIG_EVERYTHING=yes make -C flashrom && \ + git clone https://review.coreboot.org/em100.git && \ + make -C em100 && \ + git clone https://review.coreboot.org/coreboot.git && \ + (cd coreboot && git submodule update --init --checkout ) && \ + make -C coreboot CPUS=$(nproc) test-abuild + +RUN \ + cd /tmp/work && \ + make -C coreboot olddefconfig && \ + make -C coreboot all -j && \ + make -C coreboot printall && \ + make -C coreboot filelist && \ + make -C coreboot ctags-project && \ + make -C coreboot cscope-project + +RUN \ + cd /tmp/work && \ + make -C coreboot test-payloads&& \ + make -C coreboot test-tools -j && \ + make -C coreboot test-lint -j && \ + make -C coreboot test-cleanup -j && \ + cd && \ + rm -rf /tmp/work/ diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index d645aa0..74b80ab 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -114,38 +114,4 @@ USER coreboot FROM coreboot-sdk -# Test the built image -RUN mkdir -p /tmp/work && \ - cd /tmp/work && \ - git clone https://review.coreboot.org/bios_extract.git && \ - make -C bios_extract && \ - git clone https://review.coreboot.org/memtest86plus.git && \ - make -C memtest86plus && \ - git clone https://review.coreboot.org/flashrom.git && \ - CONFIG_EVERYTHING=yes make -C flashrom && \ - git clone https://review.coreboot.org/em100.git && \ - make -C em100 && \ - git clone https://review.coreboot.org/coreboot.git && \ - (cd coreboot && git submodule update --init --checkout ) && \ - make -C coreboot CPUS=$(nproc) test-abuild - -RUN \ - cd /tmp/work && \ - make -C coreboot olddefconfig && \ - make -C coreboot all -j && \ - make -C coreboot printall && \ - make -C coreboot filelist && \ - make -C coreboot ctags-project && \ - make -C coreboot cscope-project - -RUN \ - cd /tmp/work && \ - make -C coreboot test-payloads&& \ - make -C coreboot test-tools -j && \ - make -C coreboot test-lint -j && \ - make -C coreboot test-cleanup -j && \ - cd && \ - rm -rf /tmp/work/ - -FROM coreboot-sdk VOLUME /home/coreboot/.ccache -- To view, visit https://review.coreboot.org/c/coreboot/+/75494?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6488799256f57ad64e14c93e7317b7ad2a71781c Gerrit-Change-Number: 75494 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in libgfxinit[master]: gma: Update DP training with new fields
by Nico Huber (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Angel Pons, Arthur Heymans, Jérémy Compostella, Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67490?usp=email ) Change subject: gma: Update DP training with new fields ...................................................................... Patch Set 18: (1 comment) File common/hw-gfx-dp_training.ads: https://review.coreboot.org/c/libgfxinit/+/67490/comment/7681f49e_73356e2f : PS8, Line 23: type T (<>) is limited private; > That could work, more like a `Port_Info` for TGL+ anyways; I was disappointed I had to go back and c […] I was able to boil it down to the addition of `Port_Config.Is_eDP` and this patch to CB:67499: http://ix.io/4xm5 Didn't push a new patch set because I don't want to make the queue more confusing. Maybe we should just skip it for now until we get to CB:67499. WDYT? -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67490?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I3f7f8a93408a74cfa29d1493a48c88ce73dc690c Gerrit-Change-Number: 67490 Gerrit-PatchSet: 18 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 02 Jun 2023 22:10:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/common/block/graphics: Add missing pci_rom_free()
by Martin L Roth (Code Review) 03 Jun '23

03 Jun '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74779?usp=email ) Change subject: soc/amd/common/block/graphics: Add missing pci_rom_free() ...................................................................... soc/amd/common/block/graphics: Add missing pci_rom_free() pci_rom_probe() can allocate memory when mapping a CBFS file, so pci_rom_free() should be called before leaving the function. BUG=b:278264488 TEST=Build and run with additional debug prints added to confirm that data are correctly unmapped Change-Id: Ie6fbbfd36f0974551befef4d08423a8148e151e7 Signed-off-by: Grzegorz Bernacki <bernacki(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74779 Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Tim Van Patten <timvp(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Himanshu Sahdev <himanshu.sahdev(a)intel.com> --- M src/soc/amd/common/block/graphics/graphics.c 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Tim Van Patten: Looks good to me, but someone else must approve Himanshu Sahdev: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved diff --git a/src/soc/amd/common/block/graphics/graphics.c b/src/soc/amd/common/block/graphics/graphics.c index d8f3e1f..93f71f9 100644 --- a/src/soc/amd/common/block/graphics/graphics.c +++ b/src/soc/amd/common/block/graphics/graphics.c @@ -157,11 +157,21 @@ return; } rom = pci_rom_probe(dev); - if (rom == NULL) + if (rom == NULL) { + printk(BIOS_ERR, "%s: Unable to find ROM for %s\n", + __func__, dev_path(dev)); + timestamp_add_now(TS_OPROM_COPY_END); return; + } + ram = pci_rom_load(dev, rom); - if (ram == NULL) - return; + if (ram == NULL) { + printk(BIOS_ERR, "%s: Unable to load ROM for %s\n", + __func__, dev_path(dev)); + } + + pci_rom_free(rom); + timestamp_add_now(TS_OPROM_COPY_END); } -- To view, visit https://review.coreboot.org/c/coreboot/+/74779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6fbbfd36f0974551befef4d08423a8148e151e7 Gerrit-Change-Number: 74779 Gerrit-PatchSet: 15 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[master]: device/pci_rom: Add simple pci_rom_free()
by Martin L Roth (Code Review) 03 Jun '23

03 Jun '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74778?usp=email ) ( 13 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: device/pci_rom: Add simple pci_rom_free() ...................................................................... device/pci_rom: Add simple pci_rom_free() It adds simple function, which frees the memory which could be allocated by pci_rom_probe(). In the next step it will be modified to free only memory, which was mapped from CBFS. BUG=b:278264488 TEST=Build and run with additional debug prints added to confirm that data are correctly unmapped Change-Id: Ibc9aad34b6bf101a3a0c06b92ed2dc6f2d7b9b33 Signed-off-by: Grzegorz Bernacki <bernacki(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74778 Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/include/device/pci_rom.h 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Felix Singer: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved build bot (Jenkins): Verified Himanshu Sahdev: Looks good to me, but someone else must approve diff --git a/src/include/device/pci_rom.h b/src/include/device/pci_rom.h index 83015a1..19728f2 100644 --- a/src/include/device/pci_rom.h +++ b/src/include/device/pci_rom.h @@ -5,6 +5,7 @@ #include <endian.h> #include <acpi/acpi.h> +#include <cbfs.h> #include <stdint.h> #define PCI_ROM_HDR 0xAA55 @@ -42,6 +43,11 @@ struct rom_header *pci_rom_load(struct device *dev, struct rom_header *rom_header); +static inline void pci_rom_free(struct rom_header *rom_header) +{ + cbfs_unmap(rom_header); +} + unsigned long pci_rom_write_acpi_tables(const struct device *device, unsigned long current, -- To view, visit https://review.coreboot.org/c/coreboot/+/74778?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc9aad34b6bf101a3a0c06b92ed2dc6f2d7b9b33 Gerrit-Change-Number: 74778 Gerrit-PatchSet: 15 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: allocator_v4: Treat above 4G resources more natively
by Felix Singer (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Felix Held, Nico Huber, Paul Menzel, Tim Wawrzynczak. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75012?usp=email ) Change subject: allocator_v4: Treat above 4G resources more natively ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Ah, the other one was reverted. Sorry for the noise. I'm wondering why Gerrit doesn't show it as reverted. -- To view, visit https://review.coreboot.org/c/coreboot/+/75012?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia822f0ce648c7f7afc801d9cb00b6459fe7cebea Gerrit-Change-Number: 75012 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 21:46:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: allocator_v4: Treat above 4G resources more natively
by Felix Singer (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Felix Held, Nico Huber, Paul Menzel, Tim Wawrzynczak. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75012?usp=email ) Change subject: allocator_v4: Treat above 4G resources more natively ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Why do CB:65413 and this one have the same commit message? The other one got merged months ago and t […] Ah, the other one was reverted. Sorry for the noise. -- To view, visit https://review.coreboot.org/c/coreboot/+/75012?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia822f0ce648c7f7afc801d9cb00b6459fe7cebea Gerrit-Change-Number: 75012 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 21:44:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: allocator_v4: Treat above 4G resources more natively
by Felix Singer (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Felix Held, Nico Huber, Paul Menzel, Tim Wawrzynczak. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75012?usp=email ) Change subject: allocator_v4: Treat above 4G resources more natively ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Why do CB:65413 and this one have the same commit message? The other one got merged months ago and this one is open. I'm confused. -- To view, visit https://review.coreboot.org/c/coreboot/+/75012?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia822f0ce648c7f7afc801d9cb00b6459fe7cebea Gerrit-Change-Number: 75012 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 21:44:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: allocator_v4: Treat above 4G resources more natively
by Nico Huber (Code Review) 03 Jun '23

03 Jun '23

Attention is currently required from: Felix Held, Paul Menzel, Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75012?usp=email ) Change subject: allocator_v4: Treat above 4G resources more natively ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75012/comment/865252b3_c23e0738 : PS4, Line 25: RESOURCE_ALLOCATION_TOP_DOWN. And turn it on by default... -- To view, visit https://review.coreboot.org/c/coreboot/+/75012?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia822f0ce648c7f7afc801d9cb00b6459fe7cebea Gerrit-Change-Number: 75012 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 21:11:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023