Attention is currently required from: Hung-Te Lin, Paul Menzel, Sheng-Liang Pan, Yu-Ping Wu.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75563?usp=email
to look at the new patch set (#4).
Change subject: mb/google/kukui: Change Juniper/Willow RAM table offset to 0x30
......................................................................
mb/google/kukui: Change Juniper/Willow RAM table offset to 0x30
All the DRAM module for Juniper/Willow can reuse the RAM ID in
offset 0x30 table, so change Juniper/Willow RAM table offset to 0x30
for introducing more DRAM modules.
BUG=b:284423187
BRANCH=kukui
TEST=emerge-jacuzzi coreboot
Signed-off-by: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Change-Id: I92740275dcc27061a94b7db7ce095655c0bd7cf5
---
M src/mainboard/google/kukui/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/75563/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/75563?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92740275dcc27061a94b7db7ce095655c0bd7cf5
Gerrit-Change-Number: 75563
Gerrit-PatchSet: 4
Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Jon Murphy has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/75642?usp=email )
Change subject: mb/google/myst: Expand flashmap to 32 MB
......................................................................
mb/google/myst: Expand flashmap to 32 MB
Expand the flashmap descriptor to 32 MB since we're using a 32 MB
flash part on Myst. FW currently fits in 16 MB so add an unused
section as a placeholder.
BUG=b:276944900
TEST=Build and boot myst
Change-Id: Ifa76c263073ab6e04e090a7142f58b3e4ae6e5bf
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M src/mainboard/google/myst/chromeos.fmd
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/75642/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75642?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa76c263073ab6e04e090a7142f58b3e4ae6e5bf
Gerrit-Change-Number: 75642
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nick Vaccaro, Nick Vaccaro, Tarun Tuli, YH Lin.
Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74713?usp=email )
Change subject: mb/google/brya/var/vell: Generate SPD ID for supported memory part
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/74713?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e6a916de08e7c05e95909d2b69bc839d13192d9
Gerrit-Change-Number: 74713
Gerrit-PatchSet: 6
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <coreboot.test(a)gmail.com>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Mon, 05 Jun 2023 01:06:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Nick Vaccaro, Shon Wang, Tarun Tuli.
Hello Nick Vaccaro, Nick Vaccaro, Tarun Tuli, YH Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74713?usp=email
to look at the new patch set (#6).
Change subject: mb/google/brya/var/vell: Generate SPD ID for supported memory part
......................................................................
mb/google/brya/var/vell: Generate SPD ID for supported memory part
Add new memory parts
DRAM Part Name ID to assign
Hynix H58G66AK6BX070 3 (0011)
Hynix H9JCNNNFA5MLYR-N6E 4 (0100)
Micron MT62F2G32D8DR-031 WT:B 4 (0100)
BUG=b:279325772
BRANCH=firmware-brya-14505.B
TEST=run part_id_gen to generate SPD id
Change-Id: I2e6a916de08e7c05e95909d2b69bc839d13192d9
Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/vell/memory/Makefile.inc
M src/mainboard/google/brya/variants/vell/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/vell/memory/mem_parts_used.txt
3 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/74713/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/74713?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e6a916de08e7c05e95909d2b69bc839d13192d9
Gerrit-Change-Number: 74713
Gerrit-PatchSet: 6
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <coreboot.test(a)gmail.com>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Jon Murphy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75642?usp=email )
Change subject: mb/google/myst: Expand flashmap to 32 MB
......................................................................
mb/google/myst: Expand flashmap to 32 MB
Expand the flashmap descriptor to 32 MB since we're using a 32 MB
flash part on Myst. FW currently fits in 16 MB so add an unused
section as a placeholder.
BUG=b:276944900
TEST=Build and boot myst
Change-Id: Ifa76c263073ab6e04e090a7142f58b3e4ae6e5bf
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M src/mainboard/google/myst/chromeos.fmd
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/75642/1
diff --git a/src/mainboard/google/myst/chromeos.fmd b/src/mainboard/google/myst/chromeos.fmd
index e1502e1..f39efe2 100644
--- a/src/mainboard/google/myst/chromeos.fmd
+++ b/src/mainboard/google/myst/chromeos.fmd
@@ -1,5 +1,6 @@
# TODO(b/276944900): Update for 32 MB support, evaluate WP_RO size
-FLASH@0xFF000000 16M {
+FLASH@0xFE000000 32M {
+ UNUSED_REGION(PRESERVE) 16M
SI_BIOS {
WP_RO 4M {
RO_GSCVD 8K
--
To view, visit https://review.coreboot.org/c/coreboot/+/75642?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa76c263073ab6e04e090a7142f58b3e4ae6e5bf
Gerrit-Change-Number: 75642
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Held, Fred Reitberger, Grzegorz Bernacki, Jakub Czapiga, Jason Glenesk, Matt DeVillier, Paul Menzel, Raul Rangel.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74269?usp=email )
Change subject: soc/amd/mendocino: Print content of manifest file
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74269/comment/be169d4c_9105e88c :
PS8, Line 14: TEST=Tested on Skyrim device
Could you post snap log here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74269?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8df54b74cd987b4a3be635932d38ea178d0b0311
Gerrit-Change-Number: 74269
Gerrit-PatchSet: 8
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Himanshu Sahdev <himanshu.sahdev(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 05 Jun 2023 00:17:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75639?usp=email )
Change subject: Docs: Update the 4.19 release notes to match the server version
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75639?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2563e7fa4b8d82ad4fbb3fd3880ee62a24a8aca
Gerrit-Change-Number: 75639
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 05 Jun 2023 00:15:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment