coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: set HBR smbus pin as NC
by Kun Liu (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Kane Chen, Kapil Porwal, Rui Zhou, Simon Zhou, Subrata Banik, Tarun Tuli. Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75643?usp=email ) Change subject: mb/google/rex/var/screebo: set HBR smbus pin as NC ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75643?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I401db32f0286de61ce3ab6c61de9528ec76cb51d Gerrit-Change-Number: 75643 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 03:22:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/nissa/var/uldren: Modify GPP_D7 and PCIE RP7
by Dtrain Hsu (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Derek Huang, Shou-Chieh Hsu, Subrata Banik, Tarun Tuli. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75644?usp=email ) Change subject: mb/google/nissa/var/uldren: Modify GPP_D7 and PCIE RP7 ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/75644?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8a2c0f5530c7a056e8d706c651cac1d49b2091c Gerrit-Change-Number: 75644 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 02:42:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/mediatek/common: Add support for power supply TPS65132S
by Ruihai Zhou (Code Review) 05 Jun '23

05 Jun '23

Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75488?usp=email ) Change subject: soc/mediatek/common: Add support for power supply TPS65132S ...................................................................... Patch Set 5: (2 comments) File src/soc/mediatek/common/tps65132s.c: https://review.coreboot.org/c/coreboot/+/75488/comment/594537f0_db20b7c7 : PS5, Line 35: mdelay(10); > Where do these delays come from? These delays come from previous CB:72749. Just keep the same as it. https://review.coreboot.org/c/coreboot/+/75488/comment/539e3b88_fce4fe3d : PS5, Line 62: mdelay(50); > For such long delays, a comment mentioning section in the datasheet would be nice. […] Got it. I will do it next times. In this case, it comes from 8.5 section Programming in TPS65132-Single-Inductor-Dual-Output-Power-Supply.pdf -- To view, visit https://review.coreboot.org/c/coreboot/+/75488?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad2c9bdea5824455efcef18b44876111061cfa1a Gerrit-Change-Number: 75488 Gerrit-PatchSet: 5 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 05 Jun 2023 02:40:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt: Fix MIPI panel power on/off sequence
by Ruihai Zhou (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Felix Held, Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu, cong yang. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75512?usp=email ) Change subject: mb/google/geralt: Fix MIPI panel power on/off sequence ...................................................................... Patch Set 4: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75512/comment/8be6b765_32cd36b8 : PS3, Line 10: large > larger Done https://review.coreboot.org/c/coreboot/+/75512/comment/1a848408_193c7a97 : PS3, Line 11: large > larger Done File src/mainboard/google/geralt/panel_geralt.c: https://review.coreboot.org/c/coreboot/+/75512/comment/c865531e_2ea9b3d3 : PS3, Line 35: { PMIC_TPS65132_VPOS, 0x11, 0x1F }, : { PMIC_TPS65132_VNEG, 0x11, 0x1F }, : { PMIC_TPS65132_DLYX, 0x95, 0xFF }, : { PMIC_TPS65132_ASSDD, 0x5b, 0xFF } > Please write hex numbers lowercase. Done https://review.coreboot.org/c/coreboot/+/75512/comment/1c49005a_b226b502 : PS3, Line 51: printk(BIOS_ERR, "Failed to setup tps65132s\n"); > TPS65132 isn't a display panel, but a voltage regulator Done, thank you. https://review.coreboot.org/c/coreboot/+/75512/comment/9a054b5f_92d67a54 : PS3, Line 51: setup > set up Done -- To view, visit https://review.coreboot.org/c/coreboot/+/75512?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ccb5be04062a0516f84a054ff3f40afbf5279be Gerrit-Change-Number: 75512 Gerrit-PatchSet: 4 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Jun 2023 02:33:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/geralt: Fix MIPI panel power on/off sequence
by Ruihai Zhou (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, Yidi Lin, Yu-Ping Wu, cong yang. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75512?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by cong yang, Verified+1 by build bot (Jenkins) Change subject: mb/google/geralt: Fix MIPI panel power on/off sequence ...................................................................... mb/google/geralt: Fix MIPI panel power on/off sequence Based on the power sequence of the panel [1], the power on T2 sequence VSP to VSN should be larger than 1ms, and the power off T2 sequence VSP to VSN should be larger than 0ms. We modify the power sequence to meet the datasheet requirement. [1] B5 TV110C9M-LL0 Product Specification Rev.P0 Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Change-Id: I4ccb5be04062a0516f84a054ff3f40afbf5279be --- M src/mainboard/google/geralt/display.c M src/mainboard/google/geralt/display.h M src/mainboard/google/geralt/panel.c M src/mainboard/google/geralt/panel.h M src/mainboard/google/geralt/panel_geralt.c M src/soc/mediatek/mt8188/Makefile.inc 6 files changed, 18 insertions(+), 71 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/75512/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/75512?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ccb5be04062a0516f84a054ff3f40afbf5279be Gerrit-Change-Number: 75512 Gerrit-PatchSet: 4 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: set HBR smbus pin as NC
by Simon Zhou (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Kane Chen, Kapil Porwal, Kun Liu, Rui Zhou, Subrata Banik, Tarun Tuli. Simon Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75643?usp=email ) Change subject: mb/google/rex/var/screebo: set HBR smbus pin as NC ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > https://qa.coreboot.org/job/coreboot-gerrit/238033/console […] thanks, Added signed-off-by in commit messages. -- To view, visit https://review.coreboot.org/c/coreboot/+/75643?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I401db32f0286de61ce3ab6c61de9528ec76cb51d Gerrit-Change-Number: 75643 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 02:32:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Comment-In-Reply-To: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: set HBR smbus pin as NC
by Simon Zhou (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Kapil Porwal, Kun Liu, Rui Zhou, Simon Zhou, Subrata Banik, Tarun Tuli. Hello Kane Chen, Kapil Porwal, Kun Liu, Rui Zhou, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75643?usp=email to look at the new patch set (#3). Change subject: mb/google/rex/var/screebo: set HBR smbus pin as NC ...................................................................... mb/google/rex/var/screebo: set HBR smbus pin as NC Since GPP_C03/GPP_04 are floating in HW design, we set HBR smbus pin as NC, in case it prevents ese and cse from entering suspend. BUG=b:283053968 TEST=Verified on screebo non-TBT SKU, suspend and resume works. Change-Id: I401db32f0286de61ce3ab6c61de9528ec76cb51d Signed-off-by: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/rex/variants/screebo/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/75643/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/75643?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I401db32f0286de61ce3ab6c61de9528ec76cb51d Gerrit-Change-Number: 75643 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: set HBR smbus pin as NC
by Kane Chen (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Kapil Porwal, Kun Liu, Rui Zhou, Simon Zhou, Subrata Banik, Tarun Tuli. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75643?usp=email ) Change subject: mb/google/rex/var/screebo: set HBR smbus pin as NC ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Does the build fail related to this change? https://qa.coreboot.org/job/coreboot-gerrit/238033/console Run checkpatch on directories that are known good (lint-extended-007-checkpatch): success Check that files end with a single newline (lint-extended-015-final-newlines): success Check for a signed-off-by line on the latest commit (lint-extended-020-signed-off-by): No Signed-off-by line in commit message test failed ERROR: 1 test(s) failed. make[1]: *** [util/testing/Makefile.inc:115: test-lint] Error 1 make: *** [util/testing/Makefile.inc:95: what-jenkins-does] Error 2 Build step 'Execute shell' marked build as failure Recording test results [Checks API] No suitable checks publisher found. [WS-CLEANUP] Deleting project workspace... [WS-CLEANUP] done Finished: FAILURE -- To view, visit https://review.coreboot.org/c/coreboot/+/75643?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I401db32f0286de61ce3ab6c61de9528ec76cb51d Gerrit-Change-Number: 75643 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 02:21:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/nissa/var/uldren: Modify GPP_D7 and PCIE RP7
by Dtrain Hsu (Code Review) 05 Jun '23

05 Jun '23

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75644?usp=email ) Change subject: mb/google/nissa/var/uldren: Modify GPP_D7 and PCIE RP7 ...................................................................... mb/google/nissa/var/uldren: Modify GPP_D7 and PCIE RP7 Uldren does not have PCIE device and should disable PCIE RP7 and GPP_D7 for preventing PCIe controller not power gate. BUG=b:283735051 BRANCH=firmware-nissa-15217.B TEST=emerge-nissa coreboot chromeos-bootimage Change-Id: Ia8a2c0f5530c7a056e8d706c651cac1d49b2091c Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/uldren/gpio.c M src/mainboard/google/brya/variants/uldren/overridetree.cb 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/75644/1 diff --git a/src/mainboard/google/brya/variants/uldren/gpio.c b/src/mainboard/google/brya/variants/uldren/gpio.c index e1e5e8c..c0c43814 100644 --- a/src/mainboard/google/brya/variants/uldren/gpio.c +++ b/src/mainboard/google/brya/variants/uldren/gpio.c @@ -21,6 +21,8 @@ PAD_CFG_GPO(GPP_C1, 1, DEEP), /* D6 : SRCCLKREQ1# ==> WWAN_EN */ PAD_CFG_GPO(GPP_D6, 1, DEEP), + /* D7 : SRCCLKREQ2# ==> NC */ + PAD_NC(GPP_D7, NONE), /* D8 : SRCCLKREQ3# ==> NC */ PAD_NC(GPP_D8, NONE), /* D15 : ISH_UART0_RTS# ==> NC */ diff --git a/src/mainboard/google/brya/variants/uldren/overridetree.cb b/src/mainboard/google/brya/variants/uldren/overridetree.cb index 77b86552..a873a62 100644 --- a/src/mainboard/google/brya/variants/uldren/overridetree.cb +++ b/src/mainboard/google/brya/variants/uldren/overridetree.cb @@ -353,6 +353,7 @@ end end end + device ref pcie_rp7 off end device ref hda on chip drivers/generic/max98357a register "hid" = ""MX98360A"" -- To view, visit https://review.coreboot.org/c/coreboot/+/75644?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8a2c0f5530c7a056e8d706c651cac1d49b2091c Gerrit-Change-Number: 75644 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/taranza: Update memory part and generate SPD ID
by Ricky Chang (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Sheng-Liang Pan, Zhuohao Lee. Ricky Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75605?usp=email ) Change subject: mb/google/dedede/var/taranza: Update memory part and generate SPD ID ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75605?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87a4dcdb6196c3ca7bed4b5c1bc654297339c16d Gerrit-Change-Number: 75605 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 02:11:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023