coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[M] Change in coreboot[master]: soc/intel/common/crashlog: Add support for IOE die
by Pratikkumar V Prajapati (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Paul Menzel, Pratikkumar V Prajapati. Hello Paul Menzel, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75475?usp=email to look at the new patch set (#5). Change subject: soc/intel/common/crashlog: Add support for IOE die ...................................................................... soc/intel/common/crashlog: Add support for IOE die Intel Meteor Lake SOC has a separate I/O Expander (IOE) die. SRAM from this IOE die contains crashlog records for the IPs of the IOE die. This patch adds functions with empty implementation using __weak attribute for IOE die related crashlog, changes common data structures while maintaining backwards compatibility, and support for filling IOE crashlog records, guarded by SOC_INTEL_IOE_DIE_SUPPORT config and makes cl_get_pmc_sram_data function as weak because it needs SOC specific implementation. Bug=b:262501347 TEST=Able to build. With Meteor Lake SOC related patch, able to capture and decode crashlog Change-Id: Id90cf0095258c4f7003e4c5f2564bb763e687b75 Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.com> --- M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h M src/soc/intel/common/Kconfig.common M src/soc/intel/common/block/acpi/acpi_bert.c M src/soc/intel/common/block/crashlog/crashlog.c M src/soc/intel/common/block/include/intelblocks/crashlog.h 5 files changed, 108 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/75475/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/75475?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id90cf0095258c4f7003e4c5f2564bb763e687b75 Gerrit-Change-Number: 75475 Gerrit-PatchSet: 5 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/rex: add Elan HID over SPI ASL for Rex0
by Eran Mitrani (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Kapil Porwal, Subrata Banik, Tarun Tuli. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74886?usp=email ) Change subject: mb/google/rex: add Elan HID over SPI ASL for Rex0 ...................................................................... Patch Set 15: (1 comment) File src/mainboard/google/rex/dsdt.asl: https://review.coreboot.org/c/coreboot/+/74886/comment/136e57d0_d28829f7 : PS13, Line 40: /* Mainboard specific */ : #include "variant/acpi/mainboard.asl" > how about adding HID_SPI elan driver based on a Kconfig ? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 Gerrit-Change-Number: 74886 Gerrit-PatchSet: 15 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 22:45:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: arch/arm64: Add EL1/EL2/EL3 support for arm64
by Julius Werner (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Arthur Heymans, Christian Walter, David Milosevic, Lean Sheng Tan, Maximilian Brune, Nico Huber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74798?usp=email ) Change subject: arch/arm64: Add EL1/EL2/EL3 support for arm64 ...................................................................... Patch Set 5: (1 comment) File src/arch/arm64/transition_asm.S: https://review.coreboot.org/c/coreboot/+/74798/comment/3dfcce3b_111228e0 : PS5, Line 155: mrs x1, currentel > We prefer linker garbage-collection over preprocessing where possible. It […] It's mostly to prevent bit rot (maybe that's what Nico meant with "test more code at once"?). If you write something like: ``` #if CONFIG_X call_func(a, b, c); #else call_func(a + 1, b, c); #endif ``` and then later someone changes the signature to call_func() to drop the third parameter, and CONFIG_X is a very rarely used option that almost nobody ever enables, it's easy to end up with a situation like: ``` #if CONFIG_X call_func(a, b, c) #else call_func(a + 1, b); #endif ``` Of course if it's just one line it's easy to see, but for bigger blocks it's not uncommon to miss something in the one the author isn't actively testing. Such a mistake can get stuck in a repo for years before anyone will notice, and then you have to do code archaeology to try to figure out how it was actually supposed to be written. If you look at U-Boot code where the policy is to always use #if for compile-time options, it's full of examples of this (or at least it used to back before I decided to never touch it again). Of course a C if() cannot prevent all kinds of bit rot either, but it helps to at least catch the simplest issues. Preprocessor #ifs also get more ugly when, say, you have a variable that's only used by paths guarded by that #if... then if you compile without it, the compiler will complain that the variable is unused, so you have to wrap yet another #if around the variable definition itself which you otherwise wouldn't have to. Also, it's just ugly (in my opinion). -- To view, visit https://review.coreboot.org/c/coreboot/+/74798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae1c57f0846c8d0585384f7e54102a837e701e7e Gerrit-Change-Number: 74798 Gerrit-PatchSet: 5 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 22:23:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex: add Elan HID over SPI ASL for Rex0
by Eran Mitrani (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Hello Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74886?usp=email to look at the new patch set (#15). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/google/rex: add Elan HID over SPI ASL for Rex0 ...................................................................... mb/google/rex: add Elan HID over SPI ASL for Rex0 This patch enables adding variant specific ASL code TEST=Kernel driver is able to communicate with device Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 --- M src/mainboard/google/rex/dsdt.asl 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/74886/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/74886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 Gerrit-Change-Number: 74886 Gerrit-PatchSet: 15 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/rex0: include Elan HID over SPI ASL
by Eran Mitrani (Code Review) 06 Jun '23

06 Jun '23

Eran Mitrani has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/74887?usp=email ) Change subject: mb/google/rex/var/rex0: include Elan HID over SPI ASL ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/74887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8af72b7c2a62145da4d2bcefb7c568e0964d0969 Gerrit-Change-Number: 74887 Gerrit-PatchSet: 16 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[master]: mb/google/rex: add Elan HID over SPI ASL for Rex0
by Eran Mitrani (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun Tuli. Hello Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74886?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/rex: add Elan HID over SPI ASL for Rex0 ...................................................................... mb/google/rex: add Elan HID over SPI ASL for Rex0 This patch enables adding variant specific ASL code TEST=Kernel driver is able to communicate with device Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 --- M src/mainboard/google/rex/dsdt.asl 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/74886/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/74886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I231482d56dd4afa150766c07cfde105158e5e124 Gerrit-Change-Number: 74886 Gerrit-PatchSet: 14 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/rex/var/rex0: add HID over SPI ACPI driver
by Eran Mitrani (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Kapil Porwal, Matt DeVillier, Subrata Banik, Tarun Tuli. Hello Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74885?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) Change subject: mb/google/rex/var/rex0: add HID over SPI ACPI driver ...................................................................... mb/google/rex/var/rex0: add HID over SPI ACPI driver Add driver to support ELAN touchscreen using SPI for rex * See "HID Over SPI Protocol Specification" section 5.2 - ACPI enum * https://www.microsoft.com/en-us/download/details.aspx?id=103325 BUG=b:278783755 TEST=Kernel driver is able to communicate with device. Also tested S0ix, ran 'suspend_stress_test -c 1' - no issues in suspend/resume. Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Signed-off-by: Eran Mitrani <mitrani(a)google.com> --- A src/mainboard/google/rex/variants/rex0/include/variant/acpi/hid_spi_elan.asl 1 file changed, 152 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/74885/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/74885?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Gerrit-Change-Number: 74885 Gerrit-PatchSet: 12 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: vboot: Drop argument to select slot from `vb2ex_ec_protect()`
by Julius Werner (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Himanshu Sahdev, Subrata Banik, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75521?usp=email ) Change subject: vboot: Drop argument to select slot from `vb2ex_ec_protect()` ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75521?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2974f0cb43ba800c2aaeac4876ebaa052b5ee793 Gerrit-Change-Number: 75521 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 22:09:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex/var/rex0: add HID over SPI ACPI driver
by Eran Mitrani (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Kapil Porwal, Matt DeVillier, Tarun Tuli. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74885?usp=email ) Change subject: mb/google/rex/var/rex0: add HID over SPI ACPI driver ...................................................................... Patch Set 11: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74885/comment/a78430ef_bd66a7dc : PS10, Line 15: waiting for HW to be available > please add a test line with S0ix being enabled Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74885?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Gerrit-Change-Number: 74885 Gerrit-PatchSet: 11 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 21:50:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex/var/rex0: add HID over SPI ACPI driver
by Eran Mitrani (Code Review) 05 Jun '23

05 Jun '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Matt DeVillier, Tarun Tuli. Hello Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74885?usp=email to look at the new patch set (#11). Change subject: mb/google/rex/var/rex0: add HID over SPI ACPI driver ...................................................................... mb/google/rex/var/rex0: add HID over SPI ACPI driver Add driver to support ELAN touchscreen using SPI for rex * See "HID Over SPI Protocol Specification" section 5.2 - ACPI enum * https://www.microsoft.com/en-us/download/details.aspx?id=103325 BUG=b:278783755 TEST=Kernel driver is able to communicate with device. Also tested S0ix, ran 'suspend_stress_test -c 1' - no issues in suspend/resume. Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 --- A src/mainboard/google/rex/variants/rex0/include/variant/acpi/hid_spi_elan.asl 1 file changed, 152 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/74885/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/74885?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0 Gerrit-Change-Number: 74885 Gerrit-PatchSet: 11 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023