coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config
by Eric Lai (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Himanshu Sahdev, Kangheui Won, Reka Norman, Tarun Tuli, Yu-Ping Wu. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75641?usp=email ) Change subject: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df Gerrit-Change-Number: 75641 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 23:57:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: libpayload/drivers/usb/xhci.c: Check for NULL in xhci_init
by Karthik Ramasubramanian (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Felix Held, Fred Reitberger. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75645?usp=email ) Change subject: libpayload/drivers/usb/xhci.c: Check for NULL in xhci_init ...................................................................... Patch Set 1: (1 comment) File payloads/libpayload/drivers/usb/xhci.c: https://review.coreboot.org/c/coreboot/+/75645/comment/836e3b40_4087f80a : PS1, Line 158: if (!physical_bar) : goto _exit_xhci; > Why is it an issue only now? Why did none of the previous platforms hit this issue? I think the exception happens while trying to initialize the USB ports under XHCI_1 controller which is turned off/unusued in Myst. -- To view, visit https://review.coreboot.org/c/coreboot/+/75645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05c32612606793adcba3f4a5724092387a215d41 Gerrit-Change-Number: 75645 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Jun 2023 23:52:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config
by Julius Werner (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eric Lai, Himanshu Sahdev, Kangheui Won, Reka Norman, Tarun Tuli, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75641?usp=email ) Change subject: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df Gerrit-Change-Number: 75641 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 23:44:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: libpayload/drivers/usb/xhci.c: Check for NULL in xhci_init
by Karthik Ramasubramanian (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Felix Held, Fred Reitberger. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75645?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: libpayload/drivers/usb/xhci.c: Check for NULL in xhci_init ...................................................................... Patch Set 1: (1 comment) File payloads/libpayload/drivers/usb/xhci.c: https://review.coreboot.org/c/coreboot/+/75645/comment/f1a51b64_8a3b8ac5 : PS1, Line 158: if (!physical_bar) : goto _exit_xhci; Why is it an issue only now? Why did none of the previous platforms hit this issue? -- To view, visit https://review.coreboot.org/c/coreboot/+/75645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05c32612606793adcba3f4a5724092387a215d41 Gerrit-Change-Number: 75645 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Jun 2023 23:44:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config
by Julius Werner (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eric Lai, Himanshu Sahdev, Kangheui Won, Reka Norman, Tarun Tuli, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75641?usp=email ) Change subject: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/75641/comment/dc0fe107_6611acc3 : PS1, Line 295: config VBOOT_GSC_BOARD_ID > Marking resolved, feel free to reopen. Yeah, I agree with Reka. -- To view, visit https://review.coreboot.org/c/coreboot/+/75641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df Gerrit-Change-Number: 75641 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 23:44:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Comment-In-Reply-To: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: libpayload/drivers/usb/xhci.c: Check for NULL in xhci_init
by Jon Murphy (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Felix Held, Fred Reitberger. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75645?usp=email ) Change subject: libpayload/drivers/usb/xhci.c: Check for NULL in xhci_init ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05c32612606793adcba3f4a5724092387a215d41 Gerrit-Change-Number: 75645 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Jun 2023 23:38:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config
by Reka Norman (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eric Lai, Himanshu Sahdev, Julius Werner, Kangheui Won, Tarun Tuli, Yu-Ping Wu. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75641?usp=email ) Change subject: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/75641/comment/5622e4f2_bf4047ec : PS1, Line 295: config VBOOT_GSC_BOARD_ID > I think using a config to store the default value is fine even if we don't override it in practice. […] Marking resolved, feel free to reopen. -- To view, visit https://review.coreboot.org/c/coreboot/+/75641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df Gerrit-Change-Number: 75641 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 05 Jun 2023 23:31:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Comment-In-Reply-To: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config
by Reka Norman (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Eric Lai, Himanshu Sahdev, Julius Werner, Kangheui Won, Tarun Tuli. Hello Eric Lai, Julius Werner, Kangheui Won, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75641?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Eric Lai, Code-Review+2 by Kangheui Won, Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config ...................................................................... mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config Board IDs are now filled in as part of the signing process, so we don't need to set them in coreboot. BUG=b:240620735 TEST=Build and check VBOOT_GSC_BOARD_ID is set to ZZCR. Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df Signed-off-by: Reka Norman <rekanorman(a)chromium.org> --- M src/mainboard/google/brya/Kconfig M src/security/vboot/Kconfig 2 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/75641/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df Gerrit-Change-Number: 75641 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config
by Reka Norman (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Himanshu Sahdev, Julius Werner, Tarun Tuli. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75641?usp=email ) Change subject: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/75641/comment/48f8dce5_9be833af : PS1, Line 295: config VBOOT_GSC_BOARD_ID > don't we need/want to remove this config existence from `src/security/vboot`? I think using a config to store the default value is fine even if we don't override it in practice. We do this for other parameters, e.g. all the key paths (VBOOT_ROOT_KEY, etc). But I can update the help text to make it clear that the specific board IDs don't need to be set in coreboot. (+Julius to check this all makes sense.) -- To view, visit https://review.coreboot.org/c/coreboot/+/75641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df Gerrit-Change-Number: 75641 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 05 Jun 2023 23:26:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common/crashlog: Add support for IOE die
by Pratikkumar V Prajapati (Code Review) 06 Jun '23

06 Jun '23

Attention is currently required from: Martin L Roth, Paul Menzel. Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75475?usp=email ) Change subject: soc/intel/common/crashlog: Add support for IOE die ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75475/comment/7298e452_c148a158 : PS4, Line 7: IOE die > What is IOE? I/O Expander File src/soc/intel/common/block/include/intelblocks/crashlog.h: https://review.coreboot.org/c/coreboot/+/75475/comment/b632cdd1_3f568af2 : PS4, Line 35: :16 > Why is this a bitfield? Just for consistency with other code. removing or keeping it won't matter technically. -- To view, visit https://review.coreboot.org/c/coreboot/+/75475?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id90cf0095258c4f7003e4c5f2564bb763e687b75 Gerrit-Change-Number: 75475 Gerrit-PatchSet: 5 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 05 Jun 2023 22:58:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023