Frans Hendriks has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/50123?usp=email )
Change subject: device/oprom/x86emu/prim_ops.c: Correct code style
......................................................................
Abandoned
Old comment which is not approved.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50123?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie90aba783aeba73e5166701c50bf013b12873fd0
Gerrit-Change-Number: 50123
Gerrit-PatchSet: 7
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: abandon
Attention is currently required from: Alexander Couzens, Nicolas Provost.
Hello Alexander Couzens, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75992?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: New port for Lenovo L420 laptop (bump from v4.18 to master).
......................................................................
New port for Lenovo L420 laptop (bump from v4.18 to master).
Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac
Signed-off-by: Nicolas Provost <dev(a)npsoft.fr>
---
A src/mainboard/lenovo/l420/Kconfig
A src/mainboard/lenovo/l420/Kconfig.name
A src/mainboard/lenovo/l420/Makefile.inc
A src/mainboard/lenovo/l420/acpi/ec.asl
A src/mainboard/lenovo/l420/acpi/platform.asl
A src/mainboard/lenovo/l420/acpi/superio.asl
A src/mainboard/lenovo/l420/acpi_tables.c
A src/mainboard/lenovo/l420/board_info.txt
A src/mainboard/lenovo/l420/cmos.default
A src/mainboard/lenovo/l420/cmos.layout
A src/mainboard/lenovo/l420/data.vbt
A src/mainboard/lenovo/l420/devicetree.cb
A src/mainboard/lenovo/l420/dsdt.asl
A src/mainboard/lenovo/l420/early_init.c
A src/mainboard/lenovo/l420/gma-mainboard.ads
A src/mainboard/lenovo/l420/gpio.c
A src/mainboard/lenovo/l420/hda_verb.c
A src/mainboard/lenovo/l420/mainboard.c
A src/mainboard/lenovo/l420/smihandler.c
A src/mainboard/lenovo/l420/status.txt
20 files changed, 1,028 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/75992/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/75992?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac
Gerrit-Change-Number: 75992
Gerrit-PatchSet: 3
Gerrit-Owner: Nicolas Provost
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicolas Provost
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Nicolas Provost.
Hello Alexander Couzens, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75992?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: New port for Lenovo L420 laptop (bump from v4.18 to master).
......................................................................
New port for Lenovo L420 laptop (bump from v4.18 to master).
Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac
Signed-off-by: Nicolas Provost <dev(a)npsoft.fr>
---
A src/mainboard/lenovo/l420/Kconfig
A src/mainboard/lenovo/l420/Kconfig.name
A src/mainboard/lenovo/l420/Makefile.inc
A src/mainboard/lenovo/l420/acpi/ec.asl
A src/mainboard/lenovo/l420/acpi/platform.asl
A src/mainboard/lenovo/l420/acpi/superio.asl
A src/mainboard/lenovo/l420/acpi_tables.c
A src/mainboard/lenovo/l420/board_info.txt
A src/mainboard/lenovo/l420/cmos.default
A src/mainboard/lenovo/l420/cmos.layout
A src/mainboard/lenovo/l420/data.vbt
A src/mainboard/lenovo/l420/devicetree.cb
A src/mainboard/lenovo/l420/dsdt.asl
A src/mainboard/lenovo/l420/early_init.c
A src/mainboard/lenovo/l420/gma-mainboard.ads
A src/mainboard/lenovo/l420/gpio.c
A src/mainboard/lenovo/l420/hda_verb.c
A src/mainboard/lenovo/l420/mainboard.c
A src/mainboard/lenovo/l420/smihandler.c
A src/mainboard/lenovo/l420/status.txt
20 files changed, 1,030 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/75992/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75992?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac
Gerrit-Change-Number: 75992
Gerrit-PatchSet: 2
Gerrit-Owner: Nicolas Provost
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicolas Provost
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Nicolas Provost has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75993?usp=email )
Change subject: lenovo/l420: fix HDA definition and various typos.
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/75993?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34e480c9911712281ad7405a405a65dc37ff77df
Gerrit-Change-Number: 75993
Gerrit-PatchSet: 1
Gerrit-Owner: Nicolas Provost
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Nicolas Provost has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75932?usp=email )
Change subject: Signed-off-by: Nicolas Provost <dev(a)npsoft.fr>
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/75932?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.18_branch
Gerrit-Change-Id: Iac36435348983f28fc2862642bee3fcc8cc75d5b
Gerrit-Change-Number: 75932
Gerrit-PatchSet: 1
Gerrit-Owner: Nicolas Provost
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Felix Singer, Jonathon Hall, Michał Żygowski, Piotr Król.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75957?usp=email )
Change subject: mb/{skl,kbl}: Use true/false macros for ScsEmmcHs400Enabled dt option
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75957?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20bfaa50dfc0e02fd0b1dfbd4d18cd624fc237e8
Gerrit-Change-Number: 75957
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 06:23:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Jonathon Hall, Michał Żygowski, Piotr Król.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75951?usp=email )
Change subject: mb/{skl,kbl}: Use true/false macros for deep_s5_enable_ac dt option
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75951?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d1286586a92f6f360f02acbaf2a90db4153f044
Gerrit-Change-Number: 75951
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 06:23:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nico Huber, Piotr Król, Tim Crawford.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75958?usp=email )
Change subject: mb/{skl,kbl}: Use true/false macros for SkipExtGfxScan dt option
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75958?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabca3e943d3f9fca88b15e5dd112a46c528a43b1
Gerrit-Change-Number: 75958
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 06:23:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment