Attention is currently required from: Angel Pons, Arthur Heymans, Eric Lai, Felix Held, Jeff Li, Johnny Lin, Jonathan Zhang, Martin L Roth, Martin Roth, Nico Huber, Nill Ge, Paul Menzel, Subrata Banik, TangYiwei, Ziang Wang, niehaitao(a)bytedance.com.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75737?usp=email )
Change subject: arch/x86/smbios: Add a config string for BIOS Vendor in SMBIOS Type 0
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75737?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6dfcca338ffc48b150c966b9aefcefe928704d24
Gerrit-Change-Number: 75737
Gerrit-PatchSet: 4
Gerrit-Owner: TangYiwei
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jeff Li <lijinfeng01(a)inspur.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: niehaitao(a)bytedance.com
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: TangYiwei
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: niehaitao(a)bytedance.com
Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com>
Gerrit-Attention: Jeff Li <lijinfeng01(a)inspur.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 21 Jun 2023 09:06:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Kane Chen, Paul Menzel, Pratikkumar V Prajapati, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769?usp=email )
Change subject: soc/intel/meteorlake: Add support for crashlog
......................................................................
Patch Set 24:
(1 comment)
Patchset:
PS23:
> > 1. I don’t see any redundant entries.
>
> can you please share your AP log (similar one that i have pasted here)
>
> ```
> [DEBUG] Region[0x0].Tag=0x7 offset=0x9b, size=0x400
> [DEBUG] Region[0x1].Tag=0x0 offset=0xa00, size=0x280
> [DEBUG] Region[0x2].Tag=0x0 offset=0x2bb0, size=0xa
> [DEBUG] Region[0x3].Tag=0x0 offset=0x3a00, size=0x80
> [DEBUG] Region[0x4].Tag=0x1 offset=0x780, size=0x280
> [DEBUG] Region[0x5].Tag=0x1 offset=0x12d8, size=0xa
> [DEBUG] Region[0x6].Tag=0x1 offset=0x1600, size=0x6e
> [DEBUG] Region[0x7].Tag=0x0 offset=0x0, size=0x0
>
> [DEBUG] Region[0x0].Tag=0x7 offset=0x9b, size=0x400
> [DEBUG] Region[0x1].Tag=0x0 offset=0xa00, size=0x280
> [DEBUG] Region[0x2].Tag=0x0 offset=0x2bb0, size=0xa
> [DEBUG] Region[0x3].Tag=0x0 offset=0x3a00, size=0x80
> [DEBUG] Region[0x4].Tag=0x1 offset=0x780, size=0x280
> [DEBUG] Region[0x5].Tag=0x1 offset=0x12d8, size=0xa
> [DEBUG] Region[0x6].Tag=0x1 offset=0x1600, size=0x6e
>
> ```
>
> my question is how to understand from the above entry which one is for SOC.PMC and IOE.PMC?
>
> >
> > in crashlog.h
> > #define CRASHLOG_DESCRIPTOR_TABLE_TAG_SOC 0x0
> > #define CRASHLOG_DESCRIPTOR_TABLE_TAG_IOE 0x1
> >
> > We parse descriptor table to learn about crashlog records in SOC PMC, and OIE PMC SRAM. Both data has different tags. Tag=7 contain BDF info for IOE PMC SRAM device, but since we already define it in header (#define PCI_DEV_IOE_SRAM) i don’t parse the tag=7. We parse descriptor table entries with tag=0 and tag=1 only. In first pass we collect SOC PMC crashlog records and also count IOE PMC records. This is needed to allocate right size of cbmem for IOE crashlog data. After this parsing i allocate CBMEM for IOE crashlog and parse descriptor table again to collect IOE crashlog data.
> >
> > 2. while copying data from SRAM, we ignore invalid crashlog entries. So the final size of crashlog is adjusted.
>
> thanks
>
> >
> > 3. that is coming from common code, pushed another patch.
>
> +2'ed
--
To view, visit https://review.coreboot.org/c/coreboot/+/74769?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0abd697fba35edf1c03d2a3a325b7785b985cd5
Gerrit-Change-Number: 74769
Gerrit-PatchSet: 24
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 08:30:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-MessageType: comment
Nicolas Provost has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75994?usp=email )
Change subject: include/cpu/x86: add the "Turbo Boost disable" bit in IA32_MISC msr
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/75994?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iead26c234415bd156bf0fef09519b80733cb0da8
Gerrit-Change-Number: 75994
Gerrit-PatchSet: 1
Gerrit-Owner: Nicolas Provost
Gerrit-MessageType: abandon
Attention is currently required from: Arthur Heymans, Bao Zheng, Felix Held, Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, Raul Rangel, Zheng Bao.
Hello Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, Raul Rangel, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72939?usp=email
to look at the new patch set (#17).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/amdfwtool: Deal with psp position in flash offset directly
......................................................................
util/amdfwtool: Deal with psp position in flash offset directly
It is based on work by Arthur Heymans, 69852.
Get rid of the confusing "position index" and use the relative flash
offset as the Kconfig setting instead.
TEST=binary identical on amd/birman amd/majolica amd/gardenia
amd/mayan amd/bilby amd/mandolin amd/chausie amd/pademelon
pcengines/apu2
google/skyrim google/guybrush google/zork google/kahlee
Change-Id: I26bde0b7c70efe9f5762109f431329ea7f95b7f2
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/mainboard/amd/chausie/Kconfig
M src/mainboard/amd/majolica/Kconfig
M src/mainboard/amd/mandolin/Kconfig
M src/mainboard/google/guybrush/Kconfig
M src/mainboard/google/kahlee/Kconfig
M src/mainboard/google/skyrim/Kconfig
M src/mainboard/google/zork/Kconfig
M src/soc/amd/cezanne/Kconfig
M src/soc/amd/cezanne/Makefile.inc
M src/soc/amd/common/Makefile.inc
M src/soc/amd/common/block/include/amdblocks/psp_efs.h
M src/soc/amd/common/block/psp/Kconfig
M src/soc/amd/glinda/Kconfig
M src/soc/amd/glinda/Makefile.inc
M src/soc/amd/mendocino/Kconfig
M src/soc/amd/mendocino/Makefile.inc
M src/soc/amd/phoenix/Kconfig
M src/soc/amd/phoenix/Makefile.inc
M src/soc/amd/picasso/Kconfig
M src/soc/amd/picasso/Makefile.inc
M src/soc/amd/stoneyridge/Kconfig
M src/soc/amd/stoneyridge/Makefile.inc
M src/soc/amd/stoneyridge/fch.c
23 files changed, 91 insertions(+), 286 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/72939/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/72939?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26bde0b7c70efe9f5762109f431329ea7f95b7f2
Gerrit-Change-Number: 72939
Gerrit-PatchSet: 17
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Herrmann, Jakub Czapiga, Jay Patel, Jérémy Compostella, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75764?usp=email )
Change subject: mb/google/rex: Enable Fast V-Mode for MTL-U 28W
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Where do the GT I_{TRIP} and SA I_{TRIP} values come from ? The Power Map from May 23rd indicates 54 A and 27 A.
I'm referring to the doc number 640982 but unable to find the exact match as you have mentioned here. Can you please clarify
Here is the logic that I have applied based on my read from PDG and pick the reference value Icc Max and Icc max APP from the power_map sheet.
For performance:
```
IA Icc max.app (85A) < IA ITRIP = 91A <= IA Icc max (110A)
```
ITRIP is greater than IccMax.App and less than IccMax in FVM applications. It is determined by customer specific VR current monitor tolerance and current capability.
Questions for you:
1. Should we refer to the performance value or baseline value for VR config ?
2. Should we calculate the value as per the logic (explained above) or should we pick any particular col from the power_map sheet (between IccMax or ITRIP_NOM)
Please advice.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75764?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If834c1af8141a19fd2daae653579225b77cfa6c8
Gerrit-Change-Number: 75764
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Herrmann <eherrmann(a)chromium.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Eric Herrmann <eherrmann(a)chromium.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com>
Gerrit-Comment-Date: Wed, 21 Jun 2023 08:00:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-MessageType: comment
Frans Hendriks has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/50040?usp=email )
Change subject: {src}: Assign values before if statement
......................................................................
Abandoned
Old patch not approved
--
To view, visit https://review.coreboot.org/c/coreboot/+/50040?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd346d31f1da71271ad1545e5645e57530c7b374
Gerrit-Change-Number: 50040
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: abandon
Attention is currently required from: Alexander Couzens, Nicolas Provost.
Hello Alexander Couzens, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75992?usp=email
to look at the new patch set (#4).
Change subject: new port for Lenovo L420 laptop
......................................................................
new port for Lenovo L420 laptop
Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac
Signed-off-by: Nicolas Provost <dev(a)npsoft.fr>
---
A src/mainboard/lenovo/l420/Kconfig
A src/mainboard/lenovo/l420/Kconfig.name
A src/mainboard/lenovo/l420/Makefile.inc
A src/mainboard/lenovo/l420/acpi/ec.asl
A src/mainboard/lenovo/l420/acpi/platform.asl
A src/mainboard/lenovo/l420/acpi/superio.asl
A src/mainboard/lenovo/l420/acpi_tables.c
A src/mainboard/lenovo/l420/board_info.txt
A src/mainboard/lenovo/l420/cmos.default
A src/mainboard/lenovo/l420/cmos.layout
A src/mainboard/lenovo/l420/data.vbt
A src/mainboard/lenovo/l420/devicetree.cb
A src/mainboard/lenovo/l420/dsdt.asl
A src/mainboard/lenovo/l420/early_init.c
A src/mainboard/lenovo/l420/gma-mainboard.ads
A src/mainboard/lenovo/l420/gpio.c
A src/mainboard/lenovo/l420/hda_verb.c
A src/mainboard/lenovo/l420/mainboard.c
A src/mainboard/lenovo/l420/smihandler.c
A src/mainboard/lenovo/l420/status.txt
20 files changed, 1,028 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/75992/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/75992?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e46810b80af72c608679235585ec8d5a98d48ac
Gerrit-Change-Number: 75992
Gerrit-PatchSet: 4
Gerrit-Owner: Nicolas Provost
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicolas Provost
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
Frans Hendriks has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/50106?usp=email )
Change subject: util/lint/kconfig_lint: Add util for used configs
......................................................................
Abandoned
Old comment which is not approved.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50106?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42bed2e2b576680b1d86cb40369482fab47a2295
Gerrit-Change-Number: 50106
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon